Re: [PATCH v5 0/4] PR gdb/31353

Andrew Burgess
2024-10-21T08:45:34Z

Markus Metzger <markus.t.metzger@intel.com> writes:

> Reviving an old patch series that was first submitted in Jan'21.
>
> It fixes issues with breakpoints at the end of the execution history,
> including PR gdb/31353, which was submitted in the meantime.
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31353

You should include this 'Bug: ...' tag at the bottom of every commit
message for commits that relate to this bug. Do 'git log' and search
for 'Bug:' if I've not been clear what I mean.

No need to repost with this change, I'm going to have a read through the
rest of the series this week.

Thanks,
Andrew

>
> Guinevere Larsen reviewed most of the series and reported an issue with
> applying the last patch. I'm resending the series, rebased on current
> master, to hopefully fix that issue.
>
> The only change to v4 is that a redundant forward declaration was removed.
>
> The changes are mostly in infrun and require global maintainer approval.
>
> Markus Metzger (4):
> gdb, infrun, btrace: fix reverse/replay stepping at end of execution
> history
> gdb, infrun, record: fix hang when step-over fails with no-history
> gdb, infrun, record: move no-history notification into normal_stop
> gdb, infrun: fix multi-threaded reverse stepping
>
> gdb/gdbthread.h | 13 +++
> gdb/infrun.c | 86 +++++++++++++-----
> gdb/infrun.h | 7 --
> gdb/record-btrace.c | 19 ++--
> gdb/testsuite/gdb.btrace/cont-hang.exp | 43 +++++++++
> .../gdb.btrace/implicit-stop-replaying.exp | 90 +++++++++++++++++++
> .../gdb.btrace/multi-thread-break-hang.exp | 84 +++++++++++++++++
> gdb/testsuite/gdb.btrace/step-hang.exp | 42 +++++++++
> gdb/testsuite/gdb.btrace/stepn.exp | 50 +++++++++++
> 9 files changed, 398 insertions(+), 36 deletions(-)
> create mode 100644 gdb/testsuite/gdb.btrace/cont-hang.exp
> create mode 100644 gdb/testsuite/gdb.btrace/implicit-stop-replaying.exp
> create mode 100644 gdb/testsuite/gdb.btrace/multi-thread-break-hang.exp
> create mode 100644 gdb/testsuite/gdb.btrace/step-hang.exp
> create mode 100644 gdb/testsuite/gdb.btrace/stepn.exp
>
> --
> 2.34.1
>
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928