[AMD Official Use Only]

Thanks Kevin, 

Requesting to review the attached patch with suggested code changes. 


Regards,
Rupesh P

> -----Original Message-----
> From: Kevin Buettner <kevinb@redhat.com>
> Sent: Saturday, April 16, 2022 1:01 AM
> To: Potharla, Rupesh <Rupesh.Potharla@amd.com>
> Cc: gdb-patches@sourceware.org; George, Jini Susan
> <JiniSusan.George@amd.com>; Parasuraman, Hariharan
> <Hariharan.Parasuraman@amd.com>; Sharma, Alok Kumar
> <AlokKumar.Sharma@amd.com>
> Subject: Re: GDB/Fortran: Support for Assumed Rank Zero.
> 
> [CAUTION: External Email]
> 
> On Fri, 15 Apr 2022 13:33:03 +0000
> "Potharla, Rupesh" <Rupesh.Potharla@amd.com> wrote:
> 
> > Apologies for missing out on these minor things.  Followed GDB
> > standard for comments and updated the attached patch.
> 
> The comments look good now.  Thanks for fixing them.
> 
> > Regarding XFAIL for flang, I looked at all possible cases in the
> > testcase where this can be handled and came up this solution which
> > will not suppress the actual failure case.  As the issue will be fixed
> > by the compiler soon, added the condition based on test number.
> 
> I suggest using setup_xfail within the loop when $test_count is 1.
> 
> Kevin