From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38415 invoked by alias); 4 Feb 2020 07:37:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38407 invoked by uid 89); 4 Feb 2020 07:37:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,FORGED_SPF_HELO,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=sk:simark, simark@simark.ca, D*simark.ca, U*simark X-HELO: NAM11-BN8-obe.outbound.protection.outlook.com Received: from mail-bn8nam11on2051.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) (40.107.236.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Feb 2020 07:37:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RjW83E18YvnSY3uEX3uoRG0l+aKwNWuAbvgJe86A7GrLH54ELrtXeiOOsDnVVdYqJZrdaT5qBy0m/qzM7n2suKO20IPtrgKwHRMM35yu+9Y9n0G/QLEowY7gyij8Ruu/82CfhpCYtieGQs6/ZVn0ZKUV883l+jZKvqcEGR5CgD2br7Em6fCZlNSsHfjEHAZh3G2sPgsgk1EB6BIhWxvGweKNb7omw5bzRLdzFOeqBDqSqLyIJrisRTlOv5+ByARrqUje4GFyyd49slVybpbx39mjKt+LYw/FzDRXfi3cwPoqkpHngP4H1YJQd7drhMh0jSVZIL8FDd79vSfqghZplA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pi7EomlXEq6uHiN+h6cY1n2axauMsoMfZ1gtNGIdafM=; b=W1Mh8qfbp/6uH5aGw9fCplZUlw8yv+Cbj9MCmpbVS0Jy0jMS0vJZGbfHzahE32q962BaQ6i/wQhLFapplR4EAzvECPJPFYdqYRk6I/6d8Tw2cVoo2VK6Q9KWas/oj4ApMD+EtSDH4TMzqy5sjCsd2SgkOeonk7Q9ID144Zfzmi4YLvqL5ZvtyrPnQ2bIFkqERcA2WotoA5G6edheOXz6k/Vht0cdoljqXdhBi3VcUwvthoS4PkySPdXAvTJ+4zeaTe3Zwz69EqcgK5u2ynYzbmC1AKdOxl9RvuVyCX4ywqksPweWDGSUY5pAQNOWX2GbSDy8tT3j8VsPbCFAgUMQKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pi7EomlXEq6uHiN+h6cY1n2axauMsoMfZ1gtNGIdafM=; b=c2dMRt31j/foWWR/EAPHrCxeisFnhg81d7U5WZJaZljXDwInF25MGAFzRuh8D6H7nd20q46TzWRX/5P+H0RTwwLwTEc7ful4CjSjYHOyVQi4OgnX2a+JRFtqM0pDW/4fNPv5CewhocyynWrA5UjxoLg2NpG34YUczaEobb9HZS0= Received: from DM6PR12MB3129.namprd12.prod.outlook.com (20.178.198.218) by DM6PR12MB3148.namprd12.prod.outlook.com (20.178.31.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.32; Tue, 4 Feb 2020 07:37:45 +0000 Received: from DM6PR12MB3129.namprd12.prod.outlook.com ([fe80::8db9:4846:593:c010]) by DM6PR12MB3129.namprd12.prod.outlook.com ([fe80::8db9:4846:593:c010%6]) with mapi id 15.20.2686.034; Tue, 4 Feb 2020 07:37:45 +0000 From: "Sharma, Alok Kumar" To: Simon Marchi , "gdb-patches@sourceware.org" CC: "George, Jini Susan" , "Achra, Nitika" , Tom Tromey Subject: RE: [PATCH] Fixed gdb to print arrays with very high indexes Date: Tue, 04 Feb 2020 07:37:00 -0000 Message-ID: References: <90a6c389-942b-5a29-970d-dd7300931e5f@simark.ca> In-Reply-To: <90a6c389-942b-5a29-970d-dd7300931e5f@simark.ca> authentication-results: spf=none (sender IP is ) smtp.mailfrom=AlokKumar.Sharma@amd.com; x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:8882; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-messagedata: Mk1kZHQBDtdxN61a30EzzQgsYhEy5wOU9d1PS45TurglNnbP6XNawFP5fAyVJgSrrYWSZ4YQpoaFth/3m//hSp8peHW0yNKv8N8svbi5o03rr4E+lGxpRRd0ufa7g9qgJzEP/wg2wdD41+a4SmwKgQ== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cR6nA2ttr8h9DDSpJhDqv2ek13HCoY5CyfoNmeniAHZ1hv6Q9KLacIAjc+QPAx5tG7dUxmoa+39TtQcber7slg== X-SW-Source: 2020-02/txt/msg00058.txt.bz2 SGkgU2ltb24sDQoNCj4gSSdsbCBkbyB0aGF0IGluIGEgZmV3IG1pbnV0ZXMs IG9uY2UgSSBjb25maXJtcyBpdCBidWlsZHMgb24gbXkgbWFjaGluZS4NCg0K VGhhbmtzIGEgbG90Lg0KDQo+IElmIHlvdSBwbGFuIG9uIGNvbnRyaWJ1dGlu ZyBwYXRjaGVzIHJlZ3VsYXJseSwgaXQgd291bGQgYmUgYW4gb3B0aW9uIGZv ciB5b3UgdG8gZ2V0IHdyaXRlIGFjY2VzcyB0byB0aGUgcmVwby4gIFlvdSBj b3VsZCB0aGVuIHB1c2ggeW91ciBvd24gcGF0Y2hlcywgb25jZSB0aGV5IGFy ZSBhcHByb3ZlZC4gIExldCBtZSBrbm93IGlmIHlvdSdkIGxpa2UgdG8gZG8g dGhhdC4NCg0KVGhhdCB3b3VsZCBoZWxwLiBJIHJlcXVlc3QgeW91IHRvIGdy YW50IG1lIHRoZSB3cml0ZSBwZXJtaXNzaW9uLiBQbGVhc2UgbGV0IG1lIGtu b3cgaWYgSSBuZWVkIHRvIGRvIHNvbWV0aGluZyBmb3IgdGhhdC4NCg0KPiBP biBhbm90aGVyIG5vdGUsIGNvdWxkIHlvdSBwbGVhc2UgZml4IHlvdXIgbmFt ZSBpbiBnaXQ/ICBJdCBjdXJyZW50bHkgYXBwZWFycyBhcyBgYWxvc2hhcm1g LCB3aGljaCBJIHByZXN1bWUgaXMgeW91ciB1c2VybmFtZS4gIFlvdSBjYW4g ZG8gZWl0aGVyOg0KDQpUaGFua3MgZm9yIHBvaW50aW5nIHRoaXMgb3V0LCBJ IGhhdmUgZml4ZWQgaXQgbm93Lg0KDQpSZWdhcmRzLA0KQWxvaw0KDQoNCg0K LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IFNpbW9uIE1hcmNo aSA8c2ltYXJrQHNpbWFyay5jYT4gDQpTZW50OiBUdWVzZGF5LCBGZWJydWFy eSA0LCAyMDIwIDY6NTMgQU0NClRvOiBTaGFybWEsIEFsb2sgS3VtYXIgPEFs b2tLdW1hci5TaGFybWFAYW1kLmNvbT47IGdkYi1wYXRjaGVzQHNvdXJjZXdh cmUub3JnDQpDYzogR2VvcmdlLCBKaW5pIFN1c2FuIDxKaW5pU3VzYW4uR2Vv cmdlQGFtZC5jb20+OyBBY2hyYSwgTml0aWthIDxOaXRpa2EuQWNocmFAYW1k LmNvbT47IFRvbSBUcm9tZXkgPHRvbUB0cm9tZXkuY29tPg0KU3ViamVjdDog UmU6IFtQQVRDSF0gRml4ZWQgZ2RiIHRvIHByaW50IGFycmF5cyB3aXRoIHZl cnkgaGlnaCBpbmRleGVzDQoNCltDQVVUSU9OOiBFeHRlcm5hbCBFbWFpbF0N Cg0KT24gMjAyMC0wMi0wMyAxMjoyMCBhLm0uLCBTaGFybWEsIEFsb2sgS3Vt YXIgd3JvdGU6DQo+IEFzIEkgZG9u4oCZdCBoYXZlIHJlcXVpcmVkIHBlcm1p c3Npb24sIEl0IHdvdWxkIGJlIGdyZWF0IGlmIHNvbWVvbmUgZnJvbSB0aGUg Z2RiLXBhdGNoZXMgcHVzaGVzIHRoaXMgcGF0Y2g/DQo+DQo+IFRoYW5rcyBp biBhZHZhbmNlICEhDQo+DQo+IFJlZ2FyZHMsDQo+IEFsb2sNCg0KSGkgQWxv aywNCg0KSSdsbCBkbyB0aGF0IGluIGEgZmV3IG1pbnV0ZXMsIG9uY2UgSSBj b25maXJtcyBpdCBidWlsZHMgb24gbXkgbWFjaGluZS4NCg0KSWYgeW91IHBs YW4gb24gY29udHJpYnV0aW5nIHBhdGNoZXMgcmVndWxhcmx5LCBpdCB3b3Vs ZCBiZSBhbiBvcHRpb24gZm9yIHlvdSB0byBnZXQgd3JpdGUgYWNjZXNzIHRv IHRoZSByZXBvLiAgWW91IGNvdWxkIHRoZW4gcHVzaCB5b3VyIG93biBwYXRj aGVzLCBvbmNlIHRoZXkgYXJlIGFwcHJvdmVkLiAgTGV0IG1lIGtub3cgaWYg eW91J2QgbGlrZSB0byBkbyB0aGF0Lg0KDQpPbiBhbm90aGVyIG5vdGUsIGNv dWxkIHlvdSBwbGVhc2UgZml4IHlvdXIgbmFtZSBpbiBnaXQ/ICBJdCBjdXJy ZW50bHkgYXBwZWFycyBhcyBgYWxvc2hhcm1gLCB3aGljaCBJIHByZXN1bWUg aXMgeW91ciB1c2VybmFtZS4gIFlvdSBjYW4gZG8gZWl0aGVyOg0KDQogICQg Z2l0IGNvbmZpZyB1c2VyLm5hbWUgIkFsb2sgS3VtYXIgU2hhcm1hIg0KDQpp biB0aGUgYmludXRpbHMtZ2RiIHJlcG9zaXRvcnksIHRvIGFwcGx5IGl0IG9u bHkgdG8gdGhhdCByZXBvLCBvcjoNCg0KICAkIGdpdCBjb25maWcgLS1nbG9i YWwgdXNlci5uYW1lICJBbG9rIEt1bWFyIFNoYXJtYSINCg0KdG8gYXBwbHkg aXQgdG8gYWxsIHlvdXIgcmVwb3MuDQoNClNpbW9uDQo= >From gdb-patches-return-163757-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Feb 04 08:55:13 2020 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 31671 invoked by alias); 4 Feb 2020 08:55:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 31662 invoked by uid 89); 4 Feb 2020 08:55:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=H*R:U*noreply, HX-Languages-Length:2431 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Feb 2020 08:55:10 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id AA5942048E; Tue, 4 Feb 2020 03:55:08 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 6937320178; Tue, 4 Feb 2020 03:55:07 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 280D32816C; Tue, 4 Feb 2020 03:55:07 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Tue, 04 Feb 2020 08:55:00 -0000 From: "Sourceware to Gerrit sync (Code Review)" To: Tom de Vries , Simon Marchi , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [pushed] [gdb/testsuite] Use non-capturing parentheses for inferior_exited_re X-Gerrit-Change-Id: I7640c6129b1ada617424d6a63730d4b119c58ef3 X-Gerrit-Change-Number: 763 X-Gerrit-ChangeURL: X-Gerrit-Commit: 780636aec079208cd8ee1079f27d0d5ac5dae48a In-Reply-To: References: Reply-To: noreply@gnutoolchain-gerrit.osci.io, simon.marchi@polymtl.ca, tdevries@suse.de, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20200204085507.280D32816C@gnutoolchain-gerrit.osci.io> X-SW-Source: 2020-02/txt/msg00059.txt.bz2 Content-length: 2370 The original change was created by Tom de Vries. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/763 ...................................................................... [gdb/testsuite] Use non-capturing parentheses for inferior_exited_re The inferior_exited_re regexp uses capturing parentheses by default: ... set inferior_exited_re "(\\\[Inferior \[0-9\]+ \\(.*\\) exited)" ... The parentheses are there to be able to use the expression as an atom, f.i., to have '+' apply to the whole regexp in "${inferior_exited_re}+". But the capturing is not necessary, and it can be confusing because it's not obvious in a regexp using "$inferior_exited_re (bla|bli)" that the first captured expression is in $inferior_exited_re. Replace by non-capturing parentheses. If we still want to capture the expression, we can simply (and more clearly) use "($inferior_exited_re)". Build and reg-tested on x86_64-linux. gdb/testsuite/ChangeLog: 2020-02-04 Tom de Vries * lib/gdb.exp (inferior_exited_re): Use non-capturing parentheses. Change-Id: I7640c6129b1ada617424d6a63730d4b119c58ef3 --- M gdb/testsuite/ChangeLog M gdb/testsuite/lib/gdb.exp 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 2b1a8ba..bc61679 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2020-02-04 Tom de Vries + + * lib/gdb.exp (inferior_exited_re): Use non-capturing parentheses. + 2020-02-03 Rogerio A. Cardoso * gdb.arch/powerpc-power8.exp: Delete trailing whitespace of diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 2d230b7..25bed76 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -117,7 +117,7 @@ set octal "\[0-7\]+" -set inferior_exited_re "(\\\[Inferior \[0-9\]+ \\(.*\\) exited)" +set inferior_exited_re "(?:\\\[Inferior \[0-9\]+ \\(.*\\) exited)" # A regular expression that matches a value history number. # E.g., $1, $2, etc. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I7640c6129b1ada617424d6a63730d4b119c58ef3 Gerrit-Change-Number: 763 Gerrit-PatchSet: 2 Gerrit-Owner: Tom de Vries Gerrit-Reviewer: Simon Marchi Gerrit-MessageType: newpatchset