From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47538 invoked by alias); 2 Mar 2020 17:00:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21789 invoked by uid 89); 2 Mar 2020 17:00:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=BAYES_00,FORGED_SPF_HELO,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=H*r:15.20.2772.18, H*c:sk:HMHPRHH, H*RU:15.20.2772.18, HX-Spam-Relays-External:15.20.2772.18 X-HELO: NAM10-MW2-obe.outbound.protection.outlook.com Received: from mail-mw2nam10on2068.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) (40.107.94.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Mar 2020 17:00:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gl2WMN2cBtsuWNPYWxlZOrqttWkunVdpK4Fp7fj66nQs3BELZsrLlvhy7xyt/apzqS+lkybHaRyZnlgvxOweV7xpufNVz4C1Of240aPXPhq9pKqgMsXcYXhlMuiihLs0fBj3ocNPGbmZu/LKXR2vPbuyAcI9onmvfKGfovk6Al2Vi8OoIwByk+cbppwtXUqX4vcikO9B2Ih4eZpM7WniamSFJ4YZevp1waU5hYZ+AUu1tEvvwlh9mRzed0O8qo1sXJbN0S8GXjhgQpD7I4bxvyfM+jBqVM9ONBfM0b1bzYl7f0XKspCAoPaP21FV1fjn3jRNvOh039klJYquWTAprw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sN7EV8uU4DddF3fFXjdtDVn997Wb4iXRZO7pZC2zguE=; b=X4RxHhFTNCwZsE0wXhUChXE0pu4f91DmcUD9P5pbkxcNG6N6ohBzcHeFFeJzqErAGeZhppORsazqVg4sA+eYvNIdHdmggYc2NjIy/ZR+5Ke2PMBdUhBqCkCLFucfv+MvSklrvnKIqvUdst8DjLbNYZuqzAQx4H3hnKnP+9PwYjn+H6BhcnLjSDGgQhp884bXInGt5psz+LOHCB/U35s/2eGH/7Gk7AiY5PxhUkK715uVkmcWvRmNbXE6+KbGma76CbTTqRs02gzYp+6ngm2Qfn/Ixy0f6/Ut9HvHW9IPcvdNpHUFgqRuIFJODHM4UGFS7cdeHvjSgpaRASr7vaXdPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sN7EV8uU4DddF3fFXjdtDVn997Wb4iXRZO7pZC2zguE=; b=K7wRnlwhEY1pyJEhAnHv2GAH0uMXfeyHpx/d0Bf8Jh3rrOK/D6JcePLDHcstcLjhuz5cy+Y2fVz/+9I5DD5qREv+QDe9cLXAwhWjWK89AQqATVvQ8++QXUN8t1LDPzwAqH/vAsELpApd7tmGncHedJRdX/kKoftMDipb8A/+rR4= Received: from DM6PR12MB3129.namprd12.prod.outlook.com (2603:10b6:5:3b::26) by DM6PR12MB3963.namprd12.prod.outlook.com (2603:10b6:5:1cd::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.18; Mon, 2 Mar 2020 17:00:06 +0000 Received: from DM6PR12MB3129.namprd12.prod.outlook.com ([fe80::25b4:d90c:9db4:1aa1]) by DM6PR12MB3129.namprd12.prod.outlook.com ([fe80::25b4:d90c:9db4:1aa1%7]) with mapi id 15.20.2772.019; Mon, 2 Mar 2020 17:00:06 +0000 From: "Sharma, Alok Kumar" To: "gdb-patches@sourceware.org" CC: "George, Jini Susan" , "Achra, Nitika" Subject: [PATCH] gdb/fortran Fixed printing of logical true values for Flang Date: Mon, 02 Mar 2020 17:00:00 -0000 Message-ID: authentication-results: spf=none (sender IP is ) smtp.mailfrom=AlokKumar.Sharma@amd.com; x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:9508; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-messagedata: w5FDFDTurV3ZuVbl/Jc8iPN/3Qb1YUTAXYmCRhQ0Rg/RxKkU0kXc3YTB1l0tsgzRXKkIGxGxHdeISySWyRq71OoYfRjK9V9V3SUVQObOVGv4Z6DtI+DUywQ1azrl3jnsd7xQLirSvmIHokZ1D3kePWkUCT4dako/1P305wtcn6GHi036WqW23AkY8QjlnCLaiL2FQ5swGtHXy08ZgZgTtA== Content-Type: multipart/mixed; boundary="_002_DM6PR12MB31294CF1BEAC6E8CA1CCE27B9EE70DM6PR12MB3129namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: awJd2NInT/R+5mUsMOOXMu2ewjgCyfole6SY5PyTLBx9XLUD8/3OFsiumzXVL/X95K2VgAC26SUx//B6swnzkA== X-SW-Source: 2020-03/txt/msg00027.txt --_002_DM6PR12MB31294CF1BEAC6E8CA1CCE27B9EE70DM6PR12MB3129namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-length: 948 Hi all, I request you all to please review the patch. Below are the details. Problem Description: gdb is not able to print logical true values for Flang compiler. actual result -------------- (gdb) p l $1 =3D 4294967295 -------------- expected result -------------- (gdb) p l $1 =3D .TRUE. -------------- Root cause: This is due to GDB expecting representation of true value being 1. The fortran standard doesnt specify how LOGICAL types are represented. Different compilers use different non zero values to represent LOGICAL TRUE. The gfortran compiler uses 1 to represent LOGICAL TRUE and flang compiler uses -1. GDB should accept all the non zero values as TRUE. Resolution: Now function 'generic_val_print_bool' is modified to be able to print true logical value for the Flang compiler. Testing: - No regression seen Please let me know your comments. Regards, Alok --_002_DM6PR12MB31294CF1BEAC6E8CA1CCE27B9EE70DM6PR12MB3129namp_ Content-Type: application/octet-stream; name="0001-gdb-fortran-Fixed-printing-of-logical-true-values-fo.patch" Content-Description: 0001-gdb-fortran-Fixed-printing-of-logical-true-values-fo.patch Content-Disposition: attachment; filename="0001-gdb-fortran-Fixed-printing-of-logical-true-values-fo.patch"; size=1883; creation-date="Mon, 02 Mar 2020 16:52:08 GMT"; modification-date="Mon, 02 Mar 2020 16:51:46 GMT" Content-Transfer-Encoding: base64 Content-length: 2554 RnJvbSBmOGE3YTgwNzBkZjM5OGExNDNlNDllZDZmOGQyNzAyNTgzNjg5MzQy IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbG9rIEt1bWFyIFNo YXJtYSA8QWxva0t1bWFyLlNoYXJtYUBhbWQuY29tPgpEYXRlOiBNb24sIDIg TWFyIDIwMjAgMjE6NDk6NTAgKzA1MzAKU3ViamVjdDogW1BBVENIXSBnZGIv Zm9ydHJhbiBGaXhlZCBwcmludGluZyBvZiBsb2dpY2FsIHRydWUgdmFsdWVz IGZvciBGbGFuZwoKZ2RiIGlzIG5vdCBhYmxlIHRvIHByaW50IGxvZ2ljYWwg dHJ1ZSB2YWx1ZXMgZm9yIEZsYW5nIGNvbXBpbGVyLgphY3R1YWwgcmVzdWx0 Ci0tLS0tLS0tLS0tLS0tCihnZGIpIHAgbAokMSA9IDQyOTQ5NjcyOTUKLS0t LS0tLS0tLS0tLS0KZXhwZWN0ZWQgcmVzdWx0Ci0tLS0tLS0tLS0tLS0tCihn ZGIpIHAgbAokMSA9IC5UUlVFLgotLS0tLS0tLS0tLS0tLQpUaGlzIGlzIGR1 ZSB0byBHREIgZXhwZWN0aW5nIHJlcHJlc2VudGF0aW9uIG9mIHRydWUgdmFs dWUgYmVpbmcgMS4KVGhlIGZvcnRyYW4gc3RhbmRhcmQgZG9lc250IHNwZWNp ZnkgaG93IExPR0lDQUwgdHlwZXMgYXJlIHJlcHJlc2VudGVkLgpEaWZmZXJl bnQgY29tcGlsZXJzIHVzZSBkaWZmZXJlbnQgbm9uIHplcm8gdmFsdWVzIHRv IHJlcHJlc2VudCBMT0dJQ0FMClRSVUUuIFRoZSBnZm9ydHJhbiBjb21waWxl ciB1c2VzIDEgdG8gcmVwcmVzZW50IExPR0lDQUwgVFJVRSBhbmQgZmxhbmcK Y29tcGlsZXIgdXNlcyAtMS4gR0RCIHNob3VsZCBhY2NlcHQgYWxsIHRoZSBu b24gemVybyB2YWx1ZXMgYXMgVFJVRS4KTm93IGZ1bmN0aW9uICdnZW5lcmlj X3ZhbF9wcmludF9ib29sJyBpcyBtb2RpZmllZCB0byBiZSBhYmxlIHRvIHBy aW50CnRydWUgbG9naWNhbCB2YWx1ZSBmb3IgdGhlIEZsYW5nIGNvbXBpbGVy LgoKZ2RiL0NoYW5nZUxvZzoKCgkqIHZhbHByaW50LmMgKGdlbmVyaWNfdmFs X3ByaW50X2Jvb2wpOiBDaGFuZ2VkIHRvIHRyZWF0IGFueQoJbm9uLXplcm8g dmFsdWUgYXMgVFJVRSBmb3IgZm9ydHJhbiBMT0dJQ0FMIHR5cGUuCgpDaGFu Z2UtSWQ6IEkwNTA5YzViNTBiZjM0ODFiOWZjYTJhYWQ0NmZiMTc3NDJlYzlh YWUzCi0tLQogZ2RiL3ZhbHByaW50LmMgfCA1ICsrKystCiAxIGZpbGUgY2hh bmdlZCwgNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEvZ2RiL3ZhbHByaW50LmMgYi9nZGIvdmFscHJpbnQuYwppbmRleCA4 YWRiYjNkZjQ1Li4xZGUwZWJkM2RmIDEwMDY0NAotLS0gYS9nZGIvdmFscHJp bnQuYworKysgYi9nZGIvdmFscHJpbnQuYwpAQCAtNzkzLDcgKzc5MywxMCBA QCBnZW5lcmljX3ZhbF9wcmludF9ib29sIChzdHJ1Y3QgdHlwZSAqdHlwZSwK ICAgICAgIHZhbCA9IHVucGFja19sb25nICh0eXBlLCB2YWxhZGRyICsgZW1i ZWRkZWRfb2Zmc2V0ICogdW5pdF9zaXplKTsKICAgICAgIGlmICh2YWwgPT0g MCkKIAlmcHV0c19maWx0ZXJlZCAoZGVjb3JhdGlvbnMtPmZhbHNlX25hbWUs IHN0cmVhbSk7Ci0gICAgICBlbHNlIGlmICh2YWwgPT0gMSkKKyAgICAgIC8q IFRoZSBmb3J0cmFuIHN0YW5kYXJkIGRvZXNudCBzcGVjaWZ5IGhvdyBMT0dJ Q0FMIHR5cGVzIGFyZSByZXByZXNlbnRlZC4KKyAgICAgICAgIERpZmZlcmVu dCBjb21waWxlcnMgdXNlIGRpZmZlcmVudCBub24gemVybyB2YWx1ZXMgdG8g cmVwcmVzZW50IExPR0lDQUwKKyAgICAgICAgIFRSVUUuICAqLworICAgICAg ZWxzZSBpZiAoY3VycmVudF9sYW5ndWFnZSA9PSAmZl9sYW5ndWFnZV9kZWZu IHx8IHZhbCA9PSAxKQogCWZwdXRzX2ZpbHRlcmVkIChkZWNvcmF0aW9ucy0+ dHJ1ZV9uYW1lLCBzdHJlYW0pOwogICAgICAgZWxzZQogCXByaW50X2xvbmdl c3QgKHN0cmVhbSwgJ2QnLCAwLCB2YWwpOwotLSAKMi4xNy4xCgo= --_002_DM6PR12MB31294CF1BEAC6E8CA1CCE27B9EE70DM6PR12MB3129namp_--