From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +s7wCqoVtmDkWwAAWB0awg (envelope-from ) for ; Tue, 01 Jun 2021 07:10:34 -0400 Received: by simark.ca (Postfix, from userid 112) id 1DF0D1F163; Tue, 1 Jun 2021 07:10:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B5DFE1E01F for ; Tue, 1 Jun 2021 07:10:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E815385B804; Tue, 1 Jun 2021 11:10:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E815385B804 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1622545831; bh=iDmsscnHdcsZpD65gPDCh3WwdjswIyp0UOJdRh+SRAE=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=A+MTUSoDUPLLX2hrdtX5eCI6JRP5bQyVc3DBb5WhFT1AHzYmXgJnm/QMt6Y9ARDT8 +zpdZv9KMBQUb/j3wvbf86cSGM+lzy3tvleZkQxNT9FV11IrLNAB63qjrLFxotgEtx clv6LJzuDhGdZzTAi3pdLXPXmZxde2CBbgcav8pM= Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2045.outbound.protection.outlook.com [40.107.95.45]) by sourceware.org (Postfix) with ESMTPS id C8CC4385B804 for ; Tue, 1 Jun 2021 11:10:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C8CC4385B804 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EjtSeO5XWmhKO2fQxNmZyI8F5eFAlX6MLqv8oMkOujv24UbG0seNLtFISSMq1mHa59wU7GldR3vCH7udAbzjQmARCzz9F9V2O0RyxDEx8/ExYqL/H7J1OogOOkHLqYM8LVwsJSGyGNDGSaH74IIYQ4pXjtsKku5JfeepyQzpo/wsu+XvikgoGhBsOjjhoJlhQfznb9Fo5uABCpQ7mun/lqBZZ5gREDBToHwpImaN+Yp1+3mA0Ig3G3N5h/RS9I+Wgh+Yd7FnjQHWSBHs9UTXgE6arxWzGI/P4k+grBA2BhqO3mTLxPMcdgXYOjMsDo+98k7V8rwbxH+yxn4abJ7RXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iDmsscnHdcsZpD65gPDCh3WwdjswIyp0UOJdRh+SRAE=; b=eOQCM0vAagimkhM+rsqm9rdr9FMr/L7nCJrV0AU4LuXObldgzFO6bs5b74gZqF/6vQoTpcLHXcMSv0fOeEH3Fw0VQUTUntQqP149R+aYtJtl6ZPO465UP/nzA85B9hb6AGinGAyOV3HzvHJ2RJlZd6nUXpzfnaUAfunKxEoPXyylCQWqHkEO585RQFOEHPNBP4l/AlkMvSOmRfnZxDDLCo8/5qrAEU799bs/5eYA2BMaHp5Pzo2ooBuho8y1c5N+j7aPrcE/ku37gWVNFereY64d2CIcvq7bOsO3L8X59hLZSwktlFFqqvURmeOJOgha7+Jha/echLhwgLOcTWqTTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM5PR12MB1450.namprd12.prod.outlook.com (2603:10b6:4:3::8) by DM5PR1201MB0124.namprd12.prod.outlook.com (2603:10b6:4:58::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.20; Tue, 1 Jun 2021 11:10:25 +0000 Received: from DM5PR12MB1450.namprd12.prod.outlook.com ([fe80::ec05:c009:c3be:d2e2]) by DM5PR12MB1450.namprd12.prod.outlook.com ([fe80::ec05:c009:c3be:d2e2%6]) with mapi id 15.20.4173.030; Tue, 1 Jun 2021 11:10:25 +0000 To: Simon Marchi , "gdb-patches@sourceware.org" Subject: RE: [PATCH] [gdb.base] Add additional next commands for clang-12 and above in foll-exec.exp Thread-Topic: [PATCH] [gdb.base] Add additional next commands for clang-12 and above in foll-exec.exp Thread-Index: AdcyLoQ1lkRAo39xTB+he/vftbq7zAiArWOAAKjqyCA= Date: Tue, 1 Jun 2021 11:10:25 +0000 Message-ID: References: <50265efc-2fa2-8bb4-7285-60fa32b8ead2@polymtl.ca> In-Reply-To: <50265efc-2fa2-8bb4-7285-60fa32b8ead2@polymtl.ca> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Enabled=true; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SetDate=2021-06-01T11:10:13Z; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Method=Standard; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Name=Internal Use Only - Unrestricted; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ActionId=1377ddff-9677-4a97-8bd4-1c048db0b3d1; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ContentBits=1 msip_justification: I confirm the recipients are approved for sharing this content x-originating-ip: [2406:7400:73:e049:b513:a09e:9507:126b] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b647ff0b-9cce-4c5b-613e-08d924eddb77 x-ms-traffictypediagnostic: DM5PR1201MB0124: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Fe64eH1Nh1kZtAn96PMFQbxuqyt5lYvpwje/WM1bo4ksxM6IdBMxUZZ3V3gzrAaowxIo4/zUU0U8bMf36KjwieUPOCJhaiUI/VVA2qI/uqjvv8WpXu7QeBXYjnX8ensEnc8gOCvNg910Avxt3LKJ45RlQGRF0ZxP4Wq8HcvYrea6LzKNZVYizzgHrMI4F7ygKgDatM7qWo26JrN5vk6/4+1ZX+a0Lsar5iQnAPCrBifKJdQAsS/l/TedPHY2kS9suhGODKDUHCRaWwnRFyXkaVL3s3kY6hVoiLjJ10+NjNTt+XK1tdP16sJbSO5mP9TSCnK+X0bQ+rFcX2U/kj9bCYxw6802wjtYtL72M/DMEfj3lawYwLStXtuHji8x5yJ9T+lPLbR+f75ZkYDnRBhCHwSoJb7V0rZm82Cm+yJ9Pc9Rq8GfGlKjn3Y98AT4xbbsJBMyemIJX2QbYLCnUjZrcB9UUfM1HxhShWvf04DOoF+i26X+Cidq7NMId9KnUgVwBgTA2pYdWBhIjKh/sxvkqcYX1FZENh+rjK0SEjU/0e0hcow9sv6tvTA9s23tuVyY8UHQoJyjaXgrCC/pXgv0BtoYLcssizA7563td9wSEdQRKmyFJiyuw8AnJGiyUN3S5bAtji6YLOxtGYR6l8AfZpuFQeVLwNgJWD5z85DOpMb005tVMtniHfCHZ5rT6BqfWTlpHjrKAaeDtlYWT4d5YrT7zGMTJ8eV07K5z+gUK445zmaHJwO7jAcvhKLi9li7eqdQJHEwmc6xMo9IeUmJXQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR12MB1450.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39850400004)(136003)(366004)(396003)(376002)(99936003)(45080400002)(64756008)(86362001)(52536014)(9686003)(83380400001)(66616009)(8676002)(33656002)(38100700002)(76116006)(66946007)(5660300002)(122000001)(6506007)(71200400001)(186003)(2906002)(478600001)(4326008)(110136005)(55016002)(316002)(66556008)(7696005)(66476007)(53546011)(66446008)(8936002)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?g0EjbG2pDBn+T8bR3UyybIQfk4/D7nNhz2z2BU9ZvuxdNZy1w/s1yt7TYRT2?= =?us-ascii?Q?5kZAnp166bU/8oW8vmXLAQkOJZadRcwq+oDQX6ynH2kbGyrqE+TdnDd8S/6w?= =?us-ascii?Q?XrWzA6NGz/4pQx+eDBpS6xCxDZAYTpbu+6Uuit/GHLjL3IRLT5Jof+Cyin73?= =?us-ascii?Q?k9bSJTDqvFwAl09gvrfyT97dU2hmEiN4l/sLUV5O3m5MzJy/AYsrQpuvzdcE?= =?us-ascii?Q?nbZ5g3XJavOB+dCIcSKEz6z0joj0Mo+HCDFGKf0ZKKWtHiS/3sJmApYSa/WU?= =?us-ascii?Q?bo5kWO4wwS84bx5dIbDDgmRLogBE10Ns8kOstTYa+JKeS1s2Ld4ZMzkNQZxO?= =?us-ascii?Q?2oFd9Kj+06htd/5IuhbnGyIjB1I3PB3V7768TP6kqMQakkJB+FEc3GOCuu2K?= =?us-ascii?Q?BlOuabRfZQcpGvioE4zo/k2SZHENyYI5PBcHrq7yxkBLVWXCq9AImFgq9aPg?= =?us-ascii?Q?6N2Vm1i+pljwZYbCGh8VXLahrfM/TfV0jRbIZ2nBt6VvDCHoN3RhWszmkbIB?= =?us-ascii?Q?hbvz+NgnkRajqmQmDNMHjXPxCrAmNVycnehp4QrlpjGSrMMy01Hl3HR1mCt8?= =?us-ascii?Q?1NxbiCb06fUb+Izic8lpP2bnrYHwpEbMKtlMKJ6mE/QaGO9kCk47K0R+gCXK?= =?us-ascii?Q?nYW7ZVQbFZoYTpq0BeJgs+5nkOAkA5UIjaKIK0VfC4+yPTUW+V70xcUinPgA?= =?us-ascii?Q?X/BvqEwCI4p2+XWz7OhB274rBJc6/JoS5E2lXDPAaIwQa0IlW6wEXMFrbpiX?= =?us-ascii?Q?V9zAR2dsTe9SynoYBYlhjZcKnu2fjWR2FETt2UOVl7AbobIwZHz2uHTnmfa2?= =?us-ascii?Q?WSoKeuaFynYfedEqDfRr9dViYOfX8piIBRAbHUpqvp2ANGAO7vttHNxA7ZfE?= =?us-ascii?Q?wLxKpnguNau1Exg9962SRrcjZS9SzG707yHGZwjbf/voVy9sz3Y+WRAw3Mds?= =?us-ascii?Q?2UaKzB6OdXKujTrVsdxqTcax+jCVcJjnvaXQ73WONiCG8LY/c4zqtMxbVZty?= =?us-ascii?Q?DtOj36bZn6+hG+o9PDtpDyr4+bug6Pe3wAGyja5g+oRXAICclJWwd+IMMcSx?= =?us-ascii?Q?WOVIU26gi+Nx5YbsaugFbs0RI5jLiBaUwA1+Q+ubGYr3CTzsGgoAaxwl39Ci?= =?us-ascii?Q?bKF1+ED9H+MxccA+O/PvJYnaLVTIPfQckwtiKuH0q6ldBZtiQBbleuQk3b6H?= =?us-ascii?Q?gwi/yeLxx4EQxrsNTskCiKnYXPZicpjKS7GHgHQhwHD7nX7CJweln0XK/pJ/?= =?us-ascii?Q?7X69L6N86xDa6aH/Bhn10cXiyMRY5LDImN3vWoIvUIuONKYyp1/oDELJqnOD?= =?us-ascii?Q?/eOpRi8by5cR47OZoxscMbpxpY7tyT1Z/qfPWhVOiCRWwn/co7iyHCqE0ylz?= =?us-ascii?Q?qalECyn34MkpBn3tMhUMI+6Qss2M?= Content-Type: multipart/mixed; boundary="_002_DM5PR12MB1450BAD6325002143B061043873E9DM5PR12MB1450namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1450.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b647ff0b-9cce-4c5b-613e-08d924eddb77 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2021 11:10:25.5979 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fUKw4EgYdG6LygimrDCzhvWBpsUJYMxK5wLWxhgvtNvTIFltbc3jfLdh01er+VOK5NLVGstyy2cTMFAsgRETEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0124 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Kumar N, Bhuvanendra via Gdb-patches" Reply-To: "Kumar N, Bhuvanendra" Cc: "George, Jini Susan" , "Achra, Nitika" , "Sharma, Alok Kumar" , "Tomar, Sourabh Singh" , "E, Nagajyothi" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" --_002_DM5PR12MB1450BAD6325002143B061043873E9DM5PR12MB1450namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - Internal Distribution Only] Hi, Thanks for your comments on this. >For some reason I can't apply your patch, git tells me it's corrupt. >Did you use git-send-email to send it? I used my email client (which is Microsoft outlook) for submitting the patc= h for review. I am reattaching the same old patch(sent on 2021-04-15) as an= attachment this time, in case if it helps for you >Does it work if we just put the whole execlp call on a single line instead= ? Yes, it works fine. if we are putting everything under one line as shred be= low, then it works fine with existing foll-exec.exp itself and no further c= hange is required to foll-exec.exp. 42 execlp (prog, /* tbreak-execlp */ prog, "execlp arg1 from foll-exec", = (char *) 0); . . . 46 execl (prog, /* tbreak-execl */ prog, "execl arg1 from foll-exec", "e= xecl arg2 from foll-exec", (char *) 0); -----Original Message----- From: Simon Marchi =20 Sent: Saturday, May 29, 2021 7:51 AM To: Kumar N, Bhuvanendra ; gdb-patches@sourcewa= re.org Cc: George, Jini Susan ; Achra, Nitika ; Sharma, Alok Kumar ; E, Nagajyothi = ; Tomar, Sourabh Singh Subject: Re: [PATCH] [gdb.base] Add additional next commands for clang-12 a= nd above in foll-exec.exp [CAUTION: External Email] On 2021-04-15 3:37 p.m., Kumar N, Bhuvanendra via Gdb-patches wrote: > [AMD Official Use Only - Internal Distribution Only] > > Hello All, > > I request all of you to please review this patch. Below are the details. > > Problem Description: > Following 8 test points started to fail after the clang patch(https://nam= 11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Freviews.llvm.org%2= FD91734&data=3D04%7C01%7CBhuvanendra.KumarN%40amd.com%7Cbdc30f93800b4f6= c032d08d92248612a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637578516557= 363689%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6= Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DFAPo1TaCGE%2FImUyN3Fhex96GdMVqerc= M6HnzS46bNQ0%3D&reserved=3D0). > > FAIL: gdb.base/foll-exec.exp: step through execlp call > FAIL: gdb.base/foll-exec.exp: step after execlp call > FAIL: gdb.base/foll-exec.exp: print execd-program/global_i (after=20 > execlp) > FAIL: gdb.base/foll-exec.exp: print execd-program/local_j (after=20 > execlp) > FAIL: gdb.base/foll-exec.exp: print follow-exec/local_k (after execlp) > FAIL: gdb.base/foll-exec.exp: step through execl call > FAIL: gdb.base/foll-exec.exp: step after execl call > FAIL: gdb.base/foll-exec.exp: print execd-program/local_j (after=20 > execl) > > Resolution: > > > These comments in the clang patch(https://nam11.safelinks.protection.outl= ook.com/?url=3Dhttps%3A%2F%2Freviews.llvm.org%2FD91734&data=3D04%7C01%7= CBhuvanendra.KumarN%40amd.com%7Cbdc30f93800b4f6c032d08d92248612a%7C3dd8961f= e4884e608e11a82d994e183d%7C0%7C0%7C637578516557373684%7CUnknown%7CTWFpbGZsb= 3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C100= 0&sdata=3DTW7QjCio73C%2B8cqsa56Gd4nh8qxVe04u2gjXPHDDmxg%3D&reserved= =3D0) explain/address the issue : > > ". . .the test is trying to "next" over a function call; gcc attributes a= ll parameter evaluation to the function name, while clang will attribute ea= ch parameter to its own location. And when the parameters span multiple sou= rce lines, the is_stmt heuristic kicks in, so we stop on each line with act= ual parameters. > > This is not ideal IMO; I'd rather be more principled about (a) stop at ev= ery parameter, or (b) stop at no parameters. But without reworking how we d= o is_stmt, I think fiddling the test to do enough single-steps to actually = get past the function call is okay." > > After this clang patch, we can see additional .debug_line entries created= while handling the function call and parameter evaluation as mentioned in = the commit message. Hence to suit the new clang behavior, its suggested to = modify the test case for clang-12 and above. > > Thanks and Regards, > Bhuvan > > Patch content inlined: > > From b6c3646cdd40fae679131107a0b2be4ff5b9eae5 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?=3DE2=3D80=3D9Cbhkumarn=3DE2=3D80=3D9D?=3D=20 > Bhuvanendra.KumarN@amd.com > Date: Fri, 16 Apr 2021 00:18:07 +0530 > Subject: [PATCH] [gdb.base] Additional next commands added for > clang-12 and above. > > After this clang=20 > patch(https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F% > 2Freviews.llvm.org%2FD91734&data=3D04%7C01%7CBhuvanendra.KumarN%40am > d.com%7Cbdc30f93800b4f6c032d08d92248612a%7C3dd8961fe4884e608e11a82d994 > e183d%7C0%7C0%7C637578516557373684%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4 > wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sda > ta=3DTW7QjCio73C%2B8cqsa56Gd4nh8qxVe04u2gjXPHDDmxg%3D&reserved=3D0), = 8 test points started to FAIL in this test case. As mentioned in this PR, "= ...this test is trying to "next" over a function call; gcc attributes all p= arameter evaluation to the function name, while clang will attribute each p= arameter to its own location. And when the parameters span across multiple = source lines, the is_stmt heuristic kicks in, so we stop on each line with = actual parameters...". > We can see additional .debug_line entries getting created after this=20 > clang patch, hence the test case is modified accordingly to suit the=20 > new clang behavior. This test case modification is required for clang-12 = and above. > > Line table: (before clang patch for the below code snippet) : > 0x000000b0: 84 address +=3D 8, line +=3D 2 > 0x000000000020196a 42 3 1 0 0 > 0x000000b1: 08 DW_LNS_const_add_pc (0x0000000000000011) > 0x000000b2: 41 address +=3D 3, line +=3D 5 > 0x000000000020197e 47 3 1 0 0 > > Line table: (after clang patch for the below code snippet) : > 0x000000b5: 84 address +=3D 8, line +=3D 2 > 0x0000000000201958 42 11 1 0 0 > 0x000000b6: 05 DW_LNS_set_column (4) > 0x000000b8: 75 address +=3D 7, line +=3D 1 > 0x000000000020195f 43 4 1 0 0 > 0x000000b9: 05 DW_LNS_set_column (3) > 0x000000bb: 73 address +=3D 7, line +=3D -1 > 0x0000000000201966 42 3 1 0 0 > 0x000000bc: 08 DW_LNS_const_add_pc (0x0000000000000011) > 0x000000bd: 4f address +=3D 4, line +=3D 5 > 0x000000000020197b 47 3 1 0 0 > > gdb.base/foll-exec.c test file snippet : > . . . > 42 execlp (prog, /* tbreak-execlp */ > 43 prog, > 44 "execlp arg1 from foll-exec", > 45 (char *) 0); > 46 > 47 printf ("foll-exec is about to execl(execd-prog)...\n"); > > Following 8 test points started to fail after the above clang patch. > > FAIL: gdb.base/foll-exec.exp: step through execlp call > FAIL: gdb.base/foll-exec.exp: step after execlp call > FAIL: gdb.base/foll-exec.exp: print execd-program/global_i (after=20 > execlp) > FAIL: gdb.base/foll-exec.exp: print execd-program/local_j (after=20 > execlp) > FAIL: gdb.base/foll-exec.exp: print follow-exec/local_k (after execlp) > FAIL: gdb.base/foll-exec.exp: step through execl call > FAIL: gdb.base/foll-exec.exp: step after execl call > FAIL: gdb.base/foll-exec.exp: print execd-program/local_j (after=20 > execl) > > gdb/testsuite/ChangeLog: > * gdb.base/foll-exec.exp: Additional next commands added for > clang-12 and above. > --- > gdb/testsuite/ChangeLog | 5 +++++ > gdb/testsuite/gdb.base/foll-exec.exp | 15 +++++++++++++-- > 2 files changed, 18 insertions(+), 2 deletions(-) For some reason I can't apply your patch, git tells me it's corrupt. Did you use git-send-email to send it? > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index=20 > 52b0752276..ad289c135d 100644 > --- a/gdb/testsuite/ChangeLog > +++ b/gdb/testsuite/ChangeLog > @@ -1,3 +1,8 @@ > +2021-04-16 Bhuvanendra Kumar =20 > +Bhuvanendra.KumarN@amd.com > + > + * gdb.base/foll-exec.exp: Additional next commands added for > + clang-12 and above. > + > 2021-02-12 Andrew Burgess andrew.burgess@embecosm.com > * gdb.fortran/allocated.exp: New file. > diff --git a/gdb/testsuite/gdb.base/foll-exec.exp=20 > b/gdb/testsuite/gdb.base/foll-exec.exp > index 6d5e21f54d..8b1fa42db9 100644 > --- a/gdb/testsuite/gdb.base/foll-exec.exp > +++ b/gdb/testsuite/gdb.base/foll-exec.exp > @@ -118,7 +118,14 @@ proc do_exec_tests {} { > # We should stop in execd-program, at its first statement. > # > set execd_line [gdb_get_line_number "after-exec" $srcfile2] > - send_gdb "next\n" > + # Clang-12 and above will emit extra .debug_line entries when > + # parameters span across multiple source lines, hence additional > + # next commands were added. > + if {[test_compiler_info {clang-1[2-9]-*}]} { > + send_gdb "next 3\n" > + } else { > + send_gdb "next\n" > + } > gdb_expect { > -re ".*xecuting new program: .*${testfile2}.*${srcfile2}:${execd_li= ne}.*int local_j =3D argc;.*$gdb_prompt $"\ > {pass "step through execlp call"} @@ -269,7=20 > +276,11 @@ proc do_exec_tests {} { > # the newly-exec'd program, not after the remaining step-count > # reaches zero. > # > - send_gdb "next 2\n" > + if {[test_compiler_info {clang-1[2-9]-*}]} { > + send_gdb "next 3\n" > + } else { > + send_gdb "next 2\n" > + } > gdb_expect { > -re ".*xecuting new program: .*${testfile2}.*${srcfile2}:${execd_li= ne}.*int local_j =3D argc;.*$gdb_prompt $"\ > {pass "step through execl call"} > -- > 2.17.1 Does it work if we just put the whole execlp call on a single line instead? Simon --_002_DM5PR12MB1450BAD6325002143B061043873E9DM5PR12MB1450namp_ Content-Type: application/octet-stream; name="gdb.base-Additional-next-commands-added.patch" Content-Description: gdb.base-Additional-next-commands-added.patch Content-Disposition: attachment; filename="gdb.base-Additional-next-commands-added.patch"; size=4834; creation-date="Tue, 01 Jun 2021 11:07:00 GMT"; modification-date="Tue, 01 Jun 2021 11:07:00 GMT" Content-Transfer-Encoding: base64 RnJvbSBiNmMzNjQ2Y2RkNDBmYWU2NzkxMzExMDdhMGIyYmU0ZmY1YjllYWU1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/PUUyPTgwPTlDYmhrdW1hcm49RTI9ODA9OUQ/ PSA8Qmh1dmFuZW5kcmEuS3VtYXJOQGFtZC5jb20+CkRhdGU6IEZyaSwgMTYgQXByIDIwMjEgMDA6 MTg6MDcgKzA1MzAKU3ViamVjdDogW1BBVENIXSBbZ2RiLmJhc2VdIEFkZGl0aW9uYWwgbmV4dCBj b21tYW5kcyBhZGRlZCBmb3IKIGNsYW5nLTEyIGFuZCBhYm92ZS4KCkFmdGVyIHRoaXMgY2xhbmcg cGF0Y2goaHR0cHM6Ly9yZXZpZXdzLmxsdm0ub3JnL0Q5MTczNCksIDggdGVzdCBwb2ludHMKc3Rh cnRlZCB0byBGQUlMIGluIHRoaXMgdGVzdCBjYXNlLiBBcyBtZW50aW9uZWQgaW4gdGhpcyBQUiwK Ii4uLnRoaXMgdGVzdCBpcyB0cnlpbmcgdG8gIm5leHQiIG92ZXIgYSBmdW5jdGlvbiBjYWxsOyBn Y2MgYXR0cmlidXRlcwphbGwgcGFyYW1ldGVyIGV2YWx1YXRpb24gdG8gdGhlIGZ1bmN0aW9uIG5h bWUsIHdoaWxlIGNsYW5nIHdpbGwgYXR0cmlidXRlCmVhY2ggcGFyYW1ldGVyIHRvIGl0cyBvd24g bG9jYXRpb24uIEFuZCB3aGVuIHRoZSBwYXJhbWV0ZXJzIHNwYW4gYWNyb3NzCm11bHRpcGxlIHNv dXJjZSBsaW5lcywgdGhlIGlzX3N0bXQgaGV1cmlzdGljIGtpY2tzIGluLCBzbyB3ZSBzdG9wIG9u IGVhY2gKbGluZSB3aXRoIGFjdHVhbCBwYXJhbWV0ZXJzLi4uIi4KV2UgY2FuIHNlZSBhZGRpdGlv bmFsIC5kZWJ1Z19saW5lIGVudHJpZXMgZ2V0dGluZyBjcmVhdGVkIGFmdGVyIHRoaXMgY2xhbmcK cGF0Y2gsIGhlbmNlIHRoZSB0ZXN0IGNhc2UgaXMgbW9kaWZpZWQgYWNjb3JkaW5nbHkgdG8gc3Vp dCB0aGUgbmV3IGNsYW5nCmJlaGF2aW9yLiBUaGlzIHRlc3QgY2FzZSBtb2RpZmljYXRpb24gaXMg cmVxdWlyZWQgZm9yIGNsYW5nLTEyIGFuZCBhYm92ZS4KCkxpbmUgdGFibGU6IChiZWZvcmUgY2xh bmcgcGF0Y2ggZm9yIHRoZSBiZWxvdyBjb2RlIHNuaXBwZXQpIDoKMHgwMDAwMDBiMDogODQgYWRk cmVzcyArPSA4LCAgbGluZSArPSAyCiAgICAgICAgICAgIDB4MDAwMDAwMDAwMDIwMTk2YSAgICAg NDIgICAgICAzICAgICAgMSAgIDAgICAgICAgICAgICAgMAoweDAwMDAwMGIxOiAwOCBEV19MTlNf Y29uc3RfYWRkX3BjICgweDAwMDAwMDAwMDAwMDAwMTEpCjB4MDAwMDAwYjI6IDQxIGFkZHJlc3Mg Kz0gMywgIGxpbmUgKz0gNQogICAgICAgICAgICAweDAwMDAwMDAwMDAyMDE5N2UgICAgIDQ3ICAg ICAgMyAgICAgIDEgICAwICAgICAgICAgICAgIDAKCkxpbmUgdGFibGU6IChhZnRlciBjbGFuZyBw YXRjaCBmb3IgdGhlIGJlbG93IGNvZGUgc25pcHBldCkgOgoweDAwMDAwMGI1OiA4NCBhZGRyZXNz ICs9IDgsICBsaW5lICs9IDIKICAgICAgICAgICAgMHgwMDAwMDAwMDAwMjAxOTU4ICAgICA0MiAg ICAgMTEgICAgICAxICAgMCAgICAgICAgICAgICAwCjB4MDAwMDAwYjY6IDA1IERXX0xOU19zZXRf Y29sdW1uICg0KQoweDAwMDAwMGI4OiA3NSBhZGRyZXNzICs9IDcsICBsaW5lICs9IDEKICAgICAg ICAgICAgMHgwMDAwMDAwMDAwMjAxOTVmICAgICA0MyAgICAgIDQgICAgICAxICAgMCAgICAgICAg ICAgICAwCjB4MDAwMDAwYjk6IDA1IERXX0xOU19zZXRfY29sdW1uICgzKQoweDAwMDAwMGJiOiA3 MyBhZGRyZXNzICs9IDcsICBsaW5lICs9IC0xCiAgICAgICAgICAgIDB4MDAwMDAwMDAwMDIwMTk2 NiAgICAgNDIgICAgICAzICAgICAgMSAgIDAgICAgICAgICAgICAgMAoweDAwMDAwMGJjOiAwOCBE V19MTlNfY29uc3RfYWRkX3BjICgweDAwMDAwMDAwMDAwMDAwMTEpCjB4MDAwMDAwYmQ6IDRmIGFk ZHJlc3MgKz0gNCwgIGxpbmUgKz0gNQogICAgICAgICAgICAweDAwMDAwMDAwMDAyMDE5N2IgICAg IDQ3ICAgICAgMyAgICAgIDEgICAwICAgICAgICAgICAgIDAKCmdkYi5iYXNlL2ZvbGwtZXhlYy5j IHRlc3QgZmlsZSBzbmlwcGV0IDoKLiAuIC4KIDQyICAgZXhlY2xwIChwcm9nLCAvKiB0YnJlYWst ZXhlY2xwICovCiA0MyAgICAgICAgICAgcHJvZywKIDQ0ICAgICAgICAgICAiZXhlY2xwIGFyZzEg ZnJvbSBmb2xsLWV4ZWMiLAogNDUgICAgICAgICAgIChjaGFyICopIDApOwogNDYKIDQ3ICAgcHJp bnRmICgiZm9sbC1leGVjIGlzIGFib3V0IHRvIGV4ZWNsKGV4ZWNkLXByb2cpLi4uXG4iKTsKCkZv bGxvd2luZyA4IHRlc3QgcG9pbnRzIHN0YXJ0ZWQgdG8gZmFpbCBhZnRlciB0aGUgYWJvdmUgY2xh bmcgcGF0Y2guCgpGQUlMOiBnZGIuYmFzZS9mb2xsLWV4ZWMuZXhwOiBzdGVwIHRocm91Z2ggZXhl Y2xwIGNhbGwKRkFJTDogZ2RiLmJhc2UvZm9sbC1leGVjLmV4cDogc3RlcCBhZnRlciBleGVjbHAg Y2FsbApGQUlMOiBnZGIuYmFzZS9mb2xsLWV4ZWMuZXhwOiBwcmludCBleGVjZC1wcm9ncmFtL2ds b2JhbF9pIChhZnRlciBleGVjbHApCkZBSUw6IGdkYi5iYXNlL2ZvbGwtZXhlYy5leHA6IHByaW50 IGV4ZWNkLXByb2dyYW0vbG9jYWxfaiAoYWZ0ZXIgZXhlY2xwKQpGQUlMOiBnZGIuYmFzZS9mb2xs LWV4ZWMuZXhwOiBwcmludCBmb2xsb3ctZXhlYy9sb2NhbF9rIChhZnRlciBleGVjbHApCkZBSUw6 IGdkYi5iYXNlL2ZvbGwtZXhlYy5leHA6IHN0ZXAgdGhyb3VnaCBleGVjbCBjYWxsCkZBSUw6IGdk Yi5iYXNlL2ZvbGwtZXhlYy5leHA6IHN0ZXAgYWZ0ZXIgZXhlY2wgY2FsbApGQUlMOiBnZGIuYmFz ZS9mb2xsLWV4ZWMuZXhwOiBwcmludCBleGVjZC1wcm9ncmFtL2xvY2FsX2ogKGFmdGVyIGV4ZWNs KQoKZ2RiL3Rlc3RzdWl0ZS9DaGFuZ2VMb2c6CiAgICAgICAgKiBnZGIuYmFzZS9mb2xsLWV4ZWMu ZXhwOiBBZGRpdGlvbmFsIG5leHQgY29tbWFuZHMgYWRkZWQgZm9yCiAgICAgICAgY2xhbmctMTIg YW5kIGFib3ZlLgotLS0KIGdkYi90ZXN0c3VpdGUvQ2hhbmdlTG9nICAgICAgICAgICAgICB8ICA1 ICsrKysrCiBnZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2ZvbGwtZXhlYy5leHAgfCAxNSArKysrKysr KysrKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRlL0NoYW5nZUxvZyBiL2dkYi90ZXN0c3VpdGUv Q2hhbmdlTG9nCmluZGV4IDUyYjA3NTIyNzYuLmFkMjg5YzEzNWQgMTAwNjQ0Ci0tLSBhL2dkYi90 ZXN0c3VpdGUvQ2hhbmdlTG9nCisrKyBiL2dkYi90ZXN0c3VpdGUvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsOCBAQAorMjAyMS0wNC0xNiAgQmh1dmFuZW5kcmEgS3VtYXIgIDxCaHV2YW5lbmRyYS5LdW1h ck5AYW1kLmNvbT4KKworICAgICAgICAqIGdkYi5iYXNlL2ZvbGwtZXhlYy5leHA6IEFkZGl0aW9u YWwgbmV4dCBjb21tYW5kcyBhZGRlZCBmb3IKKwljbGFuZy0xMiBhbmQgYWJvdmUuCisKIDIwMjEt MDItMTIgIEFuZHJldyBCdXJnZXNzICA8YW5kcmV3LmJ1cmdlc3NAZW1iZWNvc20uY29tPgogCiAJ KiBnZGIuZm9ydHJhbi9hbGxvY2F0ZWQuZXhwOiBOZXcgZmlsZS4KZGlmZiAtLWdpdCBhL2dkYi90 ZXN0c3VpdGUvZ2RiLmJhc2UvZm9sbC1leGVjLmV4cCBiL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2Uv Zm9sbC1leGVjLmV4cAppbmRleCA2ZDVlMjFmNTRkLi44YjFmYTQyZGI5IDEwMDY0NAotLS0gYS9n ZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2ZvbGwtZXhlYy5leHAKKysrIGIvZ2RiL3Rlc3RzdWl0ZS9n ZGIuYmFzZS9mb2xsLWV4ZWMuZXhwCkBAIC0xMTgsNyArMTE4LDE0IEBAIHByb2MgZG9fZXhlY190 ZXN0cyB7fSB7CiAgICAjIFdlIHNob3VsZCBzdG9wIGluIGV4ZWNkLXByb2dyYW0sIGF0IGl0cyBm aXJzdCBzdGF0ZW1lbnQuCiAgICAjCiAgICBzZXQgZXhlY2RfbGluZSBbZ2RiX2dldF9saW5lX251 bWJlciAiYWZ0ZXItZXhlYyIgJHNyY2ZpbGUyXQotICAgc2VuZF9nZGIgIm5leHRcbiIKKyAgICMg Q2xhbmctMTIgYW5kIGFib3ZlIHdpbGwgZW1pdCBleHRyYSAuZGVidWdfbGluZSBlbnRyaWVzIHdo ZW4KKyAgICMgcGFyYW1ldGVycyBzcGFuIGFjcm9zcyBtdWx0aXBsZSBzb3VyY2UgbGluZXMsIGhl bmNlIGFkZGl0aW9uYWwKKyAgICMgbmV4dCBjb21tYW5kcyB3ZXJlIGFkZGVkLgorICAgaWYge1t0 ZXN0X2NvbXBpbGVyX2luZm8ge2NsYW5nLTFbMi05XS0qfV19IHsKKyAgICAgICBzZW5kX2dkYiAi bmV4dCAzXG4iCisgICB9IGVsc2UgeworICAgICAgIHNlbmRfZ2RiICJuZXh0XG4iCisgICB9CiAg ICBnZGJfZXhwZWN0IHsKICAgICAgLXJlICIuKnhlY3V0aW5nIG5ldyBwcm9ncmFtOiAuKiR7dGVz dGZpbGUyfS4qJHtzcmNmaWxlMn06JHtleGVjZF9saW5lfS4qaW50ICBsb2NhbF9qID0gYXJnYzsu KiRnZGJfcHJvbXB0ICQiXAogICAgICAgICAgICAgICAgICAgICAge3Bhc3MgInN0ZXAgdGhyb3Vn aCBleGVjbHAgY2FsbCJ9CkBAIC0yNjksNyArMjc2LDExIEBAIHByb2MgZG9fZXhlY190ZXN0cyB7 fSB7CiAgICAjIHRoZSBuZXdseS1leGVjJ2QgcHJvZ3JhbSwgbm90IGFmdGVyIHRoZSByZW1haW5p bmcgc3RlcC1jb3VudAogICAgIyByZWFjaGVzIHplcm8uCiAgICAjCi0gICBzZW5kX2dkYiAibmV4 dCAyXG4iCisgICBpZiB7W3Rlc3RfY29tcGlsZXJfaW5mbyB7Y2xhbmctMVsyLTldLSp9XX0gewor ICAgICAgIHNlbmRfZ2RiICJuZXh0IDNcbiIKKyAgIH0gZWxzZSB7CisgICAgICAgc2VuZF9nZGIg Im5leHQgMlxuIgorICAgfQogICAgZ2RiX2V4cGVjdCB7CiAgICAgIC1yZSAiLip4ZWN1dGluZyBu ZXcgcHJvZ3JhbTogLioke3Rlc3RmaWxlMn0uKiR7c3JjZmlsZTJ9OiR7ZXhlY2RfbGluZX0uKmlu dCAgbG9jYWxfaiA9IGFyZ2M7LiokZ2RiX3Byb21wdCAkIlwKICAgICAgICAgICAgICAgICAgICAg IHtwYXNzICJzdGVwIHRocm91Z2ggZXhlY2wgY2FsbCJ9Ci0tIAoyLjE3LjEKCg== --_002_DM5PR12MB1450BAD6325002143B061043873E9DM5PR12MB1450namp_--