From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id p94PNtlozmkY+AMAWB0awg (envelope-from ) for ; Thu, 02 Apr 2026 09:02:17 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=aKyDGW82; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CC4D01E04F; Thu, 02 Apr 2026 09:02:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 80F7A1E04F for ; Thu, 02 Apr 2026 09:02:16 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 77A844BA23FB for ; Thu, 2 Apr 2026 13:02:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 77A844BA23FB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=aKyDGW82 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010071.outbound.protection.outlook.com [52.101.85.71]) by sourceware.org (Postfix) with ESMTPS id 4EF754BA2E19 for ; Thu, 2 Apr 2026 13:01:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4EF754BA2E19 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4EF754BA2E19 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=52.101.85.71 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1775134903; cv=pass; b=CVbPwUsp+u044YKzIT7e+8mNqDrYxIAscgUPY0FKuAEbSOxsZqOXlh0gmgfOdwZoPX9ZlxQRbTTBtkmHRAGgpr20IaVtt0B1j2tUOEWDK1PgPXnhukX+NblbXBFGpKA9YZaANTwBve0uEqlBOX97uDjr5GaqvylDIBL0J2WeSZQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1775134903; c=relaxed/simple; bh=yPGKhLMsFmF5hcve7IDKae04dcr6kYbnF0AOeJXPFlQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Md4AWoMCzi4+g5cf85kMu4zHEwKJh6u07eLwOtwALM/H/rImcMZ9+sdNfvUlFtwwVMpMyJvQiI/RlpvleB06vTsQLNYghMLXno9LTUxOk+Sj51zica4ED3VI1rlKECAbKkT1Hk57r561ll8gg1IRnFifjey8hlMBJLPM0vFSTrc= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4EF754BA2E19 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Xug5UI2dBRaPcuI8e4LYMdzVa+3xZCJwuN3z+W6uWTZs+vgreLnTSA0+D8adPAmpMa4LSjQEyb8yVFRSqD5eGjayMrF/2/7+UUaPvQijRSd2k7M1r/0Vun7VPGU5sljZ7fOtbORFNZTY6gP0H+DnkzhXxfmP6x+sTVQECCtFOgzWJF5nibeDV2aUdqQ0a/YATgEJtiiT4FQ7U+nlUoR722AOIp5F52HYTJUu8vm49QQCGqviwKBQUjiFM4k4zHSa/PjDxio5jkrLkc2OGLptwEMfGJJG40trcD9QHyeZvko/TKx1uLzGWIYDNEEY4alf3FqUL1d+k8vPt5YBab6W1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iQ9ygCn9GDOPtrBUGpayKjjn0HneDfmeALWPlAxaRP0=; b=B0qgA1zyG2FBmdKPDQaDgch1yzlxwiXOsjPM3chKEKVuxxrAnANnZJZl8bTLDnWLYPPMAU/CfcM+9dccKn5X/7BvlbNf/AlxuNHJ6f/yN9USCQJbpEhoYghExUOPdYiiKLtdTNk3iuF9I+KWINy9CbuLD8rXe0oPsUxMmDG/yrJ5gLsxXENrJXbmpg5CJZiYRMHFi/knwPOV9rC5Zdj8Zc9/kBbWfUvMn28dIOaFINyyw6JYZWmWZmJrnTdwyWXlI7enqiCoLf2w5ThRa9WKusmTiNM5mSgu3uLBKc9O1Ldsk45VASzzNeOrsTWifih1D5GroFUr+igEZy9RwbixWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iQ9ygCn9GDOPtrBUGpayKjjn0HneDfmeALWPlAxaRP0=; b=aKyDGW82GNCuAKsAbFPYoOXOCpk3qL4CviGEkBC0p3vO3uxapKc3BUHw9BJxfPsbxB9GpTHxoZJJY7swJuKnciWeVk1ZJ2iiF2FPn8kZ7QNPDUOU+jmgix4Z+/YAP/lrqYjS46K94Z+RoXjmr3lNXYH86td4+OX7a8dhvXURJcw= Received: from DM4PR12MB7623.namprd12.prod.outlook.com (2603:10b6:8:108::13) by IA0PR12MB8908.namprd12.prod.outlook.com (2603:10b6:208:48a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.20; Thu, 2 Apr 2026 13:01:36 +0000 Received: from DM4PR12MB7623.namprd12.prod.outlook.com ([fe80::d694:7c9d:58ba:8fb4]) by DM4PR12MB7623.namprd12.prod.outlook.com ([fe80::d694:7c9d:58ba:8fb4%5]) with mapi id 15.20.9769.017; Thu, 2 Apr 2026 13:01:36 +0000 From: "Filipovic, Bratislav" To: Andrew Burgess CC: "gdb-patches@sourceware.org" , "simon.marchi@efficios.com" Subject: RE: [PATCH] test: basename filenames in dwarf2 frame checks Thread-Topic: [PATCH] test: basename filenames in dwarf2 frame checks Thread-Index: AQHcvHUuq41xvPr+fEOmOeaS+0iOB7XLmUAAgAADqwCAAClqgIAAAgxA Date: Thu, 2 Apr 2026 13:01:36 +0000 Message-ID: References: <87a4vl659l.fsf@redhat.com> <20260402102559.323847-1-bfilipov@amd.com> <874ilt5xso.fsf@redhat.com> In-Reply-To: <874ilt5xso.fsf@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=True; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2026-04-02T13:00:14.0000000Z; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=3; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB7623:EE_|IA0PR12MB8908:EE_ x-ms-office365-filtering-correlation-id: fda14f9c-0f08-4cf5-2824-08de90b7f907 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700021|56012099003|18002099003|22082099003; x-microsoft-antispam-message-info: FtgCOMdYa0/X1E1es8ANyzCdH98dKqtSX8yXYTjFMptMfFlomM+DR/Ejda7x3sYM3BiOtXn5bHLa8nx4wqFx3nGG1h8EpibIPJHEBHRq87UH10F15Z2ytUTUGMB8MScKTtOy8s+ixE1KMo8tm24mz5FLEb5Gd6hBPn55sZ9gvYieRsZcZ8EBF4QaYhi9sCtXUkdZ7MnqpSlCUegk9xjchoKAcN//X76YAWhYeclrVnokRDd4ClGyjpp3gbxaG9lUmKAmRF/5aPJuYowCBCDj5aU8m+gEp4cX3N9m5+bOvhyRImMqHoOSZTKAT2retzWUxmGQL/1D4WKkF0tNI1w03PDefW0Ua8hFSomK3aWpeLZy74IK2k+uy2m9FE016vFwY4eSHm25Q9LMzu2WVceaBUvTa9tfQH6/RPS1b0n4F2kxAJAqbKo/llHwZMNC1/xnhoI8iJ0LlR1YVzJBWw96hlneZP8lbTHbGpbNAmaS3h/1wQhbBP7KW+TWTuEnSzFWHPnmpRmVy7Dr3YpRmZ+9Z6lGP9lF5Joz1FIVTS9P1HEu1J6ceyE9j9IngLA5zN8Qawyx/vxJxnh5AzsoTzLCWiUPTpfWAg+mG6aKjNIgetn4h72pKJrz5Z6EI8kYRh56yK7m3VOedi48YTuJgxVJza2oifPuenGM6UKNtCL5hgvzs9TA1gb2i6lkIIsgqwYDydg6qR9xv1PVVRDBWSn89MA4Km6VEl0DfFqwXjchI01aTMu25mnd3RhHGQaOgzf1PphD9q9wVd2Uatmpkv/qzOS26vdFLdBGnEU3JAj+fsg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB7623.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700021)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0GE1e18C5v9ZSLadscyo0I9TilnmJAaRfZntLYfP4fdSnWYDIvS/DuOWR/Jo?= =?us-ascii?Q?XD2yQjhjQVXcdfUjnmmTNdIN5T87hMYPP5zLbW+bcU7MyhYcnprfq/ZmHhW2?= =?us-ascii?Q?PP4miCY1+UHpugrwsCV3L3tG1DzbRVDhKp/d+2PEQvV/sTfdOOJAr5lhBoTp?= =?us-ascii?Q?zTcNrOMmE09iiF5ILmqlMsEqDNnEldeZMS1hSPfMGZ/5jpBdWbz5AAInhNpz?= =?us-ascii?Q?aWNDyNQW/gEYATRQ5adjj1Yf9okuUjezw5cOVog4a6rCOKJYwfiXCj9P6TDK?= =?us-ascii?Q?rc8jicgl1TuvFqSW7pfhrWuLtkouXqMooIaAJ24xOyv/gY6nj20SzM+S6wGq?= =?us-ascii?Q?BtomiWzdSFCjpN9zh0AvxQLzLKVKzav6FQHS2w7NQcZHxIM1sHl/AhEcB4pY?= =?us-ascii?Q?Oh6RCULjR6zLkXOibtcc6dHt93k2o6eJs0IyDrqPt3hFfhu1mNPKr62frY/l?= =?us-ascii?Q?e1r8AP4Uc4+1NX4GYxQMnrycMcSYI2AdkOUvQ/HtTR0m9hP2nHXG5QwUtwek?= =?us-ascii?Q?3fAclUFvX8mfaZXaUui8JCBac3JgtWL9ZWY36E1YK3quv54sT65+L8vFlqgY?= =?us-ascii?Q?KYF47hXMhzaEgFgJMcDdDM+o/uDbzRNsweB0amNtfjWe3lgFzkh1ur8TWDIX?= =?us-ascii?Q?50vleCh3+ehae3lOyNaUupcecytubt0zdPrybRITO7LYjQVXAkznduYiI+DD?= =?us-ascii?Q?y6exXJ4YPFTpCUfbUgZSchn8NTEIQShk1P70yBbtCMHWbMz3TYK2qoZrAxNw?= =?us-ascii?Q?M88NeP3Vq7m8GzksjPzZfwq51KG3+1MNoTh57FZbzy1i9FHc2hhGjBeB7Ns4?= =?us-ascii?Q?8IJLJdXSLFnwnoV2KklGaVFoN6Re6UdieVo1yvd9FBgHi9y7AFlfR+IKb/AX?= =?us-ascii?Q?nnvx9mDYU1xarueVt+afMCe73qTQziSRwG7SdKUrd0jU1BONVuUBhbinFO0R?= =?us-ascii?Q?JOQXb4oy8aF5ZLf8vsmNtH8KE0tMMMxtMq4QBEo5auDr7I9ufVtFy4JOe9Ic?= =?us-ascii?Q?P78MUAc30FJi7AJ9tRlFvUnmpkFSsgIxXP9Cu1DZKDtKO0NwcysrrXcl2uXh?= =?us-ascii?Q?StpEZ4BNdR7sDAPhQmkaNlVYFashb1eeI5GEjY7p0ENq2eu6V1blyJxWbaCR?= =?us-ascii?Q?Ut0CClq7QSIqb9yEA6QpZ3xviz3U/R+8fITk6lyJWLdKmX9LbHDzVVSLpbre?= =?us-ascii?Q?VHzyvzM9vv18l0hM+D3lHYZarNJV2/OXEiagMTs5v0frpcfPfFI3ykO6JdTt?= =?us-ascii?Q?6DibuvbYv1vzhFE5oCeaN+drMZ45VXjofGqc8o4/gO8ApNcRyxyi4fuIZNUm?= =?us-ascii?Q?OJOIJPOBmNTv6RKZGtnMpeGqDpuqz48RwSlI492SJ0bVOPOXwo5uKIItpn1t?= =?us-ascii?Q?zEpBp6LxjAJphiqQX2w1iSw0M6NVvGRefTCwdX68ty74rxSTExkNyhdyUw+2?= =?us-ascii?Q?icObBVmAaDntjyE0R9JNX08xYhcvH2p0f/rinX6mA9DmgsllBGplFYclbjUg?= =?us-ascii?Q?zmyvFb/d/lFvGtEd7SO52FrfhYOEfA1EXAkz1+Vwb1WUv2jYUMxOoCWAzboB?= =?us-ascii?Q?ga1F1MWAMef/GIhMoxmPk+iSRk65YeZZ2ite0+7dcvWcFxhTWg7xCqKUOzjp?= =?us-ascii?Q?w5qxG12343sUK9fmQSR88gWSDzJp7CUT8RWjJeHROIJEpthsBjf6qc1dPB9y?= =?us-ascii?Q?13MFvrYKZIWGWnN7hdTOdNIS3JsrWgl8VWCaT5XumRJ0q6MC?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB7623.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fda14f9c-0f08-4cf5-2824-08de90b7f907 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2026 13:01:36.4368 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5VaKQXbAOXo+tABlFNwRMEwWWJXuQCfzoQTvnM+WvKxEYCWYETXkKQTnOHKwFJEs3Nu17k+Hh+U0D7uS2jyJ/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8908 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org [AMD Official Use Only - AMD Internal Distribution Only] Hello Andrew, I still don't have write-after-approval yet. Can you get it pushed? Regards Bratislav -----Original Message----- From: Andrew Burgess Sent: Thursday, April 2, 2026 2:53 PM To: Filipovic, Bratislav Cc: Filipovic, Bratislav ; gdb-patches@sourcew= are.org; simon.marchi@efficios.com Subject: Re: [PATCH] test: basename filenames in dwarf2 frame checks [You don't often get email from aburgess@redhat.com. Learn why this is impo= rtant at https://aka.ms/LearnAboutSenderIdentification ] Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Bratislav Filipovic writes: > Some gdb.dwarf2 tests match the output of commands like frame and > expect to see locations printed as fission-base.c:LINE (no directory > prefix). When the test programs are built with clang as > CC_FOR_TARGET, GDB can print an absolute source path instead, causing FAI= Ls. > > For example, with clang: > > (gdb) PASS: gdb.dwarf2/fission-base.exp: ptype func > (gdb) frame > #0 main () at /path/to/gdb/testsuite/fission-base.c:27 > 27 return func (-1); > (gdb) FAIL: gdb.dwarf2/fission-base.exp: frame in main > > With gcc: > > (gdb) PASS: gdb.dwarf2/fission-base.exp: ptype func > (gdb) frame > #0 main () at fission-base.c:27 > 27 return func (-1); > (gdb) PASS: gdb.dwarf2/fission-base.exp: frame in main > > The difference comes from the DWARF line table contents. With clang, > the .debug_line directory table can contain an absolute directory that > the file table entries reference: > > The Directory Table: > 0 /path/to/gdb/testsuite > > The File Name Table: > 0 Dir=3D0 Name=3Dfission-base.c > 1 Dir=3D0 Name=3Dfission-base.c > > Whereas with gcc the directory table is empty and only the bare > filename is present: > > The Directory Table is empty. > > The File Name Table: > 1 Name=3Dfission-base.c > > This difference reflects toolchain/assembler behavior in how > .file/.loc are translated into .debug_line and is orthogonal to what > these tests aim to validate. > > Force set filename-display basename in the affected tests so the > output is stable across toolchains. > > Test: gdb.dwarf2/fission-base.exp (CC_FOR_TARGET=3Dclang, gcc) > Test: gdb.dwarf2/dw2-undefined-ret-addr.exp (CC_FOR_TARGET=3Dclang, gcc) > --- > > Thanks for the review Andrew. Fixed the comments. Looks good. Feel free to push this patch. Approved-By: Andrew Burgess Thanks, Andrew > > Regards Bratislav > > > gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp | 5 +++++ > gdb/testsuite/gdb.dwarf2/fission-base.exp | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp > b/gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp > index 32ddaf4a..88765d4f 100644 > --- a/gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp > +++ b/gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp > @@ -30,6 +30,11 @@ if {![runto "stop_frame"]} { > return -1 > } > > +# If test is compiled with clang, GDB would display absolute path. > +# This command keeps output consistent across toolchains. > + > +gdb_test_no_output "set filename-display basename" > + > # stop_frame should be the outermost frame. > > # Check that backtrace shows only frame #0. > diff --git a/gdb/testsuite/gdb.dwarf2/fission-base.exp > b/gdb/testsuite/gdb.dwarf2/fission-base.exp > index 035fe731..d1abf6c9 100644 > --- a/gdb/testsuite/gdb.dwarf2/fission-base.exp > +++ b/gdb/testsuite/gdb.dwarf2/fission-base.exp > @@ -46,6 +46,11 @@ if {![runto_main]} { gdb_test "ptype main" "type =3D > int \\(\\)" > gdb_test "ptype func" "type =3D int \\(int\\)" > > +# If test is compiled with clang, GDB would display absolute path. > +# This command keeps output consistent across toolchains. > + > +gdb_test_no_output "set filename-display basename" > + > gdb_test "frame" "#0 *main \\(\\) at $testfile\\.c:$decimal.*" \ > "frame in main" > > -- > 2.43.0