From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7351JKZadGogqQwAWB0awg (envelope-from ) for ; Thu, 06 Aug 2026 05:57:58 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=UbIr6fUZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 833B31E166; Thu, 06 Aug 2026 05:57:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 416691E033 for ; Thu, 06 Aug 2026 05:57:56 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BBC5E4BB3BD8 for ; Thu, 6 Aug 2026 09:57:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BBC5E4BB3BD8 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=UbIr6fUZ Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013032.outbound.protection.outlook.com [40.93.196.32]) by sourceware.org (Postfix) with ESMTPS id ECF564BAE7CC for ; Thu, 6 Aug 2026 09:57:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ECF564BAE7CC Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ECF564BAE7CC Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=40.93.196.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1786010247; cv=pass; b=Ble5BV6whyKtyqImiBpjeztKwmTCuoGaWnc5FaNWGBiLWXZPLICqb+WOLxn2XEH4PLTV9dD3c+bswDv1u8bJXSTaK0v0gP6awp/5+GcGSqS3PRNRwXmycE2a+T6GELgw9twoSvQRMqlBHzfkkdcRYtuCnCtOXqHyAJtPmr8zC/Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1786010247; c=relaxed/simple; bh=tD67VDCsce8uaQFDNGNx1HPC9R3vEu005KhfDVJxaM8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Spx09QaLTf36/Y21tpk2Ddjml/LRYXeRMQ5wtHqQoXpUwIfmO6QoQoEOsomltPTfDITXTlErcJK2VgRUXCwQd0ZeX1dmkVvia6ne1KWQVyH5BrrvaUTJFuipaVmPnm+xthd7bHbnFQazR8H+1lbPDcLAuGY5mcMuEv1mcySNqS4= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=UbIr6fUZ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ECF564BAE7CC ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nLjS+ivx7vcwEa5oPcdRpJkvg80cI38D/vOev5BLccsXtFdJu3cGCmn+xqrK2MzfmqbmLdiaJqKkASBj02k+gfN/P1zqpbgrzhJQ/lEv+6n+BG+ZQ3q9NoXhLIu/84KerFf2WR6lcmrc9tSq+NyoRJM7hNGY74YkdDQSNWB6X6Y7YP8Wj9v3sk6ml89E2Wi/tE4xNJe7x7TRenjUwoY1wfxLmc0JP18zheDkyVYvy8FUEHVLh3UCo/wNz8V8XF6yghz6/nngLxSkrbGQHl+2Z15fhMMcFOhUDRmHRxSs0Zz4KbftYYRDqQQLDxi0Ow8PZAVXECOr5RF64WQXvCglvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kRTjl6FqsLiT9iE4BODzya4kX5QD4EQCGUEcZUpZiLQ=; b=AG/OMkd/Bx7o8WV+EEX6K5M+Iq5Km3LxrFQZrS/KAEXEg3yvRM3H2rMreiXTUIj5/bTqiHWf1mksH9rFZhLU5aN5yHq9DQDXUpJnGdPxLV9KkZSn/GDmTWgmy/TGGU4oiMwnjKPCEsv/sj+2lGusYtgYh2YA8sliCpC6Ex9oc2s2kyNxIFvSK52yuXc6tZFw9XOg9+y3UgFH1kkvbpxVD9ldzuhxq/LGBe8/eaB0AIvla8z64U6ekhKeJFjRbhC7lAIyfgHMpOYGw42Zhga2cpnJ4Har8U2SQf2IkFzCRqqEgRMwkbT/Z4sWCa+RHFyN7RsE+igMnyaRXGNZv8Vf6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kRTjl6FqsLiT9iE4BODzya4kX5QD4EQCGUEcZUpZiLQ=; b=UbIr6fUZnte2LS4XD6ybZOFyjFeweyRcbmSkthNIRmSp5K44lq18C7Is0c3fLs+ENxVjeH2nlcuYkp9Vki0CBDWvbp1xW4+CgKuAjkAyVqzazMuP7m4VdKuHLbqszhQWgIDYMsU7p1beRCVXY4+t3cABPP7r2hDcCP3/6LQatsE= Received: from DM4PR12MB6470.namprd12.prod.outlook.com (2603:10b6:8:b8::12) by SA3PR12MB9228.namprd12.prod.outlook.com (2603:10b6:806:39c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Thu, 6 Aug 2026 09:57:23 +0000 Received: from DM4PR12MB6470.namprd12.prod.outlook.com ([fe80::c988:e72b:f5b3:db1b]) by DM4PR12MB6470.namprd12.prod.outlook.com ([fe80::c988:e72b:f5b3:db1b%3]) with mapi id 15.21.0292.018; Thu, 6 Aug 2026 09:57:23 +0000 From: "Aktemur, Baris" To: Tom Tromey , "gdb-patches@sourceware.org" Subject: RE: [PATCH] Remove redundant check from check_types_equal Thread-Topic: [PATCH] Remove redundant check from check_types_equal Thread-Index: AQHdJRHpSKnQpzshREyk7dlfnTNisLaQyV8A Date: Thu, 6 Aug 2026 09:57:23 +0000 Message-ID: References: <20260805193723.175636-1-tromey@adacore.com> In-Reply-To: <20260805193723.175636-1-tromey@adacore.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Enabled=True; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SetDate=2026-08-06T09:55:47.0000000Z; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Name=AMD General v26; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_ContentBits=3; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB6470:EE_|SA3PR12MB9228:EE_ x-ms-office365-filtering-correlation-id: 2f2e1da3-b227-466f-d84a-08def3a11d21 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|23010399003|22082099003|18002099003|11063799006|56012099006|38070700021|10067099003; x-microsoft-antispam-message-info: cb32fCnB6L3v1MkdwAZvC/bHL28nVdV3pLTihxBDJjwXucHJFOs7b6/XHJeS98VNbPWcrRFA6woyoa9j0suBOfFM0koyjXl7QKIHyfD1wnXd8usf1gQWwZGHolMcurZEbFifaTFoWhs6LgE4XneQJnXQuWhpJ8QqisoIWXRW3g3t3Fbf3R0XG/i0Y294iUoSrC+hoip1GPjb6iRh02F1aTYUp7bBf7Q3CC8XBv6GDuneBCwUoSuQPRv9THHxRn20L/86rOjpctWKFCYdBDTZaAJSAnSHD/waiEEpkJ6Rc7+UYHT5NiOjwleGi1MJOjbdgWPp6XUqDq7Ri+2PYCqDXfwGZ9Of/XqewWCkXrd1tOT+4M//Er2VIqS7e1sElf1OoPZmtvC5BqGr3FB+B9S8xp2rY4VlaXZZb9ixdk3bbKdl6Ol/FWtcOSA8IG4nCU5A+3J1CGAtr6Q61/g232FcXS4sbZZJjcuqgVyBNylDjLNL20uDZWMqJ6wb0i8J2N9GvU+fJZl8ifk3KslsvmDvG7YXxbkoPih7SPD7XMql6pVAofhJ1xDjFqUNpDiu+uzzZyZRQ/JhQUTNdyKy1uhA8OZOksWlJaCW/afOxyGzPeRhIzZEI4vdP2KPnQIzx46ToBDHILdjwsuP1oFIgSGkeA9rhdws3E7nkrV+ZsOPXzcEhtzRnTyNcA0xFVBAwaRtuZSMY+fM6mrvmgXzPICO9+TXXX2f1qB0+pblr4/j3QY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB6470.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(22082099003)(18002099003)(11063799006)(56012099006)(38070700021)(10067099003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aV1VcxxPAB4zkVesyIfSsq2sxqoPBctb739+a13lBgF/bniHPF24y3ZQSiQL?= =?us-ascii?Q?xiirJhUvFr5P9ZmkrnMS0dSEYeC5eQRUqRtZ1xorPbtAOGwcf/7bXn9CMHWT?= =?us-ascii?Q?lwn5V+MB/PSa4x+oxbe7xC1kO9F8f5ijcMvdMBM/1C0IsvVdjvWuAJefABrH?= =?us-ascii?Q?8frdaHBhrIdOnudVr3md9UvBSmbedk8MPpU8FNgtqIVJRE/jyxRUc02LNY6N?= =?us-ascii?Q?NnbKv72+SFWCLxzX6ekUL6xmoEYhOoaTd2t0agDbb4Chs1zKznHMABFYD01i?= =?us-ascii?Q?oyK/1QYwoxM03py87wewFAimFkwoC079W00xLX6VFJ2sOmhrf7NjvAA9q6uR?= =?us-ascii?Q?RZOvTgTF7HPTeIu8RGIbbjKIPF+VTWYAzOcNkBrUrJzXR98dsgpW2LaGnuhJ?= =?us-ascii?Q?/NKUZczrGqbKIiLIPa1glZYCOnkqwM9u0OAw8uvxDzb2ThlJ79GvzwVjmuUI?= =?us-ascii?Q?ClToS3xqXy1tWBhY8RFQ6iP+VlAYAKJRUzwH+SHlLYCmLKu8Efnd/njKSQUb?= =?us-ascii?Q?C8MuxM3AVT5uhyuTdrd2ElrFisctExXJljoXMCxMoCIC6KDgCFPMKuBBn2rI?= =?us-ascii?Q?mM7rU+lc4PCFG8Pmbks2VFgfEtD5L72vcxsx/Vzl5WfKbE4jF8PgV4J20DWC?= =?us-ascii?Q?2hUr2uCMaRIy7WjQyoBnunvbE0YVgcHwMpMT/a7Glq0BCmbIkktFWoDyif4N?= =?us-ascii?Q?sTbQ5Bqp6LvNiSqqJEJ8LCpiND+oQKVbPrlwbJtpadQTXDT1EcsGvqEJfU/g?= =?us-ascii?Q?am0SLL39oE1ByI38rjmGwgkWTV3pyipI5nVheyAEWLA5/+/7XoycZjqk+ecp?= =?us-ascii?Q?GuCDkQ9WC/uaRVniFbswcB1P3l5m01E4hcAud2qkaSNe9NyE2XM4l87LOV4M?= =?us-ascii?Q?3fLyCo/BvypRDQH+JAlkjLzwlY8s6jnCL9mU6E6dszqNKZn8ZLJ+Sj7mhNp4?= =?us-ascii?Q?wIPJMNCQHbpudWwOaa56GOPTOIxmd1gqQ/T7egx9GNOTmZqB/TOM1JwjH+vy?= =?us-ascii?Q?hc7VKpBfO0YiCYvcme8hkSITYTJMhkO6R/XK1Qkm8m4u0Nc3GdWZO/HnqTD6?= =?us-ascii?Q?MT+70SIF2jfPwPnSTZY4DJu0gsEFtfYGGfXS5bic7EEi38o176ScHlvxUCDh?= =?us-ascii?Q?H8IInR22diMX1lnZrJa0ifrR7s1RyB5Fkm/0kEPNZHWmOiK4ZJ9IfsxEcWaT?= =?us-ascii?Q?J26nZE4CzciTUblDnzZKgrQW+ptT/YbcSB/WpQL0i4w0H1CPLcFCu1MBKxFT?= =?us-ascii?Q?336fWNNOfRgmzAYNStgCFzgcY7Wyv5+5bqw04WQRsrnrR28Yyo10S5DgE16r?= =?us-ascii?Q?Z2DH5r7qZv2l59btl3k08t+EAuWNoWC71Xfx7UIB5nbPHiIdBaSCevEdA3P2?= =?us-ascii?Q?//ea49tL4he0gBbUzhs0+g6yxckY/rX9Kmc8oUIF1yrNR1wPlIvmZbDMKuJr?= =?us-ascii?Q?QPvFCmOA7EgflJxwAq34IiwVo6zfeCv3ACLBkM63DJq+WHqRJUa2r3jBEoNU?= =?us-ascii?Q?X2fzD/PIiSCdtOGAcUR+EEHP+uWUlhMqMYiznp1r4WNpQ5hXolkIbCTAI4NV?= =?us-ascii?Q?BJL7WrW8Qs+/DWKaAp6H3pETtBn0q9hDBRajEkUyGHFnyDX22Ldv1naZ7pcj?= =?us-ascii?Q?QMw2iDmO29uGh8vaytn7I4I3egO+Tch2srX2i+0I9FYFggP/aajB2gU2KyKd?= =?us-ascii?Q?QAm7jH+Tmik+5Y70J/SbkNUsx67vIFWfUkB2SQYHO0LMp2JR?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6470.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f2e1da3-b227-466f-d84a-08def3a11d21 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2026 09:57:23.6872 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GlLnzSDUx0LTLD0QE+8pvLk8IJQOMWl6M/kyOwam2/WYdpQhzUFoYKomJpPOxQ3SK/rvZQYnMAR/4PUh/2C/lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9228 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org AMD General Hi Tom, > check_types_equal compares both is_nottext and instance_flags, but the > latter includes the former, so the redundant check can be removed. > --- > gdb/gdbtypes.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c > index f5c0177bff2..4b6c01910f4 100644 > --- a/gdb/gdbtypes.c > +++ b/gdb/gdbtypes.c > @@ -4092,7 +4092,6 @@ check_types_equal (struct type *type1, struct type = *type2, > || type1->endianity_is_not_default () !=3D type2->endianity_is_not= _default () > || type1->has_varargs () !=3D type2->has_varargs () > || type1->is_vector () !=3D type2->is_vector () > - || type1->is_nottext () !=3D type2->is_nottext () > || type1->instance_flags () !=3D type2->instance_flags () > || type1->num_fields () !=3D type2->num_fields ()) > return false; This LGTM. Thanks. Reviewed-By: Tankut Baris Aktemur -Baris