From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8XYTMP2bYGpCwCQAWB0awg (envelope-from ) for ; Wed, 22 Jul 2026 06:31:25 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=5qtHrJFC; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BA5101E09E; Wed, 22 Jul 2026 06:31:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EAF501E099 for ; Wed, 22 Jul 2026 06:31:23 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7307A4BA2E0E for ; Wed, 22 Jul 2026 10:31:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7307A4BA2E0E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=5qtHrJFC Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazlp170120007.outbound.protection.outlook.com [IPv6:2a01:111:f403:c101::7]) by sourceware.org (Postfix) with ESMTPS id 199B34BA2E3C for ; Wed, 22 Jul 2026 10:29:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 199B34BA2E3C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 199B34BA2E3C Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c101::7 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1784716163; cv=pass; b=r6rALyWxAmj6aqJL6iDMTqRBVEIYLYtCp+2RijGnGKLBNCTW3GFvUTWKpElNnbaAnfRrCbakmO+GtEtRKdy9b3YSQThrk9I3RpidA0wPywfKOqJdmMU8J2eXwxZC8fVOYHbla4M+nfIUoGG+Az3B2LDvd16z4XrhW4jGIocGjks= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1784716163; c=relaxed/simple; bh=zy5T2Sb5R/E8i6YCW9/An8W3n4FidV3WYiIQU4ytfYI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=SLgKfUp750PAhcZyIXvYlUBVoUWocV9IyNJgrS9rfBI/qMMEvGshH6xk0BynLLQw+HxAy+JdPVw8Fu81bbGsDCaeAL94oMOAsfnAKgQCxu3te1gldqxC5i8zfSzd1Ns1kfCt4V/5fkdkoGa/H0ciffGeq4BBVKCppG9V8jHkF2M= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=5qtHrJFC DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 199B34BA2E3C ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HKPLklacY97C+lqjoAQO9VNtwi9+sc5pm3Ex3yBdoPd47U09Hx7Ys6OuCxxOTASnK78RrgoTieeXff22GYNyte00tYokijd5SIBBCHAxwv+PlT0orHCCKEzTkkNWl2wclIOM1nN8jTvldsVpvE3mVeBuzKrz412jQfe9zxUfyVcMe2VJ7vU4QNriJJ3jXL6VF9R8Af1+P0qFeGY6Juhf5SQCASrd2rNb4uoBcgJ65tJnYLdol9wxEJUZWEL+wiU2YYixrXozjwfX2eZN5oSUay+Gyx61sULw10IajVeEAijiTElPhs/+XWFXQtG+NkmitK9IRn6l/DPBSkFwU3iv3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rE+0iTrgNyTvFF0JBTaPQVK8/ta5OfEGg9DER0ixmBM=; b=eEdiqhML5JXkPM4+qAq+zFxEG7lE2tpGOEVu71oX1r6kwT97hPB1SjtFhwwSS8czLbNxkpiDQrvjeMRihoZVYZdHqVUrMm05xghI7PYa7yZkJzQdza9wckDfsK5p0T48WPdDPrYjSC2HO5Z98H8/rZGBS1jy4ipGgOA1wHI+rwz6H129EnurWRSI7RQpg+bUFBVmUpCuk+kR2myd448wxhemxnB9jcVsDIKAKgvIUhmGYsqRXQb5DQAldRKHurSERfuVQyZRNUId7GqC6gAQTanJHo2hRSKr3D9Wf0yVNSjn7218kj7FBpN9yjgyqdgBigCu3fLoL0vgAPtG7y/bBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rE+0iTrgNyTvFF0JBTaPQVK8/ta5OfEGg9DER0ixmBM=; b=5qtHrJFC825Q/CKTHxxZBT6wQQoxI2zBRHuhG+kuYuNTbo4VmGw3Z9Yjcm6pfeLFk/M65a0e6Efvy6Q+9yGpIbaNiZGa1zgbGwZoZdVL6xWsFh0iWMWDNwDBXeqVMBBZ/raAN8E6Hdx760+i6By5k/wN9xB1BctUjkkcAwRrfO4= Received: from DM4PR12MB6470.namprd12.prod.outlook.com (2603:10b6:8:b8::12) by BY5PR12MB4260.namprd12.prod.outlook.com (2603:10b6:a03:206::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 10:29:17 +0000 Received: from DM4PR12MB6470.namprd12.prod.outlook.com ([fe80::c988:e72b:f5b3:db1b]) by DM4PR12MB6470.namprd12.prod.outlook.com ([fe80::c988:e72b:f5b3:db1b%3]) with mapi id 15.21.0223.017; Wed, 22 Jul 2026 10:29:17 +0000 From: "Aktemur, Baris" To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 05/16] gdb: inline address_space_{name, type_instance_flags}_to_{type_instance_flags, name} Thread-Topic: [PATCH 05/16] gdb: inline address_space_{name, type_instance_flags}_to_{type_instance_flags, name} Thread-Index: AQHdGT7vOBO56L1mW06QpUmkAyC6B7Z5NzKg Date: Wed, 22 Jul 2026 10:29:17 +0000 Message-ID: References: <20260713-users-aktemur-type-instance-flags-v1-0-779cad0c85ec@amd.com> <20260713-users-aktemur-type-instance-flags-v1-5-779cad0c85ec@amd.com> <87fr1ctcv6.fsf@tromey.com> In-Reply-To: <87fr1ctcv6.fsf@tromey.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Enabled=True; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SetDate=2026-07-22T08:34:00.0000000Z; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Name=AMD General v26; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_ContentBits=3; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB6470:EE_|BY5PR12MB4260:EE_ x-ms-office365-filtering-correlation-id: 406062e4-5c22-4084-85ff-08dee7dc15a2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|23010399003|366016|1800799024|11063799006|10067099003|4143699003|56012099006|18002099003|22082099003|38070700021; x-microsoft-antispam-message-info: pfVMMzgFaWlAjcNemZMtziTVhNhh88ZS727WlHGI4KPNMdbtj2yMGGUvUhDIB/dfsZaMffKDtnsMJgNrF+eaXzz8VegDgR0vhi41U/caReS8iEr5hGl+m64G4Sskpo3LIh8KzUSGiqHxUNgHYNveQnmkNrnfNFM7vG+hZywl2C83htefHDZ0+BpEiAJgIDNuPtnen1DJ6RIzK1qs+60dDHEAtUYwWbksHVbnuS85YAtH/8KFCxHmQloy5ZA/St3Px69Tq28yA/ykg3T+ILz5ELjKItthS/HW9nwf/EuIHXc32BotDBfUJF4pYVOjs13xdPgvzPyEFBqu2+UyOIkD71FfqLlgY/U4L4kic7AJv6dF+TxnqIIOPVSI9w/WsgMzJIEgWSXMr3XaC6+9wSSbGNeoK2KP8ad3gn6LzDX8EetWL0sE+jZiMu0K9ezEPRSq5Q2Z8ho6ekJaxq5DdV6ajU8RcJxc9yv4byqe6NTWIxJV0vRaufBqu8Db+Szg7/q56NRwzitvk6uFK7Eg6n0knDsBy9nJ9MMbph/LQZjYaq1x3Do5xSKy3xNMvF8rbvL3zLzKEmp4tFePhEZYxvHAgeMyh2cc+3HFzlufR0//tEAwsvePN5t+8zpTptRSWVhMa3xzdHHH70/nhphE7o5ga+k8n5VI1ZViOkmsOFRtShGljb9hSoLhvfdGOA6ggvCORIIUr7fhdq4G6ZMxA0jGB2r/xyVpE2l3njDPC7oYQtU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB6470.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(23010399003)(366016)(1800799024)(11063799006)(10067099003)(4143699003)(56012099006)(18002099003)(22082099003)(38070700021); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kHezhzSbp1KhR884CL/bwNQxWCk9yaxAXTNPtAP27nIEI6o/+MSMqNTbRu3j?= =?us-ascii?Q?ak8lo5ot2+JgY0yVlfxxgBvFvUxeXbdYXEkuFbpMGn48uJJmzTETU1QveDXs?= =?us-ascii?Q?P4MTvgRB2+sySjrOL1PvCt0t9DVIREhuYkevxN3USG0m4/YY4/racs43Iu6A?= =?us-ascii?Q?GEzdKLeaxvb+B1Gl3XQHpPssGL9bf7iou0H0A/f3r7D/g95jjvRtU3Z+SHEy?= =?us-ascii?Q?utgTdZQMAkydgpYhhcc7wlthLMq2eHB5yuarfm6AgLw1sSJ+qkeR0n8foITk?= =?us-ascii?Q?YCVk5RUBrNo6TEp1kQ3PLU/rlUQhkszOGszrl1j2G1uYFVlMqO4nSsZs9kPi?= =?us-ascii?Q?thywXzKpi8Ar1XNq1CWr/DSNCjPaAsQ/MbIxGyQUEQ5GA7cscci4YQ1W603u?= =?us-ascii?Q?nDXJg8xTKT0enp26f5K5lAHKrbbwI5WKTsHgEEzMkqK03HO4RrKItFVQiviE?= =?us-ascii?Q?0E0sF5V/LIIplSrmTsdEhBqmOrfV/GNjfUXXJyrgOjDv1OuB6srsltVPqV2b?= =?us-ascii?Q?l174NC3uIEHvrfK4Ho3B66jZJof2P5sM6tfweobckrD/5fDevgl/Hwv8Ln6l?= =?us-ascii?Q?aM4Cu4eQfE6FOSni0qJb+px7q5TvOT2O5H1y0XFDcvKmmPvEdp1be6ydZBku?= =?us-ascii?Q?io9FbwdrlNSGGsX3jWJIEngvHBB3Ti6IigQIqIKhhe/Q2xE5cEuu7/o9zq3P?= =?us-ascii?Q?hDgVzjnWEsmO8b0waqePQ/1P/9915t+zyINMhhwjosEgip4RTG082UYkl7Sa?= =?us-ascii?Q?pKkEsgwstZDbjMWYzqfCi17Bv0zRCdDVTbsZm4CYhUH9pjmOz2c5zlgYTTEi?= =?us-ascii?Q?7cmdwoSqIuq4cDgby48BUNgyEHW/Oa4ZHUacLlIfLctmhSLaooE9xC40v/L0?= =?us-ascii?Q?lFiqRyctS+c4QlA7akjoyQzsVMvQj0pq2oJmTQ8OUCNzVq06WlVdap0ea2A6?= =?us-ascii?Q?hZ6diIjFS/5DtO1wpXG+TJjPKTf3FOSc+ML2bTJmDnDJGwxKexkWz7vmv8uw?= =?us-ascii?Q?TTxknghAE2mm4G3hpo4hygxfNgBELehJKYDXxojeMQ0TPehv4PkroprnbwJJ?= =?us-ascii?Q?MkaFS+NNZSCPdtEptn4zd3wnKNoIDva0nfIzjLe7Y98GGHOCO2C+hNRpRz+g?= =?us-ascii?Q?Yu8fJRdB5fzJqV1dPZV4Vbtid4s4DgsDyOmtyoufNc0M8ttXM3yVD5/mxmab?= =?us-ascii?Q?C5dlIu1YFsi9qe2hZMXy5pfqgyniGTJRhq794DsRup8BGaEnu8LR7c6P43DP?= =?us-ascii?Q?zBaxZb5u332cQruA4g52Ce7rc1WiN9SvCFIPXbx1p1HqXFTsTdOfrIW6rhRQ?= =?us-ascii?Q?4CFV8OBQCrG2LYS47yb3bHGXaOrfW4yZ17ncI7b68kgrmxh5hBYBFpOJcFbP?= =?us-ascii?Q?bp9pWP+awjz6g4cA6hBoAgzJlIige4QbyghuMBb3SmTK5IFSPQ6O09gosnkO?= =?us-ascii?Q?fZ/EqkGOm5liEA2CnXBbTmeSBVMrgKt2+Phz4C9ZdKvjbo7jCa92KPV5rYm2?= =?us-ascii?Q?axysUdHRkuEJrr72KnjtuWKPKj0/BTV00wRMpqJAH5Ai/Uno3MHwE+0kUL0g?= =?us-ascii?Q?Rr9/biTdjBio9UraQqC4klR9Wl/0BgTMOD0JycHw4Ocd9XAly7f5YRn+rgyr?= =?us-ascii?Q?eEIuKj3ExBQi7h4YeKIMNsqggdI0+9O1n4hgSJVuci35390tMZKTDoVQcWrA?= =?us-ascii?Q?F3zmKGZM9Ajtp8U3SNtAmTgqtzcmXbaLnbt/j+7RbBCED+GM?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6470.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 406062e4-5c22-4084-85ff-08dee7dc15a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2026 10:29:17.4964 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iJ5XioyoUZiD/UEloIA8LgFE5QrIUqXr4Db/lQ2CtQ1NpwpdHb7mPOl3f2wzBwXC59UlJby10ucxRnbAB6hyDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4260 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org AMD General Hi Tom, Thank you for your review. On Tuesday, July 21, 2026 8:30 PM, Tom Tromey wrote: ... > > + enum type_pieces piece; > > + int int_val; > > + unsigned int aclass; > > + > > + /* Check for Harvard address space delimiters. */ > > + if (streq (string, "code")) > > + { > > + piece =3D tp_harvard_aspace_identifier; > > + int_val =3D TYPE_INSTANCE_FLAG_CODE_SPACE; > > + } > > + else if (streq (string, "data")) > > + { > > + piece =3D tp_harvard_aspace_identifier; > > + int_val =3D TYPE_INSTANCE_FLAG_DATA_SPACE; > > + } > > + else if (gdbarch_address_class_name_to_id_p (gdbarch) > > + && gdbarch_address_class_name_to_id (gdbarch, > > + string, > > + aclass)) > > + { > > + piece =3D tp_aclass_identifier; > > + int_val =3D (enum type_instance_flag_value) (aclass << 4); > > + } > > + else > > + error (_("Unknown address space/class specifier: \"%s\""), string)= ; > > + > > + element.piece =3D piece; > > insert_into (slot, element); > > - element.int_val > > - =3D address_space_name_to_type_instance_flags (gdbarch, string); > > + element.int_val =3D int_val; > > I think the various 'if' branches might as well just assign directly to > element.*; and 'aclass' can be moved into the if like > > else if (unsigned int aclass =3D 0; > gdbarch_address_class_name_to_id_p (...) > && ...) I had chosen to write it the way I posted because we're inserting two elements back-to-back, which are of different union kinds. Looking at the code again based on your comments, I think we can do better if we have an overload of the insert_into method. I'm adding a new refactoring patch and this patch will look better based on that, IMHO. Please check in v2. > > I didn't read the whole series yet but if we're going to use different > words, as is done in that error message, then some spot in the manual > ought to explain this. I went through the GDB manual, and I don't see address classes or Harvard address spaces described anywhere. The built-in `@code` and `@data` syntax is also not explained. This seems to be a gap in the documentation. I can write a small section for this, but let me do that in a separate submission. Regards, -Baris