From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id fZr6ESVtaGrMcDEAWB0awg (envelope-from ) for ; Tue, 28 Jul 2026 04:49:41 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=Ga1Z08fV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 365F71E099; Tue, 28 Jul 2026 04:49:41 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 310671E099 for ; Tue, 28 Jul 2026 04:49:39 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9CA184BB3B80 for ; Tue, 28 Jul 2026 08:49:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9CA184BB3B80 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=Ga1Z08fV Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azlp170110003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c107::3]) by sourceware.org (Postfix) with ESMTPS id 730FD4BA2E0F for ; Tue, 28 Jul 2026 08:49:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 730FD4BA2E0F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 730FD4BA2E0F Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c107::3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1785228550; cv=pass; b=sJn6j25Xutztl/sOibcK0p+qhJ5JX6FCfjrwPTLtIUSxvVEL7OxBkEhOj+W3C29DNluPH2GrtCjXlGjC/IQKN4lDZlp4R/mZfMkxKvMKG+YM3Kma6KSvhIyW0BqYUU9YS4ph0Ar7BiSE1QzH4j9RfMoTkYy9+VTg3PCK3DrTAo4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1785228550; c=relaxed/simple; bh=KykDkDxTt1mpZ34fIbb7AsPidXySSOFQxcgmPNVmTAI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=g0EWX2+zUCM5MiE/RIvXo7O30h/cwQjmg6G/rgNheu27IkEGA/pBhB6w38PLrs2kTfugkr+3EQVmBRcFAFOKU/AkP0/KvrACJy39s5Rjq3a7Hx8jA4AHLcdeYVEwwauyn8bWQJXU0Pd99mGA6J597Fq60+T2aLffaFYVTU4StMM= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=Ga1Z08fV DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 730FD4BA2E0F ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vddWjZTNTVj/LUb+TyNezsziaVM6bRWrZ1vuwywtyiIlISkPHBb0rYr2it4mlf2tuqpxYcAz/QPg62WXP2QpZFef6MbPL/ggbjfwkcPZpnlDmgjes3JAW67yAqYBHq+P2w+B2X1gRkmKlpcHYsmU9t+aQ96Z6s9zu6GoO8pU2JZUQZ4K0LqoBv8T9YoYJ1FXF3jgLfVy/jXMA3qdoOyf21pvHRsEnRkdlm/nrsJj61qFpIfDTrWnDaIj/xNL+B5uYSOFzABiyiO2N32Vxvje7UXXqBSwvTdsQz7jri7J/U2Pep3s2yy9r4OMteiAcf8f/fek2NdpPXFraluHVAk5mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QbhzTVu09wEV88z8BjS5KfZk+wXvL5gw1y1oV0U5F9Y=; b=ie2FhW+iR8GQmlQ8frAWa5/O5ONJzr/woHjI1pacYeaRVHNgodnpEgQ2ZlqfLJHPbmSkvVzRWXN98mR+sdfCL2HPeHcpOQ6/NUEASf2t06yRbRXnTsZ7CpOQwvmD8tCRYVnXuaf1EWD/qSp9DlfPbBwveNac9WA2V3X/O8ihVKv2eVOb6SNHsnwFxX+KlCZOmuGMZAbgcyK4Rf4u+zdhQlJP9TtOuLAd4snej4CIPW5SqARyQLS/2CUQLv1KzxGv78tabi0GHfObKQrchyB7CZl8dRW78FOWG+Z4v5hgfKyBmIP0G0NY5515BVa4mxO93JkR/JXK9W6sZybWlKZMaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QbhzTVu09wEV88z8BjS5KfZk+wXvL5gw1y1oV0U5F9Y=; b=Ga1Z08fVjfTjbCnceF3YtyxS/JvDfKQ161rbOrEWqTDW/7Zzk9JoSUgYrhMH/peqRBaweaOcmQX4nj/7HO/M7jQQAfdqjSEXlI3lPUwJRL0sHRF1jeJfwDomoRk4/zzw7wxS6nK7mT9O+Zi3V1o94lgAF0AY99BOgyQ0fAs6RJU= Received: from DM4PR12MB6470.namprd12.prod.outlook.com (2603:10b6:8:b8::12) by PH7PR12MB7187.namprd12.prod.outlook.com (2603:10b6:510:203::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.13; Tue, 28 Jul 2026 08:49:04 +0000 Received: from DM4PR12MB6470.namprd12.prod.outlook.com ([fe80::c988:e72b:f5b3:db1b]) by DM4PR12MB6470.namprd12.prod.outlook.com ([fe80::c988:e72b:f5b3:db1b%3]) with mapi id 15.21.0245.012; Tue, 28 Jul 2026 08:49:04 +0000 From: "Aktemur, Baris" To: "aburgess@redhat.com" , "Gerlicher, Klaus" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v4 1/1] gdb: avoid conversion of SIGSEGV to SIGTRAP on user breakpoints Thread-Topic: [PATCH v4 1/1] gdb: avoid conversion of SIGSEGV to SIGTRAP on user breakpoints Thread-Index: AQHdFcA9avoS2EjXD0OkH3cYMCJ5q7ZxbYNwgABGC4CAEPxwkA== Date: Tue, 28 Jul 2026 08:49:04 +0000 Message-ID: References: <20260717074453.253386-1-klaus.gerlicher@intel.com> <20260717074453.253386-2-klaus.gerlicher@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Enabled=True; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SetDate=2026-07-17T09:13:18.0000000Z; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Name=AMD General v26; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_ContentBits=3; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB6470:EE_|PH7PR12MB7187:EE_ x-ms-office365-filtering-correlation-id: 5ce01eb0-e825-4ec6-9f8d-08deec8513db x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|23010399003|376014|366016|1800799024|22082099003|10067099003|18002099003|4143699003|11063799006|56012099006|38070700021; x-microsoft-antispam-message-info: Of+a66v9brERcSQ5wRBOOVHA+ee+I6uff89U3w4kRKWE4OIOGkltoXBneoYa2FkLOwb2VP9LQRJotytG5wpim75Xc/8pntI65Jt35a/q7tHDvuCxsSEEM5zUDWGyAza0ouw5VRjBuwidIX5Pdyp3HnuKPoqj5pLCWa9afVpSV7wjRq4cYtB9GPI1gHHqcJiDhsFK8gnGowTo8yY2F28hZuqUvioLgaFZiq2ETlnZxnEbhoqI6hyMXnc+KelISSuxXB5a2QVLJnab9RhK4GOqEBaWo9jLXyssR6vmzlhyw7eFTFGBedd2Uq1moAFw2UNVSl4wQAE7cTxAPlidnaNGhVcxuqHK3cY+LmQjL/JS68WYtFWuE/wRyxFrstohXqhi99jxc7NHsQfBpmFVXto4zoLuuiEUnk2sbislyP2K+uvxPxw5uBetd22QlKtZEkxaXDF2Y5YlU5dCxDvA1PWz2Hp9VVzlkWYmQeYC5RXBeLmUB4b907PxY4RDFKgWVkIdJ/YLZ9ylD2rJ/D4rVHhrdBO4qQsFnWScZIY1OwMzLueQ9TullFLxX32xIPGVaS9X+2MtEt2jQnyEYzxSJ+eh2Z7YM2vcNaIwhhLaFbCeL6j1P+Ixi0C54hwcb54ZcvyvCOAqIMGtDAtFwBo/Y8BHbJGLYdZgJuM1FQmK5EtDd9I= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB6470.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(376014)(366016)(1800799024)(22082099003)(10067099003)(18002099003)(4143699003)(11063799006)(56012099006)(38070700021); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z3YLi2Ih+SU6BJN9o31oFEQD328V/I+TGzM5cSMxtW567IYn9E/Qly2MMf/B?= =?us-ascii?Q?V/IhEE0ROfDxJwStG07v63mcZD4sN39Oq7EVBTga1mcWw5r0HJtKRH72wKcr?= =?us-ascii?Q?gC1m18WPnTzjEk9pMAfxZEPGqpsHe4Fa7VjeN5sCW3prI+zOTFxYv40juHxU?= =?us-ascii?Q?lUwwkVKaU0cYUTqg19mKbxnnjlnB5j+O1rrM772XR4PPQixwAMR8eu6eZHIg?= =?us-ascii?Q?dW6E5ceaz5+6KY9TQ90g5RHJ156pORDIH51wcTAjRakK2jGWF3suLkisMx2Y?= =?us-ascii?Q?5uPCCujqPAbDWyniFQv5fPXLdosFyyO8XHPejSLFexKtL6QYniCr2xIlSuiQ?= =?us-ascii?Q?O+ZBpsWBOu9TZk3aY0xd+GopNxxjEtom+wongUnej740kfyXQEvRig5H+H/w?= =?us-ascii?Q?U4XeONadFf482WC67zp0BA6XSs4W7Lsc6BNjahknUrD+S6THvuoOfPhQNtEM?= =?us-ascii?Q?+2esnX6+WfYJhwgF0BxDJMtlo22zlC/eCNvyAOKy7ga60bFuyUfxl3sx013G?= =?us-ascii?Q?EpMnd9xS/9O2z9rtzTJ517LibDy3rB47PVBav2kTAOhKkOVQLCn485bfqZkQ?= =?us-ascii?Q?fHlb4vqQCeCZ9B3Lom7kwSa6mKaXCZL+aH68luZ6Psj3jXgqNMmPQvyVpHgJ?= =?us-ascii?Q?et/RLjt6tzDOG0pfbTlGVA+Pvk/kJLsXvlA31PVNDA5tHZIJ7vmjMlF/MLYt?= =?us-ascii?Q?7JI/jUFR4r4cpswvwOy88TgTDf3bdcGB0AXVt+0Dmdr/T1OWjJPElVlD3H3E?= =?us-ascii?Q?5/wl3XNDaWBMJ+j8BOvDifdd/1wxSZ8/Z5S+0IHEgesImnCeh7gBAyqIxzaT?= =?us-ascii?Q?Cw7CjUU0BUu3sbSjgf0qPEfX93WEGmwWzbM9UbOS/IVqcDd6b6pl90bzoEO2?= =?us-ascii?Q?R1Ux8UzUurjYXpv+IncMkpJDUPYc8Ym3488cPgPh73utrxsFxhGTPNK4YVNb?= =?us-ascii?Q?Fxhw4M94kGEQeUbURMIbXuGNPrPOjVnBpea7mFvLeCgnq4sLoeHMJIOIpNeW?= =?us-ascii?Q?D+/+T3bW860hAxGJSGr88DRJR5go02jriqfJNX7NlqWVnINBLcBAhc28S0Yd?= =?us-ascii?Q?AsUmgQWzZwGUby9AkU9dnsGhDATPIkCF9pK+WuPjVUcCN2xpgOyCaBcLZXdv?= =?us-ascii?Q?iMrJxxkpY/PFOLNp+3MNyuESv9x7o0xLVb3NAN7up/ST0z3M3N10xw6uzSM3?= =?us-ascii?Q?mVHXC4cw4kXiOYWtRPpdMCgVPxD/1/wSKugLDUvKamDeORvUZPjZNojrj9uS?= =?us-ascii?Q?qX9n9eZ30dOAR37/fe2sHodbRHrVk8VIUdpgPu/cCaMvby1QZR9SkoxIasO0?= =?us-ascii?Q?udJoZ9aFsqukHgKpVWHH1VZ0ox2yCwdsASXwQELGTAMyjDFuaxoycGu1ynz/?= =?us-ascii?Q?Q5Ag5F8Sopl9fvP465vMVPj13VP7yWTJj9tLcK0ZFggEvW/gXCKPU1hcIDsc?= =?us-ascii?Q?F3VT/MBS8AS6+rfb+IpjIgBr1B8mDap4GcKEQnC2NL6sRcjtL/A36jhGKE3c?= =?us-ascii?Q?sultYHFLhkHneVZl58FukVGItqe4BqU8nXfAy0aCzW8aQI/hfNYpen3DYomB?= =?us-ascii?Q?38P93fblHbYSUHkzzYX7gF8Ue2sjQXSVLBHqYXIW9mdaERiSSnpVL7FLEsJf?= =?us-ascii?Q?BYyiCFK3p4u6b/lrJeTdBmY8PchnEtmY1pj87LsyeuTwm5E7cLhuUKSj8NNK?= =?us-ascii?Q?AicX8LZygjIIR+S1QPXm8TXihMNWeENbAzLMD9O45FOvD/Rr?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6470.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ce01eb0-e825-4ec6-9f8d-08deec8513db X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2026 08:49:04.0615 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: U4I7vCx+AlA9jC8NGq+5RlDs62myttX9OJ7guPEb2OAVvI9+y4mRudEaCy9J6UTfgFhmX05rIYjtpBstdLT+zQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7187 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org AMD General Hi Andrew, Kindly pinging for a re-approval. Regards, -Baris On Friday, July 17, 2026 3:25 PM, Gerlicher, Klaus wrote: > Thank you, Baris. > > I discovered this too *after* I posted. I'll make sure it's updated once= Andrew > approves again. > > Thanks > Klaus > > > -----Original Message----- > > From: Aktemur, Baris > > Sent: Friday, July 17, 2026 11:17 AM > > To: Gerlicher, Klaus ; gdb- > > patches@sourceware.org > > Cc: aburgess@redhat.com > > Subject: RE: [PATCH v4 1/1] gdb: avoid conversion of SIGSEGV to SIGTRAP= on > > user breakpoints > > > > AMD General > > > > Hi Klaus, > > > > On Friday, July 17, 2026 9:45 AM, Klaus Gerlicher wrote: > > > GDB converts signals GDB_SIGNAL_ILL, GDB_SIGNAL_SEGV and > > GDB_SIGNAL_EMT to > > > GDB_SIGNAL_TRAP if a breakpoint is inserted at the fault location. I= f, due > > > to imprecise page fault reporting, a breakpoint is at the same addres= s as > > > the fault address, this signal would always be reported as > > GDB_SIGNAL_TRAP. > > > > > > Add a new gdbarch function, imprecise_pagefault_reporting, that allow= s the > > > signal conversion from GDB_SIGNAL_SEGV to GDB_SIGNAL_TRAP to be > > skipped for > > > an architecture. The default is false (conversion enabled), preservi= ng > > > existing behavior. > > > > It seems gdbarch.py has been updated since the last time you generated > > gdbarch files. > > Re-generating gives the diff below. The patch LGTM with that fixed. > > > > Reviewed-By: Tankut Baris Aktemur > > > > Thank you. > > -Baris > > > > > > diff --git a/gdb/gdbarch-gen.c b/gdb/gdbarch-gen.c > > index d9bb3e7078c..0b815296261 100644 > > --- a/gdb/gdbarch-gen.c > > +++ b/gdb/gdbarch-gen.c > > @@ -5295,8 +5295,8 @@ set_gdbarch_get_shadow_stack_pointer (struct > > gdbarch *gdbarch, > > bool > > gdbarch_imprecise_pagefault_reporting (struct gdbarch *gdbarch) > > { > > - gdb_assert (gdbarch !=3D NULL); > > - gdb_assert (gdbarch->imprecise_pagefault_reporting !=3D NULL); > > + gdb_assert (gdbarch !=3D nullptr); > > + gdb_assert (gdbarch->imprecise_pagefault_reporting !=3D nullptr); > > if (gdbarch_debug >=3D 2) > > gdb_printf (gdb_stdlog, "gdbarch_imprecise_pagefault_reporting > > called\n"); > > return gdbarch->imprecise_pagefault_reporting (); > > diff --git a/gdb/gdbarch-gen.h b/gdb/gdbarch-gen.h > > index bb95df25eb6..a96692c206c 100644 > > --- a/gdb/gdbarch-gen.h > > +++ b/gdb/gdbarch-gen.h > > @@ -1756,6 +1756,6 @@ void set_gdbarch_get_shadow_stack_pointer > > (struct gdbarch *gdbarch, gdbarch_get_ > > /* Returns true if architecture has imprecise pagefault reporting. Th= is is > > used in conversion of SIGSEGV to SIGTRAP for an architecture. */ > > > > -typedef bool (gdbarch_imprecise_pagefault_reporting_ftype) (); > > -extern bool gdbarch_imprecise_pagefault_reporting (struct gdbarch > > *gdbarch); > > -extern void set_gdbarch_imprecise_pagefault_reporting (struct gdbarch > > *gdbarch, gdbarch_imprecise_pagefault_reporting_ftype > > *imprecise_pagefault_reporting); > > +using gdbarch_imprecise_pagefault_reporting_ftype =3D bool (); > > +bool gdbarch_imprecise_pagefault_reporting (struct gdbarch *gdbarch); > > +void set_gdbarch_imprecise_pagefault_reporting (struct gdbarch *gdbarc= h, > > gdbarch_imprecise_pagefault_reporting_ftype > > *imprecise_pagefault_reporting); > > > > Intel Deutschland GmbH > > Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany > Tel: +49 89 991 430, www.intel.de > Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell > Chairperson of the Supervisory Board: Nicole Lau > Registered Seat: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928