From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HMICESsDdGqyzAsAWB0awg (envelope-from ) for ; Wed, 05 Aug 2026 23:44:43 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=4DHKjI4H; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 214021E166; Wed, 05 Aug 2026 23:44:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D667B1E033 for ; Wed, 05 Aug 2026 23:44:41 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C68F34BB3BBB for ; Thu, 6 Aug 2026 03:44:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C68F34BB3BBB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=4DHKjI4H Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012033.outbound.protection.outlook.com [40.107.200.33]) by sourceware.org (Postfix) with ESMTPS id BC8174BB3BBB for ; Thu, 6 Aug 2026 03:44:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BC8174BB3BBB Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BC8174BB3BBB Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=40.107.200.33 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1785987855; cv=pass; b=bIxgo4k9k6eSGgkpbRDlxi/vHMYPzqmo1yqt1hMQC5dcx3nvIOHfqtSFgQ1V0YyBc1wj8rq2PYODphpHM2MRc+gKu9sM8NYVM5NYqEOXyrnSJbigNJY26+Kk905NVzbCWztIiJJ2pM4kDdG2lo2JjFPBMCVWWl3Pw+Uv5DHiLSY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1785987855; c=relaxed/simple; bh=HX21Be/VMjbEqJ1MgiKKhudtRgUCaKJcpt0f8iLBjCw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=UIylKQ80xUlifg7n7P8VuuORE5uaHNCTOFBnrZ4VecrjDpVxYYp1oe5Vz/yJo8+xsgRjpXkkvyBhWZvMI6KR18ht7Y8VCViiVyA4GMkrrm7fyqzXY2D13evZhrWqUNN3ud4kNw369zlJnKZcemgopprvaJsz2bfzsf3VxT5F408= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=4DHKjI4H DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BC8174BB3BBB ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uarJNXqnJrIr1hy1xS1P3Iw5ndgej1mlwJRHxgWS+tjI7j8rfbvqx8vLfidGnFxW+XJeZenjSo9wuV8kjCAoyUIrl38YBTd5wDy92PxBxtOL1pi0f5BzyNgPszAYHLqg0uO1lccAhqld65+oDSgKUZ6Z18U/HpxPzJCzWPEl5RgFpSG7/Rbi2Owqm0XjRzWE2ABEziXXaPDl/12NJN+EoIjjpslM+vnDhlmCz4Qtg56AfZQczd9Bpk3MhvEsewPkDeXutzmkRgVE3WTjyJM1j2D0pRYlrsIznSbO49HBfzTH5lX+9oaikae58lNhqFAR6XtgY2c3M0emJWga8guUWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yRd88OZoudx0CYs+/1UVdmQE6MEyMlg6u9bQKOuL4RM=; b=xbcsc3pKsa6Ywbuj5VsULURh2jjp1Wmgw5QBlpzMvkAcIQ7BKf5NCJcNJCaRosDrsaUYibYMKP3s+9Gif9cEdj/Ki3lTjmvh+HIq0diLI+ew5IZfub6efLF2/rYi3jiqOrOhe57fNPeQqNgwtUEvNPoRYS15li8x/NTIKEpyP8itIli2PVNwisosicDu4AJEA9ZA114NvUn7yoe7Oe17RrYPFVfnWYC9RH9FN+ZWnDJFm6OiUsr2ZyfIWg8tZjMijzyYF++XeiQDyZAcjM0pR6DwNV+7pBkALLm+gAGX5M8MaHDhVDGMM+USUv+tRCwFigaIkmPzGZefJu37lswdAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yRd88OZoudx0CYs+/1UVdmQE6MEyMlg6u9bQKOuL4RM=; b=4DHKjI4HGRg6GaYbTKbF3m/gz7c4FmmP+7OpEgjaqVT5r1LbIUH4BYxu0syKE8cOvWwGLSyyEY2oFKb1HER8jfExcVKJ1lhdrjr26woogQsoZicXphdpQz0L1/jtDQYqK5DfmlQCSG90wTz+w9myugCLXFSOSH4Cqzzlf7xHQvs= Received: from DM4PR12MB6470.namprd12.prod.outlook.com (2603:10b6:8:b8::12) by SJ5PPF5D591B24D.namprd12.prod.outlook.com (2603:10b6:a0f:fc02::994) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Thu, 6 Aug 2026 03:44:08 +0000 Received: from DM4PR12MB6470.namprd12.prod.outlook.com ([fe80::c988:e72b:f5b3:db1b]) by DM4PR12MB6470.namprd12.prod.outlook.com ([fe80::c988:e72b:f5b3:db1b%3]) with mapi id 15.21.0292.018; Thu, 6 Aug 2026 03:44:08 +0000 From: "Aktemur, Baris" To: "Six, Lancelot" , "gdb-patches@sourceware.org" CC: "pedro@palves.net" Subject: RE: [PATCH] gdb/amdgpu: Handle SIGABRT with a higher priority than SIGTRAP Thread-Topic: [PATCH] gdb/amdgpu: Handle SIGABRT with a higher priority than SIGTRAP Thread-Index: AQHdJSk7fPO+ko76qkibE3iqLbfYxraQWwhg Date: Thu, 6 Aug 2026 03:44:08 +0000 Message-ID: References: <20260805222425.588196-1-lancelot.six@amd.com> In-Reply-To: <20260805222425.588196-1-lancelot.six@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Enabled=True; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SetDate=2026-08-06T03:21:31.0000000Z; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Name=AMD General v26; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_ContentBits=3; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB6470:EE_|SJ5PPF5D591B24D:EE_ x-ms-office365-filtering-correlation-id: 03e43303-962d-40ce-eee8-08def36cf8a1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|23010399003|18002099003|22082099003|11063799006|56012099006|3023799007|38070700021|6133799003|10067099003; x-microsoft-antispam-message-info: yzjKCBHoifGjGBEm2a9WwuGjguiwVqCRGWZOlkrCCXwSvZoaJQhTQq50Ipg2u1owLPujABtkM1SCrMJuYvRp+BnF6o2+lpgWRPbYM71Dts8cV3w8D8H599LgG2EcdUHv/+13OlB22oeRQWcVp2aFyYG+Nh9H1utO7jh6wIWHhBlX4lf/XpviFDGf7AIcSujTZM89c1tB2YYApX9ufrz+nfuAdOhciszmuTJDMJGc+CFv6zoqa5k3lIfjMmu+jSGmsZqcIvFO1bFIAsL7lZrrYk4MhQMoPS61fk+8FS6vdJ1JzsfcBnfQfqpPMI1TdTJcRaZO4xKF6021h9+B28K7W/kQHu6s95ERy+jW4LAmoA0vKt4HiWu0TYGYYu6dWwzJHFcfXrtySIWgsG57d/XdD96xy/2rX4c9r9aM06sQEt5nH+wrZ+qUop0uxvM4U91SpGAeI27yKNtVycuEJYvQME2TxoFhSEtcgoyrd9JlNCrl96X3UWGkFUkmvfCcnuQVrfaj9eUX6R77pk/o6+WVKC06gPXLU37Rz2sKF2o2M9lApRf655G5w5ZBFghacEl3G5BS1+vzELp8fJEZSBtWJT0KuMdHXHamKwuSBIr/5ABfEoIg4TH44PCJqcUdDAD6P5RrP3pA294t4+UO5sQMYIVX5nc1m6az8szKItSS5mxOtLhqNh0jFqiNnK3xP5ru9q3CznUV+loPsthc2u7hR7kMbZ4SAZ9qfq6AQNgRFoE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB6470.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(18002099003)(22082099003)(11063799006)(56012099006)(3023799007)(38070700021)(6133799003)(10067099003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?t4KsvI5iKUQhoigt+DJlsBNkp7SfMbtZxCrf9BmVOkGYvnV/tlKqCJSXVm1t?= =?us-ascii?Q?avsojIbMeMJ2fpvmMMSnuxkQ4ERv+oh+OF0EuJGJW69FoYEdjL872zggRE8u?= =?us-ascii?Q?83lVsY1/RTdXtV5e11EC8t9tLY2rqAHKDxAVPnTg/MasgeelswHKT/LCrbAH?= =?us-ascii?Q?6OVg4vHVK/RfJTYCnP+/dFH6EsK/mp3BqyFcl2TxPMKwmR7gN6uejqD1HA7W?= =?us-ascii?Q?8ULapzdwYDZIif/WSWna/Qk8aLe3iGM1AEHGDB5HJheW9+WGraPDrQMFOrpx?= =?us-ascii?Q?Due9fSOC931KFozsu1eMsgGTQ1M/7lcP3OYlHrD9FAQZlH1UBdnHyXm7cP2F?= =?us-ascii?Q?U5SE80LprFnVHiF4slmDNM+4N3ZOMyIpAcxh4MGrvGSkg4MRBX0yLo74MTD1?= =?us-ascii?Q?2JgKurN6GRV+atYTEhTxZlt2xHOwin+EEOSzOlxTe4YRXfSsAEXTnq32xKQE?= =?us-ascii?Q?qESKto3++DXT3cvpfdwUd5fBTBjSaIsjoLaNlV822efsIDDHlpyN1Yhxof+x?= =?us-ascii?Q?7f+r2tdod0+iB6BGl2xj76yZKQg0EornfBQJvk08dI9SacyHeED3a/YBEvGp?= =?us-ascii?Q?Xn3PQFjqdFsZZR3Og/wKm/S9OG1DmRR89AKJQIV8HgyhckgVJHNnI0c6XL6a?= =?us-ascii?Q?DbY3K1Azp/vFdXeTsUmEfKAIp+5kQpJ5FWE5dRhkfqWsN42zJwF8yc4CBXNv?= =?us-ascii?Q?Zn9WArnL+YNgLW5u24UzYgIg8Sfj6dIkMLUe3Pa8ELCr5mIFlXY3vLZR0Eg9?= =?us-ascii?Q?ihY+TVl0+tl8gS4Dd9frRDW/DRu4kCc8KKH+9uRlvH+NerDZ7nPZjJFQfBMb?= =?us-ascii?Q?yDZGwp9xgm+rSjlXWevUN3GE6s3CP3RNHaJl1QNaNQPLa4mUBuhCL6FCFbv7?= =?us-ascii?Q?puURBxHOrx/MSEvH7xptXEjH5AjJXVEOBbo2x3w1nZiiGICUzAIoTcAo6S5Q?= =?us-ascii?Q?6Z4ycm4l/cbE5+Nf3/nbeQsPwxV2WvENCFOmCUT8EwuO12gx1HH7Mk0R227M?= =?us-ascii?Q?f/LctbT64ZM8mKihOztozCswwsPPEuBfek5iR0gGDB5abt48XFgGIbdo18SG?= =?us-ascii?Q?/bD7FqcyirusME3Ljyn+5VBdfLbbxwMG1QCI8DpHUOKWSoKoAiNHTybRSQGL?= =?us-ascii?Q?GIOzaHaRhKlaWCW7gL2zdi0SPFPJ/9xs7/oOqG1lO9nxKNczHVBUZxXv+2Kl?= =?us-ascii?Q?zpnwjHtGicfTc5ecIvp9FdVuy9lxkJVxhH3XKr/jsFFsC7RSER//3s/1eFOM?= =?us-ascii?Q?htXdV2x2YbK5LMYYiSqzv69pzQPC5uvCc2lj4f0W7bTLBD7M93vbLPnpgxA6?= =?us-ascii?Q?IpFv47X4ra3fxQ4GZxwrWivPnwy7NH61YeGZx6TytfU1rmRnvbURPm6NPN6a?= =?us-ascii?Q?QVojUvIJRNry+XnpWHgtm5Flqd7pgqaXBbsWyTNbtW4hvH4iBUF+/Ff+/9jU?= =?us-ascii?Q?ZWCGy8ksG8xepQE8VHt2oc8UFjT7Dx5fJEZol1bKYw7wV70yr+Aj+kyaJyQp?= =?us-ascii?Q?MhsSxb9ss27TF8UUgjBypDBqUvHlcA86CvnAqQCilSgaTdE99aRJw4gWs4RW?= =?us-ascii?Q?oSNluULaBUMNOyYo6bxKIdKayAEsdhRGnW2cWHCoIQUm+CG5/VO8ccBTXi5S?= =?us-ascii?Q?S16pfzaEZtUoQocwhrczb/zkHhiMptxvvzo/uCARIBDKAHBMST+ugoOm7scY?= =?us-ascii?Q?Hvl6mGgt6ZvQL682JwnSblc9Bq5M6hFqLvgd6Jj1vM9+ig29?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6470.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03e43303-962d-40ce-eee8-08def36cf8a1 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2026 03:44:08.6366 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /5/icrrGMAKJohmQZHJiSE0r2Qp0AF39fiB+ZoPW3Ed5XuQb7ino/qX9u0YdkIBm13ld9Y3k/M8MASNHQ0z0xQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ5PPF5D591B24D X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org AMD General Hi Lancelot, On Thursday, August 6, 2026 12:24 AM, Six, Lancelot wrote: > On the AMDGPU target, waves (known as threads by GDB) can report > multiple events at the same time. However, the amd-dbgapi-target can > only report one target_waitstatus to the core of GDB. This means that > when multiple exceptions are reported at once, the target needs to > choose which one is the most important. > > In the current implementation, if we single step the instruction which > should cause a STOP_REASON_ABORT, the target only reports the single > step (GDB_SIGNAL_TRAP), missing the abort signal (GDB_SIGNAL_ABRT). > However, when single stepping an abort, we expert SIGABRT to be shown to Typo: expert -> expect > the user. > > This patch proposes to change the priority in the target so > STOP_REASON_ASSERT_TRAP takes priority over STOP_REASON_SINGLE_STEP and > other debugger related traps such as watchpoint. > > Add a testcase which have GDB single step a simple shader until it calls > abort (). Before this patch, we had: > > (gdb) x/3i $pc > =3D> 0x7ffff7fa9600 <_Z4kernv>: s_sleep 8 > 0x7ffff7fa9604 <_Z4kernv+4>: s_trap 2 # The abort instruction > 0x7ffff7fa9608: v_illegal > (gdb) si > 0x00007ffff7fa9604 in kern() () from file:///.../step-abort#offset=3D= 8192&size=3D3296 > (gdb) si > 0x00007ffff7fa9608 in ?? () > (gdb) si > > Thread 5 "kern" received signal SIGILL, Illegal instruction. > 0x00007ffff7fa960c in ?? () > > GDB would single step over the s_trap 2 instruction, but silently hide > the SIGABRT, trying to execute past the end of the shader. With this > patch, GDB correctly recognises the abort: > > (gdb) si > 0x00007ffff7fa9604 in kern() () > from file:///.../step-abort#offset=3D8192&size=3D3296 > (gdb) si > > Thread 5 "kern" received signal SIGABRT, Aborted. > 0x00007ffff7fa9608 in ?? () > > Since the SIGABRT is now correctly reported to GDB, the next continue > will be able to resume the thread with the appropriate signal, notifying > the runtime that the queue where the shader was running is now in the > error state. > > Tested on x86_64-linux + AMDGPU gfx1031. Looks good to me. Thanks. Reviewed-By: Tankut Baris Aktemur -Baris