From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uQ+GL8h4lmqA8BkAWB0awg (envelope-from ) for ; Tue, 01 Sep 2026 03:03:36 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=OWXvQvkl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BD5661E166; Tue, 01 Sep 2026 03:03:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3E3601E09B for ; Tue, 01 Sep 2026 03:03:36 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5FF434BA23ED for ; Tue, 1 Sep 2026 07:03:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5FF434BA23ED Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=OWXvQvkl Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013042.outbound.protection.outlook.com [40.93.196.42]) by sourceware.org (Postfix) with ESMTPS id 481F64BA2E10 for ; Tue, 1 Sep 2026 07:03:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 481F64BA2E10 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 481F64BA2E10 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=40.93.196.42 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1788246183; cv=pass; b=ZvGr4QOOaV8pico/eI/05lH+osRHC04L25dMzMbp0LdyyZM1dQ7o7B7VV8CVS5KUjsPUvybmqR2ebWDtWM+uR1uX93ikdHZLWCmwIY6fahD4Q7AoTud5luVtNTKnplKTOhitCzCWDCpbJpofgWZdm3/LKbS5GCGJk4+3cd628AU= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1788246183; c=relaxed/simple; bh=oXKw7N98ZXBobc3uHGT/TZj0xnxC4TxoRdzOU3wCdQY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=PVc3Tn3VnF57570klRJF2Rj2ou0gLBB+oL2rMwq5oLka4V/rxN6vAVv5R2YwjN/5QvjVEs+Mbnp0NPfl5Vb5EsynV3ZdNhjBEJVe8AOHn8jOpzSqB9WPzrwLQyUueJt1UcXT3vUrkbmtGhNw6banARSt2ZEtEnO5DXPYP2KQOTU= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=OWXvQvkl DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 481F64BA2E10 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=X4+XVwUzfN3SqqGcDS1T1V2r6/WeIHvtEHd+34Kegr2D3wmLFgDFgfWWeerHPsQWfQ7WI1wKxe3t3MCtQEYIjMpBt8iXJtoNFO+YIWQ0OudMMib8KTKAeMSgZIQLtb23YCIJa3Ef7FsKoSVkzapMJoJ138MN+ZfjNQoyj40nZk7v14AVPXyblHVbygqItpQmhHL7V79QtZMbw74UDAtcy7XPnf++CHo2nMlSZi+e5E3JSYpX63DhdC9utAPm/0qFBCRfbEUZZG4uV8IUhELictT8phRcxMdd7xcMMsAMbLF8/gyVlDcjusBO5p/jYqYahwJH+CASR6iVFcERy84Qkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p0gmNNm45L8e0j/v8qBjNKJ+LeHvZy6pk5/plPBdGKE=; b=ZKuSgJnQQ2uDHj9BSa1MimGc9NbFTPp/ehy6OZap1gDAyVo8j2IbBojqZwkEp+9VS1K0MJQ8D7b+O5PrsWW1+rOMJ/SBfdz5ZEHxC6VEpsjWXayALR8Jj8mRqpTADXO0nazbSaug+059a2yLSm1ueIwu3Rf1ezP7lVhGtX/v98ow/cPyHMqWOXZdLuKjaQEBMgFSOVr5Hzqu/wqe0JbNCiLpzzTAdB9vN9DhUHQqJ9bhd1AmuZqR0CAUM/ZDFBIFSJ7EA7VQQyuEWMJWWqY4QEWlZ0/JFFtEmdlBI19pU3E4eDOPPh6RfKjCdEzPxINv6SfMi5CNWYYTL1weDqMkog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p0gmNNm45L8e0j/v8qBjNKJ+LeHvZy6pk5/plPBdGKE=; b=OWXvQvklYVsAzKrYYAdIBKl8DJgJS8dLrzCn2dSICK+Dbp4M45TCZjeQfVFhQ482Q5ttcZlHqJwlZqyZhQJGV7kT0phTK7FGrjMvmrwjou22UfWAv+SWPeI8fpIaPwMGnD9k6bFd0zPD86gOpzIlDEmrvl0JdejbN+wLXKQhN6Y= Received: from DM4PR12MB6470.namprd12.prod.outlook.com (2603:10b6:8:b8::12) by IA0PR12MB9012.namprd12.prod.outlook.com (2603:10b6:208:485::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.13; Tue, 1 Sep 2026 07:02:52 +0000 Received: from DM4PR12MB6470.namprd12.prod.outlook.com ([fe80::c988:e72b:f5b3:db1b]) by DM4PR12MB6470.namprd12.prod.outlook.com ([fe80::c988:e72b:f5b3:db1b%3]) with mapi id 15.21.0360.008; Tue, 1 Sep 2026 07:02:52 +0000 From: "Aktemur, Baris" To: Klaus Gerlicher , "gdb-patches@sourceware.org" CC: "aburgess@redhat.com" , "simark@simark.ca" Subject: RE: [PATCH v5 1/1] gdb: avoid conversion of SIGSEGV to SIGTRAP on user breakpoints Thread-Topic: [PATCH v5 1/1] gdb: avoid conversion of SIGSEGV to SIGTRAP on user breakpoints Thread-Index: AQHdNuvOjvUMO9kIWE2sM0dXVXxxAba5UQ4A Date: Tue, 1 Sep 2026 07:02:51 +0000 Message-ID: References: <20260828125003.253648-1-klaus.gerlicher@intel.com> In-Reply-To: <20260828125003.253648-1-klaus.gerlicher@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Enabled=True; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SetDate=2026-09-01T06:59:36.0000000Z; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Name=AMD General v26; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_ContentBits=3; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB6470:EE_|IA0PR12MB9012:EE_ x-ms-office365-filtering-correlation-id: 2c270989-460d-4e8f-588d-08df07f70a19 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|23010399003|376014|22082099003|18002099003|56012099006|3023799007|38070700021|11063799006|10067099003; x-microsoft-antispam-message-info: flSVfzmvJgOAI3+BKFliU2NWA5nzPZUmrzlYp9RJKYSJ4Qu0Ma/dg8Ty7DXqgDil9DrTv/Z6JHXmyat+8kAFr9tixbK6NV3PSLk5md1MO2zal0lnr6K1sbzvwFQ96DlV1zlCoSBM/Tmvnokd6dXnVbTk2qIwrMMoK9jqb8UqBJeWdhW+9RnbSg8o7QklUq9EhUMADK5NGru81dVOrJibSMXs+zPlD/vyAw3C5rwsFyZ0cOpLICsP3Qu4n8hicJ4l6kshU4xbVaLE28O4ZlQt2pPVb4hNgb9I2b+l9a0arLJ7O32Uhjh4VHkqp/rCxzrYKiJaqwqaG32VA0l+rAVZxCKgy0ny1WYNbxRFTQWr32k67k+ydbWxENOMAaV7YMDt1IbbiLA12TAHLkwWfiI1zXISRtN/XFJSwLqSdGKgVP0NThhPRppHMOBvFN1kxnbNf5lcSUGfMpFRu5yVnbhrCU6LKWuz4I799jQsBohCkh0HacBT3RoLUX5pg1JKUtUmt3xRmskUdrZyxBGmwRLJmEq3T/dtbwHnPBsZSViowntHehiUCVxmZXT1jg9sZFuOgfwyM3ckVAUkrFjIH/osrWq0QG3FLOPlPXyCNZf6UWebEfywfbYDRiBiJE+rmM/CtshKq7NZuCihpb0oU9mAUETbeEtFiCdG0z4DY82yq87BwY2+1/oqyyDs4a8iBdBZr1vC+0uePHoSoilQR9ZUs2hy3woKWD73D5zZz9BLXj8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB6470.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(22082099003)(18002099003)(56012099006)(3023799007)(38070700021)(11063799006)(10067099003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lhjexZh7PhIWPDXUn6LYeMGWksAIXAOAcoVv+gUB6eIdppPKHlDkCBAt3lKK?= =?us-ascii?Q?uv3Z53/TR3wUtuyOrUHtEepWljHwtK51QwH9llRxbtp1g+brS5hLV1Pnyfs9?= =?us-ascii?Q?Xcjxgw5No785tbYwHnm4uwlkjDYchfgNvzZNtjfAPgV8CilbJc3KTsFuipnn?= =?us-ascii?Q?EVqixEXjQAn0WxrBfJR3W5JzQ0bl/Ip7LDsO5QMAkKqAG2ngPDIQpQpIcZU0?= =?us-ascii?Q?8kbQB+Oeg+SSgVcpyxyjmoBz81YED8ggvVYHW6XtG3vPby/HIIK/axsonDq1?= =?us-ascii?Q?LlBgIKXRWiKMudO7w5TE8ix+6rAN8Vz9O9jAsUs40bzNIY63Qj2I8fsmFpWH?= =?us-ascii?Q?VBgb+yFLeLLgnsRX74qzunRS1UZ2s5AKvkb3hns5MPigrX8xDLzdD+vWFOyU?= =?us-ascii?Q?7J39ofjZ4NbWS5PAkj09ZcnVKLMalU3kCPPFzdl6LKCwf+A5alaFqSOvSNJj?= =?us-ascii?Q?Xw7mTtzzX1P7o7RnhStbWRa9XsUpAveuSRLPU3ujRmd82PYvyeDcPvr9KX/M?= =?us-ascii?Q?umzOo+BtM0+6YKFAgZxg+e/OdFQpXSC53Vu87PrBdzLFUk+V4HrAoAW2OzGO?= =?us-ascii?Q?3ZLAobp8a4mBoOeU53CqQmOzWSZvACC5y+TICXqwURSuFTywQwslqcwJghMV?= =?us-ascii?Q?gnRAEDUgETpuxqA1IgXmf4M2A5YzmP89pFUG3nmhhduhyjikQ/r+JnhgUjM9?= =?us-ascii?Q?mPbcl5YUodoI39DRmyi500F4li29POlNts9At4g+YFEh6nnQFoI3dfBYd8tb?= =?us-ascii?Q?gdonhq70yKmJCpG0Ywiu8cP2xtpNWdX+HuwywDBF3tYrqJdHIRwz9/aLG9G1?= =?us-ascii?Q?FG1QpoPQjEaYSVCUWMQxEMSXhF7YVdlcwcwnteMDY0VdtyRl3EXWzM9Lu/bl?= =?us-ascii?Q?pdjlHfgqkL8dGCC+NCxgMNsI2gOEG8JKSZpItVAFiNPEMe+hO2sOjYgoDisD?= =?us-ascii?Q?Z0o5NtJMbGeRIeTz0QuuhYblEKCgR02YwkT68NxKo7QCDLneMUgNa6gdodHu?= =?us-ascii?Q?qJzuYmVXJs76DKbjCdloI5YiA4nUzE5WwqrQInmOWhphUvC4Bf5FsUMdY8gu?= =?us-ascii?Q?rI/eHq3UevzzxBtOwVLco1eXK6SHd3YZyKuQ0cMbhufzAqG5J/BLsYnBnHNZ?= =?us-ascii?Q?I5eksQmgZU/gUV0qdytfx4IVrxkQ2k260UbksJreuTMA0bYJ6YTiqdVmWwFV?= =?us-ascii?Q?3aS5PG8uuQY0f+XugjZc13+s/8FOXPpSe8whrTt7JIcVo/994Ta5u946+b2e?= =?us-ascii?Q?5QtW3O4z7MHFtqwkT7FhvapZ7jJpGRjNOSr//UdRAEnWvvMZJq6Z5Dp3ARxY?= =?us-ascii?Q?YJpogulkrSlLVTfUkbkOCS+fXHt45vWGTzgfcV9rK1lW4DIm3vZt4TsZlGxH?= =?us-ascii?Q?McgFjliydy503P3y9zYC8/WRskn3BDJTCyY+6dbUCWuKl4ElpW+QumMlVPht?= =?us-ascii?Q?4uy+XrXnyu1RfA51kZbLGaNt11fuKm2C/+wB4yE9eWa5QczUWGHMhqY+I241?= =?us-ascii?Q?Y+dv/5zAlfuIgeJwqxl/KHWcGdiXzdq3mrzRPKLKcuDw+RgwrJCQtbOBqiGu?= =?us-ascii?Q?vcWSv5qI47qK/omBoiUozN/P4I1c3wCRmdKX0Y517ZKYrwBygoyEhgzALQdL?= =?us-ascii?Q?1Eg4q1/8vjRzgD5+plAQwY9eZNfVxjqOWH38d1tCRpabiTnOLO9cDFvgVrB4?= =?us-ascii?Q?jPbDJKcTRbQayFxBk8bPib8WudHGPELQDINJkKPgRGR76Kuv?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6470.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c270989-460d-4e8f-588d-08df07f70a19 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2026 07:02:51.7029 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nfHYZIROrQpzOw1BV61AEt2pTs5+nIxoloTy7zf/9gbVVdwQ6jzYjneZ6Kec/8Bq8v3LJsbKMrEuBF9F4bQfag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB9012 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org AMD General On Friday, August 28, 2026 3:50 PM, Klaus Gerlicher wrote: > From: "Gerlicher, Klaus" > > GDB converts signals GDB_SIGNAL_ILL, GDB_SIGNAL_SEGV and GDB_SIGNAL_EMT t= o > GDB_SIGNAL_TRAP if a breakpoint is inserted at the fault location. This > conversion logic assumes that when these signals occur at a breakpoint > location, the signal was actually caused by hitting the breakpoint rather > than a genuine fault. > > However, some architectures have "imprecise page fault reporting," where = a > memory access violation can be reported several instructions after the > faulting instruction. For example: > > INSN1 <-- generates a SIGSEGV > INSN2 > INSN3 <-- breakpoint installed here > > If INSN1 causes a memory access violation, the backend may report the sto= p > at INSN3, where a breakpoint happens to be installed. GDB's logic then > incorrectly assumes "there is a breakpoint at INSN3, so this SIGSEGV must > mean we hit the breakpoint" and converts it to SIGTRAP. On architectures > with imprecise fault reporting, this is wrong: if a breakpoint is never > reported via SIGSEGV, then receiving a SIGSEGV at a breakpoint location > means we have a genuine SIGSEGV, not a breakpoint hit. > > Add a new gdbarch function, imprecise_pagefault_reporting, that allows th= e > signal conversion from GDB_SIGNAL_SEGV to GDB_SIGNAL_TRAP to be skipped f= or > an architecture. The default is false (conversion enabled), preserving > existing behavior. Architectures with imprecise fault reporting should > override this to return true. Looks good to me. Thanks. Reviewed-By: Tankut Baris Aktemur When this is merged, I'll submit a patch that overrides the gdbarch method in the amdgpu target and includes a test. -Baris