From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id JkOaGFUBTmqvAywAWB0awg (envelope-from ) for ; Wed, 08 Jul 2026 03:50:45 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=v3hU7yF+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 55C7E1E070; Wed, 08 Jul 2026 03:50:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 270F81E070 for ; Wed, 08 Jul 2026 03:50:44 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9633C4BA2E24 for ; Wed, 8 Jul 2026 07:50:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9633C4BA2E24 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=v3hU7yF+ Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazlp170110009.outbound.protection.outlook.com [IPv6:2a01:111:f403:c111::9]) by sourceware.org (Postfix) with ESMTPS id C74424BA5436 for ; Wed, 8 Jul 2026 07:50:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C74424BA5436 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C74424BA5436 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c111::9 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783497016; cv=pass; b=YCQ4FLuXthFbpLJsjDJF1Sj4fRvJAcyLM5AK7RuqvuPSThMbSwiYHOwWOT9w9nFT7xAoBO7GoX6IXYjpwGggvIUmfQ5yuTwCLFKEbHt2AmdKMNfsGm4GUyx+Q4hnhQ+UDzsKMXdM2Aj5Fsppf3LRKqVQ6g+2AmiHTkYv/+n6znk= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783497016; c=relaxed/simple; bh=yLX/xHMyM0garigpQAYw2EDvpd4PWDoZIZQbxep3A14=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kRxiKspkBZ9jLhEvTpGX5h2uWoebI9Tm2j9xaBU4uCI044xABUMS7kM27ZCpDtOEGhEbUG93Isvmi62jT3sYaceRsjbAcZequDhrCvtnrOcNZKY5tmZYgHBpilYe6ylGUDZnIPb2eaNyxZ8e/NFU6D39UxRfwyjb3QHh9PMse2w= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=v3hU7yF+ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C74424BA5436 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W+rGHRJ/RTAfjzqK0MxTLegcppfrQe8G7i3yMVhIVRLisXMRuTcYzSaoBxrEToKGH6FC88pvvg4ocbxg4XCYGuj3hJ3bzb5IlTGYwm44tYbaSOnDWXb56yDWFjC4kSZT2ua+IuNNz5u055KCnHa3G/gsHiLNKIw7/LlHZkJ0WnORp6iRGkC8mj+HAdTZxZrl3vHTzluNPbrNLRK/eJmMi0lCqU3zSfQpnzKI2r0E51qFv11N8QzL5v4KkX/o1bwQFeAtEXBzpua9svsv9WXF/WSXvtAVoYPKvjfcNwik/nxEFAh8INB/6excSrUwW4pLxlh59zriwqjsAGUBTfIgzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4yAcVOplE+rinljvcq505khKsRFvh4ZGO83yeKnN1uA=; b=Xed8Ui2wKYvCan1c1YKpc/SGGVkqlpQUWdcFzk2suGxBZ76F1jPWgCfZqSFGP4fbn+JxAt0FTY9B1C71bGqLp+TabZy2XywZ8iGPsVJerzaVk1HnSsVcZpf3ZXfm4vwdYD4/aQaRbsNgWbP0AUpJ57XhNkmd63OBrhQSmUNXqUFQEOk4fH1ScYK6pYZbpSPKJSqiW/7e7Pt9qkjk7rr3a+1QrWCPf9j4FkqiydMKYF//5sLtvfFDvbU+pPUw0jmmIZCrp/26pOWjQcgcU5l3klTJWLrJRARmMsszcHRN4OjoOll8mFRy8xJG0/2ojhhT1xv72Zz3JPrVpWnZwIL53g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4yAcVOplE+rinljvcq505khKsRFvh4ZGO83yeKnN1uA=; b=v3hU7yF+SIkL6ZmTMgpAARMxQw86XfmJCIzOb5PlZgqCc6J2ORk4WKcLEacPNs+eFqq5lkWnIlBsPv3mcF/zcNjaoExBH8e78sGButZ2DYXTjMZr8bkCwj2vYQcyIZNrxBWuaiEesrtGaAp9mFloCakSj2JQvPb8aTEpvopE+Ik= Received: from DM4PR12MB6470.namprd12.prod.outlook.com (2603:10b6:8:b8::12) by DS0PR12MB8562.namprd12.prod.outlook.com (2603:10b6:8:164::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Wed, 8 Jul 2026 07:50:09 +0000 Received: from DM4PR12MB6470.namprd12.prod.outlook.com ([fe80::c988:e72b:f5b3:db1b]) by DM4PR12MB6470.namprd12.prod.outlook.com ([fe80::c988:e72b:f5b3:db1b%3]) with mapi id 15.21.0181.009; Wed, 8 Jul 2026 07:50:08 +0000 From: "Aktemur, Baris" To: Thiago Jung Bauermann , "gdb-patches@sourceware.org" CC: Luis Subject: RE: [PATCH] GDB: aarch64: Fix inferior function call if GCS is present but disabled Thread-Topic: [PATCH] GDB: aarch64: Fix inferior function call if GCS is present but disabled Thread-Index: AQHdDp+avUWMQv1EwEGSdo/eLtaHarZjPtdg Date: Wed, 8 Jul 2026 07:50:08 +0000 Message-ID: References: <20260708060331.347616-1-thiago.bauermann@linaro.org> In-Reply-To: <20260708060331.347616-1-thiago.bauermann@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Enabled=True; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SetDate=2026-07-08T07:47:36.0000000Z; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Name=AMD General v26; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_ContentBits=3; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB6470:EE_|DS0PR12MB8562:EE_ x-ms-office365-filtering-correlation-id: 8237edb5-4d41-404b-3c5f-08dedcc5884e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|23010399003|376014|1800799024|366016|38070700021|6133799003|11063799006|56012099006|22082099003|18002099003; x-microsoft-antispam-message-info: /AoUIBFIIz5g1w/AnP3+kv3ezVX97k+S9oLUBxTK5eP7MXNnxKVN9YiMrRgIEFJP0qSb3LRTpZmPYYpfUWOn7J1UO23z6oewsDq3j61oqnGPaEROdNB+tXwtIpkXfjtZRPUumV/lb76HAddFb+oTaqV2ZBpdm/S/AiL53j21KaQPZElRYAxrGoh/bnqoiept7JCG7tGugs993WN4cDoAgfLx2dfPOX9SAlsqJ80kNTztxLrzQo067O7DGeZK5TbZR6YjpSqPMj6y/uz5VQmtBV88vybaoSKkUdFtMzKBR7WuXsRykf/8bbT2VuZ9kI4IFBHcFitkzGToLuhvkIIxz2a8hlAsfX85rqTB81mAieBGWrAj6XMbpccov3qRcr56gmVmhsmANqVW4UyZEQzfn4P4w+Fbac/QEoEeChb1kWD1PfIAoljmRmG8r8ImtJ6ldOCNdB8jO8+y4nJqKmScGBIHjqvIMIbOZrhTLqLs/1pgNrlUPy1cGUMnw5poZUvqVEu8E+77zjzWveDoCfwd4IhaGpCUvSOH68cYsVrgn93R9RcwD/zIjCYEPU1UVYn6u+FRO/MRj1KLQLoWdUjadUNwJFIX/O791hROoliPBaCfgBlZf8/okiOdgB+94k8demIQlSGfPSxyX3XizCiwBH4w0/ZqO+wQoHqzgwfhGz9vTarn2wH+1DrW5I42m4ookkw9r9ydC5kwnckUjNdjZaKH63UxtVThQx+ujjK6tvo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB6470.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(38070700021)(6133799003)(11063799006)(56012099006)(22082099003)(18002099003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?K1R6EDud+xAijwKW1lFZ+Xuw+Jdd9SqHZvXoneQCbHH7QE5NkpfBl9Pr+iRz?= =?us-ascii?Q?zWkojVV+DnkHiRjpZOJ5vgiToYgQOs0VFb+O505lJnZoIlsFflUu+GoJAxZ4?= =?us-ascii?Q?XlktGNGwUggpUc7jjNyoJ/bDsKbVl9+6Lqwbch8YFHgpmM7BI/8WjChkw9bt?= =?us-ascii?Q?+RPcW102ukd5S2ACmTwlbXUru44ZYvgZdqfO0Y7+mTX9cc8YO0955BKBEYtK?= =?us-ascii?Q?TLTKO1Keb3Ck4Mjug++UWOQjfkG5FN0/DFCTX/jY8EIV3HBY8YftxxbBFxPE?= =?us-ascii?Q?jR8dUD1wdaKtXhsoX4J7hhU2dkq7aiXWudYYvF+Frn2R5qld1YeCnu8u9Q6k?= =?us-ascii?Q?6CxFwHMPa0KU86x+U+13OGIz7sH8nKiN+SY/VMFpkSG/c4l6LUKvbivQqc9A?= =?us-ascii?Q?HmLJ0VndPSEbRgke0OX+cHoqQ3Nq4n9BdB4W8QbM0VcLi6rq5G1++1/QQxXI?= =?us-ascii?Q?KMugKRoc9OYDyaO4OhirZfiVlw4diq29gIydYRgRr9Jen/7q98zEcsMnaVJc?= =?us-ascii?Q?oPb+uNNhXpezRQFK7HeTClnUi0L0D/A4Jrekw72xht6qeZFAcuBcQVIL/CWp?= =?us-ascii?Q?63DAp80BYPMLi/pRTrtwbc2KvpDkCKgqIe9Wnl6W5OKkyldIoNzdAH0CiVoh?= =?us-ascii?Q?tjAdvwSXFb5SiA/Zdeflzn5j027umO39fhu0DaYSoeN/lSkc4bUnK84mXVJI?= =?us-ascii?Q?Jyet6xZH2kYYAKdSNS6nmK2P0q/dRssogYsjtah8FwL7TxMTUff0fwaDkqkW?= =?us-ascii?Q?FfgR8CVgrij5KISv2e4M7Y/kuI2zr4Lhc0L5ARgeDsNuQPGJI1wcCfzpEkts?= =?us-ascii?Q?QHTnRyb4S5ldd+oJc8Bi1ViNLcs0clIVU36jykeZ5YkamU/mlJPRmSVdos/T?= =?us-ascii?Q?31i043AuJsADBQpILS3wHZS4+f3HOVpaTtSYj+w1goubYftifydSrPdDLk/s?= =?us-ascii?Q?6XPf+RGsa79NWp4QZKnUTy9sc3nTO/8gsTfCHASgAG9aXKXCuIzrOH05yayx?= =?us-ascii?Q?mGRNFgGf1WT4SBKBzqFdb32unEHMTSOF6VqP8mIq04jnAZOBEyEJzqMbnpr3?= =?us-ascii?Q?tM+0hWfX7L47XmtcXF4WrZ0RvV6vFQgslb5oEE/+c3UCMRHehS22+3wXubMD?= =?us-ascii?Q?WoVVhAryM2T/fofzpTjbQvFmXZUxVBewR5wxI0mQUi7VJfeJwuydBqudbiV+?= =?us-ascii?Q?gwhBGOmZHe2KPJUTl5a7D8PtOWncmaCmiWShn5V+yy9FeuEHN//E0kI+RtC/?= =?us-ascii?Q?m+DO46knR4iMjfX9zsDnNvCDxuddF0L7b8iSg7h6RCE/BopAgFPH7V2W6fbu?= =?us-ascii?Q?Yo9U+easp7VDSXJB/qFH6GmHaTA5mBbUWuX5vA8mXQjQAmS68Q+6K8qXjT3E?= =?us-ascii?Q?AoqAUYajVUx3K9xMXSeNS5lHJokCQJu98K7BaPmZRiKXSpjLY1iVPQVMIjSM?= =?us-ascii?Q?NibUNhpKnelOv0VGs8qLaToL8hVJAj71UyJP9c0NWr+E/Dw2RY+ZuvhV9Wcz?= =?us-ascii?Q?+qJAIUvXshJrTgtxOLbDusJO9sCHf2BOrQbKAgUgJkYKdxfY0IVxkTwYvmF1?= =?us-ascii?Q?n7kpoIKaJ3mNpSW0RvFKa3xzEupMnyLbb1kSoyGOXJyERC8RcPNNJA8l1zU7?= =?us-ascii?Q?a1rbNE+a58u56GRHB68Y3dpxJzjRWW8lGWsj6XHBXiZzWriQtedCGAjKIav8?= =?us-ascii?Q?q7r+IkhEAKJhly46xGRFr48FqEP1YZDR2VZ3e6PHYYC9vNZa?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6470.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8237edb5-4d41-404b-3c5f-08dedcc5884e X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2026 07:50:08.5436 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pFWvlSfCuCJmq/UQpJXa6QYHdJwhsRH/8ECm9ovcaA13E43PCzDiJNF+4avjqlbQztgm0Y5ZQptgY+yroCd2oA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8562 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org AMD General Hi Thiago, > On AArch64, even if the Guarded Control Stack feature is present on the > system the inferior may not have enabled it. > > There's a bug in GDB's GCS support in that if the system supports GCS, > GDB will always push a GCS entry when doing an inferior function call > even if the inferior doesn't have it enabled. This causes inferior > function calls to fail. E.g.: > > (gdb) p foo () > Can't write to Guarded Control Stack. > > The error message is because the GCSPR doesn't point to a valid memory > address. > > Fix by checking whether GCS is enabled in the inferior before trying to > push a GCS entry. > > Regression tested on an aarch64-linux-gnu QEMU VM with GCS present. > --- > > GCS support first appeared in GDB 17, so if this patch is approved for > trunk is it ok to also commit it to the branch? > > gdb/aarch64-tdep.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c > index 886e7ce1e7b6..b4437dcccc8a 100644 > --- a/gdb/aarch64-tdep.c > +++ b/gdb/aarch64-tdep.c > @@ -1934,7 +1934,11 @@ static void > aarch64_shadow_stack_push (gdbarch *gdbarch, CORE_ADDR new_addr, > regcache *regcache) > { > - aarch64_push_gcs_entry (regcache, new_addr); > + bool gcs_is_enabled; > + > + gdbarch_get_shadow_stack_pointer (gdbarch, regcache, gcs_is_enabled); Some analyzer tools may flag this because the return value is not being use= d. Maybe put a `(void)` in front to indicate the return value is being ignored deliberately. Regards, -Baris