From: "Aktemur, Baris" <TankutBaris.Aktemur@amd.com>
To: "Six, Lancelot" <Lancelot.Six@amd.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "pedro@palves.net" <pedro@palves.net>
Subject: RE: [PATCH] gdb/amdgpu: Handle SIGABRT with a higher priority than SIGTRAP
Date: Thu, 6 Aug 2026 03:57:14 +0000 [thread overview]
Message-ID: <DM4PR12MB647068F649B6D5E408C80105F8D22@DM4PR12MB6470.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20260805222425.588196-1-lancelot.six@amd.com>
AMD General
> diff --git a/gdb/testsuite/gdb.rocm/step-abort.exp b/gdb/testsuite/gdb.rocm/step-
> abort.exp
> new file mode 100644
> index 00000000000..a385bc435e4
> --- /dev/null
> +++ b/gdb/testsuite/gdb.rocm/step-abort.exp
> @@ -0,0 +1,72 @@
> +# Copyright 2026 Free Software Foundation, Inc.
> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
> +
> +# This test ensures that we receive SIGABRT when we step over an abort
> +# instruction.
> +
> +load_lib rocm.exp
> +
> +standard_testfile .cpp
> +
> +require allow_hipcc_tests
> +
> +# We want to have a small kernel as we are going to single step all the way
> +# to our abort instruction (s_trap 2). Using -O1 allows the compiler to inline
> +# the sleep and abort instructions.
> +if {[build_executable "failed to prepare" $testfile $srcfile {hip additional_flags=-
> O1}]} {
> + return
> +}
> +
> +proc do_test {} {
> + clean_restart
> + gdb_load $::binfile
I forgot to mention a nit. This can be a single line:
clean_restart $::testfile
Regards,
-Baris
prev parent reply other threads:[~2026-08-06 3:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 22:24 Lancelot SIX
2026-08-06 3:44 ` Aktemur, Baris
2026-08-14 8:34 ` Lancelot SIX
2026-08-06 3:57 ` Aktemur, Baris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB647068F649B6D5E408C80105F8D22@DM4PR12MB6470.namprd12.prod.outlook.com \
--to=tankutbaris.aktemur@amd.com \
--cc=Lancelot.Six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox