From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TAneGl7zWWpBMA4AWB0awg (envelope-from ) for ; Fri, 17 Jul 2026 05:18:22 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=MyHaXa6i; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5D6591E09E; Fri, 17 Jul 2026 05:18:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DBFDC1E099 for ; Fri, 17 Jul 2026 05:18:20 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 636044BA23C9 for ; Fri, 17 Jul 2026 09:18:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 636044BA23C9 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=MyHaXa6i Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010069.outbound.protection.outlook.com [40.93.198.69]) by sourceware.org (Postfix) with ESMTPS id 8F2284BA2E24 for ; Fri, 17 Jul 2026 09:16:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F2284BA2E24 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8F2284BA2E24 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=40.93.198.69 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1784279815; cv=pass; b=dh2PbrtNm04aoupXr+FEL2DBO1oKyMpSIw3xQAKllsRZ0n5K5TmVXPwNVsnvSEYp5LGUwjcm4CG+ex1c7u5Lwgy8iZ53gyFuzHPfF/cseL2jeLMJu77w2wERptqMoNUTFACDRKD6BjeI3suYKerVmPPi2SKxMtcnliva+hXQbso= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1784279815; c=relaxed/simple; bh=aYWsIKOhkyvai8jK8/2hSwyZ5lK0gKf8ufQHaFma1oI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=icAd5zslQ+XvYvO99z7mBi58AKtFuWoMsCq93k6og68PeXXDrRsuOJShF1Oic81EsKYq73OCfGnGFHdEarEVllXkNLB5ZlYCglDIGGk4l4oMcnSQ0f52gTbjxtJqG7ITNnnIfqJEsafO2uNMSKKKGv1CZ0P9zFds7R4WrEsqGxM= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=MyHaXa6i DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8F2284BA2E24 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RIENdTXKKjYhpHFvUmwlI8RhWQsS2s/b+T9oLgY+1ljaBrMktEeyQ4FTVIjNEHV0hB8ImhAchKJlk1wLXZdbZsBm/XQYpk6I3AcLp5COzOAZQRCEom/rWfgKwSSb/VBCeZ/qTaMiHUeymX2vTku/PLarqRVcfvaDhLf+nPMzexBvswVOcc+Ql7WhcAIK4sxLj0NuXYAViugbHfbMs2qIga4TCmF3ViZHLOXT5ZXh49ErarwmVF5SHBU7MikMy/2HI2F6KLz3v1MaVokESu9qwPPDLdl8MM1EmNv73evf2E8qKdZNcWOIZf0TUEuyuUvAInFur192aaCKZOgGy4alzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3IWiErh5PoNzvScAP0do6mbboxVQDN7NEFTIC3TY7vM=; b=weStI4rNc7Tnw78m3c5Rr643uApW90CstWfPYvlltMpgmk4FNA+X66GRjrgTc70g6H74ebadTHMIV/F6GVyMa08qLGX/BPzH6qx87wq3QIfs2FvxVtOk/09sHi8TmJJ95RGtg5Gti30Txz/0VIevSTRTGR/XEzKkyoDk0TFZ2CoZAYoyYnabF/gjzAqvp1LVuSDPZA7+qI/JIcn9LwugWl8SuVm7i0Cs5xZrmB/t29qZq2n9XuxZFz1NF31xpzQXIhNTBUsktSz/XWvANtNyZEyBPxYxq/QBbJR063m+6VovGx+TPSGB4BxvXR6y2Fb3sGwakBsaAqPVZToYVrPtdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3IWiErh5PoNzvScAP0do6mbboxVQDN7NEFTIC3TY7vM=; b=MyHaXa6iN7Y/ily2glT1gUvTc0IuVGIAtA1DeiRNSwGrOSAuMNp8I+zUSU5GQ2DLIKy3Az2BVBd690dEoRd6HmdDLCf6fqdHBR/KyqacOnqu2u9nvVXdwhzbrvyJm+NM/JCO6IUqrjn4q3E1SLWjKndZCqLRneEi7i1r3Wz1x3o= Received: from DM4PR12MB6470.namprd12.prod.outlook.com (2603:10b6:8:b8::12) by DS0PR12MB6461.namprd12.prod.outlook.com (2603:10b6:8:c7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 09:16:49 +0000 Received: from DM4PR12MB6470.namprd12.prod.outlook.com ([fe80::c988:e72b:f5b3:db1b]) by DM4PR12MB6470.namprd12.prod.outlook.com ([fe80::c988:e72b:f5b3:db1b%3]) with mapi id 15.21.0223.012; Fri, 17 Jul 2026 09:16:49 +0000 From: "Aktemur, Baris" To: Klaus Gerlicher , "gdb-patches@sourceware.org" CC: "aburgess@redhat.com" Subject: RE: [PATCH v4 1/1] gdb: avoid conversion of SIGSEGV to SIGTRAP on user breakpoints Thread-Topic: [PATCH v4 1/1] gdb: avoid conversion of SIGSEGV to SIGTRAP on user breakpoints Thread-Index: AQHdFcA9avoS2EjXD0OkH3cYMCJ5q7ZxbYNw Date: Fri, 17 Jul 2026 09:16:48 +0000 Message-ID: References: <20260717074453.253386-1-klaus.gerlicher@intel.com> <20260717074453.253386-2-klaus.gerlicher@intel.com> In-Reply-To: <20260717074453.253386-2-klaus.gerlicher@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Enabled=True; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SetDate=2026-07-17T09:13:18.0000000Z; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Name=AMD General v26; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_ContentBits=3; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB6470:EE_|DS0PR12MB6461:EE_ x-ms-office365-filtering-correlation-id: 1ea24d95-34a6-4740-7fc4-08dee3e42194 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|23010399003|366016|18002099003|22082099003|38070700021|11063799006|4143699003|10067099003|56012099006; x-microsoft-antispam-message-info: YRR0sUfLcAfVqx2wk2MFyKeJ//+uPwZNvZGzEvITa3OLAXIdtI6gHjKc8w4TY/E2ml6ru7KxboomF/zL+B1FhWRfp3whySkl32npNJc6hbHbp2agKbbe36aJwkykO0BXyy2u8gFZ437BC/Mhcr/R1WSX64yRfLi8uonmi06qH9uzVpQiqgDKkNTEs7sr1rsnMbQJX7ugU3s0Vj+cOJ7iBpgxbHNbn41FJIHOXVeE5yk0gKvRJwFjywWXJI9wJDRW5T2qT6jdL5i6xu5aGarBvWFMI6q036fTOpLyX5nytuBVgXb9/9+7zk1ny34A3pH0rshkMRZS//RIebql7A4Ra8BjgILuSyYR5L76PlXj0D1mM0Sz7kiBFtDpvEqIoFL4KLd1WJEcAUK4wiOopDgQOu8vMW2ENqNiDTJgAVMtOJ36PlSb0exWhNjAhu3UDWueJwWVftKDZg/qXoS69svTh2jbi7nHn0PQXqQ/hufswtof20hgc1elQfj3qFBdBhejMHx0rTySyYjzZJ76uzwXRvGeRLi5NSJ9CayqGV+k8qExuMsvey3e+56vpB3iEWOIyfIw+Xy6/oxjDDSVEafb9P2H3a2lqasWOr4iF+YFx8ao8N0qhZuv2/OUK/aD50/iayWsyIKXcup2Mhiil4vkgptbmbnGzETozXW96Ll20n6aJu42uONlCFDs76BLzs5mBVo5vV5ktjIaeYDIFlzOrpOWtVhJjw9zc8V3GkAfu2A= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB6470.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(23010399003)(366016)(18002099003)(22082099003)(38070700021)(11063799006)(4143699003)(10067099003)(56012099006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EB6zlFg1bKZQAbsLmRmlvyEIDOB5fzgIzlyx3edvN4W9A6aAj4p91Ej0vLh0?= =?us-ascii?Q?WYkH2JIr3DoEL6+yUDYa2koV4onej8m/dRI7fg9Uq8uC/Kkw5dduPZRbL9lr?= =?us-ascii?Q?A2qBw9bU7iEFf2g76L7ib0tlfMl2vzTPm2JfeSkjLAkSVKaM/STh1Vc8qEWx?= =?us-ascii?Q?OlrR4ybUTJt08QHVEUMmNer6XPQtnZklfcmoZ+sK9CBIZ+NMysCmL0fPZMe6?= =?us-ascii?Q?ZuMpuVbmO1tqTHWX+C2r0DmidU2kHQDrQ4LXZIMtGyh/cG88P7/+AdSurE+Y?= =?us-ascii?Q?BuQ1stO7CX2blYQtYAkaH3ATWx6M2CWwa+zw50nl150tuxQVgwRyfjUmgR2G?= =?us-ascii?Q?/sRoN8pLV7XPMcOr+T7ZK9VXnAMjl5rXrVT9Ysdq2JGc+Ssk9g/Y9svV9f0l?= =?us-ascii?Q?Yp9Wq8EdSqu0Z0neUlndCWT883Ra61ex40L2/j4+9V7XpbvL+IpGjaanb3zP?= =?us-ascii?Q?OD5yEkbfoiuyFWZd16mGIGyPcz9tPAKbQTSYJTNECKIwjJWBt7j+T2QtIn88?= =?us-ascii?Q?+jp9Ss+KC9PsdKJqUhyFmVFxZe783//Ry1Y6Gl9bWFCtcSCIA4QZIyl2QfOF?= =?us-ascii?Q?1jAwAoS/qYna8hIt8kG/kKZKkgMNDpsCvvxkQqJndCry0x9w+W/g+SE/Pwa+?= =?us-ascii?Q?hn1KRz4uQBlgqANWv/wXAYIFE8NTMrjFss08MMhWpQtt+YL56TFkUzvDkGYe?= =?us-ascii?Q?MMxWOM9+lTWzhIPytezV4jljIcWoUNjml53dEPFtuV47/LszvPLEpgM0/Mw/?= =?us-ascii?Q?kSPO51qTSrHOlW94mYVNjlr4OZLWoK5vsyYqFhFhBZKorFsRlvajLAjtbSUl?= =?us-ascii?Q?6pEuLOeVuYH7tZHiP6RffRIy+IbClMBqMz6vLcISKUrmEpTSR73IR5wpCTne?= =?us-ascii?Q?lOaMWU05Jh+WFM6g9yL6u/cv4yLczXlIq9N9QI5hjQgZhfPCWcpZumad6L0F?= =?us-ascii?Q?e6mBQCqLndGpx50V/7Kgo1cX4o6ZEh4Wd4j2fd9X7onO1ZBOw5oRtT/UwCsP?= =?us-ascii?Q?msw+NWBnylZrDpiWckxCs8eaa+PjSOVz0WI6kEwjO7WyrQEB8KSJbYj79o8k?= =?us-ascii?Q?1EG7CMsXjHVzw53sa4sy1mwBEzDT97d6PHkRV6ykWIYDHSsvg/Yk7Wuh+wSF?= =?us-ascii?Q?5wdL5mD/4WPR+EDMz9S45qZjAvhQu6gx+JG3TwysW738ISQQ6TFp51xdecP5?= =?us-ascii?Q?w0tJ3syZlzZwOOeBWYkJ02skIwiIAi2jWdt0sdlQbs1g3Oa94UJzkX+kZF1e?= =?us-ascii?Q?Rdid9s6yGJ4PPtcvdNx5E0voN//Ke5l5qmrMwD7QxzX5xFCNvrX/KCZjRifE?= =?us-ascii?Q?11b4wO38ptHhGpO9y+xKVZO+w62B0mO64csvAh5W3PBbs7v1Yf+mrorlkVel?= =?us-ascii?Q?PKOVI9G3Nm+vGC9oXzmVjFqK+LZN8PqKGy9i3nmz3OgfwFRjtiHeIBajnhOM?= =?us-ascii?Q?O7Uwv1oi8b7LcyySZnbB1t0RPYGXIOsOtRogPfiRN+Z6N6bmEB88nZbGe8ma?= =?us-ascii?Q?3+rr/7ZyYfKc0kECDYlVZBHZIpIrqSdMdsw0i43AML7OyVsB6xNZlSJ/H+QE?= =?us-ascii?Q?5V0Zw/cX1WXOgdWy2S/w4GfH9OdQQwNVdPeTJcMPxg6CyiOow738WTYLOvCx?= =?us-ascii?Q?Hw+tHTTgn9LbiH92TXKuzzxvHAQB5Z7efijLD6ijMHT00cRqGFdIYfY5TkVU?= =?us-ascii?Q?NSdOSTxUPleUHFe/f81cWaa+m6HHpHwpw7Yqu0byDUNWETyR?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6470.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ea24d95-34a6-4740-7fc4-08dee3e42194 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2026 09:16:48.8015 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KKKlw7mxe1LBg6/bWUJ2fODuhb0zKKj9rVjc/974wFlyAba0/kx8QEYQwX8NPZtxjKcNwGMRIMOqxwz/KYwTLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6461 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org AMD General Hi Klaus, On Friday, July 17, 2026 9:45 AM, Klaus Gerlicher wrote: > GDB converts signals GDB_SIGNAL_ILL, GDB_SIGNAL_SEGV and GDB_SIGNAL_EMT t= o > GDB_SIGNAL_TRAP if a breakpoint is inserted at the fault location. If, d= ue > to imprecise page fault reporting, a breakpoint is at the same address as > the fault address, this signal would always be reported as GDB_SIGNAL_TRA= P. > > Add a new gdbarch function, imprecise_pagefault_reporting, that allows th= e > signal conversion from GDB_SIGNAL_SEGV to GDB_SIGNAL_TRAP to be skipped f= or > an architecture. The default is false (conversion enabled), preserving > existing behavior. It seems gdbarch.py has been updated since the last time you generated gdba= rch files. Re-generating gives the diff below. The patch LGTM with that fixed. Reviewed-By: Tankut Baris Aktemur Thank you. -Baris diff --git a/gdb/gdbarch-gen.c b/gdb/gdbarch-gen.c index d9bb3e7078c..0b815296261 100644 --- a/gdb/gdbarch-gen.c +++ b/gdb/gdbarch-gen.c @@ -5295,8 +5295,8 @@ set_gdbarch_get_shadow_stack_pointer (struct gdbarch = *gdbarch, bool gdbarch_imprecise_pagefault_reporting (struct gdbarch *gdbarch) { - gdb_assert (gdbarch !=3D NULL); - gdb_assert (gdbarch->imprecise_pagefault_reporting !=3D NULL); + gdb_assert (gdbarch !=3D nullptr); + gdb_assert (gdbarch->imprecise_pagefault_reporting !=3D nullptr); if (gdbarch_debug >=3D 2) gdb_printf (gdb_stdlog, "gdbarch_imprecise_pagefault_reporting called\= n"); return gdbarch->imprecise_pagefault_reporting (); diff --git a/gdb/gdbarch-gen.h b/gdb/gdbarch-gen.h index bb95df25eb6..a96692c206c 100644 --- a/gdb/gdbarch-gen.h +++ b/gdb/gdbarch-gen.h @@ -1756,6 +1756,6 @@ void set_gdbarch_get_shadow_stack_pointer (struct gdb= arch *gdbarch, gdbarch_get_ /* Returns true if architecture has imprecise pagefault reporting. This i= s used in conversion of SIGSEGV to SIGTRAP for an architecture. */ -typedef bool (gdbarch_imprecise_pagefault_reporting_ftype) (); -extern bool gdbarch_imprecise_pagefault_reporting (struct gdbarch *gdbarch= ); -extern void set_gdbarch_imprecise_pagefault_reporting (struct gdbarch *gdb= arch, gdbarch_imprecise_pagefault_reporting_ftype *imprecise_pagefault_repo= rting); +using gdbarch_imprecise_pagefault_reporting_ftype =3D bool (); +bool gdbarch_imprecise_pagefault_reporting (struct gdbarch *gdbarch); +void set_gdbarch_imprecise_pagefault_reporting (struct gdbarch *gdbarch, g= dbarch_imprecise_pagefault_reporting_ftype *imprecise_pagefault_reporting);