From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cfTdFyacYGpCwCQAWB0awg (envelope-from ) for ; Wed, 22 Jul 2026 06:32:06 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=P56Vr0qa; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 54A2B1E166; Wed, 22 Jul 2026 06:32:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E6FBA1E09B for ; Wed, 22 Jul 2026 06:32:04 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CA05B4BA23C2 for ; Wed, 22 Jul 2026 10:32:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CA05B4BA23C2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=P56Vr0qa Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azlp170100005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c005::5]) by sourceware.org (Postfix) with ESMTPS id B2C5E4BA2E2C for ; Wed, 22 Jul 2026 10:29:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2C5E4BA2E2C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B2C5E4BA2E2C Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c005::5 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1784716176; cv=pass; b=JhvUVPl3KH3cXhQmanVN0p/p/TwhyHJm362hX5xfx/3VP88QaJmcq6pa2aZicqLEUUKpx7Xjcjai03VwkJroOWhmOdqERlx1jICyQ1m0TcSctlqULx3KUXYmqQBo5XeEQY/sf4lQVDT0BqbAC2Mszd/C+GcaXjslnZ26kDENEp0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1784716176; c=relaxed/simple; bh=BIe0lJoCVwPgBLSEuXpJnFVDJvEZRFM+ibCJPrQ/+U4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=C1XIq4rJl+MlpKFusunBWl7uD//ONNjGivA8kEF2TBkWtpVoZMemAAZiTFKzCsXhHmVABTjpjhERyUBhGGHBbvDCgQ8O/cZJYwas2c3xXNcKaP+RgacmBmeWLAdx0VJFhBQIVLYdPTcjG2bqvmeR/aAGH0yiCNIYJGl21juMxHw= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=P56Vr0qa DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B2C5E4BA2E2C ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VpLB84W/ij6L6xvOe3MWa7LdIbTq1c66FjdTXfxvihTBCyiAd9sSfjC/jVYivzSpherI7nggnbrrktzBbgWD2F2onl8wMeJ2ZSvDGJu8yezGaNSJBtdVFBT0AqOENsCWJeBFKc06DeJM2GiCQtRbKAxt1DhQMBNKVTx9HFgLjpPYltRX3tPQG7mM7uifTe0jpBAxT7yglV98FhMnMEZoPJPocxwYbJQfyQblLE0BBsipriELbH3GsgBKuMe+DoVch/b30dU2YZL4rWgPI0TFsHWUWpS7AfAXh6YZciBjzXarQ8sYNN7vMgnSza8Wb/+6bIicNZ0rIMMHBtKqGGX7Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KaKafcixOoZeexSLsVemNPh8Dlr5o3YtmUXDrxs0k5o=; b=sWYXXeNiP/jj2hdGgY8959dFWfNe0UDmwVwSCs5f+kSqAdvU8pBxNT74O8ukC/24/FrYf5PrQaIPSLxykOygib0+vepVr2dpYKreEDwpq/CT0ID1bZBWipijrGUrP1ztcU5nGeFaaERVYz8RPKCtrtBTNDXK/K76nzSouYU1nyLMgFyQ7KLor5tnta5FLhUOA/IMoylYhxhzjVbmDK03p+at01u8qMFicLvcLIrqthiC78ha4Zy/zQwnPtBjZrDl+jONhCxLd9O4+UkNlJfXAkox6LN5oxttcWv5dESCpNfODLvgST0JDkOqcYxReyyArEfwFiQxNskyuioKUBVEZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KaKafcixOoZeexSLsVemNPh8Dlr5o3YtmUXDrxs0k5o=; b=P56Vr0qaAoFjIj5HtbzZDQqVsTazBqHuyLOZvWWBJU1d3gLm4PjIsI6PWXvT5jeBIAmBKskuoHvMlmVXbJ+ErIb6NEJY0c+PDbpPYrhYVuMH6O2Yq5WKxi02L9hNuSEQLX2PG5Z/U/fXJw0o72SghY29tQoiXGGmJ2wP8mCtNcU= Received: from DM4PR12MB6470.namprd12.prod.outlook.com (2603:10b6:8:b8::12) by BY5PR12MB4260.namprd12.prod.outlook.com (2603:10b6:a03:206::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 10:29:30 +0000 Received: from DM4PR12MB6470.namprd12.prod.outlook.com ([fe80::c988:e72b:f5b3:db1b]) by DM4PR12MB6470.namprd12.prod.outlook.com ([fe80::c988:e72b:f5b3:db1b%3]) with mapi id 15.21.0223.017; Wed, 22 Jul 2026 10:29:30 +0000 From: "Aktemur, Baris" To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 07/16] gdb: convert type instance flags to bitfields Thread-Topic: [PATCH 07/16] gdb: convert type instance flags to bitfields Thread-Index: AQHdEtByyWIaY318wUOv5UqUHkBOI7Z4ZHW+gADrd7A= Date: Wed, 22 Jul 2026 10:29:30 +0000 Message-ID: References: <20260713-users-aktemur-type-instance-flags-v1-0-779cad0c85ec@amd.com> <20260713-users-aktemur-type-instance-flags-v1-7-779cad0c85ec@amd.com> <87qzkwrw9t.fsf@tromey.com> In-Reply-To: <87qzkwrw9t.fsf@tromey.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Enabled=True; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SetDate=2026-07-22T09:16:27.0000000Z; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Name=AMD General v26; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_ContentBits=3; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB6470:EE_|BY5PR12MB4260:EE_ x-ms-office365-filtering-correlation-id: e3b584cc-90cd-48e7-bc7b-08dee7dc1d71 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|23010399003|366016|1800799024|11063799006|10067099003|4143699003|56012099006|18002099003|22082099003|38070700021; x-microsoft-antispam-message-info: Go6jzyfahu5mrS4CAo1wjsLDu+uZtYSvrOngmxOsjhAoiBkuflenicBFZfMlt9eJp2Ff2loCLd+Gq9InrvdM4fqgs1gVohPm+tFNHPPtd151LEGHWOUl8YkALTYy2GVDB1cxfKXuYdzBnRra9iG+Nrc0c87r+ok2m5TwMXD0BLTgH8rRzeNYiUm5yGjYzckl30Nz5FSMtugwxMPpNbjxW//5o67ONdsjxc4eFLJBvCWVvYhbq4O/t+ckaDhkCeLP1TYZcrLsLsuXQXgFXxjxfdJmlnZwT4huHl+Pr0F6iukTOthEMcF7DEBEKRaCopShgGZ2kHISZ9Sj1bRLxB3DfhEkKKKm6164phNhOL8l9e+ok80xGUQj3hCPbmwFpGlDTGOJJR+JOgWRy7WJDLpOyjDa9g9hClBQmnvM6EaiKFT8eqNEvxtGMddHbBigfOfV4YGDG+i91XFL5mr7QG2Af9ffv6DTKUNc9EUukgbh3NtyfELlzQ5p+pSNMWWFa1Lfd/CPxeVyFaTjLbO9z7pLBGUPIpusyxBtUnZcDIn/6vJ5cWL3XXTiQ3jKMKTnS5mtJ4DprTG3Aa9sqYckGZYBqcmscjfvYsCucADnw2NibcoGWQz4T+UmwI46fK/U0kMZSpTZJsPJ5SENAc80sSM71cwH5wjdfU+O8/2YpYMieccayq6bms4w1ZgavtrOhdh//j50Cx0FDhnoYRQ3yNI6QeDySB0HgXemDnMAnzt0M7I= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB6470.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(23010399003)(366016)(1800799024)(11063799006)(10067099003)(4143699003)(56012099006)(18002099003)(22082099003)(38070700021); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?161o2RnFh7acKtl1ut9Vj0OvTOgFWpNe5n5K1E7lDacdT2jJ/wgV1oitFwPV?= =?us-ascii?Q?2vp4chcsDnkBLPlWYPNXaOi49QBSg2OUxsnRJodemN+9Cz0ondYvFbUsV6pu?= =?us-ascii?Q?b5ExJFPcBN4LuQFys8qO4BsrpErkM+DZ8dsFqYFmoi4MokrboLivXFCVhOsS?= =?us-ascii?Q?Kn8kXq59KJX1tI718NTStcOgWJ7Vlyu5TTwf+kFATvSPv1EmxFD80/yJ5PQV?= =?us-ascii?Q?KaQ8zCy5Xr9wPxDkkJehdiQcYIoylhdvDPto29hZ/4LSP4uBTaMO6mGcj6sS?= =?us-ascii?Q?trydxztMIYNfLZuq0fCHQ3vT+RITIi5kzsGOXDq/4G2p1/DtFPg7+a3KRVIw?= =?us-ascii?Q?3OzhO41F3pfDsQHDzF1zRiUo+YA9o6rqWarLSLo3hfbTnoATbAiHOvi9/Tc6?= =?us-ascii?Q?Hu7zyz/zIw4NQOFoShVGnG5zCzTGZbu1X9c/2MVr+9ul0jsF8HtFWleljJtb?= =?us-ascii?Q?hAz3qt81lubYLFeNxYw1m/eBUex/K89SkvbLHWf+8020qx1x3JjDIdV/lGMw?= =?us-ascii?Q?DoPa/Ng0J1iPtfQAyum6mEmcunoMvoDQaOk6qS+6nx7mZrp9w1IPldbv8pHc?= =?us-ascii?Q?iVfbg3WvmJclSeAyF3bgP/1X8JUfvBynm4wu/SptUKP1RXWx4X+U0GDbR/9+?= =?us-ascii?Q?GAJCL12RTuGqUhP0YCIOd8rngfAaAFJrxZWhSNbu71CfuJNPK4J5borB99pB?= =?us-ascii?Q?M7Kk3OhIDcaDesizvUVsq6ngkQFxMAT/Qy7e8qqtQ94lAJ4++cfN6gY+m7jB?= =?us-ascii?Q?0Uso2u32xnbcFeCXRZY6Tu47XMxCxxQ8z2za1Jqgfj3oAbTiJCbZRq941spa?= =?us-ascii?Q?z6kJ82nDrIZSDVCPmGeZe9bR8+0qrHV9DNdKMwXJa3Msy2xNd4b39RmSmbZc?= =?us-ascii?Q?o58wGdzSOBR8v9sCBXiRsk098a5MwLctgKhDw1gW55w6dCks8bhWDMBF1oM3?= =?us-ascii?Q?w6dzFa5BYtLqDZAlqdAJ2DAmusQ/kamU0IPxNcWVT3Tz3WLqs1xM9x10qSl7?= =?us-ascii?Q?/okW1RtJtGT++AI58LZDETGHq1Ekmnee/ZFRepDSkyNhIZPvYextXpiKm18y?= =?us-ascii?Q?dutkm8+wpSWL8jJ4as1vLRzz1j7eYP9Y1v2pHNq9U5C8cvnC8eIKoBhHolrL?= =?us-ascii?Q?TBlemeV6ZLrxjJGfVM27oEGNB5ydN8YSfS8wtpIKouc9YcTs/apq5kVhJwUD?= =?us-ascii?Q?+eZqz+NEyWMsATYxCivu/diX+n3fkLC/UBS5GiZETSaCaDKaokEBJp5LU5hn?= =?us-ascii?Q?sTni2Iz8/mOleLd/soXLSThy06L1HaeBiLG4YCFE2K/6I3ToHHLSrsWhQQMo?= =?us-ascii?Q?z3m/vHWBWaVdFnyGj/MrgQ0AumI3Mw0RoUPZJUEGDanyeEH9jQ2kFQzEWtcm?= =?us-ascii?Q?ySDZty0paO8h+OTDC9Pl5mFXWonka+AOLWDEb5SGaji5/HssFrkyKTR3b7cj?= =?us-ascii?Q?2JzirwGo/ttK1jHdKCZITJipYTZE1uihGi6CkBvjaM3tJkKg2FIq1LTlBz4l?= =?us-ascii?Q?AMD2OGkBTdxn/3zOrHbZ1+HJ8OrjAUl7ldGjPLOib1s5p2QeR0OjhsmfIswo?= =?us-ascii?Q?8H5jLwlolQdnjAnpIe4Y2YJgYC5ESGlIbQS0H5EZZOsj7czvY/SutK1DY6F6?= =?us-ascii?Q?o+HtH8g/opQghSNbKOrlHqmPGH+a8THn8M9VPuB1+X7wZjR8RXFFQOrz9a/R?= =?us-ascii?Q?IvuYZH37rA4fHEACTaOvfC4/jCndkni5fL8lYIxVoyO21k97?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6470.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3b584cc-90cd-48e7-bc7b-08dee7dc1d71 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2026 10:29:30.5607 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OaZrx/TvGeoYR11K5KWd/6/ZAy/CMEqk3FoTHHLBZfEi2PKos3F+avH1w2sDtp8EYE1Jm0oRcHZ3LuyW6MJE0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4260 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org AMD General On Tuesday, July 21, 2026 9:14 PM, Tom Tromey wrote: > >>>>> Tankut Baris Aktemur writes: > > > Convert the instance flags of a type to a struct with bitfields. This > > helps avoid bitwise operations and instead refer to the fields by > > name. In particular, Harvard address space information (i.e. code > > space and data space) and address class information become enum values > > instead of being handled by seemingly independent bits. > > Thanks. > > I like this direction. I have a couple minor questions. > > > + type_instance_flags &operator|=3D (const type_instance_flags &other) > > + { > ... > > + harvard_aspace > > + =3D static_cast (harvard_aspace > > + | other.harvard_aspace); > > + address_class =3D address_class | other.address_class; > > These two assignments in particular don't really make sense to me. > Perhaps they should assert that the relevant member of 'this' is 0? I agree. I updated the patch accordingly. Thanks for catching this. > > @@ -1593,7 +1616,7 @@ struct type > > instance flags are completely inherited from the target type. No > > qualifiers can be cleared by the typedef. See also > > check_typedef. */ > > - unsigned m_instance_flags : 9; > > + type_instance_flags m_instance_flags; > > I would guess this increases the size of 'struct type'. > I don't think it's a big deal, but I'm curious about it. Checking with sizeof, both before and after the change, the size of a type object is 56. -Baris