RE: [PATCH] gdb/amd-dbgapi-target: suppress a repeated stop request

["Aktemur, Baris" <TankutBaris.Aktemur@amd.com>]

AMD General

On Wednesday, May 20, 2026 12:10 PM, Six, Lancelot wrote:
> Hi,
...
> > +
> > +    # Resume the thread in the background.  It will loop.  Then we
> > +    # interrupt twice.  To be able to run the "interrupt" command back
> > +    # to back, we define a user command.
> > +    gdb_test "continue &" "Continuing." "continue async"
> > +
> > +    gdb_test_multiple "define inttwice" "" {
> > +   -re "End with .*>$"  {
> > +       pass $gdb_test_name
> > +   }
> > +    }
> > +
> > +    gdb_test [multi_line_input \
> > +             {interrupt} \
> > +             {interrupt} \
> > +             {end}] \
> > +   "" \
> > +   "enter commands"
>
> Having 2 tests here seems odd. There should be just one PASS/FAIL for
> the entire command.
>
> There are 2 approaches to do this.
>
> First, gdb_test has all the machinery in place to do the "question -
> response" interaction:
>
>      gdb_test \
>        "define inttwice" \
>        "" \
>        "define inttwice" \
>        "Type commands for definition of \"inttwice\"\.\r\nEnd with a
> line saying just \"end\"\.\r\n>" \
>        [multi_line_input "interrupt" "interrupt" "end"]
>
> The second approach is to use gdb_test_multiple all the way, and use
> send_gdb to reply to the question
>
>      gdb_test_multiple "define inttwice" "" {
>       -re "Type commands for definition of \"inttwice\"\.\r\nEnd with a line
> saying just \"end\"\.\r\n>$" {
>               send_gdb [multi_line_input "interrupt" "interrupt" "end" ""]
>               exp_continue
>       }
>       -re "$::gdb_prompt $" {
>               pass $gdb_test_name
>       }
>      }

As usual, I had copied from an existing test, but I agree that changing this
part makes sense (and there are many existing tests using a nested
gdb_test_multiple/gdb_test approach, which I could've used).

I'll soon send v2.

Thank you.
-Baris