Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
To: Andrew Burgess <aburgess@redhat.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH 2/2] gdb, multi-target: pass a target argument to delete_exited_threads
Date: Mon, 20 Apr 2026 14:28:31 +0000	[thread overview]
Message-ID: <DM4PR11MB7303B0D0E1AD39B42B1E3239C42F2@DM4PR11MB7303.namprd11.prod.outlook.com> (raw)
In-Reply-To: <87tst9d36d.fsf@redhat.com>

Hi Andrew,

On Friday, April 17, 2026 5:20 PM, Andrew Burgess wrote:
> Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> writes:
> 
> > Similar to the parent commit, delete_exited_threads is also mostly
> > used in the context of a particular target.  Pass that target as a
> > parameter and skip other targets.
> >
> > There seems to be two cases where we actually would want to iterate
> > all targets.  One use is in inferior_appeared (inferior.c) and the
> > other is in thread_select (thread.c).  To handle these cases, allow
> > the argument to be nullptr.
> 
> Similar comment to patch #1 in this series; I'd like to understand if
> there was some motivating issue that triggered this change or not.

No particular issue for this one but it is so similar to prune_threads
that it would smell if we did filtering for one but not for the other.

-Baris


Intel Deutschland GmbH
Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

  reply	other threads:[~2026-04-20 14:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17 11:14 Tankut Baris Aktemur
2026-04-17 15:20 ` Andrew Burgess
2026-04-20 14:28   ` Aktemur, Tankut Baris [this message]
2026-04-17 15:39 ` Simon Marchi
2026-04-20 14:30   ` Aktemur, Tankut Baris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR11MB7303B0D0E1AD39B42B1E3239C42F2@DM4PR11MB7303.namprd11.prod.outlook.com \
    --to=tankut.baris.aktemur@intel.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox