From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aNZ0Ln4bfmiHtjgAWB0awg (envelope-from ) for ; Mon, 21 Jul 2025 06:50:38 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=mlLSVlYa; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B9A721E11C; Mon, 21 Jul 2025 06:50:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 38DA81E0C2 for ; Mon, 21 Jul 2025 06:50:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A75F63858D35 for ; Mon, 21 Jul 2025 10:50:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A75F63858D35 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=mlLSVlYa Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by sourceware.org (Postfix) with ESMTPS id 60E073858C41 for ; Mon, 21 Jul 2025 10:50:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 60E073858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 60E073858C41 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=192.198.163.13 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1753095001; cv=fail; b=eKXpGNmU6L6kPUn/MjRwj9FA21Ls8gHZ6CxWHHvjndVi20EZizFLefP3pN4hkChpPYCLm3R0bEbMdkSGkhcEaZnkYzqEjGZD/dodOuuVEttfDweHJlKtIIoisYYBFOnGlBLgLL1mF+UN3QwwPi0/7RxgmoJxdXIPgzxG4hJQVD0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1753095001; c=relaxed/simple; bh=cL8YwWmDDd0860bNkOifG2hvn3Nr5QrzB0uXlrz7ux0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=fzlFtVpgJ6zbcPStymZBE67fKs12Jap0meHJgh3JZ4CJ68i2x7smf03ZV85AVsoTwXAqJnfvXFoEKm6jcl+loIpMg7SBYLODYj666+52AQtjcL0KpvyXfqH0MdZgs+8vSVqMVPd/t9tZXLRNdkxsQRecwqeQT4WBAAmDqyPW/Ow= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 60E073858C41 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1753095001; x=1784631001; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=cL8YwWmDDd0860bNkOifG2hvn3Nr5QrzB0uXlrz7ux0=; b=mlLSVlYaVppij+n2vNQiP4OFg5miFYxiMgo8HNnIEblQBVVvQNAcFKpt YgVp0I2BekZz7TS27WgIYqRVHz+uMqAtf8BbAKVlg2ACFrejb8c1lED18 OafKY4rDcgQLsK0QmuF33eosGCE5ndfZlJVCAm7midxgyXd+FHuREKi7g wKw9YPo2M92QAmEtcojIw6N41sq+VN974QTEVa7rYafNDmAY2Tm6BYeRA ZQUzXhChvryPF/FUr9YT2bFlWePreHmBy6sOBNtxEnLG+nZnTbSq0SzRw EETSEXds5RVP63dGeDTyhCTOZ8S7zWC3EyCNmGSY00IJ7kZf6HZIuPP5V g==; X-CSE-ConnectionGUID: Rw7y9jsFSPq50T8JIqcn7w== X-CSE-MsgGUID: M1Mll8iRQ+S1hudgPsxXhg== X-IronPort-AV: E=McAfee;i="6800,10657,11498"; a="57925006" X-IronPort-AV: E=Sophos;i="6.16,328,1744095600"; d="scan'208";a="57925006" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2025 03:49:57 -0700 X-CSE-ConnectionGUID: yT/rp7PpToG7fxMhquhfGQ== X-CSE-MsgGUID: rVtAqKZDQw2f9P1mVuUZ0w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,328,1744095600"; d="scan'208";a="163023766" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2025 03:49:57 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.26; Mon, 21 Jul 2025 03:49:56 -0700 Received: from ORSEDG902.ED.cps.intel.com (10.7.248.12) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.26 via Frontend Transport; Mon, 21 Jul 2025 03:49:56 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (40.107.94.59) by edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Mon, 21 Jul 2025 03:49:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UjnS/lOUy869v90GaeQ983hKPA54vIisdNO++cpLmJiwOPb9sKRDMIAmN+2U196j4g3FqnJQwgsGzbRQ4E2FLnb1Q7AgNWOsHtK38/p3nY4fODMOos2XLEOuSrwyeu07wyRjEcMKrS1KoVSWgTGtED10VFl6oOo1xsEwk62brwkEvneFIRVfytgMs/TXARXloHtP19imuffcVi6lNOta2i1HSrfASDWRw2KqNs7QN/1x7aaciDx3vA+4jlJgw09XViG1+AfBI7xLa7Wmi8Fa0nVW8462n5CtJJdImTHGsyTfKE+kU1WU1cL8eSQoi3AFqWgV2KXzrNzEm5AVltI6Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xqceBMIQ6mkg/vIz4/a9ghSwbv+NsTFZqxoTjxSVujE=; b=rTJjAFwDxA3OOfQl70pG4gIet7vs1T7NNC64/X9tjXNRu4E0OX1nD3lBAiPX3I8B7G2QPNoPzGUHotT6rawPkcB0cAV4e3OlRNfxjM/Ef6JlLF5AAoiz0O5bCHtamB3KTb10V08bjcF1pE5u6q2zbjVyCRo2t8yubTICnRKDdqtKkyjvw3arNjzTVq7XYq+ZDXnM0KZJOycV2C/WW6MVlxBq0Tsj9rME2rbsSd3YIMbyxPdIXtpvJ5jpWDacRbvJ95WGSuPUOj+2TXD20PayoqJ3ehNBXZLxXHfzK4yWdWpGTujYfZ9U/7kZ/DYKjYKOw8VMsELnqTmrQAu92jBITg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by SA2PR11MB4905.namprd11.prod.outlook.com (2603:10b6:806:117::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8943.30; Mon, 21 Jul 2025 10:49:53 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::3935:4973:1b78:da44]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::3935:4973:1b78:da44%3]) with mapi id 15.20.8943.029; Mon, 21 Jul 2025 10:49:53 +0000 From: "Aktemur, Tankut Baris" To: Thiago Jung Bauermann , "gdb-patches@sourceware.org" CC: "Metzger, Markus T" Subject: RE: [PATCH v2 07/47] gdb, gdbserver, gdbsupport: add 'device' tag to XML target description Thread-Topic: [PATCH v2 07/47] gdb, gdbserver, gdbsupport: add 'device' tag to XML target description Thread-Index: AQHbTXheVvtD65DUXkCCzq4BULzpWrQo3+IcgBTL58A= Date: Mon, 21 Jul 2025 10:49:53 +0000 Message-ID: References: <20241213-upstream-intelgt-mvp-v2-0-5c4caeb7b33d@intel.com> <20241213-upstream-intelgt-mvp-v2-7-5c4caeb7b33d@intel.com> <87bjpvs4zf.fsf@linaro.org> In-Reply-To: <87bjpvs4zf.fsf@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|SA2PR11MB4905:EE_ x-ms-office365-filtering-correlation-id: f1c21611-e684-472f-43ac-08ddc844530e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?h9ks2D5Gk3TPWNwDOEkoUHlUMovniYSTJWMpABIQMGZd037ctq98NJjliNx6?= =?us-ascii?Q?PEyJZGw5NN8LnVC9SkQnnW604y8M+bJUsVS5KC6hGQogfSx6Vl/rvpV1xyF7?= =?us-ascii?Q?N6LJwrdlKWeYbkuTMMLzX5RAfGGCiK9wMQMrNKuzO0TsvZmnTuqiWRbs6oB2?= =?us-ascii?Q?JlRMZTCYRFElyuhXyDx0opMAonuvDr/V198AuhpB96VMe+wgO2f49L9hD0DI?= =?us-ascii?Q?fqYaPvBiNbu2F6Lb6mFa+EhLQUQapdeHxr8YS48ZolXbFuMQdOTzsPzETiwE?= =?us-ascii?Q?QoX+q6rc9ngN591Wax7QWaMKEwNVbSi/0bOJ2M0JE9mSIAwNDqtCE+Nev8L/?= =?us-ascii?Q?cnOlQ3+CXJvvhhOqxdQT123BTa1BxGh0Oa6qQ8mzExEZfAlcbjhkoPEUhVTy?= =?us-ascii?Q?n6iI40MvHQs81Yd3NUZHA8rJKvsiglt/panfigsjkWye1mI7F8bQvZcutwzq?= =?us-ascii?Q?RHt+NBW81wEtFu4t8Qp/sLVR79bSEIdB1e+OwrZhJRBnr6vMjYa3vwA9fKjC?= =?us-ascii?Q?jvtsKFZuNzBlo+lw/LvpFuoufTBSDnVYP7MZoAbHLFEvtkxQMMd7/jNXYvc+?= =?us-ascii?Q?+JX+zGJ1Zc/g25+/+lGfpW6HhUW18B4ZFKzDM0jPOA9PXfkDCvrjFV7rd/KA?= =?us-ascii?Q?0kYgzeE5sRV3mFIGps3IcBBeKrGBIwSya0NnAKBM7rw40EZ/5QRMr6q3KwOC?= =?us-ascii?Q?rnbjkwdSxTipvmjAA73GBbFTd1ISRuklmDRKyqpqwF/QF6mmX0JZ4XaDmcYB?= =?us-ascii?Q?XDnBf+iQq7hfI4waRoWjtlB4t1/yDwN7Fj5erclLyCKXUOxJ13l+NYdG0Ssu?= =?us-ascii?Q?rDE/KY6oArxJium5N71IHgGtozjrgA85aGIjNPfQ/384sdodrbSvUhW3Pr9H?= =?us-ascii?Q?CwzSLoYgXsdeQewNqdwr72Rzuz8NxvExH0PZkn89svNKaeClGIc99hpp3/4E?= =?us-ascii?Q?/mMWPdBMtIlSyS02O31FsFljvdiMQyrkop1aYFIDhSZ/NXslGPudNPaKNkoJ?= =?us-ascii?Q?JtMjXdo+8NVDiEQMvSvLZK1ve4ek/OP/hL4r09pMyzV8Q3oUPwyp8n2e763P?= =?us-ascii?Q?sOtdMAH6wVxlK5l1RYvCTu46N/hKfa8fcne1Ihzld+JHdn06QBwcUtNy90Ju?= =?us-ascii?Q?I7G1pgj4l3hBtpq067oMxLCNF5NaKk9qy7U6WZorwS/RowR/IvWeElh+zV5w?= =?us-ascii?Q?rC5TAeB4HRhKy0ZMj+FpN2Fy039SNoJh8yW3Z4dhgioU4GQ2sj9cznaoxBQU?= =?us-ascii?Q?hWrDQZ8cqe7oSwIJvyJU1vKgTHBZ1xuPIin4TBkCLA9mj5GOeiDtBr3rMyur?= =?us-ascii?Q?pB+JW7rTvQ1xgmVI/GpG8J3IhtTLz9oiQ4NgCW9sZdxvzczyPQTXf19G/GbS?= =?us-ascii?Q?9kFUcfbeix+I9tAE1p0Kh0y5DMbJrJr/aucoAxhrbiCYtpxifBkbSfsItrVY?= =?us-ascii?Q?2YulMxsIdZmKSzqJTOkQWN+Q4tVyoyamc6BhD2HevyNp4TdLOymuCQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB7303.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9hSimlnpe3p4eqXpwoFOZQVVSxugw1qltVLlxAkH7rPsSQV2zbMJRGcmaHZm?= =?us-ascii?Q?YQaVd/yHJRQJiNDgw1wx0NsH+OvwJ5YQ+bn7BAFXNl6JuUxJAB6NY13wJD0t?= =?us-ascii?Q?fGOtYY93bwO7+1ggCyGS/vUazZCsy6ZHrGwLbeAnwyQgiAyT3aHYHxjJpXFy?= =?us-ascii?Q?IfDhl2Os8sEyBEw+clqyI7pycEaN8kOSOCrA1YsSXGPNU0xXToWRtQx+sUGf?= =?us-ascii?Q?Xyoh7U7u6zw4NzQRAaJIewc6OALQ/WXDM2jnsTWYWb51JXODzkHGhmSP0Tm7?= =?us-ascii?Q?hcC6cktpN1ZFUrIhYPNd8rzDzIvkpGbXeZS6IZBEQU+7SbmsLeWctMl5IEwe?= =?us-ascii?Q?g3ovcrgMesZPGzZy4MabfVdefH/yBBSbKS3VMF+j0bCxQ1Tl23KRfqJCx2U3?= =?us-ascii?Q?5RNuiotoaKkzmLx1FCgHr762rG2pgAFc4YrdrpGLvriQaX49GCOKzRoUnzp7?= =?us-ascii?Q?QPVTETGph4v81nrnwPjM9Q1uTA423lHlye8nSdeLGfyNlO+9NbsZmBYdw6wy?= =?us-ascii?Q?13qoz+VwJQpTMdoRzdt7A5HiJwCL+fUh5I//t0ySvIliccaje4Io+8q/PXPF?= =?us-ascii?Q?1oeBAjVKDikrl3ZNETCdEekbQDvO6ZUST4/73nu56RuTJGpO3juMxZvHsZ6u?= =?us-ascii?Q?umob7QN3/CM9C0p3P0A4KRsjQkvNQNrXjwOv9N8fMO/5lDNZSUtyo79285st?= =?us-ascii?Q?AIvN8fP0UqBlUcf3NnuOHq+S6DBn/+UTshLDxJ//+KPMTGfviJ5vO14lQRom?= =?us-ascii?Q?mKXZwCWGY+FmBQuyEGHPwuxm5qf+YKzJFHVDMbsHfhmkM76R6mofPRkQzfKq?= =?us-ascii?Q?1EIcYYLqbdjujWa/6vy5EccAsJ2jWPC4fcVBXv3narEvc/lAmzRik2tAEeF5?= =?us-ascii?Q?I7xk1jY6V5mvprPpNnCCyJALBGnnUTwHcDS6q0AAsiKCSlX6KNuLsruqBTtf?= =?us-ascii?Q?qwqm/0IWfTddHK29tT/tYYQM2DDGHaf3F3tE5MnCvFw2yqd4E1qqaw1WSCHe?= =?us-ascii?Q?hrXJyX8jxqqjeykozjuod9VzhwupX9/UmRjTjTcy8J2gIdxdUfVNJTCAaVs/?= =?us-ascii?Q?W61nWVxXsTi03lDkPYk+f9OLI2/Fu9a4ApiLyKJO/Z2YCm33HRJG5Ci/+evH?= =?us-ascii?Q?HL7M6H7dXd4FgjKdSl05D5LGLoqrsek/eXgS537oEWpnKkA407Bitw4RG1Cn?= =?us-ascii?Q?PbqhATgr+ZnrJNnq+hjE4K6IYvQnchAiTw4odeiOtwbLfhRNGOymxcHsxozo?= =?us-ascii?Q?Dnty1nzZwTGW44XdVV0pZ7lGbEzBsLI6PqDReFGKZ/US2IF0YcYwLsk8qNXE?= =?us-ascii?Q?8q4Sp9njARUFCzEZcMifd5fmitBl0kk9V2eOCDh82aT50ahbMqTRkkCpTSNo?= =?us-ascii?Q?786yNgBOaS9t4MnCYvS+nrEtFk95GvG7KuKHe45IR212pik8EdT8/Cndl5hS?= =?us-ascii?Q?dGPmKpuseqI415ipmNOXWkqp0fvihwZ2O2cdG7NBWwO8UeFsLSEJJYHKq+2B?= =?us-ascii?Q?QPm1ueBZfiZ5LDcgvO1SgSxAJ2WvbB+K1C2NgeC231UYyVIkQPoW7lagnuLr?= =?us-ascii?Q?Ffj+7bBnlVxRhVoJrYLmVCDfAMiL26tDyjhM4+eWHAYyNZS3cwOwSnmM6Oan?= =?us-ascii?Q?EA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1c21611-e684-472f-43ac-08ddc844530e X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2025 10:49:53.2845 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AmGNSs8G5Gi/WbDy6WCEdgzLZ+KrO25R28d8TNjwoxZEgn8oBl+1TDRsX2fO1lG+8D/22jDI0Vf4QgOXmdVsH/51z2nfF9Dy5WVSD2R7aVg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4905 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Tuesday, July 8, 2025 6:04 AM, Thiago Jung Bauermann wrote: > Tankut Baris Aktemur writes: > = > > diff --git a/gdb/xml-tdesc.c b/gdb/xml-tdesc.c > > index 436c493d4f914eb71a80bcbc08dc2ddd38c72027..61cba42e9eee2ec4cc66e14= a120c5bef909e48b0 > 100644 > > --- a/gdb/xml-tdesc.c > > +++ b/gdb/xml-tdesc.c > > @@ -137,6 +137,65 @@ tdesc_end_compatible (struct gdb_xml_parser *parse= r, > > tdesc_add_compatible (data->tdesc, arch); > > } > > > > +/* Handle the end of a element and its value. */ > = > s/the end/the start/ > = > > +static void > > +tdesc_start_device (struct gdb_xml_parser *parser, > > + const gdb_xml_element *element, > > + void *user_data, std::vector &attributes) > > +{ > = > > = > > +void > > +print_xml_feature::visit (const tdesc_device *device) > > +{ > > + if (device =3D=3D nullptr) > > + return; > > + > > + std::string tmp =3D " > + if (device->vendor_id.has_value ()) > > + string_appendf (tmp, " vendor-id=3D\"0x%04" PRIx32 "\"", > > + *device->vendor_id); > > + > > + if (device->target_id.has_value ()) > > + string_appendf (tmp, " target-id=3D\"0x%04" PRIx32 "\"", > > + *device->target_id); > > + > > + string_appendf (tmp, " family=3D\"%s\"", device->family.c_str ()); > > + string_appendf (tmp, " model=3D\"%s\"", device->model.c_str ()); > = > For all the string attributes in device: isn't it better to check > whether the string is empty and only emit the attribute if it isn't? Added the checks. > > + if (device->stepping.has_value ()) > > + string_appendf (tmp, " stepping=3D\"%d\"", *device->stepping); > > + > > + string_appendf (tmp, " name=3D\"%s\"", device->name.c_str ()); > > + string_appendf (tmp, " pci-slot=3D\"%s\"", device->pci_slot.c_str ()= ); > > + string_appendf (tmp, " uuid=3D\"%s\"", device->uuid.c_str ()); > > + > > + if (device->total_cores.has_value ()) > > + string_appendf (tmp, " total-cores=3D\"%ld\"", *device->total_core= s); > > + > > + if (device->total_threads.has_value ()) > > + string_appendf (tmp, " total-threads=3D\"%ld\"", *device->total_th= reads); > > + > > + if (device->subdevice_id.has_value ()) > > + string_appendf (tmp, " subdevice-id=3D\"%d\"", *device->subdevice_= id); > > + > > + string_appendf (tmp, "/>"); > > + add_line (tmp); > > +} > > + > > /* See gdbsupport/tdesc.h. */ > > > > void > > diff --git a/gdbsupport/tdesc.h b/gdbsupport/tdesc.h > > index c9e7603369cbf986187908c2d1f8fbe35a0dc02d..29de4d231f16667c8297bcb= e403f683c30a28762 > 100644 > > --- a/gdbsupport/tdesc.h > > +++ b/gdbsupport/tdesc.h > > @@ -26,6 +26,7 @@ struct tdesc_type_builtin; > > struct tdesc_type_vector; > > struct tdesc_type_with_fields; > > struct tdesc_reg; > > +struct tdesc_device; > > struct target_desc; > > > > /* The interface to visit different elements of target description. */ > > @@ -56,6 +57,9 @@ class tdesc_element_visitor > > > > virtual void visit (const tdesc_reg *e) > > {} > > + > > + virtual void visit (const tdesc_device *e) > > + {} > > }; > > > > class tdesc_element > > @@ -315,6 +319,84 @@ struct tdesc_feature : tdesc_element > > > > typedef std::unique_ptr tdesc_feature_up; > > > > +/* The device information in a target description. */ > > + > > +struct tdesc_device : tdesc_element > > +{ > > + tdesc_device () > > + { > > + family =3D "-"; > > + model =3D "-"; > > + name =3D "-"; > > + pci_slot =3D "-"; > > + uuid =3D "-"; > = > Why aren't the strings left empty? Not included in this series but we have a patch that defines an "info devic= es" command to display the device properties. It was for convenience to print = "-" if the feature was not included. To be more generic, it makes sense to ini= tialize the strings empty and then do the checks at the usage side. Thanks, -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928