From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105836 invoked by alias); 22 Jun 2017 14:36:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105800 invoked by uid 89); 22 Jun 2017 14:36:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-he1eur01on0045.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (104.47.0.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Jun 2017 14:36:30 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1178.14; Thu, 22 Jun 2017 14:36:25 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::9063:8caa:1bc4:156f]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::9063:8caa:1bc4:156f%14]) with mapi id 15.01.1178.023; Thu, 22 Jun 2017 14:36:25 +0000 From: Alan Hayward To: Pedro Alves CC: Yao Qi , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from py-unwind.c Date: Thu, 22 Jun 2017 14:36:00 -0000 Message-ID: References: <86bmpgjso6.fsf@gmail.com> <82556349-1E8C-44C3-9FC9-68F15E36D4D4@arm.com> <8b641cf5-6cdc-5c4e-6f85-eb28f08bed9c@redhat.com> In-Reply-To: <8b641cf5-6cdc-5c4e-6f85-eb28f08bed9c@redhat.com> authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0101;7:sDRBBQkeb4MnE/VIZ295gZncuEz3BR8hVvwQrBvutKvcqqWO1d/bvOzkH3tBPAmkJw/zY+ILeoh8rIaKu42AGBaUeFCEXYZdNIVYXgeYkyeeX9qrmrzrWYWV3g/wVEfsgWw0oxn9+xb/Uzd+SDmdENoN0pTkwt2HITFtvOeuZNN/uzpg6PVO0Z0reQ4crLI3e1/gau09xWUIZFC8drCSs71Ubv010v78gZBdfiutr3PNnI3T9zwMfTc6FqPpomKCizFCUHImv2FFlMQmbvSTDKXZFrkiDapYzibbkANMavOEsNfInYKmFberSJq8OEH/eY1bpSCsKyArXCmrH0zkZ3L5yg09b31Z6MKpS7cOyfCGpRqJ15OhYa02AjNg0a3WHXNZQ8nGGSsZmBH4IERtj9ExzFcCEqZRQOAIhFAHK3/LAsflbxQ8ZbmX+Ov7t7592X7IC+N3NzSqhixKlPCxJNvLkYg8piUhycwisRl4cbUmW7AXn3C7OcuHwzAmSj5pJ4lb6ybUHAsYs99gdUjS8yG84CB50zuHFWYN63kP2D9XTm3V/P432LCQxM/k0zt7TUzy2knHLD1y4vOKK/h3rNxyMwrw2jgEuxpCBImiH0gdJ6Z4I/edKbtIB7oyTS9RBgpIGHkCk61IOkqmbNhB4LB1vjgP8hSXV3e+ZGU/hrR05YM3V0LKSyGWpEIoCKbCyIUOyFoGhCv8Tn5QiJAuwsMnQ1ZHrG3jXrUxTlNTjoEKIY7fhTCTDFlL3+338okgVN7v41WZgARYXQgEC5yE9HtZNLcsLkgNdHoAP4r7fr0= x-ms-office365-filtering-correlation-id: ecf156b4-3a02-4b49-fe20-08d4b97c0fc6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:AM3PR08MB0101; x-ms-traffictypediagnostic: AM3PR08MB0101: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123555025)(20161123560025)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR08MB0101;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR08MB0101; x-forefront-prvs: 03468CBA43 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39410400002)(39400400002)(39850400002)(39450400003)(39840400002)(39860400002)(377454003)(24454002)(377424004)(305945005)(36756003)(66066001)(7736002)(6486002)(229853002)(478600001)(2906002)(2950100002)(6916009)(3280700002)(86362001)(3660700001)(14454004)(72206003)(81166006)(8936002)(81156014)(99286003)(189998001)(6506006)(8676002)(6512007)(54906002)(25786009)(5660300001)(4326008)(3846002)(102836003)(6116002)(2900100001)(83716003)(33656002)(6246003)(110136004)(6436002)(38730400002)(5250100002)(54356999)(76176999)(39060400002)(50986999)(93886004)(82746002)(53546010)(53936002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0101;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <7183C94F4DF8A74196B1D0E690E64C05@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2017 14:36:25.7083 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0101 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00648.txt.bz2 DQo+IE9uIDIyIEp1biAyMDE3LCBhdCAxNDoyMiwgUGVkcm8gQWx2ZXMgPHBh bHZlc0ByZWRoYXQuY29tPiB3cm90ZToNCj4gDQo+IE9uIDA2LzIyLzIwMTcg MDI6MTMgUE0sIEFsYW4gSGF5d2FyZCB3cm90ZToNCj4gDQo+PiBPaywgcHVz aGVkIHdpdGggY2hhbmdlcyBhcyBzdWdnZXN0ZWQuDQo+PiANCj4+IFBhdGNo IGJlbG93Lg0KPiANCj4gU29ycnksIGJ1dCB0aGlzIGxvb2tzIGJyb2tlbiB0 byBtZS4NCj4gDQo+IGNhY2hlZF9mcmFtZV9pbmZvIGlzIHVzaW5nIHRoZSB0 cmFpbGluZyBhcnJheSBpZGlvbSAuLi4NCj4gDQo+PiBAQCAtOTMsNyArODQs NyBAQCB0eXBlZGVmIHN0cnVjdA0KPj4gICAvKiBMZW5ndGggb2YgdGhlIGBy ZWcnIGFycmF5IGJlbG93LiAgKi8NCj4+ICAgaW50IHJlZ19jb3VudDsNCj4+ IA0KPj4gLSAgc3RydWN0IHJlZ19pbmZvIHJlZ1tdOw0KPj4gKyAgY2FjaGVk X3JlZ190IHJlZ1tdOw0KPj4gfSBjYWNoZWRfZnJhbWVfaW5mbzsNCj4+IA0K PiANCj4+IA0KPj4gLSAgICBjYWNoZWRfZnJhbWUNCj4+IC0gICAgICA9ICgo Y2FjaGVkX2ZyYW1lX2luZm8gKikNCj4+IC0JIHhtYWxsb2MgKHNpemVvZiAo KmNhY2hlZF9mcmFtZSkNCj4+IC0JCSAgKyByZWdfY291bnQgKiBzaXplb2Yg KGNhY2hlZF9mcmFtZS0+cmVnWzBdKSkpOw0KPj4gKyAgICBjYWNoZWRfZnJh bWUgPSBYTkVXIChjYWNoZWRfZnJhbWVfaW5mbyk7DQo+IA0KPiBidXQgbm93 IHlvdSdyZSBub3QgYWxsb2NhdGluZyBlbm91Z2ggc3BhY2UgZm9yIHRoZSBh cnJheSBlbGVtZW50cy4uLg0KPiANCj4gDQo+PiAgICAgY2FjaGVkX2ZyYW1l LT5nZGJhcmNoID0gZ2RiYXJjaDsNCj4+ICAgICBjYWNoZWRfZnJhbWUtPmZy YW1lX2lkID0gdW53aW5kX2luZm8tPmZyYW1lX2lkOw0KPj4gICAgIGNhY2hl ZF9mcmFtZS0+cmVnX2NvdW50ID0gcmVnX2NvdW50Ow0KPj4gQEAgLTU4MCwx MyArNTY4LDE0IEBAIHB5dXdfc25pZmZlciAoY29uc3Qgc3RydWN0IGZyYW1l X3Vud2luZCAqc2VsZiwgc3RydWN0IGZyYW1lX2luZm8gKnRoaXNfZnJhbWUs DQo+PiAgICAgICAgIHN0cnVjdCB2YWx1ZSAqdmFsdWUgPSB2YWx1ZV9vYmpl Y3RfdG9fdmFsdWUgKHJlZy0+dmFsdWUpOw0KPj4gICAgICAgICBzaXplX3Qg ZGF0YV9zaXplID0gcmVnaXN0ZXJfc2l6ZSAoZ2RiYXJjaCwgcmVnLT5udW1i ZXIpOw0KPj4gDQo+PiAtICAgICAgICBjYWNoZWRfZnJhbWUtPnJlZ1tpXS5u dW1iZXIgPSByZWctPm51bWJlcjsNCj4+ICsJY2FjaGVkX2ZyYW1lLT5yZWdb aV0ubnVtID0gcmVnLT5udW1iZXI7DQo+IA0KPiAuLi4gdGhhdCB5b3UncmUg YWNjZXNzaW5nIGhlcmUgYW5kIGJlbG93Lg0KPiANCj4gVmFsZ3JpbmQgcHJv YmFibHkgc2hvd3MgdGhlIG5vdy1vdXQtb2YtYm91bmRzIGFjY2Vzc2VzLg0K PiANCj4gDQoNCk91Y2ghIE15IG1pc3Rha2UuDQoNClF1aWNrIHBhdGNoIHRv IHJldmVydCB0aGF0IGxpbmUgdG8gaXTigJlzIHByZXZpb3VzIHN0YXRlLg0K DQpPaz8NCg0KDQoyMDE3LTA2LTIyICBBbGFuIEhheXdhcmQgIDxhbGFuLmhh eXdhcmRAYXJtLmNvbT4NCg0KCSogcHl0aG9uL3B5LXVud2luZC5jIChweXV3 X3NuaWZmZXIpOiBBbGxvY2F0ZSBzcGFjZSBmb3INCglyZWdpc3RlcnMuDQoN Cg0KZGlmZiAtLWdpdCBhL2dkYi9weXRob24vcHktdW53aW5kLmMgYi9nZGIv cHl0aG9uL3B5LXVud2luZC5jDQppbmRleCBkYTE3MDNlY2YyYjg0M2Q5YTY3 OTBmMDk1ZTY0YzI5MTUyODBhZTM1Li4xZDgwMGE3Yjc4NjFkYTZhMTY4NDQw YjYwMGZiMjg2MmM0MmI0ZTRiIDEwMDY0NA0KLS0tIGEvZ2RiL3B5dGhvbi9w eS11bndpbmQuYw0KKysrIGIvZ2RiL3B5dGhvbi9weS11bndpbmQuYw0KQEAg LTU1Nyw3ICs1NTcsMTAgQEAgcHl1d19zbmlmZmVyIChjb25zdCBzdHJ1Y3Qg ZnJhbWVfdW53aW5kICpzZWxmLCBzdHJ1Y3QgZnJhbWVfaW5mbyAqdGhpc19m cmFtZSwNCiAgICAgc2F2ZWRfcmVnICpyZWc7DQogICAgIGludCBpOw0KDQot ICAgIGNhY2hlZF9mcmFtZSA9IFhORVcgKGNhY2hlZF9mcmFtZV9pbmZvKTsN CisgICAgY2FjaGVkX2ZyYW1lDQorICAgICAgPSAoKGNhY2hlZF9mcmFtZV9p bmZvICopDQorCSB4bWFsbG9jIChzaXplb2YgKCpjYWNoZWRfZnJhbWUpDQor CQkgICsgcmVnX2NvdW50ICogc2l6ZW9mIChjYWNoZWRfZnJhbWUtPnJlZ1sw XSkpKTsNCiAgICAgY2FjaGVkX2ZyYW1lLT5nZGJhcmNoID0gZ2RiYXJjaDsN CiAgICAgY2FjaGVkX2ZyYW1lLT5mcmFtZV9pZCA9IHVud2luZF9pbmZvLT5m cmFtZV9pZDsNCiAgICAgY2FjaGVkX2ZyYW1lLT5yZWdfY291bnQgPSByZWdf Y291bnQ7DQoNCg0KDQo= >From gdb-patches-return-140029-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Jun 22 14:49:11 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 68292 invoked by alias); 22 Jun 2017 14:49:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 68277 invoked by uid 89); 22 Jun 2017 14:49:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=SYSTEM, DOCTYPE, doctype, !DOCTYPE X-HELO: mail-io0-f177.google.com Received: from mail-io0-f177.google.com (HELO mail-io0-f177.google.com) (209.85.223.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Jun 2017 14:49:08 +0000 Received: by mail-io0-f177.google.com with SMTP id c201so24379499ioe.1 for ; Thu, 22 Jun 2017 07:49:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=p1Ro1uFXL2cHR3+Ql3wAMNNbpy2hcMAnCcndjFRxe4I=; b=KcqCfmHHyM19xI7uuzeC22sYnRZyt7j9qHxUOpCHOQaXx3+6uwtvqPXEUZbvlcVA4c 6opOWtBnyuNMM9E14CTrqPaQZdZtUNobPOg+D8Z/M2jbglpm5J4LLN/MKwdkBXbT+T+b UTTCZRU4mpJqhqMF3nz/k/cuvOHxmLcC25beJNtQiEFBfKUqXFFRD3cts+YLWFXDCc0v tFfK4/DLv6ybWrS61ukYR5Px4VSvWDOCbOqpYM0OYXvRl6Q17hcLIMImFm+2MlFy/mQF 1aiRWWm8b87Q68oadx2uIFbTHGfs69w8Rg1/IGAvdnrAG3xYfvErV5vSbt7MYww5N90J LgUw== X-Gm-Message-State: AKS2vOz1bsUWEc2OAtE+N9JSCxla6dxhPbbsPmzcIzqkR6Svey8DC0q2 rIRjjMBl4rfKxUPD X-Received: by 10.107.191.71 with SMTP id p68mr2592756iof.100.1498142946874; Thu, 22 Jun 2017 07:49:06 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id h67sm1103453itb.19.2017.06.22.07.49.05 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 22 Jun 2017 07:49:06 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 06/25] Generate c for feature instead of tdesc References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-7-git-send-email-yao.qi@linaro.org> Date: Thu, 22 Jun 2017 14:49:00 -0000 In-Reply-To: (Pedro Alves's message of "Tue, 20 Jun 2017 11:59:46 +0100") Message-ID: <86mv90hyci.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00649.txt.bz2 Content-length: 1661 Pedro Alves writes: > On 06/12/2017 09:41 AM, Yao Qi wrote: >> +$(FEATURE_CFILES): %.c: %.xml.tmp >> + $(GDB) -nx -q -batch \ >> + -ex 'maint print c-tdesc $<' > $@.tmp >> + sh ../../move-if-change $@.tmp $@ >> + rm $< >> + >> +%.xml.tmp: %.xml >> + echo "" > $@ >> + echo "" >> $@ >> + echo "" >> $@ >> + echo " " >> $@ >> + if test $(findstring i386/32bit-,$@); then echo "i386" >> $@ ; fi; >> + echo " " >> $@ >> + echo " " >> $@ >> + echo "" >> $@ >> + > > Don't we need move-if-change here? > move-if-change from what to what? *.xml.tmp is removed after *.c is generated. > The findstring bits warrants a comment. > Yes, comment is needed. >> +/* THIS FILE IS GENERATED. -*- buffer-read-only: t -*- vi:set ro: >> + Original: 32bit-avx512.xml.tmp */ > > I don't think we should be pointing "Original" at a=20 > temporary file that does not exist in the repo? Fixed locally. > > On 06/12/2017 09:41 AM, Yao Qi wrote: >> - print_c_tdesc v (filename_after_features); >> + if (strncmp (filename_after_features.c_str(), "i386/32bit-", 11) =3D= =3D 0) > > startswith > > But again, this looks like needs at least a comment. I'd > like to see an expanded rationale for this. It's not > immediately obvious why/what's this special casing for. OK. Note that the special case and the findstring in Makefile are needed during the target description transition. Once we move all targets to the flexible target description, we don't need them. --=20 Yao (=E9=BD=90=E5=B0=A7)