Re: [RFA] Always use addr info to add a separate debug file

Tristan Gingold
2010-01-07T09:32:12Z

On Jan 6, 2010, at 8:42 PM, Tom Tromey wrote:

>>>>>> "Tristan" == Tristan Gingold <gingold@ACT-Europe.FR> writes:
>
> Tristan> 2010-01-04 Tristan Gingold <gingold@adacore.com>
> Tristan> * symfile.c (build_section_addr_info_from_objfile): New function.
> Tristan> (symbol_file_add_separate): Don't use offsets from objfile but
> Tristan> built an addr info.
>
> Thanks. Just one nit.
>
> Tristan> + sap->other[i].addr = bfd_get_section_vma (objfile->obfd, sec)
> Tristan> + + objfile->section_offsets->offsets[i];
>
> According to GNU rules the RHS of the assignment should be
> parenthesized, and the second line thus more deeply indented.

Ah, I thought this was optional but after re-reading the GNU standard, it isn't.

Thanks for the prompt review, committed with the nit fixed.

Tristan.