From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-69307-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10604 invoked by alias); 7 Jan 2010 09:32:12 -0000
Received: (qmail 10593 invoked by uid 22791); 7 Jan 2010 09:32:11 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Jan 2010 09:32:07 +0000
Received: from localhost (localhost [127.0.0.1]) 	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 9869ECB000F; 	Thu,  7 Jan 2010 10:32:05 +0100 (CET)
Received: from mel.act-europe.fr ([127.0.0.1]) 	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) 	with ESMTP id WO2w5fJLUYhq; Thu,  7 Jan 2010 10:32:05 +0100 (CET)
Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) 	(using TLSv1 with cipher AES128-SHA (128/128 bits)) 	(No client certificate requested) 	by mel.act-europe.fr (Postfix) with ESMTP id 86F41CB021C; 	Thu,  7 Jan 2010 10:32:05 +0100 (CET)
Subject: Re: [RFA] Always use addr info to add a separate debug file
Mime-Version: 1.0 (Apple Message framework v1077)
Content-Type: text/plain; charset=us-ascii
From: Tristan Gingold <gingold@adacore.com>
In-Reply-To: <m38wcb3tqo.fsf@fleche.redhat.com>
Date: Thu, 07 Jan 2010 09:32:00 -0000
Cc: Tristan Gingold <gingold@ACT-Europe.FR>,  gdb-patches@sourceware.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <DBFB27FF-7A9F-49D3-8C45-B8EAAFF7F624@adacore.com>
References: <20100106111823.GA15402@chinon.act-europe.fr> <m38wcb3tqo.fsf@fleche.redhat.com>
To: tromey@redhat.com
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-01/txt/msg00131.txt.bz2


On Jan 6, 2010, at 8:42 PM, Tom Tromey wrote:

>>>>>> "Tristan" =3D=3D Tristan Gingold <gingold@ACT-Europe.FR> writes:
>=20
> Tristan> 2010-01-04  Tristan Gingold  <gingold@adacore.com>
> Tristan> 	* symfile.c (build_section_addr_info_from_objfile): New functio=
n.
> Tristan> 	(symbol_file_add_separate): Don't use offsets from objfile but
> Tristan> 	built an addr info.
>=20
> Thanks.  Just one nit.
>=20
> Tristan> +      sap->other[i].addr =3D bfd_get_section_vma (objfile->obfd=
, sec)
> Tristan> +        + objfile->section_offsets->offsets[i];
>=20
> According to GNU rules the RHS of the assignment should be
> parenthesized, and the second line thus more deeply indented.

Ah, I thought this was optional but after re-reading the GNU standard, it i=
sn't.

Thanks for the prompt review, committed with the nit fixed.

Tristan.