From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104105 invoked by alias); 31 Jan 2018 11:28:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103493 invoked by uid 89); 31 Jan 2018 11:28:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=bridge X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0074.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Jan 2018 11:28:36 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0150.eurprd08.prod.outlook.com (10.161.35.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Wed, 31 Jan 2018 11:28:33 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c95:81b8:c681:ae2]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c95:81b8:c681:ae2%17]) with mapi id 15.20.0444.016; Wed, 31 Jan 2018 11:28:33 +0000 From: Alan Hayward To: Yao Qi , Omair Javaid CC: Philipp Rudo , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH v2 0/8] Remove XML files from gdbserver Date: Wed, 31 Jan 2018 11:28:00 -0000 Message-ID: References: <7C97CC6A-92CB-4702-820D-206022F07102@arm.com> <20180125141138.701802b4@ThinkPad> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0150;7:wM01SFPRcdecrnWNUMPViRiooPC6hH7BoUvJ6B7IvHWUxziFbWBGW3H8EmBDPn/UQGaCkig5ET23uBwGZEIgssSaVd5SN3f2Qxy/lt91uuHF5zAzgFw0/qfTcbl/QY3dUlc+2eXF2g2nzO4JyqHgXqY/Iwok+RVJ+yQPaQwR0uM2zpwMpURHjtYNmJHaq0sJyxinoD0Gjxwe271oAkZKublqudt7J0buIjOofVVQOIUrihZsJgPeFF+yRt24o3SV x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 71ad71f9-f61b-4045-7432-08d5689dc2f7 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:AM3PR08MB0150; x-ms-traffictypediagnostic: AM3PR08MB0150: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(85827821059158); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231101)(2400082)(944501161)(10201501046)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(6072148)(201708071742011);SRVR:AM3PR08MB0150;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0150; x-forefront-prvs: 056929CBB8 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(376002)(346002)(396003)(39860400002)(39380400002)(199004)(189003)(186003)(105586002)(68736007)(3280700002)(106356001)(3660700001)(6116002)(76176011)(5250100002)(3846002)(2906002)(14454004)(36756003)(5660300001)(86362001)(6436002)(2950100002)(53546011)(102836004)(6512007)(6486002)(81156014)(66066001)(6246003)(81166006)(7736002)(82746002)(229853002)(93886005)(97736004)(316002)(305945005)(8676002)(4326008)(6506007)(25786009)(8936002)(83716003)(26005)(72206003)(2900100001)(110136005)(53936002)(99286004)(39060400002)(478600001)(54906003)(33656002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0150;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: NjQNdDRcLfYBwYb99wTe0NgkGKY0XM0RGF9M3EKKLukxvgSJl3hLo9qGEQv1WGOoeeHaDdCQMebygAioCCJj2A== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <957FDD3584BB094F8BC91602920268B5@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71ad71f9-f61b-4045-7432-08d5689dc2f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2018 11:28:33.2006 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0150 X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00649.txt.bz2 DQoNCj4gT24gMjkgSmFuIDIwMTgsIGF0IDE3OjEzLCBBbGFuIEhheXdhcmQg PEFsYW4uSGF5d2FyZEBhcm0uY29tPiB3cm90ZToNCj4gDQo+IE9ubHkganVz dCBzcG90dGVkIHRoaXMgdGhyZWFkLg0KPiANCj4+IE9uIDI5IEphbiAyMDE4 LCBhdCAxNjoyOCwgWWFvIFFpIDxxaXlhb2x0Y0BnbWFpbC5jb20+IHdyb3Rl Og0KPj4gDQo+PiBIaSBPbWFpciwNCj4+IFRoYW5rcyBmb3IgdGVzdGluZyB0 aGVzZSBwYXRjaGVzLi4uDQo+PiANCj4+IE9uIEZyaSwgSmFuIDI2LCAyMDE4 IGF0IDEwOjMxIFBNLCBPbWFpciBKYXZhaWQgPG9tYWlyLmphdmFpZEBsaW5h cm8ub3JnPiB3cm90ZToNCj4+PiBIaSBBbGFuLA0KPj4+IA0KPj4+IEkganVz dCByYW4gZ2RiIHRlc3RzdWl0ZSB3aXRoIG5hdGl2ZS1nZGJzZXJ2ZXIgY29u ZmlndXJhdGlvbiBvbiB5b3VyDQo+Pj4gcGF0Y2hlcyBhbmQgZm91bmQgYSBj b3VwbGUgb2YgcmVncmVzc2lvbnMuIEF0IGxlYXN0IGZpcnN0IHRocmVlIHNl ZW1zIHRvIGJlDQo+Pj4gY29taW5nIG91dCBvZiB5b3VyIHBhdGNoIHNlcmll cyBhcyB0aGV5IHNlZW0gcGVyc2lzdGVudCBvdmVyIG11bHRpcGxlIHJ1bnMN Cj4+PiBvZiB0ZXN0c3VpdGUuDQo+Pj4gDQo+Pj4gMWMxDQo+Pj4gPCBUZXN0 IFJ1biBCeSBvbWFpciBvbiBTYXQgSmFuIDI3IDAyOjUxOjI0IDIwMTgNCj4+ PiAtLS0NCj4+Pj4gVGVzdCBSdW4gQnkgb21haXIgb24gU2F0IEphbiAyNyAw MTo1ODowNiAyMDE4DQo+Pj4gMTI1NywxMjU4YzEyNTcsMTI1OA0KPj4+IDwg RkFJTDogZ2RiLmFyY2gvaTM4Ni1tcHguZXhwOiBibmRjZmd1IGZvcm1hdGlu Zw0KPj4+IDwgRkFJTDogZ2RiLmFyY2gvaTM4Ni1tcHguZXhwOiB0ZXN0IGlm IGJuZHN0YXR1cyBpcyBlbmFibGVkDQo+Pj4gLS0tDQo+Pj4+IFBBU1M6IGdk Yi5hcmNoL2kzODYtbXB4LmV4cDogYm5kY2ZndSBmb3JtYXRpbmcNCj4+Pj4g UEFTUzogZ2RiLmFyY2gvaTM4Ni1tcHguZXhwOiB0ZXN0IGlmIGJuZHN0YXR1 cyBpcyBlbmFibGVkDQo+Pj4gNjcwNmM2NzA2DQo+Pj4gPCBGQUlMOiBnZGIu YmFzZS9nY29yZS5leHA6IGNvcmVmaWxlIHJlc3RvcmVkIGFsbCByZWdpc3Rl cnMNCj4+PiAtLS0NCj4+Pj4gUEFTUzogZ2RiLmJhc2UvZ2NvcmUuZXhwOiBj b3JlZmlsZSByZXN0b3JlZCBhbGwgcmVnaXN0ZXJzDQo+Pj4gNTA3OTBjNTA3 OTANCj4+IA0KPj4gSWYgSSByZWFkIHRoZSBkaWZmIGNvcnJlY3RseSwgdGhl cmUgYXJlIHJlZ3Jlc3Npb25zIGluDQo+PiBnZGIuYXJjaC9pMzg2LW1weC5l eHAgYW5kIGdkYi5iYXNlL2djb3JlLmV4cC4NCj4gDQo+IExvb2tpbmcgaW50 byBpdCwgSSBhbHdheXMgZ2V0IFVOVEVTVEVEOiBnZGIuYXJjaC9pMzg2LW1w eC5leHA6IGZhaWxlZCB0byBwcmVwYXJlDQo+IA0KPiBNUFggd2FzIGEgU2t5 bGFrZSBhZGRpdGlvbi4gSeKAmXZlIGJlZW4gdXNpbmcgYSBTYW5keSBCcmlk Z2UgcHJvY2Vzc29yLg0KPiANCj4gSXMgdGhlcmUgYW55IGVtdWxhdG9yIHNl dHVwIG9yIHN1Y2hsaWtlIHRvIGVuYWJsZSB0ZXN0aW5nPw0KPiANCj4gSeKA mWxsIHNlZSBpZiBJIGNhbiBmaW5kIGEgc3VpdGFibGUgYm94IHRvIHVzZS4N Cg0KV2FzIGZpbmFsbHkgYWJsZSB0byBydW4gdGhlIG1weCB0ZXN0cy4NCihN eSBNYWNCb29rIGlzIGEgU2t5bGFrZSwgYnV0IGlzIHJ1bm5pbmcgbWFjT1Mu IFVzaW5nIHVidW50dSBpbiB2aXJ0dWFsYm94IGRpc2FibGVzDQptcHgsIGJ1 dCB1c2luZyB1YnVudHUgaW4gdm13YXJlIGZ1c2lvbiBpcyBmaW5lISBUaGFu a2Z1bGx5IGRpZG7igJl0IGhhdmUgdG8gcmVzb3J0IHRvIGENCmxpdmUgdXNi IHN0aWNrKQ0KDQpPbiB0aGUgbGF0ZXN0IGhlYWQsIHdpdGggb3Igd2l0aG91 dCBteSBwYXRjaGVzIEkgYWx3YXlzIGdldCB0aGUgc2FtZSByZXN1bHRzOg0K DQpNcHggdGVzdHMgcGFzcyB3aXRoIHVuaXggLyBubyB0YXJnZXQgYm9hcmQs IGJ1dCBmYWlsIHdpdGggbmF0aXZlLWdkYnNlcnZlcg0KDQoiZ2NvcmUuZXhw OiBjb3JlZmlsZSByZXN0b3JlZCBhbGwgcmVnaXN0ZXJz4oCdIGZhaWxzIHdp dGggdW5peCAvIG5vIHRhcmdldCBib2FyZCwgYW5kIHBhc3Nlcw0Kd2l0aCBu YXRpdmUtZ2Ric2VydmVyLg0KDQpJIGNhbuKAmXQgc2VlIGFueSBvYnZpb3Vz IHJlYXNvbiB3aHkgbXkgcGF0Y2hlcyB3b3VsZCBicmVhayBtcHggb3IgdGhl IGdjb3JlIHRlc3RzLA0KYnV0IG5ldmVyIHNheSBuZXZlci4NCg0KSXMgaXQg d29ydGggbWUgZGlnZ2luZyBtb3JlIGludG8gdGhlc2UgdGVzdHM/DQoNCj4g DQo+IA0KPj4gDQo+Pj4gPCBQQVNTOiBnZGIudGhyZWFkcy90aHJlYWQtdW53 aW5kb25zaWduYWwuZXhwOiBjb250aW51ZSB1bnRpbCBleGl0DQo+Pj4gLS0t DQo+Pj4+IEZBSUw6IGdkYi50aHJlYWRzL3RocmVhZC11bndpbmRvbnNpZ25h bC5leHA6IGNvbnRpbnVlIHVudGlsIGV4aXQgKHRpbWVvdXQpDQo+Pj4gNTUx NDUsNTUxNDZjNTUxNDUsNTUxNDYNCj4+IA0KPj4gVGhpcyB0ZXN0IGNhc2Ug aXNuJ3Qgc3RhYmxlIGZvciBtZSwgSSByZW1lbWJlciBJIHNhdyB0aGUgZmFp bCBzZXZlcmFsIHRpbWVzDQo+PiBiZWZvcmUuDQo+PiANCj4+IC0tIA0KPj4g WWFvICjpvZDlsKcpDQoNCg== >From gdb-patches-return-145176-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Jan 31 11:43:44 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 112025 invoked by alias); 31 Jan 2018 11:43:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 110948 invoked by uid 89); 31 Jan 2018 11:43:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*c:alternative X-HELO: mail-qk0-f176.google.com Received: from mail-qk0-f176.google.com (HELO mail-qk0-f176.google.com) (209.85.220.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Jan 2018 11:43:41 +0000 Received: by mail-qk0-f176.google.com with SMTP id l64so14285212qke.13 for ; Wed, 31 Jan 2018 03:43:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ETE/S7C3N+OyFjUFC9RmLD4iBTPVENuwmb9uh4AKSTU=; b=R1UmaRyG4VGn7sBcFc9DFHzZlTrhzZBCN/yG4UZ52vskMhhaVCojB93rffPU4/NHJH ED/HP9eE2vTxv5gvC1Q9A5H3G8cXrlAysrZ0alHFLrlTq0xj02T4M9gYoQhKI+ZqLzmx 4YtdKBu4w/5yC9WpHTAwmaw8ug70SCqMJeBXJFNxc6n+Kk2EAAO+JynKv9STYltwpwoT Irsk48+tmzibYpZSgfrAK/WjRboRb0cHg5Br7ZlTfTCUM1FHPgeQ/vGmX3+o8Fgy6L6b PsFTyYc2TlRgnE9kxUypjrxek19ZWQR/sEUaQ/KK9/suriaAhjNG+AnXx7IiviHajR3B lYzA== X-Gm-Message-State: AKwxytf7VfiNUBvuPe2Ot9nb/d0Yl5jG/w69iuaJQlUUXw43wLxMEUS1 XVq5z/UpfaLDH40lGSMsl61ve+KVuSuBdcalVA2bjg== X-Google-Smtp-Source: AH8x227BaFlwgBCPFTGQpJWRCHVdKunk+ZFg4c4R/zWJxrqSBlIRL0tIeND1sPJLceh0FKzUthmhcki4Mf50s6lj1R4= X-Received: by 10.55.190.130 with SMTP id o124mr44418049qkf.246.1517399019424; Wed, 31 Jan 2018 03:43:39 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.55.4 with HTTP; Wed, 31 Jan 2018 03:43:09 -0800 (PST) In-Reply-To: References: <7C97CC6A-92CB-4702-820D-206022F07102@arm.com> <20180125141138.701802b4@ThinkPad> From: Omair Javaid Date: Wed, 31 Jan 2018 11:43:00 -0000 Message-ID: Subject: Re: [PATCH v2 0/8] Remove XML files from gdbserver To: Alan Hayward Cc: Yao Qi , Philipp Rudo , "gdb-patches@sourceware.org" , nd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00650.txt.bz2 Content-length: 3200 On 31 January 2018 at 16:28, Alan Hayward wrote: > > > > On 29 Jan 2018, at 17:13, Alan Hayward wrote: > > > > Only just spotted this thread. > > > >> On 29 Jan 2018, at 16:28, Yao Qi wrote: > >> > >> Hi Omair, > >> Thanks for testing these patches... > >> > >> On Fri, Jan 26, 2018 at 10:31 PM, Omair Javaid > wrote: > >>> Hi Alan, > >>> > >>> I just ran gdb testsuite with native-gdbserver configuration on your > >>> patches and found a couple of regressions. At least first three seems > to be > >>> coming out of your patch series as they seem persistent over multiple > runs > >>> of testsuite. > >>> > >>> 1c1 > >>> < Test Run By omair on Sat Jan 27 02:51:24 2018 > >>> --- > >>>> Test Run By omair on Sat Jan 27 01:58:06 2018 > >>> 1257,1258c1257,1258 > >>> < FAIL: gdb.arch/i386-mpx.exp: bndcfgu formating > >>> < FAIL: gdb.arch/i386-mpx.exp: test if bndstatus is enabled > >>> --- > >>>> PASS: gdb.arch/i386-mpx.exp: bndcfgu formating > >>>> PASS: gdb.arch/i386-mpx.exp: test if bndstatus is enabled > >>> 6706c6706 > >>> < FAIL: gdb.base/gcore.exp: corefile restored all registers > >>> --- > >>>> PASS: gdb.base/gcore.exp: corefile restored all registers > >>> 50790c50790 > >> > >> If I read the diff correctly, there are regressions in > >> gdb.arch/i386-mpx.exp and gdb.base/gcore.exp. > > > > Looking into it, I always get UNTESTED: gdb.arch/i386-mpx.exp: failed to > prepare > > > > MPX was a Skylake addition. I=E2=80=99ve been using a Sandy Bridge proc= essor. > > > > Is there any emulator setup or suchlike to enable testing? > > > > I=E2=80=99ll see if I can find a suitable box to use. > > Was finally able to run the mpx tests. > (My MacBook is a Skylake, but is running macOS. Using ubuntu in virtualbox > disables > mpx, but using ubuntu in vmware fusion is fine! Thankfully didn=E2=80=99t= have to > resort to a > live usb stick) > > On the latest head, with or without my patches I always get the same > results: > > Mpx tests pass with unix / no target board, but fail with native-gdbserver > > "gcore.exp: corefile restored all registers=E2=80=9D fails with unix / no= target > board, and passes > with native-gdbserver. > > I can=E2=80=99t see any obvious reason why my patches would break mpx or = the gcore > tests, > but never say never. > > Is it worth me digging more into these tests? > > Thanks Alan for looking into these failures. As Yao suggested these tests have been failing previously so there could be chance of a false positive here. If these failures persists with only your patch series then it would be worthwhile looking into the reasons behind those failures. Probably, at this stage its better to fix other review comments and then see if your patch series is breaking anything or not. > > > > > >> > >>> < PASS: gdb.threads/thread-unwindonsignal.exp: continue until exit > >>> --- > >>>> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit > (timeout) > >>> 55145,55146c55145,55146 > >> > >> This test case isn't stable for me, I remember I saw the fail several > times > >> before. > >> > >> -- > >> Yao (=E9=BD=90=E5=B0=A7) > >