From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129553 invoked by alias); 30 Sep 2015 16:22:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129542 invoked by uid 89); 30 Sep 2015 16:22:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Sep 2015 16:22:28 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1ZhK9B-00039O-3w from Don_Breazeal@mentor.com ; Wed, 30 Sep 2015 09:22:25 -0700 Received: from NA-MBX-02.mgc.mentorg.com ([169.254.2.143]) by SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) with mapi id 14.03.0224.002; Wed, 30 Sep 2015 09:22:24 -0700 From: "Breazeal, Don" To: Pedro Alves , "gdb-patches@sourceware.org" Subject: RE: [pushed][PATCH v3 1/4] Extended-remote follow exec Date: Wed, 30 Sep 2015 16:22:00 -0000 Message-ID: References: <1441996698-12694-1-git-send-email-donb@codesourcery.com> <560C0BB8.30804@redhat.com> In-Reply-To: <560C0BB8.30804@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2015-09/txt/msg00671.txt.bz2 > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Wednesday, September 30, 2015 9:20 AM > To: Breazeal, Don; gdb-patches@sourceware.org > Subject: Re: [pushed][PATCH v3 1/4] Extended-remote follow exec >=20 > Hi Don, >=20 > On 09/11/2015 07:38 PM, Don Breazeal wrote: > > @@ -5977,6 +6065,7 @@ remote_parse_stop_reply (char *buf, struct > stop_reply *event) > > struct remote_arch_state *rsa =3D get_remote_arch_state (); > > ULONGEST addr; > > char *p; > > + int skipregs =3D 0; > > > > event->ptid =3D null_ptid; > > event->rs =3D get_remote_state (); > > @@ -6089,11 +6178,42 @@ Packet: '%s'\n"), > > event->ws.kind =3D TARGET_WAITKIND_VFORK_DONE; > > p =3D skip_to_semicolon (p1 + 1); > > } > > + else if (strncmp (p, "exec", p1 - p) =3D=3D 0) > > + { >=20 > I happened to notice that this is still using strncmp while the rest > of the magic registers are now using strprefix instead (26d56a939e). > Looks like a mid-air collision happened. > This one could be adjusted to use strprefix too, right? =20 Absolutely, thanks for pointing it out. I will take care of that today. --Don