From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36788 invoked by alias); 8 Apr 2019 09:38:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36778 invoked by uid 89); 8 Apr 2019 09:38:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.0 required=5.0 tests=AWL,BAYES_20,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=auxv.c, auxvc, UD:auxv.c, franco X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr130074.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (40.107.13.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Apr 2019 09:38:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VZALs/snjgC1uVOIcWUAI3Aa/UrQWAEl9EbdbcwviIs=; b=Z49Hu3akD/EVB6Fkrg2TBfml6R3wBNmg7J+YLZEbdFW7PI4ouSjYwX8ODhxGhcGqUVdXzmwG7FnEh14z25jUwQN1JIwpj7+kD//18XjmccHQxtDRbh6GMNmjLHQtwCW8obPTzl9BrqolN7kMJf/Dxv47nYa6MagwXTTxe+8N34w= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2326.eurprd08.prod.outlook.com (10.172.228.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.13; Mon, 8 Apr 2019 09:38:51 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::399b:3a32:bff9:827e]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::399b:3a32:bff9:827e%10]) with mapi id 15.20.1771.016; Mon, 8 Apr 2019 09:38:51 +0000 From: Alan Hayward To: Ulrich Weigand , Pedro Franco de Carvalho CC: Simon Marchi , "gdb-patches\\@sourceware.org" , nd , "anton@linux.ibm.com" Subject: Re: [PATCH 2/2] gdbserver: Add linux_get_hwcap Date: Mon, 08 Apr 2019 09:38:00 -0000 Message-ID: References: <20190405163946.2DB32D802DA@oc3748833570.ibm.com> In-Reply-To: <20190405163946.2DB32D802DA@oc3748833570.ibm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="utf-8" Content-ID: <5C944EE326DEBA45A075586E3FCD9E4D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00122.txt.bz2 QXBvbG9naWVzLCBJ4oCZdmUgYmVlbiBhd2F5IGZvciB0aGUgbGFzdCB3ZWVr LCBvbmx5IGp1c3Qgc2F3IHRoaXMgd2hvbGUgdGhyZWFkLg0KVGhhbmtzIGZv ciBmaXhpbmcgdGhpcyB3aXRob3V0IG1lLg0KDQpQZWRybzogU29tZSBjb21t ZW50cy9uaXRzIGJlbG93LiAgR2l2ZW4gdGhpcyBpcyBwdXNoZWQsIEnigJlt IGhhcHB5IGlmIHlvdSBkb27igJl0DQpyYWlzZSBhIHdob2xlIG5ldyBwYXRj aCBmb3IgaXQuDQoNCg0KPiBPbiA1IEFwciAyMDE5LCBhdCAxNzozOSwgVWxy aWNoIFdlaWdhbmQgPHV3ZWlnYW5kQGRlLmlibS5jb20+IHdyb3RlOg0KPiAN Cj4gUGVkcm8gRnJhbmNvIGRlIENhcnZhbGhvIHdyb3RlOiANCj4gDQo+PiBO b3RlIHRoYXQgdGhlcmUgaXMgYSBkaWZmZXJlbmNlIGluIHRoZSBpbnRlcmZh Y2UgYmV0d2VlbiBsaW51eF9nZXRfYXV4dg0KPj4gYW5kIGxpbnV4X2dldF9o d2NhcCgyKSwgdGhlIGxhdHRlciBzdGlsbCByZXR1cm4gYm90aCB0aGUgc3Rh dHVzIGFuZCB0aGUNCj4+IGVudHJ5IHZhbHVlLCBidXQgSSBkaWRuJ3Qgd2Fu dCB0byBjaGFuZ2UgYWxsIHRoZWlyIHVzZXJzLg0KPiANCj4gQWN0dWFsbHks IEkgdGhpbmsgdGhpcyBpcyBmaW5lIC0tIGZvciBod2NhcCwgMCBpcyBhIG5h dHVyYWwgZGVmYXVsdA0KPiB2YWx1ZSB0byB1c2UgaWYgdGhlIGVudHJ5IGlz IG5vdCBwcmVzZW50Lg0KDQpZZXMsIGFsbCB0aGUgdGFyZ2V0cyBpbiBHREIg dHJlYXRlZCBhbiBlcnJvciBjb25kaXRpb24gdGhlIHNhbWUgYXMgYSBod2Nh cA0KdmFsdWUgb2YgMC4gIFdoaWNoIGlzIHNlbnNpYmxlIGdpdmVuIGl04oCZ cyBmb3IgY2hlY2tpbmcgZmVhdHVyZXMgcHJlc2VudCBpbg0KdGhlIGhhcmR3 YXJlL2NwdS4NCg0KPiANCj4+IEFsc28sIGNvbnRyYXJ5IHRvIHRoZSBnZGIg Y2xpZW50IHZlcnNpb24gKHRhcmdldF9hdXh2X3NlYXJjaA0KPj4gZ2RiL2F1 eHYuYyksIHRoaXMgb25lIGRvZXNuJ3QgZGlmZmVyZW50aWF0ZSBiZXR3ZWVu IGFuIGVycm9yIGFuZCB0aGUNCj4+IGVudHJ5IG5vdCBiZWluZyBmb3VuZC4N Cj4gDQo+IFRoYXQgYWxzbyBzZWVtcyByZWFzb25hYmxlLiAgSWYgYW55Ym9k eSByZXF1aXJlcyBtb3JlIHNwZWNpZmljIGVycm9yDQo+IGhhbmRsaW5nLCB0 aGF0IGNhbiBhbHdheXMgYmUgYWRkZWQgbGF0ZXIuDQoNCg0KT3JpZ2luYWxs eSBJIHdhcyBnb2luZyB0byBrZWVwIGdkYnNlcnZlciBsaW51eF9nZXRfYXV4 diB3aXRoIHRoZSBzYW1lIHJldHVybnMNCmFzIHRoZSBnZGIgdmVyc2lvbi4g IEhvd2V2ZXIsIGdpdmVuIGl0IGlzIGEgc3RhdGljIGZ1bmN0aW9uIGFuZCB0 aGUgaHdhcA0KZnVuY3Rpb25zIHdlcmUgbm90IGNoZWNraW5nIHRoZSBlcnJv ciB2YWx1ZSwgSSByZW1vdmVkIGl0Lg0KDQo+IA0KPj4gZ2RiL2dkYnNlcnZl ci9DaGFuZ2VMb2c6DQo+PiAyMDE5LTA0LUREICBQZWRybyBGcmFuY28gZGUg Q2FydmFsaG8gIDxwZWRyb21mY0BsaW51eC5pYm0uY29tPg0KPj4gDQo+PiAJ KiBsaW51eC1sb3cuYyAobGludXhfZ2V0X2F1eHYpOiBSZW1vdmUgc3RhdGlj LiAgUmV0dXJuIGF1eHYgZW50cnkNCj4+IAl2YWx1ZSBpbiBhcmd1bWVudCBw b2ludGVyLCByZXR1cm4gMSBpZiB0aGUgZW50cnkgaXMgZm91bmQgYW5kIDAN Cj4+IAlvdGhlcndpc2UuICBNb3ZlIGNvbW1lbnQuDQoNClJldHVybmluZyB0 cnVlL2ZhbHNlIHdvdWxkIGhhdmUgYmVlbiBiZXR0ZXIgdGhhbiAxLzAuIFRo ZSBidWlsZCByZXF1aXJlcyBDKysgc3VwcG9ydC4NCg0KPj4gCShsaW51eF9n ZXRfaHdjYXAsIGxpbnV4X2dldF9od2NhcDIpOiBVc2UgbW9kaWZpZWQgbGlu dXhfZ2V0X2F1eHYuDQo+PiAJKiBsaW51eC1sb3cuaCAobGludXhfZ2V0X2F1 eHYpOiBEZWNsYXJlLg0KPj4gCSogbGludXgtcHBjLWxvdy5jIChpc19lbGZ2 Ml9pbmZlcmlvcik6IFVzZSBsaW51eF9nZXRfYXV4di4NCj4gDQoNCg0KPiBp bmRleCBkODI1MTg0ODM1Li5kNWQwNzRlZmM1IDEwMDY0NA0KPiAtLS0gYS9n ZGIvZ2Ric2VydmVyL2xpbnV4LWxvdy5oDQo+ICsrKyBiL2dkYi9nZGJzZXJ2 ZXIvbGludXgtbG93LmgNCj4gQEAgLTQzNSw2ICs0MzUsMTQgQEAgYm9vbCB0 aHJlYWRfZGJfdGhyZWFkX2hhbmRsZSAocHRpZF90IHB0aWQsIGdkYl9ieXRl ICoqaGFuZGxlLCBpbnQgKmhhbmRsZV9sZW4pOw0KPiANCj4gZXh0ZXJuIGlu dCBoYXZlX3B0cmFjZV9nZXRyZWdzZXQ7DQo+IA0KPiArLyogU2VhcmNoIGZv ciB0aGUgdmFsdWUgd2l0aCB0eXBlIE1BVENIIGluIHRoZSBhdXh2IHZlY3Rv ciB3aXRoDQo+ICsgICBlbnRyaWVzIG9mIGxlbmd0aCBXT1JEU0laRSBieXRl cy4gIElmIGZvdW5kLCBzdG9yZSB0aGUgdmFsdWUgaW4NCj4gKyAgICpWQUxQ IGFuZCByZXR1cm4gMS4gIElmIG5vdCBmb3VuZCBvciBpZiB0aGVyZSBpcyBh biBlcnJvciwgcmV0dXJuDQo+ICsgICAwLiAgKi8NCg0KQ29tbWVudCBzaG91 bGQgc3RhdGUgdGhhdCBWQUxQIGlzIG5vdCBjaGVja2VkIGZvciBudWxscHRy Lg0KDQo+ICsNCj4gK2ludCBsaW51eF9nZXRfYXV4diAoaW50IHdvcmRzaXpl LCBDT1JFX0FERFIgbWF0Y2gsDQo+ICsJCSAgICBDT1JFX0FERFIgKnZhbHAp Ow0KPiArDQoNCg0KDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZ2RiL2dkYnNlcnZl ci9saW51eC1sb3cuYyBiL2dkYi9nZGJzZXJ2ZXIvbGludXgtbG93LmMNCj4g aW5kZXggMjY1MDQzZjk3ZS4uNjU5MTljMzI2MiAxMDA2NDQNCj4gLS0tIGEv Z2RiL2dkYnNlcnZlci9saW51eC1sb3cuYw0KPiArKysgYi9nZGIvZ2Ric2Vy dmVyL2xpbnV4LWxvdy5jDQo+IEBAIC03NDI3LDExICs3NDI3LDEwIEBAIGxp bnV4X2dldF9wY182NGJpdCAoc3RydWN0IHJlZ2NhY2hlICpyZWdjYWNoZSkN Cj4gICByZXR1cm4gcGM7DQo+IH0NCj4gDQo+IC0vKiBGZXRjaCB0aGUgZW50 cnkgTUFUQ0ggZnJvbSB0aGUgYXV4diB2ZWN0b3IsIHdoZXJlIGVudHJpZXMg YXJlIGxlbmd0aA0KPiAtICAgV09SRFNJWkUuICBJZiBubyBlbnRyeSB3YXMg Zm91bmQsIHJldHVybiB6ZXJvLiAgKi8NCj4gKy8qIFNlZSBsaW51eC1sb3cu aC4gICovDQo+IA0KPiAtc3RhdGljIENPUkVfQUREUg0KPiAtbGludXhfZ2V0 X2F1eHYgKGludCB3b3Jkc2l6ZSwgQ09SRV9BRERSIG1hdGNoKQ0KPiAraW50 DQo+ICtsaW51eF9nZXRfYXV4diAoaW50IHdvcmRzaXplLCBDT1JFX0FERFIg bWF0Y2gsIENPUkVfQUREUiAqdmFscCkNCj4gew0KPiAgIGdkYl9ieXRlICpk YXRhID0gKGdkYl9ieXRlICopIGFsbG9jYSAoMiAqIHdvcmRzaXplKTsNCj4g ICBpbnQgb2Zmc2V0ID0gMDsNCg0KV291bGQgYmUgdXNlZnVsIHRvIHNldCB2 YWxwIHRvIHplcm8gaGVyZS4gKE5vdCBzdXJlIGlmIHRoZSBHREIgdmVyc2lv bg0KZG9lcyB0aGlzIGVpdGhlcikuDQoNCj4gQEAgLTc0NDIsMTUgKzc0NDEs MjEgQEAgbGludXhfZ2V0X2F1eHYgKGludCB3b3Jkc2l6ZSwgQ09SRV9BRERS IG1hdGNoKQ0KPiAgICAgew0KPiAgICAgICBpZiAod29yZHNpemUgPT0gNCkN Cj4gCXsNCj4gLQkgIHVpbnQzMl90ICpkYXRhX3AgPSAodWludDMyX3QgKilk YXRhOw0KPiArCSAgdWludDMyX3QgKmRhdGFfcCA9ICh1aW50MzJfdCAqKSBk YXRhOw0KPiAJICBpZiAoZGF0YV9wWzBdID09IG1hdGNoKQ0KPiAtCSAgICBy ZXR1cm4gZGF0YV9wWzFdOw0KPiArCSAgICB7DQo+ICsJICAgICAgKnZhbHAg PSBkYXRhX3BbMV07DQo+ICsJICAgICAgcmV0dXJuIDE7DQo+ICsJICAgIH0N Cj4gCX0NCj4gICAgICAgZWxzZQ0KPiAJew0KPiAtCSAgdWludDY0X3QgKmRh dGFfcCA9ICh1aW50NjRfdCAqKWRhdGE7DQo+ICsJICB1aW50NjRfdCAqZGF0 YV9wID0gKHVpbnQ2NF90ICopIGRhdGE7DQo+IAkgIGlmIChkYXRhX3BbMF0g PT0gbWF0Y2gpDQo+IC0JICAgIHJldHVybiBkYXRhX3BbMV07DQo+ICsJICAg IHsNCj4gKwkgICAgICAqdmFscCA9IGRhdGFfcFsxXTsNCj4gKwkgICAgICBy ZXR1cm4gMTsNCj4gKwkgICAgfQ0KPiAJfQ0KDQoNCg0KPiBkaWZmIC0tZ2l0 IGEvZ2RiL2dkYnNlcnZlci9saW51eC1wcGMtbG93LmMgYi9nZGIvZ2Ric2Vy dmVyL2xpbnV4LXBwYy1sb3cuYw0KPiBpbmRleCA4ZGViMGNlMDY4Li5mMTdm MDVhMGEzIDEwMDY0NA0KPiAtLS0gYS9nZGIvZ2Ric2VydmVyL2xpbnV4LXBw Yy1sb3cuYw0KPiArKysgYi9nZGIvZ2Ric2VydmVyL2xpbnV4LXBwYy1sb3cu Yw0KPiBAQCAtMTEwNywxMCArMTEwNywxMyBAQCBpc19lbGZ2Ml9pbmZlcmlv ciAodm9pZCkNCj4gI2Vsc2UNCj4gICBjb25zdCBpbnQgZGVmX3JlcyA9IDA7 DQo+ICNlbmRpZg0KPiAtICB1bnNpZ25lZCBsb25nIHBoZHI7DQo+ICsgIENP UkVfQUREUiBwaGRyOw0KPiAgIEVsZjY0X0VoZHIgZWhkcjsNCj4gDQo+IC0g IGlmICghcHBjX2dldF9hdXh2IChBVF9QSERSLCAmcGhkcikpDQo+ICsgIGNv bnN0IHN0cnVjdCB0YXJnZXRfZGVzYyAqdGRlc2MgPSBjdXJyZW50X3Byb2Nl c3MgKCktPnRkZXNjOw0KPiArICBpbnQgd29yZHNpemUgPSByZWdpc3Rlcl9z aXplICh0ZGVzYywgMCk7DQo+ICsNCj4gKyAgaWYgKCFsaW51eF9nZXRfYXV4 diAod29yZHNpemUsIEFUX1BIRFIsICZwaGRyKSkNCj4gICAgIHJldHVybiBk ZWZfcmVzOw0KDQpJIGRvbuKAmXQgdGhpbmsgdGhlcmUgaXMgYSByZXF1aXJl bWVudCBoZXJlIGZvciB0aGUgZXJyb3IgdG8gYmUgcmV0dXJuIHNlcGFyYXRl bHkNCnRvIHRoZSBwaGRyLiBXaXRoIHRoZSBteSB2ZXJzaW9uIG9mIGxpbnV4 X2dldF9hdXh2LCBvbiBlcnJvciB5b3Ugd291bGQgZ2V0IDANCmZvciBwaGRy LiBHaXZlbiB0aGF0IGl0IGlzIGFuIGFkZHJlc3MsIDAgc2hvdWxkIG5ldmVy IGJlIGEgdmFsaWQgdmFsdWUuDQoNCldpdGggdGhlIGNvZGUgcHJlIG15IHBh dGNoIGFuZCB0aGlzIHBhdGNoLCBJ4oCZbSBub3Qgc3VyZSB3aGF0IHdpbGwg aGFwcGVuIGlmIHRoZQ0KUEhEUiB2YWx1ZSBpcyAwIC0gd2lsbCByZWFkX2lu ZmVyaW9yX21lbW9yeSB0aGVuIHRoZSBtZW1jbXAgZGVhbCB3aXRoIHRoYXQ/ IChUbw0KYmUgZmFpciwgSSBzdXNwZWN0IHRoZXJlIGFyZSBiaWdnZXIgaXNz dWVzIHRvIGRlYWwgd2l0aCBpZiBwaGRyIGlzIDApLg0KDQpUaGVyZWZvcmUg SeKAmWQgc3VnZ2VzdCBpdOKAmWQgYmUgYmV0dGVyIHRvIGhhdmU6DQoNCkNP UkVfQUREUiBwaGRyID0gbGludXhfZ2V0X2F1eHYgKHdvcmRzaXplLCBBVF9Q SERSKTsNCmlmIChwaGRyID09IG51bGxwdHIpDQogIHJldHVybiBkZWZfcmVz Ow0KDQoNCg0KVGhhbmtzLA0KQWxhbi4NCg0KDQoNCg== >From gdb-patches-return-155218-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Apr 08 13:24:53 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 127198 invoked by alias); 8 Apr 2019 13:24:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 127047 invoked by uid 89); 8 Apr 2019 13:24:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*Ad:U*palves, HX-Google-Smtp-Source:APXvYqx, HX-Languages-Length:708, months X-HELO: mail-wm1-f68.google.com Received: from mail-wm1-f68.google.com (HELO mail-wm1-f68.google.com) (209.85.128.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Apr 2019 13:24:51 +0000 Received: by mail-wm1-f68.google.com with SMTP id o25so14329888wmf.5 for ; Mon, 08 Apr 2019 06:24:51 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id y3sm12465884wmi.27.2019.04.08.06.24.48 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 08 Apr 2019 06:24:48 -0700 (PDT) Subject: Re: [PATCH v3 0/7] Make exceptions self-managing To: Tom Tromey , gdb-patches@sourceware.org References: <20190407195715.24669-1-tom@tromey.com> From: Pedro Alves Message-ID: <0ddeb436-34e0-6c1e-4bba-c7d93e2819c7@redhat.com> Date: Mon, 08 Apr 2019 13:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190407195715.24669-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-04/txt/msg00123.txt.bz2 Content-length: 669 On 4/7/19 8:57 PM, Tom Tromey wrote: > This is the tail end of the series to remove cleanups -- the parts > that rewrite the exception code to use C++ construct directly, rather > than macros. > > V2 was here: > > https://sourceware.org/ml/gdb-patches/2019-02/msg00516.html > > ... though there were reviews in subsequent months. > > I believe this update addresses all the review comments. > Tested by the buildbot. This version LGTM. Please push. Note, I notice that your script-generated patches are producing reverse-sorted ChangeLog entries. I think we can optimize gdb_exception construction a bit. I'll send a follow up patch. Thanks, Pedro Alves