Re: [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode

Eli Zaretskii
2011-12-09T19:11:02Z

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Fri, 9 Dec 2011 16:30:20 +0000
> Cc: gdb-patches@sourceware.org
>
> On Monday 05 December 2011 16:01:02, Pedro Alves wrote:
> > I have tested this on x86_64-linux (-m64|-m32), which showed no
> > regressions. The patch also adjusts all other users of i396-nat.c:
> > djgpp/go32; i386 BSDs (FreeBSD only it seems); Windows (cygwin/mingw)
> > and macosx (darwin), but I haven't tested those. I'd appreciate
> > testing or an extra pair of eyes.
> >
> > Actually darwin has the i386 watchpoint hooks in place, but it doesn't
> > install them:
> >
> > $ grep i386_darwin_dr_get_status *
> > i386-darwin-nat.c:i386_darwin_dr_get_status (void)
> > $
> >
> > ??
>
> Anyone want to comment on those platform bits?

My extra pair of eyes spotted this:

> --- a/gdb/go32-nat.c
> +++ b/gdb/go32-nat.c
> @@ -801,6 +801,28 @@ go32_get_dr6 (void)
> return STATUS;
> }
>
> +/* Get the value of the DR6 debug status register from the inferior.
> + Here we just return the value stored in D_REGS, as we've got it
> + from the last go32_wait call. */
> +static unsigned long
> +go32_get_dr7 (void)
> +{
> + return CONTROL;
> +}

The comment says DR6, but the function uses dr7. I think the comment
is wrong.

No other comments. Thanks.