Re: [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode

Jan Kratochvil
2011-12-11T20:33:37Z

On Fri, 09 Dec 2011 17:30:20 +0100, Pedro Alves wrote:
> On Monday 05 December 2011 20:25:13, Jan Kratochvil wrote:
> > The patchset
> > [patch 0/4] hw watchpoints across fork() + multi-inf
> >
> > which I am rebasing now on top of HEAD which already reimplements its part by
> > commit 96fd921972966166fda0eb300bfa4e5479f3b31f
> > Author: Pedro Alves <pedro@codesourcery.com>
> > Date: Fri Jul 22 16:58:30 2011 +0000
> > http://sourceware.org/ml/gdb-patches/2011-07/msg00586.html
>
> You mean you were already pulling in this non-stop change from
> gdbserver? :-(

I did not test non-stop but the patch reimplements the amd64_linux_dr
removal contained in the patchset started in 2007:
http://sourceware.org/ml/gdb-patches/2010-12/msg00041.html

Last time you stopped that patchset due to referenced merging with gdbserver
http://sourceware.org/ml/gdb-patches/2010-12/msg00348.html
which AFAIK Yao Qi was working on but which has not yet happened, so not sure
how more years it cannot get merged. It was probably my wrong assumption for
the last year the i386-nat.c merging with gdbserver was being worked on while
in fact you only mentioned it would be good to do.

> --- a/gdb/mi/mi-main.c
> +++ b/gdb/mi/mi-main.c
> @@ -1743,12 +1743,11 @@ mi_cmd_list_target_features (char *command, char **argv, int argc)
> struct cleanup *cleanup = NULL;
> struct ui_out *uiout = current_uiout;
>
> - cleanup = make_cleanup_ui_out_list_begin_end (uiout, "features");
> + cleanup = make_cleanup_ui_out_list_begin_end (uiout, "features");
> if (target_can_async_p ())
> ui_out_field_string (uiout, NULL, "async");
> if (target_can_execute_reverse)
> ui_out_field_string (uiout, NULL, "reverse");
> -
> do_cleanups (cleanup);
> return;
> }

Unrelated whitespace cleanup only. Not present in the ChangeLog.

Regards,
Jan