Re: [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode

Pedro Alves
2011-12-13T16:21:14Z

On Friday 09 December 2011 19:10:22, Eli Zaretskii wrote:

> My extra pair of eyes spotted this:
>
> > --- a/gdb/go32-nat.c
> > +++ b/gdb/go32-nat.c
> > @@ -801,6 +801,28 @@ go32_get_dr6 (void)
> > return STATUS;
> > }
> >
> > +/* Get the value of the DR6 debug status register from the inferior.
> > + Here we just return the value stored in D_REGS, as we've got it
> > + from the last go32_wait call. */
> > +static unsigned long
> > +go32_get_dr7 (void)
> > +{
> > + return CONTROL;
> > +}
>
> The comment says DR6, but the function uses dr7. I think the comment
> is wrong.

Indeed. I copied the comment from go32_get_dr6, and forgot to adjust.
Fixed now.

> No other comments. Thanks.

Thanks a lot.

--
Pedro Alves