From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7154 invoked by alias); 9 Dec 2011 16:45:10 -0000 Received: (qmail 7123 invoked by uid 22791); 9 Dec 2011 16:45:05 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Dec 2011 16:44:50 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 01B2CCB1303; Fri, 9 Dec 2011 17:44:51 +0100 (CET) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NeSGnrip2txi; Fri, 9 Dec 2011 17:44:50 +0100 (CET) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id DF174CB0898; Fri, 9 Dec 2011 17:44:50 +0100 (CET) Subject: Re: [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode Mime-Version: 1.0 (Apple Message framework v1251.1) Content-Type: text/plain; charset=windows-1252 From: Tristan Gingold In-Reply-To: <201112091630.20916.pedro@codesourcery.com> Date: Fri, 09 Dec 2011 16:47:00 -0000 Cc: Jan Kratochvil , gdb-patches@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201112051601.59664.pedro@codesourcery.com> <20111205202513.GA26929@host2.jankratochvil.net> <201112091630.20916.pedro@codesourcery.com> To: Pedro Alves X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00295.txt.bz2 On Dec 9, 2011, at 5:30 PM, Pedro Alves wrote: [=85] >=20 > On Monday 05 December 2011 16:01:02, Pedro Alves wrote: >> I have tested this on x86_64-linux (-m64|-m32), which showed no >> regressions. The patch also adjusts all other users of i396-nat.c: >> djgpp/go32; i386 BSDs (FreeBSD only it seems); Windows (cygwin/mingw) >> and macosx (darwin), but I haven't tested those. I'd appreciate >> testing or an extra pair of eyes. >>=20 >> Actually darwin has the i386 watchpoint hooks in place, but it doesn't >> install them: >>=20 >> $ grep i386_darwin_dr_get_status * >> i386-darwin-nat.c:i386_darwin_dr_get_status (void) >> $ >>=20 >> ?? >=20 > Anyone want to comment on those platform bits? >=20 > Tristan, are we just missing a patchlet to glue=20 > i386-darwin-nat.c with i386-nat.c.? Correct. HW watchpoint are currently not enabled on Darwin, but almost all= the code is here. I will try to fix that soon. Thanks, Tristan.