From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2084 invoked by alias); 7 Sep 2012 19:27:32 -0000 Received: (qmail 2074 invoked by uid 22791); 7 Sep 2012 19:27:31 -0000 X-SWARE-Spam-Status: No, hits=-3.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from server-nat-6.cs.umd.edu (HELO bacon.cs.umd.edu) (128.8.127.149) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Sep 2012 19:27:18 +0000 Received: from wireless-206-196-167-133.umd.edu (wireless-206-196-167-133.umd.edu [206.196.167.133]) (Authenticated sender: khooyp) by bacon.cs.umd.edu (Postfix) with ESMTPSA id 12303B4027A; Fri, 7 Sep 2012 15:27:16 -0400 (EDT) Subject: Re: [PATCH] Add -nx for "xgdb" test in gdb/testsuite/gdb.gdb/selftest.exp Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: multipart/mixed; boundary=Apple-Mail-50--628353713 From: Khoo Yit Phang In-Reply-To: <20120907164915.GB18234@host2.jankratochvil.net> Date: Fri, 07 Sep 2012 19:27:00 -0000 Cc: Khoo Yit Phang , GDB Patches Message-Id: References: <387EE3E3-80B3-42E0-AFE7-1BAA78B422D3@cs.umd.edu> <20120907164915.GB18234@host2.jankratochvil.net> To: Jan Kratochvil X-CSD-MailScanner-ID: 12303B4027A.AA053 X-CSD-MailScanner: Found to be clean X-CSD-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-50, required 5, autolearn=not spam, ALL_TRUSTED -50.00) X-CSD-MailScanner-From: khooyp@cs.umd.edu X-CSD-MailScanner-Watermark: 1347650836.29324@OlfA32tMRw8Kd13jOJEB/A Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00082.txt.bz2 --Apple-Mail-50--628353713 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Content-length: 578 Hi Jan, (Sorry for the resend yet again; one day, I'll get the hang this.) On Sep 7, 2012, at 12:49 PM, Jan Kratochvil wrote: >=20 > On Mon, 03 Sep 2012 04:40:27 +0200, Khoo Yit Phang wrote: >> I found a few more tests with the same issue, here's an updated patch th= at >> covers those tests. >=20 > I am fine with checking in the patch if one can replace that '-nw -nx' by > $INTERNAL_GDBFLAGS instead. If it does not work please reply here. Ah, thanks for the info, and it works. I'll check in the updated patch late= r today, barring any issues. Yit September 7, 2012 --Apple-Mail-50--628353713 Content-Disposition: attachment; filename=xgdb-no-init.txt Content-Type: text/plain; name="xgdb-no-init.txt" Content-Transfer-Encoding: quoted-printable Content-length: 3662 Replace -nw option with $INTERNAL_GDBFLAGS in "xgdb" tests to avoid spuriou= s results due to ~/.gdbinit. gdb/testsuite/ChangeLog 2012-09-02 Khoo Yit Phang Replace -nw option with $INTERNAL_GDBFLAGS in "xgdb" tests to avoid spurious results due to ~/.gdbinit. * gdb.gdb/complaint.exp (setup_test): Replace -nw option with $INTERNAL_GDBFLAGS in run command. * gdb.gdb/observer.exp (setup_test): Ditto. * gdb.gdb/selftest.exp (test_with_self): Ditto. * gdb.gdb/xfullpath.exp (setup_test): Ditto. diff --git a/gdb/testsuite/gdb.gdb/complaints.exp b/gdb/testsuite/gdb.gdb/c= omplaints.exp --- a/gdb/testsuite/gdb.gdb/complaints.exp +++ b/gdb/testsuite/gdb.gdb/complaints.exp @@ -31,6 +31,7 @@ proc setup_test { executable } { global gdb_prompt global timeout + global INTERNAL_GDBFLAGS =20 # load yourself into the debugger # This can take a relatively long time, particularly for testing where @@ -73,7 +74,7 @@ set timeout 600 =20 set description "run until breakpoint at captured_command_loop" - gdb_test_multiple "run -nw" "$description" { + gdb_test_multiple "run $INTERNAL_GDBFLAGS" "$description" { -re "Starting program.*Breakpoint \[0-9\]+,.*captured_command_loop= .data.* at .*main.c:.*$gdb_prompt $" { pass "$description" } diff --git a/gdb/testsuite/gdb.gdb/observer.exp b/gdb/testsuite/gdb.gdb/obs= erver.exp --- a/gdb/testsuite/gdb.gdb/observer.exp +++ b/gdb/testsuite/gdb.gdb/observer.exp @@ -25,6 +25,7 @@ proc setup_test { executable } { global gdb_prompt global timeout + global INTERNAL_GDBFLAGS =20 # load yourself into the debugger # This can take a relatively long time, particularly for testing where @@ -67,7 +68,7 @@ set timeout 600 =20 set description "run until breakpoint at captured_main" - gdb_test_multiple "run -nw" "$description" { + gdb_test_multiple "run $INTERNAL_GDBFLAGS" "$description" { -re "Starting program.*Breakpoint \[0-9\]+,.*captured_main .data.*= at .*main.c:.*$gdb_prompt $" { pass "$description" } diff --git a/gdb/testsuite/gdb.gdb/selftest.exp b/gdb/testsuite/gdb.gdb/sel= ftest.exp --- a/gdb/testsuite/gdb.gdb/selftest.exp +++ b/gdb/testsuite/gdb.gdb/selftest.exp @@ -242,6 +242,7 @@ global det_file global decimal global timeout + global INTERNAL_GDBFLAGS =20 # load yourself into the debugger # This can take a relatively long time, particularly for testing where @@ -303,7 +304,7 @@ set timeout 600 =20 set description "run until breakpoint at captured_main" - gdb_test_multiple "run -nw" "$description" { + gdb_test_multiple "run $INTERNAL_GDBFLAGS" "$description" { -re "Starting program.*Breakpoint \[0-9\]+,.*captured_main .data.* at .*m= ain.c:.*$gdb_prompt $" { pass "$description" } diff --git a/gdb/testsuite/gdb.gdb/xfullpath.exp b/gdb/testsuite/gdb.gdb/xf= ullpath.exp --- a/gdb/testsuite/gdb.gdb/xfullpath.exp +++ b/gdb/testsuite/gdb.gdb/xfullpath.exp @@ -25,6 +25,7 @@ proc setup_test { executable } { global gdb_prompt global timeout + global INTERNAL_GDBFLAGS =20 # load yourself into the debugger # This can take a relatively long time, particularly for testing where @@ -67,7 +68,7 @@ set timeout 600 =20 set description "run until breakpoint at captured_main" - gdb_test_multiple "run -nw" "$description" { + gdb_test_multiple "run $INTERNAL_GDBFLAGS" "$description" { -re "Starting program.*Breakpoint \[0-9\]+,.*captured_main .data.*= at .*main.c:.*$gdb_prompt $" { pass "$description" } --Apple-Mail-50--628353713 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Content-length: 1 --Apple-Mail-50--628353713--