From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16351 invoked by alias); 14 Feb 2014 10:41:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16340 invoked by uid 89); 14 Feb 2014 10:41:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Feb 2014 10:40:59 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WEGCV-0000TP-6k from Mohsan_Saleem@mentor.com ; Fri, 14 Feb 2014 02:40:55 -0800 Received: from SVR-IES-FEM-03.mgc.mentorg.com ([137.202.0.108]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 14 Feb 2014 02:40:54 -0800 Received: from EU-MBX-04.mgc.mentorg.com ([169.254.4.137]) by SVR-IES-FEM-03.mgc.mentorg.com ([137.202.0.108]) with mapi id 14.02.0247.003; Fri, 14 Feb 2014 10:40:52 +0000 From: "Saleem, Mohsan" To: Tom Tromey , Mohsan Saleem CC: "gdb-patches@sourceware.org" , "palves@redhat.com" Subject: RE: [PATCH] fix PR-12417 Date: Fri, 14 Feb 2014 10:41:00 -0000 Message-ID: References: <521E2414.40602@codesourcery.com> <52254BC6.1050105@codesourcery.com> <1378282781.96893.YahooMailNeo@web142604.mail.bf1.yahoo.com> <0377C58828D86C4588AEEC42FC3B85A71766C229@IRSMSX105.ger.corp.intel.com> <1378293943.43616.YahooMailNeo@web142603.mail.bf1.yahoo.com> <1379391306.56146.YahooMailNeo@web142602.mail.bf1.yahoo.com> <8738n91939.fsf@fleche.redhat.com> In-Reply-To: <8738n91939.fsf@fleche.redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-SW-Source: 2014-02/txt/msg00503.txt.bz2 SGkgRXZlcnlvbmUsDQo+Pk1vaHNhbj4gK2NvbnN0IGNoYXIgKg0KPj5Nb2hz YW4+ICt0aHJlYWRfbmFtZSAoc3RydWN0IHRocmVhZF9pbmZvICp0aSkgew0K DQo+PlRoaXMgbmVlZHMgYW4gaW50cm9kdWN0b3J5IGNvbW1lbnQuDQpPaw0K DQo+Pk1vaHNhbj4gICAgaWYgKHByaW50X3RocmVhZF9ldmVudHMpDQo+Pk1v aHNhbj4gLSAgICBwcmludGZfdW5maWx0ZXJlZCAoXygiW05ldyAlc11cbiIp LCB0YXJnZXRfcGlkX3RvX3N0ciAocHRpZCkpOw0KPj5Nb2hzYW4+ICsgICAg cHJpbnRmX3VuZmlsdGVyZWQgKF8oIltOZXcgJXMgXCIlc1wiXVxuIiksIA0K Pj5Nb2hzYW4+ICsgdGFyZ2V0X3BpZF90b19zdHIgKHB0aWQpLCB0aHJlYWRf bmFtZSAocmVzdWx0KSk7DQoNCj4+VGhpcyBsaW5lIGlzIHRvbyBsb25nLg0K Pj5BbHNvLCBJIHRoaW5rIHRoZSBvdXRwdXQgd2lsbCBiZSB3ZWlyZCBpZiB0 aGUgdGhyZWFkIGRvZXMgbm90IGhhdmUgYSBuYW1lLg0KV2hhdCBJJ20gc3Vw cG9zZWQgdG8gZG8gYWJvdXQgbGluZSBsZW5ndGg/DQpBbnkgdGhyZWFkIHdp dGhvdXQgYSBuYW1lIGlzIGF1dG9tYXRpY2FsbHkgYXNzaWduZWQgd2l0aCB0 aGUgcHJvZ3JhbSBuYW1lIGFyZ3ZbMF0uIFNvIEVtcHR5IHN0cmluZyBjb3Vs ZCBub3QgYmUgYSBwcm9ibGVtIGhlcmUuDQoNCg0KPj5Ud28gdGhvdWdodHMg Y29tZSB0byBtaW5kIGZvciB0aGUgcGF0Y2guDQoNCj4+Rmlyc3QsIHBlcmhh cHMgYSBzaW5nbGUgZnVuY3Rpb24gZm9yIGVtaXR0aW5nIHRoZSB0aHJlYWQg ZGVzY3JpcHRpb24gd291bGQgYmUgYmV0dGVyLiAgVGhlbiBpdCBjb3VsZCBi ZSBub3JtYWxpemVkIGFjcm9zcyBhbGwgb2YgZ2RiLg0KPj5TZWNvbmQsIGl0 IHdvdWxkIGJlIG5pY2UgdG8gdXNlIHVpLW91dCBwcm9wZXJseSBpbiBzdWNo IGEgZnVuY3Rpb24sIHNvIHRoYXQgTUkgY2FuIHNlZSB0aGUgdGhyZWFkIG5h bWUgZGlzdGluY3RseSBmcm9tIHRoZSBvdGhlciBiaXRzLg0KDQpTb3JyeSwg SSBkaWRuJ3QgZ290IHlvdXIgcG9pbnQgaGVyZS4gQ291bGQgeW91IHBsZWFz ZSBlbGFib3JhdGUgaXQgYSBsaXR0bGUgbW9yZSwgYXMgSSBhbSBuZXcgdG8g R0RCLg0KDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBn ZGItcGF0Y2hlcy1vd25lckBzb3VyY2V3YXJlLm9yZyBbbWFpbHRvOmdkYi1w YXRjaGVzLW93bmVyQHNvdXJjZXdhcmUub3JnXSBPbiBCZWhhbGYgT2YgVG9t IFRyb21leQ0KU2VudDogVGh1cnNkYXksIE5vdmVtYmVyIDA3LCAyMDEzIDM6 MDQgQU0NClRvOiBNb2hzYW4gU2FsZWVtDQpDYzogZ2RiLXBhdGNoZXNAc291 cmNld2FyZS5vcmc7IHBhbHZlc0ByZWRoYXQuY29tDQpTdWJqZWN0OiBSZTog W1BBVENIXSBmaXggUFItMTI0MTcNCg0KPj4+Pj4gIk1vaHNhbiIgPT0gTW9o c2FuIFNhbGVlbSA8bW9oc2Fuc2FsZWVtX21zQHlhaG9vLmNvbT4gd3JpdGVz Og0KDQpNb2hzYW4+IDIwMTMtMDktMDQgwqBNb2hzYW4gU2FsZWVtwqAgPG1z YWxlZW1AY29kZXNvdXJjZXJ5LmNvbT4NCk1vaHNhbj4gwqDCoMKgIFBSIHRo cmVhZHMvMTI0MTcNCk1vaHNhbj4gwqDCoMKgICogdGhyZWFkLmMgKHRocmVh ZF9uYW1lKTogTmV3IGZ1bmN0aW9uLg0KTW9oc2FuPiDCoMKgwqAgKGFkZF90 aHJlYWRfd2l0aF9pbmZvKTogVXBkYXRlIHRvIHByaW50IHRocmVhZCBuYW1l Lg0KTW9oc2FuPiDCoMKgwqAgKHRocmVhZF9hcHBseV9hbGxfY29tbWFuZCk6 IExpa2V3aXNlLg0KTW9oc2FuPiDCoMKgwqAgKHRocmVhZF9hcHBseV9jb21t YW5kKTogTGlrZXdpc2UuDQpNb2hzYW4+IMKgwqDCoCAodGhyZWFkX2ZpbmRf Y29tbWFuZCk6IExpa2V3aXNlLg0KTW9oc2FuPiDCoMKgwqAgKGRvX2NhcHR1 cmVkX3RocmVhZF9zZWxlY3QpOiBMaWtld2lzZS4NCg0KVGhhbmtzLg0KIA0K TW9oc2FuPiArY29uc3QgY2hhciAqDQpNb2hzYW4+ICt0aHJlYWRfbmFtZSAo c3RydWN0IHRocmVhZF9pbmZvICp0aSkgew0KDQpUaGlzIG5lZWRzIGFuIGlu dHJvZHVjdG9yeSBjb21tZW50Lg0KDQpNb2hzYW4+ICAgIGlmIChwcmludF90 aHJlYWRfZXZlbnRzKQ0KTW9oc2FuPiAtICAgIHByaW50Zl91bmZpbHRlcmVk IChfKCJbTmV3ICVzXVxuIiksIHRhcmdldF9waWRfdG9fc3RyIChwdGlkKSk7 DQpNb2hzYW4+ICsgICAgcHJpbnRmX3VuZmlsdGVyZWQgKF8oIltOZXcgJXMg XCIlc1wiXVxuIiksIA0KTW9oc2FuPiArIHRhcmdldF9waWRfdG9fc3RyIChw dGlkKSwgdGhyZWFkX25hbWUgKHJlc3VsdCkpOw0KDQpUaGlzIGxpbmUgaXMg dG9vIGxvbmcuDQpBbHNvLCBJIHRoaW5rIHRoZSBvdXRwdXQgd2lsbCBiZSB3 ZWlyZCBpZiB0aGUgdGhyZWFkIGRvZXMgbm90IGhhdmUgYSBuYW1lLg0KDQpN b2hzYW4+ICsgICAgICAgICAgICBwcmludGZfZmlsdGVyZWQgKF8oIlxuVGhy ZWFkICVkIFwiJXNcIiAoJXMpOlxuIiksDQpNb2hzYW4+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHRwX2FycmF5W2tdLT5udW0sDQpNb2hzYW4+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRocmVhZF9uYW1lICh0 cF9hcnJheVtrXSksDQpNb2hzYW4+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHRhcmdldF9waWRfdG9fc3RyIA0KTW9oc2FuPiArIChpbmZlcmlv cl9wdGlkKSk7DQoNCkxpa2V3aXNlIGNvbmNlcm5pbmcgdGhlIG5vLW5hbWUg Y2FzZS4NCg0KTW9oc2FuPiArCSAgcHJpbnRmX2ZpbHRlcmVkIChfKCJcblRo cmVhZCAlZCBcIiVzXCIgKCVzKTpcbiIpLCB0cC0+bnVtLCANCk1vaHNhbj4g K3RocmVhZF9uYW1lICh0cCksDQoNClRvbyBsb25nLCBwbHVzIG5vLW5hbWUu DQoNCk1vaHNhbj4gICAgdWlfb3V0X3RleHQgKHVpb3V0LCAiW1N3aXRjaGlu ZyB0byB0aHJlYWQgIik7DQpNb2hzYW4+ICAgIHVpX291dF9maWVsZF9pbnQg KHVpb3V0LCAibmV3LXRocmVhZC1pZCIsIHBpZF90b190aHJlYWRfaWQgDQpN b2hzYW4+IChpbmZlcmlvcl9wdGlkKSk7DQpNb2hzYW4+IC0gIHVpX291dF90 ZXh0ICh1aW91dCwgIiAoIik7DQpNb2hzYW4+ICsgIHVpX291dF90ZXh0ICh1 aW91dCwgIiBcIiIpOw0KTW9oc2FuPiArICB1aV9vdXRfdGV4dCAodWlvdXQs IHRocmVhZF9uYW1lICh0cCkpOyAgdWlfb3V0X3RleHQgKHVpb3V0LCANCk1v aHNhbj4gKyAiXCIgKCIpOw0KTW9oc2FuPiAgICB1aV9vdXRfdGV4dCAodWlv dXQsIHRhcmdldF9waWRfdG9fc3RyIChpbmZlcmlvcl9wdGlkKSk7DQpNb2hz YW4+ICAgIHVpX291dF90ZXh0ICh1aW91dCwgIildIik7DQoNClR3byB0aG91 Z2h0cyBjb21lIHRvIG1pbmQgZm9yIHRoZSBwYXRjaC4NCg0KRmlyc3QsIHBl cmhhcHMgYSBzaW5nbGUgZnVuY3Rpb24gZm9yIGVtaXR0aW5nIHRoZSB0aHJl YWQgZGVzY3JpcHRpb24gd291bGQgYmUgYmV0dGVyLiAgVGhlbiBpdCBjb3Vs ZCBiZSBub3JtYWxpemVkIGFjcm9zcyBhbGwgb2YgZ2RiLg0KDQpTZWNvbmQs IGl0IHdvdWxkIGJlIG5pY2UgdG8gdXNlIHVpLW91dCBwcm9wZXJseSBpbiBz dWNoIGEgZnVuY3Rpb24sIHNvIHRoYXQgTUkgY2FuIHNlZSB0aGUgdGhyZWFk IG5hbWUgZGlzdGluY3RseSBmcm9tIHRoZSBvdGhlciBiaXRzLg0KDQpUb20N Cg== >From gdb-patches-return-110405-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Feb 14 10:53:55 2014 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 31347 invoked by alias); 14 Feb 2014 10:53:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 31335 invoked by uid 89); 14 Feb 2014 10:53:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FSL_NEW_HELO_USER,RP_MATCHES_RCVD,SPF_PASS,UNPARSEABLE_RELAY autolearn=no version=3.3.2 X-HELO: userp1040.oracle.com Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 14 Feb 2014 10:53:53 +0000 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s1EArlBK021878 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 14 Feb 2014 10:53:51 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s1EArlo0011352 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 14 Feb 2014 10:53:47 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s1EArk5I010874; Fri, 14 Feb 2014 10:53:46 GMT Received: from termi.oracle.com (/10.175.6.182) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 14 Feb 2014 02:53:46 -0800 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][SPARC64] Fix invalid offsets to access fpregset_t References: <874n439dgk.fsf@oracle.com> <201402131941.s1DJfn5n018925@glazunov.sibelius.xs4all.nl> Date: Fri, 14 Feb 2014 10:53:00 -0000 In-Reply-To: <201402131941.s1DJfn5n018925@glazunov.sibelius.xs4all.nl> (Mark Kettenis's message of "Thu, 13 Feb 2014 20:41:49 +0100 (CET)") Message-ID: <871tz6nerw.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00504.txt.bz2 Content-length: 1016 > I noticed that the %fsr register is not being properly accessed from gdb > in sparc64. This is because sparc64_supply_fpregset and > sparc64_collect_fpregset are using the offsets from the > sparc32_bsd_fpregset constant instead of sparc64_bsd_fpregset. > > How to reproduce the problem: set %f32 to some value and see how $fsr is > modified as well. Also, execute a FCMP* instruction (if (myfloat > > 3.14)) and see how $fsr does not change to reflect the fp condition > codes. > > I checked and the BSD sparc64 targets are using the proper offsets. > Ditto for the linux sparc32 target. > > This little patch fixes this problem. No noticeable regressions running > the test suite. > > Ok to apply? Sure! > 2014-02-13 Jose E. Marchesi > > * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Register > the proper offsets to access fpregset_t. > Thanks. Committed.