From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45905 invoked by alias); 23 Aug 2017 13:24:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44007 invoked by uid 89); 23 Aug 2017 13:24:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=firing, H*M:1111 X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0074.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Aug 2017 13:24:27 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0580.eurprd08.prod.outlook.com (10.163.188.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1341.21; Wed, 23 Aug 2017 13:24:03 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::3d9d:a238:3471:1cc3]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::3d9d:a238:3471:1cc3%16]) with mapi id 15.01.1362.019; Wed, 23 Aug 2017 13:24:03 +0000 From: Alan Hayward To: Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 1/7] Regcache: Subclass ptid functionality to target_regcache Date: Wed, 23 Aug 2017 13:24:00 -0000 Message-ID: References: <6AAAA989-5B31-4E54-963C-57F2B7452BD7@arm.com> <86mv6qr2u9.fsf@gmail.com> In-Reply-To: <86mv6qr2u9.fsf@gmail.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0580;6:V7qMsYNrqfOQptcmCXIy4qqPzYW1sPKsEHgkKCojjzKUCkBtg6Fj1Vy1jCmZ8X6cEEJOA/wKNilmB426DXZs1lW1LWG/oyxvMmWaRB4zKc9dMrwnXz+ZGXQSWx4t/1aArfYyzKunZzExpDMep4HsyfdlIgqW4vrnkKQu5gloxEe3yfAxAg0GeRdG0UVrACJ7tzGT5bTehOxBW6m44PAF2/pxagH8ia4OxBmgDNuYPaexaHisaVZXa60Yq3PYm0VteW+bPoo5L4O/s54RscjnDwhtUqgtn0LP0Bn6+oR2t0uIcnouKJncO0YV5Vv1kml8MnU2SyK4mOqmKpISIwzcWA==;5:jUfP2q2njFfoOrefirzX4cHKtIZ0ioQjXkkxv/2HWuWPknpMdEqZX7wLOMoVsmY+L7xOgDb2g9V+nQWiMJOLwWsK+X4lYASstyHiwyyvVqlIB8q3qfZFYlWapozHT9EOuOSWo6PwXz/3PadI+g25BA==;24:9HgK6pGtV0wme9Ohds16vT1nnT/Ej6O4ea0z30vKYTDtvP6XlSEYcPjqpwCCX+7zOy8COde0DDgleLrdeeuVweHEIt4Ih8koJLyn6eaT+Lg=;7:6KCYODkmN9p9z/wBuWMx0WK2AqucO8nm9HfBr9sjghZuMqd7B62Oh1WDZv+Ap8GwHiecttARdUDT/rqen2sOmqdIp3NuqpUUChkapWFmUGs3399CCgxEQpxL7Ots9RcG1k/6HREXox8gUVrMT23pR5nYNF6ajDn67kXt67BPAKg5B9HZy3kZQPFORkLNiYfDaMRvOGXDHX1+wr8pqjiZHjH4MSjqiJbMXM7KoEMBKLw= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: fed1f92e-896b-467a-e7b9-08d4ea2a3968 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603184)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:AM3PR08MB0580; x-ms-traffictypediagnostic: AM3PR08MB0580: nodisclaimer: True x-exchange-antispam-report-test: UriScan:(180628864354917); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR08MB0580;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR08MB0580; x-forefront-prvs: 040866B734 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(199003)(24454002)(189002)(51444003)(57704003)(39060400002)(33656002)(2950100002)(5660300001)(1411001)(81166006)(83716003)(110136004)(8936002)(25786009)(81156014)(66066001)(6246003)(478600001)(102836003)(3660700001)(7736002)(6116002)(36756003)(68736007)(82746002)(229853002)(2906002)(99286003)(53936002)(6512007)(6916009)(3846002)(189998001)(3280700002)(14454004)(101416001)(305945005)(54906002)(86362001)(6506006)(97736004)(6486002)(106356001)(105586002)(4326008)(53546010)(72206003)(76176999)(5890100001)(50986999)(8676002)(5250100002)(54356999)(2900100001)(6436002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0580;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2017 13:24:03.7066 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0580 X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00443.txt.bz2 DQo+IE9uIDIzIEF1ZyAyMDE3LCBhdCAxMTozMywgWWFvIFFpIDxxaXlhb2x0 Y0BnbWFpbC5jb20+IHdyb3RlOg0KPiANCj4gQWxhbiBIYXl3YXJkIDxBbGFu LkhheXdhcmRAYXJtLmNvbT4gd3JpdGVzOg0KPiANCj4+IEFsbCBwdGlkIHJl bGF0ZWQgZnVuY3Rpb25zIGFyZSBtb3ZlZCB0byB0YXJnZXRfcmVnY2FjaGUu DQo+PiANCj4gDQo+IFdoYXQgaXMgdGhlIHJhdGlvbmFsZSBvZiB0aGlzIGNo YW5nZT8gIFRoZSByZWdjYWNoZSBpcyBwZXItdGhyZWFkLCBldmVuDQo+IGl0 IGlzIGRpc2Nvbm5lY3RlZCBmcm9tIHRhcmdldC4NCg0KSW4gdGhlIGV4aXN0 aW5nIGNvZGUsIHdoZW4gY2FsbGluZyByZWdjYWNoZV9kdXAgLyBjb3B5IGNv bnN0cnVjdG9yLA0KcHRpZCBvZiB0aGUgbmV3IHJlY2FjaGUgaXMgYWx3YXlz IHNldCB0byAtMS4NCg0KSW4gdGhlIHNhdmUgLyByZXN0b3JlIGZ1bmN0aW9u cyB0aGUgcHRpZCBpcyBub3QgdXBkYXRlZC4NCg0KVGhlIHJlZ2NhY2hlLmMg ZnVuY3Rpb25zIHdoaWNoIHJlYWQvd3JpdGUgdGhlIHB0aWQgb25seSBkbyB0 aGF0IHVzaW5nIHRoZQ0KdGFyZ2V0IGNvbm5lY3RlZCByZWdjYWNoZXMuDQoN CkNhbGxpbmcgcmVnY2FjaGVfZ2V0X3B0aWQgb24gYSByZWFkb25seSByZWdj YWNoZSB3aWxsIHJlc3VsdCBpbiBhbiBhc3NlcnQNCmZpcmluZy4NCg0KDQpU aGVyZWZvcmUsIGluIGV4aXN0aW5nIGNvZGUsIGEgcmVhZG9ubHkgcmVjYWNo ZSB3aWxsIGFsd2F5cyBoYXZlIGEgcHRpZA0Kb2YgLTEuIEluIHRoZSBuZXcg Y29kZSB0aGlzIHByb3BlcnR5IG5vdyBiZWNvbWVzIHBhcnQgb2YgYSBkZXRh Y2hlZA0KcmVnY2FjaGUuDQoNCkhvd2V2ZXIuLi4uLg0KDQo+IA0KPj4gQSBy ZWdjYWNoZSByZXRhaW5zIHRoZSBwdGlkICgpIG1ldGhvZCwgd2hpY2ggYWx3 YXlzIHJldHVybnMgLTEuDQo+IA0KPiBwdGlkX3QgKC0xKSBpcyBtaW51c19v bmVfcHRpZCwgd2hpY2ggaGFzIGEgc3BlY2lhbCBtZWFuaW5nLg0KDQpBZ3Jl ZWQuIFRoZSBleGlzdGluZyBjb2RlIGFscmVhZHkgdHJlYXRzIC0xIHRwaWQg dG8gbWVhbiBkaWZmZXJlbnQgdGhpbmdzLg0KDQpJ4oCZdmUgYmVlbiB0aGlu a2luZyBhYm91dCB0aGlzIGFnYWluLg0KcmVnY2FjaGVfZ2V0X3B0aWQgYXNz ZXJ0cyBpZiBwdGlkIGlzIC0xLiBUaGVyZWZvcmUgcHRpZCgpIHNob3VsZCBh bHNvDQphc3NlcnQgb24gYSBkZXRhY2hlZCByZWNhY2hlID8NCldpdGggdGhp cyBjaGFuZ2UsIGEgZGV0YWNoZWQgcmVjYWNoZSB3b3VsZCBuZXZlciBoYXZl IGEgcHRpZC4NCkkgdGhpbmsgdGhhdCBzaW1wbGlmaWVzIHRoZSBjb2RlIHRv by4NCg0KPiANCj4+IFRoaXMgZW5zdXJlcyB1c2VycyBjYW4gYWx3YXlzIHRl c3QgaWYgYSByZWdjYWNoZSBpcyBhdHRhY2hlZCB0byBhDQo+PiB0YXJnZXQs IHdpdGhvdXQgbmVlZGluZyB0byBrbm93IGlmIGl0IGlzIGEgdGFyZ2V0X3Jl Z2NhY2hlLg0KPiANCj4gV2hlbiBkbyB3ZSBuZWVkIHN1Y2ggdGVzdCAoImlm IGEgcmVnY2FjaGUgaXMgYXR0YWNoZWQgdG8gYSB0YXJnZXTigJ0pPw0KDQpX ZSBkb27igJl0LiBJ4oCZbSBoYXBweSB0byBkcm9wIHRoaXMgc3RhdGVtZW50 Lg0KSWYgd2UgZG8gbmVlZCB0byBhZGQgYSB0ZXN0LCB0aGVyZSB3aWxsIHBy b2JhYmx5IGJlIGEgYmV0dGVyIHdheSBvZiBkb2luZyBpdC4NCg0KPiANCj4g LS0gDQo+IFlhbyAo6b2Q5bCnKQ0KDQo= >From gdb-patches-return-141152-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Aug 23 13:42:59 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 64230 invoked by alias); 23 Aug 2017 13:42:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 64198 invoked by uid 89); 23 Aug 2017 13:42:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LOTSOFHASH,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Happy X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-he1eur01on0074.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (104.47.0.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Aug 2017 13:42:52 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0072.eurprd08.prod.outlook.com (10.160.211.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1362.18; Wed, 23 Aug 2017 13:42:48 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::3d9d:a238:3471:1cc3]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::3d9d:a238:3471:1cc3%16]) with mapi id 15.01.1362.019; Wed, 23 Aug 2017 13:42:48 +0000 From: Alan Hayward To: Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 3/7]: Regcache: Remove xmalloc/xfree methods Date: Wed, 23 Aug 2017 13:42:00 -0000 Message-ID: <4E041E77-7A11-431C-8142-7CF9165DD012@arm.com> References: <08C93960-8ED8-431A-B786-3455FF149B77@arm.com> <86ziaqr5mi.fsf@gmail.com> In-Reply-To: <86ziaqr5mi.fsf@gmail.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0072;6:3g+epryz81he9NrSxdkFPAkvO6Q3LdFA+DI9k+2xqcabEBdoPuoIyrjvCbH/OIUCg/uRY/Mob61Jjw3J859u9nBQwkeKPrHeSCaua+w1+GY5s6mSosk7nbWf4sKOFT8bn3wDIaGO0AvfC5uCdLuvm24kQSnDz/et5ALvXkaIo9H1cKffglUdrHYd9omhvCZr5LMHArn9U8n5ig736cr/yR9lq9G+HdAocX5ivuOCx+c/Z3IAoabXNiuKqWKDce6xXSU9QWesj+2NkeBlnRRFp+pYjOR5LvRpOqd2rhRewbLBfoq7wh0blSFORST861hPKlQ3Lotle77PEQAE8vfOkg==;5:6FVsDDvqB8wRFMxCBZ+/mA3xLOZJBoRB5U2I0n+kU4AnUcqUlKlDTPalQGUFKWjCWf0Ff8u6CYeT9EfsXLbJE8PV8oLHm2MTZZ7MaXwocQe+iSwU8ufK4DnSteep5bEHef5cN91UPXQGwzVDnjCONQ==;24:PeFHXEudWdmhSHv/GDFeOr8lS5vwUgdrjsRLs3q3FSm8OoDdQ6JVL4QXmCjLr1qUijF1HXNMbuc0usPyx/Zec0yeyKZxSRFPlf137foeCB8=;7:4EJ6x/8Q1BooPLSVV+0o7rSaYDM17G/DTpBHgG9I2Bd7wsYWQbPEu8BtSp+dnfPt33fT3f3B+VDquO8xieqNFJhPBxvto7I0ZMOqmhNCm1fj1LItOrgvHUBF2Leu/dwGmQ+bTpcycUib3oebuG6CASjKzCMY6YC98S8lUCCnQ6x3q4M9FH1+AdM+2hgy4/aIo6TNOW1Ih46VUyg81E/kugC9Sd3xQDA0Wte8pG8Jcj4= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: e30ca713-8009-4e20-24b8-08d4ea2cd79f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603184)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:AM3PR08MB0072; x-ms-traffictypediagnostic: AM3PR08MB0072: nodisclaimer: True x-exchange-antispam-report-test: UriScan:(180628864354917); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR08MB0072;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR08MB0072; x-forefront-prvs: 040866B734 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(24454002)(199003)(189002)(86362001)(82746002)(110136004)(102836003)(6116002)(575784001)(50986999)(53546010)(6246003)(3846002)(76176999)(36756003)(6506006)(2950100002)(6916009)(2900100001)(478600001)(8936002)(25786009)(54356999)(6436002)(229853002)(106356001)(5660300001)(54906002)(305945005)(72206003)(105586002)(1411001)(6512007)(83716003)(4326008)(7736002)(33656002)(2906002)(97736004)(101416001)(6486002)(8676002)(81166006)(81156014)(66066001)(189998001)(68736007)(5250100002)(53936002)(99286003)(3280700002)(39060400002)(3660700001)(14454004);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0072;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <748182A5E25AB448AB9EF9B1C387A70E@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2017 13:42:48.1511 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0072 X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00444.txt.bz2 Content-length: 8203 DQo+IE9uIDIzIEF1ZyAyMDE3LCBhdCAxMDozMiwgWWFvIFFpIDxxaXlhb2x0 Y0BnbWFpbC5jb20+IHdyb3RlOg0KPiANCj4gQWxhbiBIYXl3YXJkIDxBbGFu LkhheXdhcmRAYXJtLmNvbT4gd3JpdGVzOg0KPiANCj4+IFJlZ2NhY2hlIGlz IGEgY2xhc3MuIFRoZXJlIGlzIG5vIG5lZWQgZm9yIGV4cGxpY2l0IHhtYWxs b2MNCj4+IGFuZCB4ZnJlZSBtZXRob2RzLCBpdCBpcyBtdWNoIHNpbXBsZXIg dG8gdXNlIG5ldyBhbmQgZGVsZXRlLg0KPj4gDQo+IA0KPiBuZXcvZGVsZXRl IGlzbid0IHNpbXBsZXIgdGhhbiB4bWFsbG9jL3hmcmVlLCBJTU8uICBXZSBz dGlsbCBuZWVkIHRvIHRha2UNCj4gY2FyZSBvZiByZWxlYXNpbmcgcmVzb3Vy Y2VzLg0KDQpBZ3JlZWQsIGJ1dCBJIHdhbnRlZCB0byBvbmx5IGhhdmUgb25l IHdheSBvZiBkb2luZyB0aGUgc2FtZSB0aGluZy4NCldlIGhhdmUgdG8gaGF2 ZSBhIGNvbnN0cnVjdG9yL2Rlc3RydWN0b3IuDQpyZWdjYWNoZV94bWFsbG9j IGFuZCByZWdjYWNoZV94ZnJlZSBhcmUgKGFsbW9zdCkgb25lIGxpbmVycyB0 aGF0IGNhbGwgbmV3L2RlbGV0ZS4NCg0KPiANCj4+IA0KPj4gZGlmZiAtLWdp dCBhL2dkYi9mcmFtZS5jIGIvZ2RiL2ZyYW1lLmMNCj4+IGluZGV4IDMwZTRh ZWFiN2UyOTAxMDc0YzI4OWFjNGQ5NmViZGE4ODU4MDVhMjkuLjdmZDRiMDdh MmU5NWYyOGIyZWI2YTE4ZGVhNGQyMDcxZjBlY2U0ZTIgMTAwNjQ0DQo+PiAt LS0gYS9nZGIvZnJhbWUuYw0KPj4gKysrIGIvZ2RiL2ZyYW1lLmMNCj4+IEBA IC0xMDIxLDEzICsxMDIxLDEyIEBAIHN0cnVjdCByZWdjYWNoZSAqDQo+PiBm cmFtZV9zYXZlX2FzX3JlZ2NhY2hlIChzdHJ1Y3QgZnJhbWVfaW5mbyAqdGhp c19mcmFtZSkNCj4+IHsNCj4+ICBzdHJ1Y3QgYWRkcmVzc19zcGFjZSAqYXNw YWNlID0gZ2V0X2ZyYW1lX2FkZHJlc3Nfc3BhY2UgKHRoaXNfZnJhbWUpOw0K Pj4gLSAgc3RydWN0IHJlZ2NhY2hlICpyZWdjYWNoZSA9IHJlZ2NhY2hlX3ht YWxsb2MgKGdldF9mcmFtZV9hcmNoICh0aGlzX2ZyYW1lKSwNCj4+IC0JCQkJ CQlhc3BhY2UpOw0KPj4gLSAgc3RydWN0IGNsZWFudXAgKmNsZWFudXBzID0g bWFrZV9jbGVhbnVwX3JlZ2NhY2hlX3hmcmVlIChyZWdjYWNoZSk7DQo+PiAr ICByZWdjYWNoZSAqYmFja3VwID0gbmV3IHJlZ2NhY2hlIChnZXRfZnJhbWVf YXJjaCAodGhpc19mcmFtZSksIGFzcGFjZSk7DQo+PiArICBzdHJ1Y3QgY2xl YW51cCAqY2xlYW51cHMgPSBtYWtlX2NsZWFudXBfcmVnY2FjaGVfZGVsZXRl IChiYWNrdXApOw0KPj4gDQo+IA0KPiBJdCBtYWtlcyBubyBzZW5zZSB0byBj aGFuZ2UgbWFrZV9jbGVhbnVwX3JlZ2NhY2hlX3hmcmVlIHRvDQo+IG1ha2Vf Y2xlYW51cF9yZWdjYWNoZV9kZWxldGUuICBXZSBzdGlsbCBoYXZlIHRvIHVz ZSBjbGVhbnVwLg0KDQpJIG1hZGUgdGhpcyBjaGFuZ2UgdG8ga2VlcCB0aGUg Y29uc2lzdGVudCB3aXRoIHRoZSBvdGhlciBjaGFuZ2VzIGluIHRoaXMgcGF0 Y2guDQpVc2luZyBuZXcgdG9nZXRoZXIgd2l0aCBzb21ldGhpbmdfeGZyZWUo KSBzb3VuZHMgd3JvbmcuDQoNCklmIEkgbWFrZSBhbGwgdGhlIGNoYW5nZXMg YmVsb3csIHRoZW4gSSB0aGluayB3ZSBjYW4gcmVtb3ZlIHRoaXMgZnVuY3Rp b24uDQoNCj4gDQo+PiAtICByZWdjYWNoZV9zYXZlIChyZWdjYWNoZSwgZG9f ZnJhbWVfcmVnaXN0ZXJfcmVhZCwgdGhpc19mcmFtZSk7DQo+PiArICByZWdj YWNoZV9zYXZlIChiYWNrdXAsIGRvX2ZyYW1lX3JlZ2lzdGVyX3JlYWQsIHRo aXNfZnJhbWUpOw0KPj4gIGRpc2NhcmRfY2xlYW51cHMgKGNsZWFudXBzKTsN Cj4+IC0gIHJldHVybiByZWdjYWNoZTsNCj4+ICsgIHJldHVybiBiYWNrdXA7 DQo+PiB9DQo+PiANCj4+IHZvaWQNCj4+IEBAIC0xMDYzLDcgKzEwNjIsNyBA QCBmcmFtZV9wb3AgKHN0cnVjdCBmcmFtZV9pbmZvICp0aGlzX2ZyYW1lKQ0K Pj4gICAgIHRyeWluZyB0byBleHRyYWN0IHRoZSBvbGQgdmFsdWVzIGZyb20g dGhlIGN1cnJlbnQgcmVnY2FjaGUgd2hpbGUNCj4+ICAgICBhdCB0aGUgc2Ft ZSB0aW1lIHdyaXRpbmcgbmV3IHZhbHVlcyBpbnRvIHRoYXQgc2FtZSBjYWNo ZS4gICovDQo+PiAgc2NyYXRjaCA9IGZyYW1lX3NhdmVfYXNfcmVnY2FjaGUg KHByZXZfZnJhbWUpOw0KPj4gLSAgY2xlYW51cHMgPSBtYWtlX2NsZWFudXBf cmVnY2FjaGVfeGZyZWUgKHNjcmF0Y2gpOw0KPj4gKyAgY2xlYW51cHMgPSBt YWtlX2NsZWFudXBfcmVnY2FjaGVfZGVsZXRlIChzY3JhdGNoKTsNCj4gDQo+ IHNjcmF0Y2ggaXMgb25seSB1c2VkIHdpdGhpbiB0aGlzIGZ1bmN0aW9uLCBz byB3ZSBjYW4gY2hhbmdlIGl0IHRvIGENCj4gbG9jYWwgb2JqZWN0IChpbnN0 ZWFkIG9mIGEgcG9pbnRlciksIGFuZCBjYWxsIHJlZ2NhY2hlX3NhdmUgaGVy ZS4gIFRoZW4sDQo+IHdlIGNhbiByZW1vdmUgdGhlIGNsZWFudXBzLg0KDQpP ay4NCg0KPiANCj4+IGRpZmYgLS1naXQgYS9nZGIvbWkvbWktbWFpbi5jIGIv Z2RiL21pL21pLW1haW4uYw0KPj4gaW5kZXggMGJmNTg3ZmZlNzAyYzY4ZjUz OGZlMjg3N2NjZTYxMTRlNjRlZTFiZC4uMWVkY2Y3NTJjODIyMzBmYzY1NjY5 ZjY3NWUxMDczNWFjOGU0ZjY1NCAxMDA2NDQNCj4+IC0tLSBhL2dkYi9taS9t aS1tYWluLmMNCj4+ICsrKyBiL2dkYi9taS9taS1tYWluLmMNCj4+IEBAIC0x MDUxLDcgKzEwNTEsNyBAQCBtaV9jbWRfZGF0YV9saXN0X2NoYW5nZWRfcmVn aXN0ZXJzIChjb25zdCBjaGFyICpjb21tYW5kLCBjaGFyICoqYXJndiwgaW50 IGFyZ2MpDQo+PiANCj4+ICBwcmV2X3JlZ3MgPSB0aGlzX3JlZ3M7DQo+PiAg dGhpc19yZWdzID0gZnJhbWVfc2F2ZV9hc19yZWdjYWNoZSAoZ2V0X3NlbGVj dGVkX2ZyYW1lIChOVUxMKSk7DQo+PiAtICBjbGVhbnVwID0gbWFrZV9jbGVh bnVwX3JlZ2NhY2hlX3hmcmVlIChwcmV2X3JlZ3MpOw0KPj4gKyAgY2xlYW51 cCA9IG1ha2VfY2xlYW51cF9yZWdjYWNoZV9kZWxldGUgKHByZXZfcmVncyk7 DQo+IA0KPiBXaHkgZG9uJ3QgeW91IGRvIHRoaXM/IHRoZW4sIHdlIGRvbid0 IG5lZWQgdGhpcyBtYWtlX2NsZWFudXBfcmVnY2FjaGVfeGZyZWUuDQo+IA0K PiBzdGQ6OnVuaXF1ZV9wdHI8cmVnY2FjaGU+IHByZXZfcmVncyAodGhpc19y ZWdzKTsNCg0KVGhpcyBpcyBuZXcgdG8gbWUuIEhhcHB5IHRvIHVzZSBpdC4N Cg0KPiANCj4+IA0KPj4gIC8qIE5vdGUgdGhhdCB0aGUgdGVzdCBmb3IgYSB2 YWxpZCByZWdpc3RlciBtdXN0IGluY2x1ZGUgY2hlY2tpbmcgdGhlDQo+PiAg ICAgZ2RiYXJjaF9yZWdpc3Rlcl9uYW1lIGJlY2F1c2UgZ2RiYXJjaF9udW1f cmVncyBtYXkgYmUgYWxsb2NhdGVkDQo+PiBkaWZmIC0tZ2l0IGEvZ2RiL3Bw Yy1saW51eC10ZGVwLmMgYi9nZGIvcHBjLWxpbnV4LXRkZXAuYw0KPj4gaW5k ZXggMzI0YjI5ZDkwYzEyNjZhNzNmMTcyZGEyMGE2MDE1MTc0MTg5NjI1Zi4u NDJhZmYyY2QxYmYzODM0MjY4YjBiNThkY2YwMGRhYzFjNTJhZGQ5NiAxMDA2 NDQNCj4+IC0tLSBhL2dkYi9wcGMtbGludXgtdGRlcC5jDQo+PiArKysgYi9n ZGIvcHBjLWxpbnV4LXRkZXAuYw0KPj4gQEAgLTEzNjQsMTMgKzEzNjQsMTMg QEAgcHB1MnNwdV9zbmlmZmVyIChjb25zdCBzdHJ1Y3QgZnJhbWVfdW53aW5k ICpzZWxmLA0KPj4gCSAgICA9IEZSQU1FX09CU1RBQ0tfQ0FMTE9DICgxLCBz dHJ1Y3QgcHB1MnNwdV9jYWNoZSk7DQo+PiANCj4+IAkgIHN0cnVjdCBhZGRy ZXNzX3NwYWNlICphc3BhY2UgPSBnZXRfZnJhbWVfYWRkcmVzc19zcGFjZSAo dGhpc19mcmFtZSk7DQo+PiAtCSAgc3RydWN0IHJlZ2NhY2hlICpyZWdjYWNo ZSA9IHJlZ2NhY2hlX3htYWxsb2MgKGRhdGEuZ2RiYXJjaCwgYXNwYWNlKTsN Cj4+IC0JICBzdHJ1Y3QgY2xlYW51cCAqY2xlYW51cHMgPSBtYWtlX2NsZWFu dXBfcmVnY2FjaGVfeGZyZWUgKHJlZ2NhY2hlKTsNCj4+IC0JICByZWdjYWNo ZV9zYXZlIChyZWdjYWNoZSwgcHB1MnNwdV91bndpbmRfcmVnaXN0ZXIsICZk YXRhKTsNCj4+ICsJICByZWdjYWNoZSAqYmFja3VwID0gbmV3IHJlZ2NhY2hl IChkYXRhLmdkYmFyY2gsIGFzcGFjZSk7DQo+PiArCSAgc3RydWN0IGNsZWFu dXAgKmNsZWFudXBzID0gbWFrZV9jbGVhbnVwX3JlZ2NhY2hlX2RlbGV0ZSAo YmFja3VwKTsNCj4+ICsJICByZWdjYWNoZV9zYXZlIChiYWNrdXAsIHBwdTJz cHVfdW53aW5kX3JlZ2lzdGVyLCAmZGF0YSk7DQo+PiAJICBkaXNjYXJkX2Ns ZWFudXBzIChjbGVhbnVwcyk7DQo+IA0KPiBXZSBjYW4gdXNlIHN0ZDo6dW5p cXVlX3B0cjxyZWdjYWNoZT4gdG9vIGhlcmUuICBBZnRlciBjYWxsDQo+IHJl Z2NhY2hlX3NhdmUsIGNhbGwgLnJlbGVhc2UgKCkgdG8gcmV0dXJuIHRoZSBy YXcgcG9pbnRlciB0byBjYWNoZS0+cmVnY2FjaGUuDQoNCk9rLg0KDQo+IA0K Pj4gDQo+PiAJICBjYWNoZS0+ZnJhbWVfaWQgPSBmcmFtZV9pZF9idWlsZCAo YmFzZSwgZnVuYyk7DQo+PiAtCSAgY2FjaGUtPnJlZ2NhY2hlID0gcmVnY2Fj aGU7DQo+PiArCSAgY2FjaGUtPnJlZ2NhY2hlID0gYmFja3VwOw0KPj4gCSAg KnRoaXNfcHJvbG9ndWVfY2FjaGUgPSBjYWNoZTsNCj4+IAkgIHJldHVybiAx Ow0KPj4gCX0NCj4+IEBAIC0xMzgzLDcgKzEzODMsNyBAQCBzdGF0aWMgdm9p ZA0KPj4gcHB1MnNwdV9kZWFsbG9jX2NhY2hlIChzdHJ1Y3QgZnJhbWVfaW5m byAqc2VsZiwgdm9pZCAqdGhpc19jYWNoZSkNCj4+IHsNCj4+ICBzdHJ1Y3Qg cHB1MnNwdV9jYWNoZSAqY2FjaGUgPSAoc3RydWN0IHBwdTJzcHVfY2FjaGUg KikgdGhpc19jYWNoZTsNCj4+IC0gIHJlZ2NhY2hlX3hmcmVlIChjYWNoZS0+ cmVnY2FjaGUpOw0KPj4gKyAgZGVsZXRlIGNhY2hlLT5yZWdjYWNoZTsNCj4+ IH0NCj4+IA0KPj4gc3RhdGljIGNvbnN0IHN0cnVjdCBmcmFtZV91bndpbmQg cHB1MnNwdV91bndpbmQgPSB7DQo+PiBkaWZmIC0tZ2l0IGEvZ2RiL3JlZ2Nh Y2hlLmggYi9nZGIvcmVnY2FjaGUuaA0KPj4gaW5kZXggYWVhYzU0ZThkN2I5 MWUyYmNmNmEzZTFjZThlNzgxYzNmOTk0MzA2Yi4uMDBiODdkYjdkMTQ1MjA1 Yjc0ODU5YzA4Y2E1YTlkODUyNDQxYTRhYSAxMDA2NDQNCj4+IC0tLSBhL2dk Yi9yZWdjYWNoZS5oDQo+PiArKysgYi9nZGIvcmVnY2FjaGUuaA0KPj4gQEAg LTM2LDEwICszNiw3IEBAIGV4dGVybiB0YXJnZXRfcmVnY2FjaGUgKmdldF90 aHJlYWRfYXJjaF9hc3BhY2VfcmVnY2FjaGUgKHB0aWRfdCwNCj4+IAkJCQkJ CQkgc3RydWN0IGdkYmFyY2ggKiwNCj4+IAkJCQkJCQkgc3RydWN0IGFkZHJl c3Nfc3BhY2UgKik7DQo+PiANCj4+IC12b2lkIHJlZ2NhY2hlX3hmcmVlIChz dHJ1Y3QgcmVnY2FjaGUgKnJlZ2NhY2hlKTsNCj4+IC1zdHJ1Y3QgY2xlYW51 cCAqbWFrZV9jbGVhbnVwX3JlZ2NhY2hlX3hmcmVlIChzdHJ1Y3QgcmVnY2Fj aGUgKnJlZ2NhY2hlKTsNCj4+IC1zdHJ1Y3QgcmVnY2FjaGUgKnJlZ2NhY2hl X3htYWxsb2MgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNoLA0KPj4gLQkJCQkg ICBzdHJ1Y3QgYWRkcmVzc19zcGFjZSAqYXNwYWNlKTsNCj4+ICtzdHJ1Y3Qg Y2xlYW51cCAqbWFrZV9jbGVhbnVwX3JlZ2NhY2hlX2RlbGV0ZSAocmVnY2Fj aGUgKnJlZ2NhY2hlKTsNCj4+IA0KPj4gLyogUmV0dXJuIFJFR0NBQ0hFJ3Mg cHRpZC4gICovDQo+PiANCj4+IEBAIC0yNjEsMTIgKzI1OCw3IEBAIHB1Ymxp YzoNCj4+ICByZWdjYWNoZSAoY29uc3QgcmVnY2FjaGUgJikgPSBkZWxldGU7 DQo+PiAgdm9pZCBvcGVyYXRvcj0gKGNvbnN0IHJlZ2NhY2hlICYpID0gZGVs ZXRlOw0KPj4gDQo+PiAtICAvKiBjbGFzcyByZWdjYWNoZSBpcyBvbmx5IGV4 dGVuZGVkIGluIHVuaXQgdGVzdCwgc28gb25seSBtYXJrIGl0DQo+PiAtICAg ICB2aXJ0dWFsIHdoZW4gc2VsZnRlc3QgaXMgZW5hYmxlZC4gICovDQo+PiAt I2lmIEdEQl9TRUxGX1RFU1QNCj4+IC0gIHZpcnR1YWwNCj4+IC0jZW5kaWYN Cj4+IC0gIH5yZWdjYWNoZSAoKQ0KPj4gKyAgdmlydHVhbCB+cmVnY2FjaGUg KCkNCj4gDQo+IFRoaXMgaXMgbm90IHJlbGF0ZWQgdG8gdGhpcyBwYXRjaC4g IEl0IHNob3VsZCBiZSBpbiBwYXRjaCAjMS4NCg0KT2suDQoNCj4gDQo+IC0t IA0KPiBZYW8gKOm9kOWwpykNCg0K >From gdb-patches-return-141153-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Aug 23 13:59:02 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 127721 invoked by alias); 23 Aug 2017 13:59:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 125171 invoked by uid 89); 23 Aug 2017 13:58:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.2 spammy=watch X-HELO: mail-wr0-f176.google.com Received: from mail-wr0-f176.google.com (HELO mail-wr0-f176.google.com) (209.85.128.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Aug 2017 13:58:58 +0000 Received: by mail-wr0-f176.google.com with SMTP id k46so634115wre.2 for ; Wed, 23 Aug 2017 06:58:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:message-id:date:mime-version :content-language:content-transfer-encoding; bh=PKOiAkpXqe7pH3G4pLylZwrjWS0daDGXYlt7U87Kwes=; b=VZKJ0PFK/uR0XfWskwiSih9o4SAc34gltS1ivxR384u4AX+hba84Soec6ZprQ63eGk LWRmY0MLNIJ0IP9R0lwFSYfqD+YsalIKyMmM3BNp+0YDv2aAsuR8L78vG9sCBzTnAVr0 KLGB2/2s/XMleCPQpHDSkLh7jWqVlvkMF/R/TishIz/jKolzaMSufhymsZcsVGPDRb5B R5KEOIndQ2MvQ1X9eE+VlwCxfFGp062SMbHA7s4LvhSGAdojzJ91k7+F+AWXWOmi4TQs Qt/+iBVJuYwHDKCbojCQLmJAKxpFk5wqEaQ4NyoQ/hgdIxurb4EiTZ3geG4z0XQJZUyt 6h+A== X-Gm-Message-State: AHYfb5iUgoNtH3j5NtCJoPJKhsvzNsEG1JseHyo14SeJP4ax6W5cUIBY RoY/6v3KfQOMjANrEMldUA== X-Received: by 10.223.183.35 with SMTP id l35mr1664184wre.266.1503496735622; Wed, 23 Aug 2017 06:58:55 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ae15:7800:4685:ff:fe66:9f4? ([2a02:c7f:ae15:7800:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id e2sm1426566wrd.60.2017.08.23.06.58.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Aug 2017 06:58:54 -0700 (PDT) From: Phil Muldoon Subject: [python] Allow explicit locations in breakpoints. To: "gdb-patches@sourceware.org" Message-ID: <04ccc2c4-7827-eedc-d8db-a83a0167acb6@redhat.com> Date: Wed, 23 Aug 2017 13:59:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00445.txt.bz2 Content-length: 5776 Hello, This minor patch allows for explicit locations to be specified in the gdb.Breakpoint constructor. It's a minor tweak, and the patch largely consists of tests to make sure the existing explicit locations mechanisms work in Python. Cheers Phil -- 2017-08-23 Phil Muldoon * python/py-breakpoint.c (bppy_init): Use string_to_event_location over basic location code. 2017-08-23 Phil Muldoon * python.texi (Breakpoints In Python): Add text relating to allowed explicit location in gdb.Breakpoints. 2017-08-23 Phil Muldoon * gdb.python/py-breakpoint.exp (test_bkpt_explicit_loc): Add new tests for explicit locations. -- diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi index 32d7939e66..a214c2a9e7 100644 --- a/gdb/doc/python.texi +++ b/gdb/doc/python.texi @@ -4825,7 +4825,8 @@ class. Create a new breakpoint according to @var{spec}, which is a string naming the location of the breakpoint, or an expression that defines a watchpoint. The contents can be any location recognized by the -@code{break} command, or in the case of a watchpoint, by the +@code{break} command, including those set as explicit locations +(@pxref{Explicit Locations}), or in the case of a watchpoint, by the @code{watch} command. The optional @var{type} denotes the breakpoint to create from the types defined later in this chapter. This argument can be either @code{gdb.BP_BREAKPOINT} or @code{gdb.BP_WATCHPOINT}; it diff --git a/gdb/python/py-breakpoint.c b/gdb/python/py-breakpoint.c index 6156eb6179..8431bed939 100644 --- a/gdb/python/py-breakpoint.c +++ b/gdb/python/py-breakpoint.c @@ -681,7 +681,7 @@ bppy_init (PyObject *self, PyObject *args, PyObject *kwargs) case bp_breakpoint: { event_location_up location - = string_to_event_location_basic (©, current_language); + = string_to_event_location (©, current_language); create_breakpoint (python_gdbarch, location.get (), NULL, -1, NULL, 0, diff --git a/gdb/testsuite/gdb.python/py-breakpoint.c b/gdb/testsuite/gdb.python/py-breakpoint.c index df6163e53a..562cab35f7 100644 --- a/gdb/testsuite/gdb.python/py-breakpoint.c +++ b/gdb/testsuite/gdb.python/py-breakpoint.c @@ -24,7 +24,7 @@ int multiply (int i) int add (int i) { - return i + i; + return i + i; /* Break at function add. */ } diff --git a/gdb/testsuite/gdb.python/py-breakpoint.exp b/gdb/testsuite/gdb.python/py-breakpoint.exp index bd138ac3d2..228489f74e 100644 --- a/gdb/testsuite/gdb.python/py-breakpoint.exp +++ b/gdb/testsuite/gdb.python/py-breakpoint.exp @@ -547,6 +547,72 @@ proc test_bkpt_events {} { check_last_event breakpoint_deleted } +proc test_bkpt_explicit_loc {} { + global srcfile testfile + + with_test_prefix test_bkpt_invisible { + # Start with a fresh gdb. + clean_restart ${testfile} + + if ![runto_main] then { + fail "cannot run to main." + return 0 + } + + delete_breakpoints + + set bp_location1 [gdb_get_line_number "Break at multiply."] + set bp_location2 [gdb_get_line_number "Break at add."] + + gdb_py_test_silent_cmd "python bp1 = gdb.Breakpoint (\"-li $bp_location1\")" \ + "Set explicit breakpoint by line" 0 + gdb_continue_to_breakpoint "Break at multiply" \ + ".*Break at multiply.*" + gdb_py_test_silent_cmd "python bp1 = gdb.Breakpoint (\"-li +1\")" \ + "Set explicit breakpoint by relative line" 0 + gdb_continue_to_breakpoint "Break at add" \ + ".*Break at add.*" + delete_breakpoints + gdb_py_test_silent_cmd "python bp1 = gdb.Breakpoint (\"-li -1\")" \ + "Set explicit breakpoint by relative negative line" 0 + gdb_continue_to_breakpoint "Break at multiply" \ + ".*Break at multiply.*" + delete_breakpoints + gdb_py_test_silent_cmd "python bp1 = gdb.Breakpoint (\"-function add\")" \ + "Set explicit breakpoint by function" 0 + gdb_continue_to_breakpoint "Break at function add" \ + ".*Break at function add.*" + delete_breakpoints + gdb_py_test_silent_cmd "python bp1 = gdb.Breakpoint (\"-source $srcfile -function add\")" \ + "Set explicit breakpoint by source file and function" 0 + gdb_continue_to_breakpoint "Break at function add" \ + ".*Break at function add.*" + delete_breakpoints + gdb_py_test_silent_cmd "python bp1 = gdb.Breakpoint (\"-source $srcfile -li $bp_location2\")" \ + "Set explicit breakpoint by source file and line number" 0 + gdb_continue_to_breakpoint "Break at add" \ + ".*Break at add.*" + delete_breakpoints + gdb_test "python bp1 = gdb.Breakpoint (\"-source $srcfile\")" \ + "RuntimeError: Source filename requires function, label, or line offset.*" \ + "Set invalid explicit breakpoint by source only" + # The below will print a warning but set pending breakpoints. + gdb_test "python bp1 = gdb.Breakpoint (\"-source foo.c -li 5\")" \ + "No source file named foo.*" \ + "Set invalid explicit breakpoint by missing source and line" + gdb_test "python bp1 = gdb.Breakpoint (\"-source $srcfile -li 900\")" \ + "No line 900 in file \"$srcfile\".*" \ + "Set invalid explicit breakpoint by source and invalid line." + gdb_test "python bp1 = gdb.Breakpoint (\"-function blah\")" \ + "Function \"blah\" not defined.*" \ + "Set invalid explicit breakpoint by missing function." + # Invalid explicit location flags. + gdb_test "python bp1 = gdb.Breakpoint (\"-foo -li 5\")" \ + "RuntimeError: invalid explicit location argument, \"-foo\".*" \ + "Set invalid explicit breakpoint by wrong flag" + } +} + test_bkpt_basic test_bkpt_deletion test_bkpt_cond_and_cmds @@ -558,3 +624,4 @@ test_bkpt_temporary test_bkpt_address test_bkpt_pending test_bkpt_events +test_bkpt_explicit_loc