Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Alan Hayward <alan.hayward@arm.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 1/8] AARCH64 SVE: Increse max register sizes
Date: Mon, 05 Dec 2016 12:26:00 -0000	[thread overview]
Message-ID: <D46B0D70.154DB%alan.hayward@arm.com> (raw)

This is part of a series adding AARCH64 SVE support to gdb and gdbserver.

In SVE the maximum size of a variable-length vector register is 256 bytes,
four
times the current maximum size currently supported in gdb. This patch
increases
the max register size and max gdbserver buffer size accordingly.

Alternatively, I could add a target variable using gdbarch.c, however
there are
80+ static arrays within the code using the value, which would all need
replacing with mallocs/frees.

Tested on x86 and aarch64.
Ok to commit as is?

Alan.



diff --git a/gdb/defs.h b/gdb/defs.h
index 
3d21f62f52cc3a59d5effb62dcb78014acdfc092..a5ad024359f84391be0e79f143674439f
d5c7f6f 100644
--- a/gdb/defs.h
+++ b/gdb/defs.h
@@ -622,7 +622,7 @@ enum symbol_needs_kind
 /* * Maximum size of a register.  Something small, but large enough for
    all known ISAs.  If it turns out to be too small, make it bigger.  */

-enum { MAX_REGISTER_SIZE = 64 };
+enum { MAX_REGISTER_SIZE = 256 };

 /* In findvar.c.  */

diff --git a/gdb/gdbserver/server.h b/gdb/gdbserver/server.h
index 
f56c0f5eca5a4a4bcba7789dde1dc41aa329fdfa..11cb3080dd7bc77231193d770df7b1c26
aa6751d 100644
--- a/gdb/gdbserver/server.h
+++ b/gdb/gdbserver/server.h
@@ -140,7 +140,7 @@ extern int in_queued_stop_replies (ptid_t ptid);
 /* Buffer sizes for transferring memory, registers, etc.   Set to a
constant
    value to accomodate multiple register formats.  This value must be at
least
    as large as the largest register set supported by gdbserver.  */
-#define PBUFSIZ 16384
+#define PBUFSIZ 19200

 /* Definition for an unknown syscall, used basically in error-cases.  */
 #define UNKNOWN_SYSCALL (-1)



             reply	other threads:[~2016-12-05 12:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-05 12:26 Alan Hayward [this message]
2016-12-12 18:11 ` Yao Qi
2016-12-13 10:05   ` Alan Hayward
2016-12-13 11:48     ` Yao Qi
2016-12-13 11:53       ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D46B0D70.154DB%alan.hayward@arm.com \
    --to=alan.hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox