Re: [PATCH] Rename block.{h,c} to gdb-block.{h, c}

Kevin Buettner
2020-09-07T02:40:31Z

On Sun, 6 Sep 2020 07:52:36 -0400
Simon Marchi <simark@simark.ca> wrote:

> Renaming our file is a little bit annoying, but I don't see a better
> solution. We could change our includes to be "./block.h" or
> "gdb/block.h", but sooner or later someone will add back a "block.h"
> include. It will silently break macOS because we don't have CI for
> that, and it will take somebody building GDB on macOS to notice and
> fix it.

Offhand, I can't think of a better solution either, but I really don't
like renaming GDB's header files to accomodate MacOS. It seems to me
that we might face future potential confilicts (not just on MacOS)
with several other GDB header files as well, e.g. probe.h, frame.h,
value.h, and possibly others too.

I really think we should look for a better / different solution.

Kevin