> On Sep 6, 2020, at 04:52, Simon Marchi <simark@simark.ca> wrote:
> 
> On 2020-09-05 10:21 p.m., Saagar Jha wrote:
>> GDB doesn’t build with newer SDKs because its block.h conflicts with macOS’s Block.h. This patch resolves the issue by renaming GDB’s files.
>> 
> 
> Hi,
> 
> Can you include in the commit message:
> 
> - which SDK are we talking about (for the non-initiated to macOS)
> - the relevant versions (macOS, SDK)
> 
> Renaming our file is a little bit annoying, but I don't see a better solution.  We could
> change our includes to be "./block.h" or "gdb/block.h", but sooner or later someone will
> add back a "block.h" include.  It will silently break macOS because we don't have CI for
> that, and it will take somebody building GDB on macOS to notice and fix it.
> 
> In your ChangeLog entry, drop the "gdb" part of the filenames, so that they are relative
> to the ChangeLog file itself (Makefile.in instead of gdb/Makefile.in).
> 
> Simon