From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 42/xBaKIe2JFnAUAWB0awg (envelope-from ) for ; Wed, 11 May 2022 05:57:54 -0400 Received: by simark.ca (Postfix, from userid 112) id 0B8361E21F; Wed, 11 May 2022 05:57:54 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=sjFfSu6U; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 475B71E00D for ; Wed, 11 May 2022 05:57:53 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DC3C83886C4B for ; Wed, 11 May 2022 09:57:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DC3C83886C4B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1652263072; bh=ROpywcUgUlHNGgg4vKImTC8RWxGuV+Jb9cHPK2OFcSY=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=sjFfSu6U58E49e4gBox9VMVXAc0D+3elsE2/KHrJSd++xSmwhIH1Gq6dl9K4/Hxkc xqQzqWCTcQEJGhntzvYUbWx8k50lRWaZtNucj5l5m1KwdgyTSxFTZSW0WptMc2mWTU m7Js/e+4xTVbc6YZgOaYHno6dOG4pUnMUsloT5/0= Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by sourceware.org (Postfix) with ESMTPS id 7F016384B07F for ; Wed, 11 May 2022 09:57:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F016384B07F X-IronPort-AV: E=McAfee;i="6400,9594,10343"; a="269587320" X-IronPort-AV: E=Sophos;i="5.91,216,1647327600"; d="scan'208";a="269587320" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 02:57:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,216,1647327600"; d="scan'208";a="553260491" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 11 May 2022 02:57:30 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 02:57:29 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 11 May 2022 02:57:29 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 11 May 2022 02:57:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UcylHaHsSZtIxIIMIPn1mA4LAwwvmv55PU97b1qbhY4H0hIixxYrwDrJVrjQh08UO96crZTsLSx/bJrOypkgsAxQxUYO6ylYt3L7PHmoTwdGmHTunMal9boKJfar5NsXx/dEHupBUIhSgoGhLqYIitYBw49ZBFGxCgmIxq6TXRndEgPH/46d7WBLLeXHLiyePPMNBsat7OdgNsjc5pSSKfFWgMy22IpZWu3GrnGoyFr2TcGAXB3S2qFxnzSQbfCQnczHd75RROKvFrTGZ45m16ph7I2lF1CjC+1TfdUPtOCJbjKFyiOb7xUrRv7bWmF/mjudgrN2rtZQXf07N0w8cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UOaVu3iWIJb36gNp55POFi8GuSVAZaf1N6PdO1PWb4M=; b=Vn3gwpE9syPF+iyLuoBPYJeSNgukfnGb1H42TkZ8UquThWbdSg+mVY2UM1UJLu+THN9243yl7q6GEv0RR5QmwrgVrJ7g5W7fCKB2dLOQM9idwZKhfIovjAUNkosHUxm9wCd99nV4pMFhwrNCVSCqOmD68D6Z+BhyERXE1xX5SPJjbOvKE1tPowcxwfTrQqK7wk4XPmg4tTr3TKasBJtruW2WNWcQ9GUt2TDnOMI5jjNxBoAAa447xzCTMCdtPbZr0vNTfCLYTrzq9RWlklFa//cVVnftq4NhIiNg3Wh7B5c0JgHufuBYxXWnVaxn83aX2zdigqHdBlNEDGiNpKSnfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR1101MB2071.namprd11.prod.outlook.com (2603:10b6:910:1a::10) by CO1PR11MB5140.namprd11.prod.outlook.com (2603:10b6:303:9e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 11 May 2022 09:57:27 +0000 Received: from CY4PR1101MB2071.namprd11.prod.outlook.com ([fe80::403f:f9f0:74f2:c5b9]) by CY4PR1101MB2071.namprd11.prod.outlook.com ([fe80::403f:f9f0:74f2:c5b9%10]) with mapi id 15.20.5250.013; Wed, 11 May 2022 09:57:27 +0000 To: Andrew Burgess , "gdb-patches@sourceware.org" Subject: RE: [PATCH 03/18] gdb/testsuite: Fix fortran types for Intel compilers. Thread-Topic: [PATCH 03/18] gdb/testsuite: Fix fortran types for Intel compilers. Thread-Index: AQHYZHnAoscJq1xpbk2/Y7kf3WAxlK0Zb/MAgAABwQA= Date: Wed, 11 May 2022 09:57:27 +0000 Message-ID: References: <20220510142437.1397399-1-nils-christian.kempke@intel.com> <20220510142437.1397399-4-nils-christian.kempke@intel.com> <87fslgl7pf.fsf@redhat.com> In-Reply-To: <87fslgl7pf.fsf@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e6dd4438-d530-4098-8e3b-08da3334a7d8 x-ms-traffictypediagnostic: CO1PR11MB5140:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TjP0ROcRDh3SlcvUVGMVSTe97cpXOZuM9bjLM6+BfVtGlMEDuz/CsRpFqJvEVSoWAgwg7vBMAcNISsQx/W+V/4HfVuBCdCWQDb7+WUVboQw+Gdzkod4qcYfQrrWYJMufF5U2RJAKdDtTZKVI9oZm/z5o10NV/TnfcH93coghnDD3BpoFsUASCxQ+eHjOZ+ZJOg2UVDgzzQjvytE2t2LF892EEdaB+5zBgApe05fBQEkp1mdQmNobdb+pn6OaksGxu6oiWXvpJ7RAAJk+n+kPnATQU1BWuqaTBKh68m+4cObXVurw+kRiLKwOaWiGpuJxVz4jy0JkonQZYI1iBBoZwJPy8/mxEdUHcbRqKctAWHVwRRMxW8J25A53AgfARHw6hG3slX67VNsXrD6f5oPzm0yNKMAv9Ajrbl1eJc/dO01sbWkqaRK+69G/CL3fPGppOwlKouuRacGu5UMGNaTVKcnrI8bgTBggIfWXxQe3AHquDB0gTMammIDMgF2eQKTL6eGwLJ+nJX77004pI+reM9md5s74pkTJmxmMiXLAnNGbo/FyWkK9kiNrgFL5BtTftJZ3wUUKGsQFzjHKxW2af0tnyTnmgIbeBOQqk+Jbj9ymj7bQXQBXCnYgtf0Z+EqIEv5szHlZjj+n0/8D5q9Jp0mibMtutjKn68iQMG31nQML8Q+qYi1BCgbsEmTD2NqYKGTW0hvSTPpZmBSHpDe9N0U0f9JJgygHX96JqUq318axMRBfrLLG6aeR4JMPHabBBgzNNs3c2nO8QhqdZhmOtskt0xakPd/Nm78fBx4I0lY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2071.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(76116006)(66946007)(66476007)(2906002)(66556008)(55016003)(15974865002)(71200400001)(86362001)(508600001)(66446008)(9686003)(64756008)(316002)(33656002)(8676002)(82960400001)(6506007)(53546011)(122000001)(38070700005)(83380400001)(38100700002)(52536014)(26005)(8936002)(5660300002)(186003)(110136005)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SLMQslp2UAPnk3cABdOQDVzn2anye7tIYyPfay5ZDH3U1kGN+HUoMpRhEJK9?= =?us-ascii?Q?yVuHsu+XVlIDo/h/nzsbC9Y+58V55CRknx2gkX9GDcXTiLS+K6CJjmpvdFe5?= =?us-ascii?Q?rqr5Om9TffjWqh+cT4dvOAUJnj9p2u/0R4Ta6h6dysyfu99U8PDWj0s7mKjy?= =?us-ascii?Q?XRFWLNbdO4y48lkN7oAU8wr3ZTdkqFKv4JsUAuRGRA+xRzvkdmD7ivHIfsSY?= =?us-ascii?Q?lFK7naKno6k3mKlOLgLGHH4fYDRXsPYcT8x8ufFGsHwrIlbm3jNq8IdMUSVY?= =?us-ascii?Q?bvMnhQqK2jTnMW0bQjCme6k3S2LGu85pkIGWdsZi6PyaVuTzfJYa+WVDK/N0?= =?us-ascii?Q?Z2R2ZRCFJ5xR35mrCUuZT1vx5M9JuxdinF9ZDYrCW/KyiFFlGVg8ZK8GCTZp?= =?us-ascii?Q?8ibFAVYu2/TE/k4XixCmavYNvgyRJKcT6wn7HIOGZJbSCfxehcZ7EiibuKlE?= =?us-ascii?Q?cQZ9bImfJxoa727WwjmVUztC4wIudLd3tuB1MHqOq826RQ2J67N7TTxxd/JB?= =?us-ascii?Q?JOL31EdmBSS9I8faFnhpppaZt8UEioIl6M0BYT9+TJr7oVP6cOavLsMo3dA3?= =?us-ascii?Q?IOU0LtDU4S7oD/859ZbejYthBMZ7MKZ/PCpdtclwH4CeTAXLrEDuHnxkAtRM?= =?us-ascii?Q?IJUs8IB9fDhxUu8G7qlMGm0t1KOnbkdUhf5z/83GKitnWbsoSP62SmmzOuhR?= =?us-ascii?Q?kU9C//hksrbYc9cnQ768bPXb7J1Er2DtUJ+N7ZicrRKNx1HNJlIgZ87wj+O7?= =?us-ascii?Q?MWv7lOltL9wvcNqtnuthVk2VrB6BQpbkjKDQoNUL6nXsotCmdprHWytnOd+c?= =?us-ascii?Q?J+ClO7nYCtyYAq3Et8dCxxEq6m0N7/4Zh7QnGYX5f3kpWHx4TdvQ9evuimoD?= =?us-ascii?Q?WLprnFVeZTX9rxlEzACpFaJHLnEPfS8EzdHlVK37w5guTiyMKxmLWn+srIZC?= =?us-ascii?Q?KqbaZJhW9564erOaWL7pOdOMx1hfsfYWBZnSl76ZFNxLByjnon+GsolvJsBJ?= =?us-ascii?Q?+M87Q8LtW0mR5B0ZeiSBow9NOVIw0wbNBympUZIsLEqUEWatw513oB7/6vRV?= =?us-ascii?Q?WEU6Jqz4LdiDhfpWwzMEIMGjYsE5lpdgMMXtxmkZiY5nNUnc2D5ho9HXyx0/?= =?us-ascii?Q?TaQ/toAH8Bqj/GeDhxR1mMqKMi/hL0gJPPV3/In2TqqEZMCYuGchhiMOBXoU?= =?us-ascii?Q?VKRY5FL68IXJnA/oklEiMM4IN+oqjNCa9A5q0Uu3of1rOTmAjzhbhJTd7KrI?= =?us-ascii?Q?8Dh7aHsi0LZoNOyDqf8BAQY2WTtRXuAlKpFhPXV7YP/CsY/rxXPUQ/qTnZUu?= =?us-ascii?Q?GmIVoVrknpq3dxIHy49DievEBsVHKaRYWRDKL0Cc0/u8hbfIPsVmgVmH8te5?= =?us-ascii?Q?LemcAC1TONRXxJKcvUKgw7xwQS0Qt72HqayPb1g5ahRSh7Smorjec+vIwG4c?= =?us-ascii?Q?TcTc+13smPjsygn4trznxaprkPi53jfrZDiDdfPHG8OmzCR4+HTsb9jauqNl?= =?us-ascii?Q?WLWNEeDe1MNOQx1cLrlro7Q/eUD+bl6TbYkGONq9xYDk4p/2FiNqtCZVOG2Z?= =?us-ascii?Q?g+Eb7nKOmVFwr27dGdzItyyKP+6JqB0VyuxO0kEnLWN/b6J9K4SA1U+n4GNU?= =?us-ascii?Q?eCWbFXByWQh37unqGxCtVxJW+SzbzAxtG/q81NQnXQ/3w1W/9aREA0Vf02yh?= =?us-ascii?Q?EvmP3ZsERldZyMghwb1nwOM/WoTto8s3Py/bl5g98Py44dbTKVaznDulAiJZ?= =?us-ascii?Q?mlwet7EmoF52AD9ZWSDkvuCegVZLuu0=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2071.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6dd4438-d530-4098-8e3b-08da3334a7d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2022 09:57:27.3337 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: is4zru8N42NOMr+KnrZ7hdjU24JMoTemn5tk9t3se7c7znC4B1bcGOf4rnaEYcOSa7Vxx2dFiITDqYY2qzTeKNNgoOQ8kolv2AjjaIYDSLs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5140 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Kempke, Nils-Christian via Gdb-patches" Reply-To: "Kempke, Nils-Christian" Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > -----Original Message----- > From: Andrew Burgess > Sent: Wednesday, May 11, 2022 11:50 AM > To: Kempke, Nils-Christian ; gdb- > patches@sourceware.org > Cc: JiniSusan.George@amd.com; Ijaz, Abdul B > Subject: Re: [PATCH 03/18] gdb/testsuite: Fix fortran types for Intel > compilers. > = > Nils-Christian Kempke via Gdb-patches > writes: > = > > From: Felix Willgerodt > > > > Newer Intel compilers emit their dwarf type name in a slightly different > > format. Therefore, this needs adjustment to make more tests pass in the > > Fortran testsuite. > = > The change itself looks fine, but I don't understand the following: > = > > There was not yet a way to handle the print for > > variable length strings to this commit introduces fortran_integerN as > > well. > = > I suspect there's just a little context missing behind this. Ah, yes. This is just a leftover in the commit message.. It should not be = there anymore. There was an obsolete change in this commit earlier, I removed it but it ap= pears that I forgot to remove the part from the commit message. I changed it locally and removed that line. > Thanks, > Andrew > = > = > > > > Co-authored-by: Abdul Basit Ijaz > > Co-authored-by: Nils-Christian Kempke > > --- > > gdb/testsuite/lib/fortran.exp | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/gdb/testsuite/lib/fortran.exp b/gdb/testsuite/lib/fortran.= exp > > index a97c6eeb4e..9531d393a1 100644 > > --- a/gdb/testsuite/lib/fortran.exp > > +++ b/gdb/testsuite/lib/fortran.exp > > @@ -38,6 +38,8 @@ proc fortran_int4 {} { > > return "integer" > > } elseif {[test_compiler_info {icc-*}]} { > > return "INTEGER\\(4\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "INTEGER\\*4" > > } else { > > return "unknown" > > } > > @@ -52,6 +54,8 @@ proc fortran_int8 {} { > > return "integer\\*8" > > } elseif {[test_compiler_info {icc-*}]} { > > return "INTEGER\\(8\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "INTEGER\\*8" > > } else { > > return "unknown" > > } > > @@ -66,6 +70,8 @@ proc fortran_real4 {} { > > return "real" > > } elseif {[test_compiler_info {icc-*}]} { > > return "REAL\\(4\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "REAL\\*4" > > } else { > > return "unknown" > > } > > @@ -80,6 +86,8 @@ proc fortran_real8 {} { > > return "double precision" > > } elseif {[test_compiler_info {icc-*}]} { > > return "REAL\\(8\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "REAL\\*8" > > } else { > > return "unknown" > > } > > @@ -94,6 +102,8 @@ proc fortran_complex4 {} { > > return "complex" > > } elseif {[test_compiler_info {icc-*}]} { > > return "COMPLEX\\(4\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "COMPLEX\\*8" > > } else { > > return "unknown" > > } > > @@ -108,6 +118,8 @@ proc fortran_complex8 {} { > > return "double complex" > > } elseif {[test_compiler_info {icc-*}]} { > > return "COMPLEX\\(8\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "COMPLEX\\*16" > > } else { > > return "unknown" > > } > > @@ -122,6 +134,8 @@ proc fortran_complex16 {} { > > return "quad complex" > > } elseif {[test_compiler_info {icc-*}]} { > > return "COMPLEX\\(16\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "COMPLEX\\*32" > > } else { > > return "unknown" > > } > > @@ -136,6 +150,8 @@ proc fortran_logical4 {} { > > return "logical" > > } elseif {[test_compiler_info {icc-*}]} { > > return "LOGICAL\\(4\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "LOGICAL\\*4" > > } else { > > return "unknown" > > } > > @@ -150,6 +166,8 @@ proc fortran_character1 {} { > > return "character" > > } elseif {[test_compiler_info {icc-*}]} { > > return "CHARACTER\\(1\\)" > > + } elseif {[test_compiler_info {intel-*}]} { > > + return "CHARACTER\\*1" > > } else { > > return "unknown" > > } > > -- > > 2.25.1 > > > > Intel Deutschland GmbH > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > > Tel: +49 89 99 8853-0, www.intel.de > > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Sil= va > > Chairperson of the Supervisory Board: Nicole Lau > > Registered Office: Munich > > Commercial Register: Amtsgericht Muenchen HRB 186928 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928