From: Jaydeep Patil <Jaydeep.Patil@imgtec.com>
To: Andrew Burgess <aburgess@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "vapier@gentoo.org" <vapier@gentoo.org>,
Joseph Faulls <Joseph.Faulls@imgtec.com>,
Bhushan Attarde <Bhushan.Attarde@imgtec.com>
Subject: RE: [EXTERNAL] Re: [PATCH v6 2/2] sim: riscv: Add support for compressed integer instructions
Date: Tue, 23 Jan 2024 05:35:08 +0000 [thread overview]
Message-ID: <CWXP265MB5321FB1B2EECA2D132195EA08C742@CWXP265MB5321.GBRP265.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <875xzl64yn.fsf@redhat.com>
<aburgess@redhat.com> writes:
> riscv_insn_length() can return lengths other than 2 or 4. I think we should retain this error block but change the condition to:
>
> if (len != 4 && len != 2)
>
> Anything else isn't going to work, so we shouldn't even try beyond this point.
Ok, I will retain the error block.
> I notice 'mach: all' here, and you've changed all the other tests to use 'all' too. This doesn't seem right. What's going on here?
I think this should be 'mach: riscv32 riscv64'.
Regards,
Jaydeep
prev parent reply other threads:[~2024-01-23 5:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 5:28 [PATCH v6 0/2] sim: riscv: Compressed instruction simulation jaydeep.patil
2024-01-11 5:28 ` [PATCH v6 1/2] sim: riscv: Fix crash during instruction decoding jaydeep.patil
2024-01-22 10:18 ` Andrew Burgess
2024-01-23 1:18 ` Mike Frysinger
2024-01-11 5:28 ` [PATCH v6 2/2] sim: riscv: Add support for compressed integer instructions jaydeep.patil
2024-01-22 10:24 ` Andrew Burgess
2024-01-23 5:35 ` Jaydeep Patil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CWXP265MB5321FB1B2EECA2D132195EA08C742@CWXP265MB5321.GBRP265.PROD.OUTLOOK.COM \
--to=jaydeep.patil@imgtec.com \
--cc=Bhushan.Attarde@imgtec.com \
--cc=Joseph.Faulls@imgtec.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox