From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KB1FOPGAnmVLoTcAWB0awg (envelope-from ) for ; Wed, 10 Jan 2024 06:35:13 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=imgtec.com header.i=@imgtec.com header.a=rsa-sha256 header.s=dk201812 header.b=dQ033Lht; dkim=pass (1024-bit key; unprotected) header.d=IMGTecCRM.onmicrosoft.com header.i=@IMGTecCRM.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-IMGTecCRM-onmicrosoft-com header.b=gQw3BBpA; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D73951E0C3; Wed, 10 Jan 2024 06:35:13 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6F1421E092 for ; Wed, 10 Jan 2024 06:35:11 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E7F533857349 for ; Wed, 10 Jan 2024 11:35:10 +0000 (GMT) Received: from mx07-00376f01.pphosted.com (mx07-00376f01.pphosted.com [185.132.180.163]) by sourceware.org (Postfix) with ESMTPS id EB7123858D38 for ; Wed, 10 Jan 2024 11:34:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB7123858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=imgtec.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EB7123858D38 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=185.132.180.163 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704886488; cv=pass; b=NScKk8b59RvNpHVfPMCjbiji3QO4QPJ+tNMpqhkP3Pv9Zj5hkqoL6Bq7SQQqs65bWUonkIu2quGd9M8v6l6ru39jyw7IrAgifIE6pu4tG24Lncis1LYbtbR9zN4VP3BmFrKgvXDwePhxJQdUR2G/1JtKvpFnx8Z953EDZ8Zk4lY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704886488; c=relaxed/simple; bh=qXihjfuijdSf7f15L/uVoLGj7aUxXE+l2nL4z1NW+C4=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=taGhaD5SXdRmb6s0KNMdi1dtNHIfeOCNu4tu8GLg4lmj60epq7rar049lkFN5l5p78LDhgmerBk9b0ncuTxEeSB/r4m4sfOKp52mryIoXiGqeJNGVgvNS2LlIhiARmaVLsAMPzAipXlsYBI+7urgb4NGALWRncr2LWHVBCm8O+s= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0168889.ppops.net [127.0.0.1]) by mx07-00376f01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40A8rEEQ007396; Wed, 10 Jan 2024 11:34:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h= from:to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s= dk201812; bh=CT053qBvPxS9uduIG0TCKY7zDMYif4xXLNwGNfHSWRk=; b=dQ0 33LhtTBi9uzSySiUeoAIOedFFhp+/jQrSIXUwJRUpWxpWVA1aHaC1MwXQlabijdu Rhme6B9EIxdy5vCkxkSAPnCgg/F7t2Tx3O+MN3XgRmrFIOF8lnKQC5b0hiAYkRV3 dWg+GMDE6hf+/UVGFN0VTlt3tWQnUrgORqj1f3ooPnnPaHBz9TRcvv9sakXwCWJX NgmUwtHbrseWeX23oJStLf4/PIRqvDtGRe6XQA0vu5V7VB/2rdfc1DCdrJWIWLZ6 2VOj9tcxIecdx3/cP3/V2BjWg40Yd7CwagOpHHFIozokQsJhgQNeyaQIUdAZ2yBV JVOT26RO8lPMDfKsIDw== Received: from hhmail05.hh.imgtec.org ([217.156.249.195]) by mx07-00376f01.pphosted.com (PPS) with ESMTPS id 3vh7qe8qda-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 10 Jan 2024 11:34:34 +0000 (GMT) Received: from HHMAIL05.hh.imgtec.org (10.100.10.120) by HHMAIL05.hh.imgtec.org (10.100.10.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Jan 2024 11:34:32 +0000 Received: from GBR01-CWX-obe.outbound.protection.outlook.com (104.47.85.41) by email.imgtec.com (10.100.10.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 10 Jan 2024 11:34:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m6lUTpbMt5f4e91EOlqYifE2TVxTrv++Q1475L0VV5PtO93fV2ZLq/nAkikrxeaKdyL7EPC/uKGb/HR5gmwSmI8JthUS7BBuxzzr1IAjwqqFVNiETD0dHXzPowJ+TAdRQ3RB92eOn9g0K88G+h1qY3IY5m+dFgfZVyivMUuiW8mySkGdGp2LDi3Hgy81pgBHq83FuTFeOqbV6PNgUlPmUqs4g7BW+eVeTDVgz3PwNEQlY3vYsBQSl/Oj+c+1Z3ZBYysI0mhA2+Sm510G/FN7E8VgiS2ZacZmMH1tKf+IGMXkueR2Z/KiDAfsVPcBwkaFhsgq5ePASVpSBU6Ocbz2og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CT053qBvPxS9uduIG0TCKY7zDMYif4xXLNwGNfHSWRk=; b=kD6+mpzKIF2U2v7lfZbRyfwAwlkldpLEFMqksJX8urp/DYNEZOoo4OSVwSXkjbt6phgLoKY7QYSxePr9Vz34Rlqv7R9MmfxyrQfNRueEyN94fSZJDni44ZKvgsfyZ95/sxwCnOVnMPuCYjwIWsAnF0PZROglhNDfOSdLtOHD41TduySVGtkR836S//cCvzpoZ/hFKresKxybI7yfvX1xcY0IvjX9P19b9nx8PlvQ0SiNO4tEcymhnFjAUJbQw1G+j1RcWpYzMEAGqRcc0Bcndmd7BO2hekBWwN/9RyqOx2K17zWOEqAWgvNgt60xJIOGMxSvpjAhXnr+f2AuAYREGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=imgtec.com; dmarc=pass action=none header.from=imgtec.com; dkim=pass header.d=imgtec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=IMGTecCRM.onmicrosoft.com; s=selector2-IMGTecCRM-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CT053qBvPxS9uduIG0TCKY7zDMYif4xXLNwGNfHSWRk=; b=gQw3BBpAcS42SvVDiF8hEyW3wxxf+icJsaTEF/DX98keRzeRmxRt+1dgNbjTe3cQQQNqNtxjWw1xUwCLR0iEdzPtxFav6So0ZmjMq7H5pI3t22oDed6N/Lldt1WQ++yKo7/ZpXPogoO0w/jOA53+q2jPemC0j6kqb24O4PaZ3QA= Received: from CWXP265MB5321.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1be::5) by LO6P265MB6750.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2fb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Wed, 10 Jan 2024 11:34:30 +0000 Received: from CWXP265MB5321.GBRP265.PROD.OUTLOOK.COM ([fe80::e3fb:de18:a70d:a65b]) by CWXP265MB5321.GBRP265.PROD.OUTLOOK.COM ([fe80::e3fb:de18:a70d:a65b%4]) with mapi id 15.20.7159.020; Wed, 10 Jan 2024 11:34:30 +0000 From: Jaydeep Patil To: Andrew Burgess , "gdb-patches@sourceware.org" CC: "vapier@gentoo.org" , Joseph Faulls , Bhushan Attarde Subject: RE: [EXTERNAL] Re: [PATCH v5 1/2] [sim/riscv] Fix crash during instruction decoding Thread-Topic: [EXTERNAL] Re: [PATCH v5 1/2] [sim/riscv] Fix crash during instruction decoding Thread-Index: AQHaNJeDm5rH1r+ABUiS9U7zHt2uxrDS9JAAgAATzTA= Date: Wed, 10 Jan 2024 11:34:30 +0000 Message-ID: References: <20231222052658.2102802-1-jaydeep.patil@imgtec.com> <20231222052658.2102802-2-jaydeep.patil@imgtec.com> <87mstd8p4b.fsf@redhat.com> In-Reply-To: <87mstd8p4b.fsf@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CWXP265MB5321:EE_|LO6P265MB6750:EE_ x-ms-office365-filtering-correlation-id: c46161f9-ff1c-4b7b-dee5-08dc11d01c33 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 95Ueg8WJTw6JR0Yd/elSkJFSC99cT2AaaVhbSwvBhZOZ3EYp5nMidzFcOrKV+9AQ31oarFohtdO7j5sQGHmS4CLA4xcRDX10L81baZBN43C2Er5d7bHImPvydyFxKW4VyJ12kZlfBHTJgQR2KGdbotXwr6Nqi7FVgg1ihoipNCtHenT5ZqbmazRiMbEaICIcFDrfk/xx/E76pz/5e5Hceq5ZNI42mn72/A4yf8fUMsJw+dlneVAhvNawK7UGbn3Sp03Pf4mGgU1V0qtmpkMTzg7X0Fgu+p7uwKfHHt+Na4DjmHpmGp5qah+EaYWW3hpfo+xvPLVj9fZmOTEglR2iTZ8OKvCDSbMcEy0Ij/D6YmeQf1kWIARthr+x3ycaUENegKwESoXMKAdJchDtTU+HMUykwES2eAtskqUXMYD+naKclhSCNlm0eHrKiPtiXkL6ZFiH5Xm+hiLpTZi2htQt8VzOJ1LhsHEZK+gWJXdgr8almcvKwbslbEC77g2ZOHKfACZSaoyVecPwrrO2G0+frxbuvc9qiMeyvapmSCNnsFArXz13aSLdkX3ezXcF3Znips71X1o2gtYbEKa0CXDftViIRO5xjaOL6UybhF3M3D4SJP/YZ33BallT8445J2Xi x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CWXP265MB5321.GBRP265.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(396003)(39850400004)(136003)(346002)(376002)(366004)(230922051799003)(1800799012)(451199024)(186009)(64100799003)(4326008)(122000001)(38100700002)(2906002)(316002)(5660300002)(9686003)(478600001)(71200400001)(6506007)(83380400001)(7696005)(33656002)(110136005)(66476007)(54906003)(26005)(64756008)(76116006)(107886003)(52536014)(66556008)(66446008)(38070700009)(66946007)(8936002)(86362001)(8676002)(41300700001)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VYJriuq739pqERL1WYOtExlhewke5kUIyPXbFPGfRBpNe+Nqls6Rmdpo0Tq7?= =?us-ascii?Q?QCfKqhl83zFdCvEhAZzm6qZes+yOskkyJQgJcVUA2G2RlodAvW5xhkc5/viU?= =?us-ascii?Q?wOyA9MUXHoswphj1U1GTkeJWp0VLVdZ2/2CZ584wE3Mins16WSR1giMgcg9b?= =?us-ascii?Q?5ooT/up8fCdVtgBEcOyMPfJh1dd4bSPTnKAwz2BSWZapzjafQ1d2jwLG1KWA?= =?us-ascii?Q?xNa/rilf03KE+7YyMuZxhaxeSTULwpCm6/LznR9IA4FYbsSj7583zKAoC5Oh?= =?us-ascii?Q?Bm8dhMl41fb2O3ezsuWhiDIM5qDEhIe3RzR2+ETQ6JIpT1iploHGj8pk+W5K?= =?us-ascii?Q?DN8yJrYzriIC4PoKv2sFzjJ7dOo0ej1vx8OFBcO1jpNuvK1StloumjjUmzQO?= =?us-ascii?Q?7xo4WQq8R8PtB/GdRl2XK7Uv9Qr8+KbXJH/eHyAW7QfWe7RoNebnGJRWOcXt?= =?us-ascii?Q?4KBELxMKcxfipQagp7MVlOJZhcwXOMN9dCu35apSk01uj4ed+n+Lqy7oDNYg?= =?us-ascii?Q?r1DDxTtSTruahFV1rTx5cbj6uKeanNza06j1oIuzMhgL7X/ROm5M4R7sdaJr?= =?us-ascii?Q?/6oaWp6b3THG1H9yemj5svx1CK2xIt8w6Xy9pJ4ze1m4kwwF/dyT+aCt9fHX?= =?us-ascii?Q?Zmef0zro202fLBYrnyO0zA8jgiqnm29QykTSEDeGTsFk4pCK9S2VotB8E7Dr?= =?us-ascii?Q?76t+zIoqPH1MRP/AWAdUSNk730OkF/N2pxmMzT+eEHayXjcbtrUg5L0S1VqE?= =?us-ascii?Q?sej7mguVcjCjtsQG8ApBo9CUAX3Zt9PclIGNXXHC7q2GdeiMR+2SfjibYx6I?= =?us-ascii?Q?BtVElY3KLfZwXLRj0ADS0N4FXsN3M3wGgF/KWHL1FWFK4L4J8qvwM03G1uOK?= =?us-ascii?Q?2OfQVfibbL6q+Im3xx1lNlHFOu2DWNST7Q+tfEHipr8Ezu6sDWX+86Izej9+?= =?us-ascii?Q?wPDgO4J70KEu7ayXR23xc1oZ9nf6iPUo2tVHVCTcZaXHxHTObhto6WCqTxXC?= =?us-ascii?Q?zEmjHJHnR7odNrF3BthA1/ksbcZeaj5fvfJxfj+G1JKqgq5MB3x76INny82Q?= =?us-ascii?Q?tD9cjilDpiaMYBaBCDUqfv+a9Y3vYY/nBCiKaJWQiCBmHADZ8CnvsBLqrab9?= =?us-ascii?Q?Y3fIXIoyBusfOOqLcRAtEELWVJzg1l/d4wev9ARBo44Tqk7TwEXIrYUMwncl?= =?us-ascii?Q?nOr9AdS3W1LycD+72/n0h5dcavcvRTsqavphhQ/jPZ0tO54ElSNKRf75j5/v?= =?us-ascii?Q?l6GLiJ6GZebtKQLHxZRBmBVOXEM+jAhNfR9KZ2Xx2JK/qJgnFwraOHkJA79t?= =?us-ascii?Q?UMXws8syI417pEcGw7n23UoyPUEcLzLCC+XiEeXfnZDvtSubkj0oxK8VtZ3S?= =?us-ascii?Q?nE+i+GM/NM0OikcvxfDCALYFex+KJhVVfaiL26hYilFcCmrhCz6RWsaOwX/1?= =?us-ascii?Q?bBaVgn5ZHSmjyh4F5yImUBoAYfoNL3lv3Mrj8M5uyhaq+me4eX6j5ZT2G/PA?= =?us-ascii?Q?F++JfDRcanTlm/WOtP6kHy5WJALLqapWINP6RRw3xeK0ppvFk5x7AP+jIUIH?= =?us-ascii?Q?VNHeelP6HKCUPLnYHEseJhiaIUX8ZsfagA4tK2xa?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CWXP265MB5321.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: c46161f9-ff1c-4b7b-dee5-08dc11d01c33 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2024 11:34:30.3311 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0d5fd8bb-e8c2-4e0a-8dd5-2c264f7140fe X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pabM7Vv3U2py8aUD94gP9T8rr9o+/3DB/QYVN13mtxWjj1MUo87aegQWuz3ssTTXJyiPm4QouR8vFjPP+xpo61Y43+naWnaPpxHg1NhSc/4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO6P265MB6750 X-OriginatorOrg: imgtec.com X-EXCLAIMER-MD-CONFIG: 15a78312-3e47-46eb-9010-2e54d84a9631 X-Proofpoint-GUID: 1fn7skZogpSa0c_OyujLOsr1TJ_UnBKf X-Proofpoint-ORIG-GUID: 1fn7skZogpSa0c_OyujLOsr1TJ_UnBKf X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org writes: >This second commit talks about treating a NULL as actually meaning match_a= lways. I've not dug into this beyond looking at those commits, but that se= cond commit does include some code similar to yours, except in that case th= ey've gone with something like: > > if (op->match_func && !(op->match_func) (op, word)) > continue; > >I'd like to see a commit message that references this history, and explain= s why this commit does something different. > >Also, does your change indicate that there exists an instruction encoding = which, if we try to disassemble it, will cause the disassembler to segfault= ? That would be a good candidate for making into a test, maybe in the gas = testsuite? > Looking at the riscv_opcodes[] table in opcodes/riscv-opc.c, we don't need = to modify opcodes/riscv-dis.c. The match_never() has been replaced with NULL for INSN_MACRO types. Thus di= sassembler will never segfault because of following code: @@ -818,7 +818,7 @@ riscv_disassemble_insn (bfd_vma memaddr, if (op->pinfo =3D=3D INSN_MACRO) continue; The segfault happens only in step_once() of sim/riscv/sim-main.c. Regards, Jaydeep