From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sbefMS8rK2XGBS4AWB0awg (envelope-from ) for ; Sat, 14 Oct 2023 19:58:39 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=RuQ9TrcZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BEEE71E0C1; Sat, 14 Oct 2023 19:58:39 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5131F1E091 for ; Sat, 14 Oct 2023 19:58:37 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B73983858C60 for ; Sat, 14 Oct 2023 23:58:36 +0000 (GMT) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2074.outbound.protection.outlook.com [40.107.95.74]) by sourceware.org (Postfix) with ESMTPS id D5B103858D20 for ; Sat, 14 Oct 2023 23:58:22 +0000 (GMT) ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D5B103858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.95.74 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697327905; cv=pass; b=SWsNdngRGm9CMAwJjrN/HW4btdEh1kMic3kCxQpMFXie8K0zu1Q9LuTWc3qUFrNRFPRtWakRyh4uS0CHNbe6tfGLVlIXLTibNPgRAyWuN3osQ9uxSLyOh0iLpBwOed8oxqBu2Iq71xJE8gp8HQvJIS9Pwne60fWgafaBojOjXEw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697327905; c=relaxed/simple; bh=qSiwL+n7o/fd/JkQsrlOEqKi6/WNjZC+jX3b/wqc7pQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=cUFH7Jt3BgneJwv7xVmF+uJkkJst4j84fbmXTYCWh9lNOIm20BfKr6h5bC4SabAdRdwu/BTX1hXJec190euWHmIwcEqPK7g+lwtjndhaLjV6bNk5EvbeTS9b2bmZ/e1AK8vqlgpWrZPFoxoxmLzhKyyjJfAAdjjaGcYh1Fmas9k= ARC-Authentication-Results: i=2; server2.sourceware.org DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D5B103858D20 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nHy9UXzjkQHGKKwdh/YdxhfQeeKm2+pTd2pvZSrIJwswcYZC/BrGLSZga4Aan2ZWcOV0aUZ2nN2dZz/iOF6S0VUpmDsEPwltY0fgqgLfFGxXLQCKAIBqcZBsarGYFQ7tg45EE5DxjuvZkhxW+fk+qsqme/oSsoeftaQZbiV1vyn+H6Dm0j4OcEVoY/diS3NJYbbks+K4JlMIZe4EYRTkp0kWTD55Xa469XxWxy2/XeFcovsjhiTP4sWJUfGC4NP7aPQC+E07+hmvEhF7YSPLMQdI8dQy7fuka0ydO5RYFTAoi0CnKkUhgdD/WQWVH0s+nCrkrZ6lc/1RQCAHCPqY3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tZ0yZ1wzfJfcnpno4ervGiSV34kRD4RKTURkbL8imSw=; b=bozY/qMox1mHkrTd6VW/F57JlCfuu5yhVU2RQjQEf4xizoRysC1FTvJUJp8EcXbjLTaP1NT6H5RYEoQXK4O/JLxL1MYDLYFloaIOm1lKWEHErcJzgpqbv/FzJ6FlwyHmxCQ8Wolsm57tcuzcD58DDGTeaUB/ZI6n8ooCrlF3Jjwuj/x9dPFdXAPbD6/44Qe4dWr34NYiEKLx+whmFkUwK7yPum1LOehRlejjDkPMji02UamikcT+NF3296NDEZeCbi/CXGSyMAMKnLUNkbMrvHUG/KwDzwPI53mGYQD2Th48ilC8GcH10lqNpSOJVVsG4hj7qe/ARLyENtnaVbCUBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tZ0yZ1wzfJfcnpno4ervGiSV34kRD4RKTURkbL8imSw=; b=RuQ9TrcZXnV+BHKpvcNu2F9SWVni2MUA6gufNr0vgdXdmN/3DsA+AOSn5QL3jlawSV192ZffGmB0KUj0eBvToAsHu8hpxfSOI6cIuwYj1DHIHlmWqJ8FmSuiNjLoQc3YgaHDyTE+bO7DZY83i8BbQoyC2Tnkzq+UNUbHPS3a6cE= Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by CYXPR12MB9428.namprd12.prod.outlook.com (2603:10b6:930:d5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.47; Sat, 14 Oct 2023 23:58:20 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::3120:8014:c770:9f8f]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::3120:8014:c770:9f8f%7]) with mapi id 15.20.6863.047; Sat, 14 Oct 2023 23:58:19 +0000 From: "Six, Lancelot" To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 06/11] gdb: Use std::string_view instead of gdb::string_view Thread-Topic: [PATCH 06/11] gdb: Use std::string_view instead of gdb::string_view Thread-Index: AQHZ/ePWhTD8SzXH10Wf1t60ntmhmbBJ1S60gAAjUSA= Date: Sat, 14 Oct 2023 23:58:19 +0000 Message-ID: References: <20231013144418.3180617-1-lancelot.six@amd.com> <20231013144418.3180617-7-lancelot.six@amd.com> <87il78x49e.fsf@tromey.com> In-Reply-To: <87il78x49e.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=f417802e-fdda-4cf1-8061-e8cfa456d7fb; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-14T23:57:07Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR12MB9079:EE_|CYXPR12MB9428:EE_ x-ms-office365-filtering-correlation-id: 637c0d04-baf8-4839-1971-08dbcd11710c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oOSD2kPoh4S2J8OY1GUiiysWjHNaA7N1NI4BWDvlAKqc0X6IfkuPJfnrnXsQfse0V8JHu68ohzLY+ubqkknt+p4ej1EJFJG6cTJKK/swr4LZFDgBm55x9sBLTUmd6m6hg0/sTI+/L1HfSr7jmHPaFRJiSQGtlCKqYUScyEwTLQGYk9L0lZADk50f0AzDZAvPczHZfasb0sJOgVLj32Y5Jm4V29qMD96okHlRvMf1OeVHvpSYnurYMSmH+yheaV2R4yfSMCMbG3eD8sqaTeWCVONsc2c4FP51u79dysimrjPJhyozeEkKvqfPga6aJ2V4FoScm00SjBRVEy5Sfk4qa75ss6fUbBowucvVHCtAsMgIKHxCD9moa5huH0q2wYkxFeZgsQ0EId2+VRlyXKRwbUtBxSoB/uWrtIxULtGsgtKKOTwhw7ptJq71VmEMaEAaRUeQl5qNGfz170KQDDJ2TtbUZoMYqH+tqKhce9ADeENYbOE1FnxM4352H1BWlmOmsBaKBlUNGkhrLeiOw5s9qhB3aRgA3zbPTxonxO2mrWG/kA1p7Km1C3IYA/ZFUjkB/I7+mIzWhS8IlqzhjPED0eFu9NOB/KxYDbhIsewE0i4vX0HoLhhPh/QZY2JGP83N x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(39860400002)(376002)(346002)(366004)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(33656002)(86362001)(55016003)(64756008)(316002)(66476007)(66556008)(66446008)(66946007)(38070700005)(6916009)(38100700002)(122000001)(83380400001)(8676002)(26005)(71200400001)(9686003)(7696005)(6506007)(2906002)(8936002)(4744005)(478600001)(41300700001)(5660300002)(4326008)(52536014)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6WopK/WmD7e9wSkHyQcK4Ybr/iPb0d74q/RlIfsSYWARBaqsZY21M0bpM12a?= =?us-ascii?Q?FPV9EsVBfWcJx6OXatRVvxM8VwAk2wcdlyxDx57ITf410QVUq/s/TfmMrLhA?= =?us-ascii?Q?ThMYJbSuhwqvGPQ1AqPf3kP62ubmWTc3SO5l2PPCFsKZATyynx7Xk7jEJPjB?= =?us-ascii?Q?JwXf9d53NXJXJU05uSGy4i6eC9q68SXeQ6WtDt1isqbJOyJaSLKLGL9EucrP?= =?us-ascii?Q?9ZL+FCJNoxx1P2ilguWqwVxoJ0QKEsS0Ghc+pcadpEj8ti0ERcIhngJyqtF/?= =?us-ascii?Q?GPd2JgmPQR7X13hc/uDo+1saPzjFAVUEk0X+JGCmOPzvFfDLRRdftysDkqok?= =?us-ascii?Q?ki+rFMGFnUetpDH5L01plhAVCVpJzt3ARmL4//OVAwI5lNa4m43CLl6RZ+hg?= =?us-ascii?Q?HpJ2mWih9I596eEGNF+RQswT/uf/jhvTcik12ybnnUcRfJMM7JCcHqWeIorm?= =?us-ascii?Q?g/56H/WlrID0Yd5XVovVJdgrsG+GgsU4OYbtfssLe1fJbEKf39M07NdFuzzO?= =?us-ascii?Q?wHyYBLKwnetZvKtRDeMWAKGc3182G88q3ISSb2TwKVre5fpcUj/e0/0BmUre?= =?us-ascii?Q?oSizPpTwqPkYbaeuKUgSB7qW9m/X21cPuzp+H6hJBhj9FQtVBrPmI7ySNmgm?= =?us-ascii?Q?ZLih8ifi5UKYYFOzq2eEcSNQmOmDMjWwhIZ+mXNNXXHBBwneWr3gJHJC3roB?= =?us-ascii?Q?6napz+7iysWMvmhDR2ZL5iUSqM7+6i2A6IjyuYzL1ZPH2vIy5UOKbEsTyeDK?= =?us-ascii?Q?A2VOMPOZm1nyAImyA6s/GtvIlewXqLq3cTLIeqCh9m8EnUC7filw3mF6x9ws?= =?us-ascii?Q?oXy7t/9zq7Lb+km0SwCMQZFUbRZ6kMHS/Fdpxj03bHzKr3QEe6z0q5jt6u5u?= =?us-ascii?Q?qCUGw34Eucr/gvatuTEaxEzRdJvfT2B+/gJV4AzyHh6FKFWJSMhtlOrkvm2c?= =?us-ascii?Q?d2Mx0MAEos2SjAa3vQc88MwfjFN7yjCd2ovS6TobUk3n9L3tgbsPW/Uyc5Sa?= =?us-ascii?Q?UuMHP+cMxRh+SU9m6PnQIUlO+BQmbdE5IEfOu4qofTedPAhGXdbPMhtTyGii?= =?us-ascii?Q?u8lStFYz7uJr23ClSPHvBBrYPay+KmEM8dqPrRREN4cItcRrzpA+Wtm822nb?= =?us-ascii?Q?UezpKCbUu7i09ag59zS+QxqYHqMoeChFClkSuYLUizNhag9vJXRDyJL+VHB0?= =?us-ascii?Q?2l4zl96mcTRhR/2BwJNyKpfmYR7eTEPuY/wkUVpGKqDRJmZPMIUugvdNlK2S?= =?us-ascii?Q?/ttnhv97NfKRqtssum37yaGRdsOP/G7gBj/BK4nb24aIzckf0AgBuKzoiDEF?= =?us-ascii?Q?/007XlDcZ7meKBqK0ioYsb8GzzrdCeaKNI6ftI4rbthzXHE4XV2bgYXUsvdB?= =?us-ascii?Q?J/QeG/7ceSM3Dz6FuhqQexBnbUdKSxSorPmZxSn/hqz+Dk+Eqr4IEMkBxQmB?= =?us-ascii?Q?qhgUKeeaf9q7EVbcZCKMz9Cm9gPbdsJOU2ue/PKqJlzLb+l9HRWyYicCkQrN?= =?us-ascii?Q?aJNh1WAN39uUkJBvbgBqwcnvnodBgh2jPUYuNnkNEN/uYXOvk4ZPJjKkBsaA?= =?us-ascii?Q?LHSfRGYvOfTsGqfOeCo=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 637c0d04-baf8-4839-1971-08dbcd11710c X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2023 23:58:19.7407 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 56xACN8hcQXNSzh/VG/ZjcWjxbyb7n+JoVOiWCSjYmOoOMf3e3/Y9FsxB/f/PRxlM4376d7PYmRufb4QEwMFfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9428 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org [AMD Official Use Only - General] > Lancelot> The implementation and tests of gdb::string_view are unchanged, > they will > Lancelot> be removed in a following patch. > > IIRC there are some spots using gdb::string_view that construct one with > nullptr, which isn't allowed by std::string_view. Maybe a test run > using the libstdc++ debug mode would detect this? > > Tom I was not aware of this. I'll do re-do regression testing using libstdc++'s= debug mode. Thanks, Lancelot.