From: Shahab Vahedi <Shahab.Vahedi@synopsys.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "palves@redhat.com" <palves@redhat.com>,
"tom@tromey.com" <tom@tromey.com>
Subject: Re: [PATCH 2/2] gdb/tui: Disassembler scrolling of very small programs
Date: Fri, 31 Jan 2020 10:10:00 -0000 [thread overview]
Message-ID: <CH2PR12MB384780E7A1EDF47FFA047B91A6070@CH2PR12MB3847.namprd12.prod.outlook.com> (raw)
In-Reply-To: <3073ce5588097f61f2391bdfad015a31665ce50d.1579900754.git.andrew.burgess@embecosm.com>
Hi Andrew,
The fix is very subtle and works flawlessly. Great job on catching all
the corner cases and putting them in tests.
Cheers,
Shahab
P.S.: For the record, the fix is already merged:
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=42330a681af23a80d3e1f201d2a65886875e74bd
From gdb-patches-return-163673-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Jan 31 10:10:48 2020
Return-Path: <gdb-patches-return-163673-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Delivered-To: listarch-gdb-patches@sources.redhat.com
Received: (qmail 60399 invoked by alias); 31 Jan 2020 10:10:47 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Delivered-To: mailing list gdb-patches@sourceware.org
Received: (qmail 60388 invoked by uid 89); 31 Jan 2020 10:10:47 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 testsºYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=unavailable version=3.3.1 spammyX-HELO: gateway23.websitewelcome.com
Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.218) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Jan 2020 10:10:46 +0000
Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway23.websitewelcome.com (Postfix) with ESMTP id DE81E71AA for <gdb-patches@sourceware.org>; Fri, 31 Jan 2020 04:10:44 -0600 (CST)
Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id xTG8iMkZg4QzmxTG8isUUV; Fri, 31 Jan 2020 04:10:44 -0600
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; sÞfault; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bhUgzmNxffkIRulyNOhGYCRGRstRs0oiK0XQr43RzZps=; b=T3ZZJkZvLoWLN3XyIWE+5hwJ/G 6xwX5+IzithXXZ4c57tMm/zeMfh2r94M6Z1yKr0ZAIeUL/oLr8gxpNGlEGHuvqntgtJAqGmcwJU0R G/ViEtcYVXmDg78jx/htWWTcL;
Received: from [109.236.135.164] (porta610 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from <tom@tromey.com>) id 1ixTG8-001LuG-At; Fri, 31 Jan 2020 03:10:44 -0700
From: Tom Tromey <tom@tromey.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Pedro Alves <palves@redhat.com>, GDB Patches <gdb-patches@sourceware.org>, tom@tromey.com, binutils@sourceware.org
Subject: Re: [PATCH] Adjust src-release.sh's getver due to gdbsupport's move to toplevel
References: <20200128222514.10753-1-sergiodj@redhat.com> <28831a42-3bb1-c232-0d8f-f18c5a4343d5@redhat.com> <87h80erq4y.fsf@redhat.com> <1b752c3b-4f74-f324-6db0-aaf52f3660b5@redhat.com> <87pnf2m3fx.fsf@redhat.com>
Date: Fri, 31 Jan 2020 10:13:00 -0000
In-Reply-To: <87pnf2m3fx.fsf@redhat.com> (Sergio Durigan Junior's message of "Wed, 29 Jan 2020 15:07:46 -0500")
Message-ID: <871rrgylzz.fsf@tromey.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2020-01/txt/msg00987.txt.bz2
Content-length: 104
Sergio> Done.
Sergio> Pushed: fc1ca146f76eea0b76b1392ea1a7aa8fb0742490
Thank you for doing this.
Tom
next prev parent reply other threads:[~2020-01-31 10:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200110115728.13940-1-shahab.vahedi@gmail.com>
2020-01-10 12:53 ` [PATCH v2][PR tui/9765] Fix segfault in asm TUI when reaching end of file Pedro Alves
2020-01-10 13:37 ` [PATCH] Don't let TUI exceptions escape to readline (PR tui/9765) Pedro Alves
2020-01-10 14:31 ` Shahab Vahedi
2020-01-13 20:46 ` [PATCH 2/2] gdb/tui: asm window handles invalid memory and scrolls better Andrew Burgess
2020-01-15 0:57 ` Tom Tromey
2020-01-13 22:04 ` [PATCH 1/2] gdb/tui: Prevent exceptions from trying to cross readline Andrew Burgess
2020-01-15 0:56 ` Tom Tromey
[not found] ` <cover.1578948166.git.andrew.burgess@embecosm.com>
2020-01-14 14:19 ` [PATCH 0/2] gdb/tui: Assembler window scrolling fixes Shahab Vahedi
2020-01-16 0:48 ` [PATCHv2 2/2] gdb/tui: asm window handles invalid memory and scrolls better Andrew Burgess
2020-01-21 16:27 ` Shahab Vahedi
2020-01-22 13:30 ` Shahab Vahedi
2020-01-22 16:32 ` Andrew Burgess
2020-01-22 19:26 ` Pedro Alves
2020-01-16 0:48 ` [PATCHv2 0/2] gdb/tui: Assembler window scrolling fixes Andrew Burgess
2020-01-24 11:22 ` Shahab Vahedi
2020-01-24 21:22 ` [PATCH 0/2] Further Assembler Scrolling Fixes Andrew Burgess
2020-01-24 21:22 ` [PATCH 1/2] gdb/tui: Update help text for scroll commands Andrew Burgess
2020-01-26 16:07 ` Tom Tromey
2020-01-24 21:29 ` [PATCH 2/2] gdb/tui: Disassembler scrolling of very small programs Andrew Burgess
2020-01-26 16:10 ` Tom Tromey
2020-01-31 10:10 ` Shahab Vahedi [this message]
2020-01-16 2:55 ` [PATCHv2 1/2] gdb/tui: Prevent exceptions from trying to cross readline Andrew Burgess
2020-01-10 14:42 ` [PATCH] Don't let TUI exceptions escape to readline (PR tui/9765) Tom Tromey
2020-01-10 13:47 ` [PATCH v2][PR tui/9765] Fix segfault in asm TUI when reaching end of file Shahab Vahedi
2020-01-11 2:00 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH2PR12MB384780E7A1EDF47FFA047B91A6070@CH2PR12MB3847.namprd12.prod.outlook.com \
--to=shahab.vahedi@synopsys.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox