From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3144 invoked by alias); 24 Sep 2012 14:37:40 -0000 Received: (qmail 3036 invoked by uid 22791); 24 Sep 2012 14:37:39 -0000 X-SWARE-Spam-Status: No, hits=-3.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from server-nat-6.cs.umd.edu (HELO bacon.cs.umd.edu) (128.8.127.149) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Sep 2012 14:37:26 +0000 Received: from [10.109.170.227] (129-2-129-154.wireless.umd.edu [129.2.129.154]) (Authenticated sender: khooyp) by bacon.cs.umd.edu (Postfix) with ESMTPSA id A9DF0B40AF0; Mon, 24 Sep 2012 10:37:21 -0400 (EDT) Subject: Re: [PATCH 2/2] Try to initialize data-directory by first searching for "data-directory" in the same directory as the gdb binary Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Khoo Yit Phang In-Reply-To: <836273jy7s.fsf@gnu.org> Date: Mon, 24 Sep 2012 14:37:00 -0000 Cc: Khoo Yit Phang , brobecker@adacore.com, jan.kratochvil@redhat.com, gdb-patches@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <21ACC598-F6B4-4117-BA7B-B316414DE9E3@cs.umd.edu> <20120919130040.GA20442@host2.jankratochvil.net> <20120921183122.GB8747@host2.jankratochvil.net> <20120922110822.GA28159@host2.jankratochvil.net> <78B3333C-92F9-474D-8352-087C5A0F575B@cs.umd.edu> <20120924072945.GA4146@adacore.com> <836273jy7s.fsf@gnu.org> To: Eli Zaretskii X-CSD-MailScanner-ID: A9DF0B40AF0.A313E X-CSD-MailScanner: Found to be clean X-CSD-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-50, required 5, autolearn=not spam, ALL_TRUSTED -50.00) X-CSD-MailScanner-From: khooyp@cs.umd.edu X-CSD-MailScanner-Watermark: 1349102241.89083@zFehNdGpmtDCOE5dQJPsWA Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00502.txt.bz2 Hi, On Sep 24, 2012, at 10:24 AM, Eli Zaretskii wrote: >> From: Khoo Yit Phang >>=20 >> How about this solution, instead of patching the gdb binary, I can insta= ll a shell script into the build directory that contains: >>=20 >> #!/bin/sh >> exec $BUILDDIR/gdb/gdb -data-directory $BUILDDIR/gdb/data-directory "$@" >>=20 >> and call this script "gdb-local" (or alternatively, call this script "gd= b" and the rename the actual binary to "gdb.exe" in the build directory). >=20 > Please don't. Invoking GDB from the build directory should "just > work". What do you mean? If we call the shell script "gdb" (only in the build-dire= ctory, to clarify; it will not be installed to /usr/bin), then it will "jus= t work" in almost all cases, except when running gdb on gdb. If we patch th= e gdb binary and incur the risk that a stray data-directory will lead to bu= gs. The first case is only slightly less convenient for GDB developers, and= the second case is permanent to GDB users when installed. Even before my Python patch, it didn't always "just work", since gdb was pi= cking up the wrong data-directory, and any updates to data-directory (XML s= ignals or Python scripts) would have been missed. Yit September 24, 2012