From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18364 invoked by alias); 19 Jun 2009 14:35:28 -0000 Received: (qmail 18313 invoked by uid 22791); 19 Jun 2009 14:35:25 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Jun 2009 14:35:18 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id BD1CB290047; Fri, 19 Jun 2009 16:35:14 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DjmVoLGaBOVt; Fri, 19 Jun 2009 16:35:14 +0200 (CEST) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id C42DC290038; Fri, 19 Jun 2009 16:35:11 +0200 (CEST) Cc: gdb-patches@sourceware.org Message-Id: From: Tristan Gingold To: Stan Shebs In-Reply-To: <4A11BE08.3090900@codesourcery.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Subject: Re: RFA: makes darwin-nat.c threads (and multi-processes) aware Date: Fri, 19 Jun 2009 14:35:00 -0000 References: <20090319141746.GA81236@ulanbator.act-europe.fr> <4A11BE08.3090900@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00502.txt.bz2 On May 18, 2009, at 9:59 PM, Stan Shebs wrote: > Tristan Gingold wrote: >> Hi, >> >> at AdaCore we have an improved version of darwin-nat.[ch] that is >> in use for a >> few months. It is mostly rewritten to handle threads and multi- >> processes. It >> also handles more corner cases in breakpoints handling. >> >> The number of regression is about 220 (to be compared to about 600 >> for the >> original version). Good progress! >> > Indeed! I've reviewed this (sorry about the delay) and it looks > generally good for committing. I just have a couple nits. > > + /* Current message state. > + If the kernel has sent a message it expects a reply and the > inferior + can't be killed > before. */ > + enum darwin_msg_state { DARWIN_RUNNING, > + DARWIN_STOPPED, > + DARWIN_MESSAGE } msg_state; > I'm not sure if there's official style on this point, but I think > it's better to make enums globally visible. It generally seems to be > the case that someone somewhere will eventually find multiple uses > for the enum values, might as well accommodate them. Now defined globally. > - darwin_ops->to_has_thread_control = tc_schedlock /*| tc_switch > */; + /* darwin_ops- > >to_has_thread_control = tc_schedlock | tc_switch */; > Might as well just whack the whole line. If someone really wants to > know what happened, CVS has the record. Removed (in a later commit - sorry). I have also adjusted machoread.c because one Mach-O bfd declaration has been changed - as obvious. The port has slightly bit-rotten (the number of regressions has increased); I will try to fix that in the following weeks. Thanks, Tristan.