From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128695 invoked by alias); 22 Feb 2019 17:10:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128408 invoked by uid 89); 22 Feb 2019 17:10:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr130080.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (40.107.13.80) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Feb 2019 17:10:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3FbkX6WjJ9g2s3DEGASCiESYzxe0ytgPZdoB8nThQQw=; b=iB10p008o39b8pmdqkhMG4XFZL3v7T3MqnVqTw9Ds0rkjM3aPtWHJe8ZiLS4xn4ldeB+02FUaIJVkeIRInr+h2879Cl20EGGgOPUHCNPqIX8jnwV+x2LOcIPAIZfYbHGc/5Y+VcWpODqWW8QPLBIYjMVIWzTaCMZv9K/el6Uzp0= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2549.eurprd08.prod.outlook.com (10.172.251.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.18; Fri, 22 Feb 2019 17:10:49 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::e974:35a7:c83c:e5b7]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::e974:35a7:c83c:e5b7%3]) with mapi id 15.20.1622.020; Fri, 22 Feb 2019 17:10:49 +0000 From: Alan Hayward To: Pedro Alves CC: Tom Tromey , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Testsuite: Ensure changing directory does not break the log file Date: Fri, 22 Feb 2019 17:10:00 -0000 Message-ID: References: <20190221103420.18162-1-alan.hayward@arm.com> <878sy8bwa5.fsf@tromey.com> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="utf-8" Content-ID: <4B86BB79E238714481E36D6E00DBE67B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00362.txt.bz2 DQoNCj4gT24gMjIgRmViIDIwMTksIGF0IDE0OjIxLCBQZWRybyBBbHZlcyA8 cGFsdmVzQHJlZGhhdC5jb20+IHdyb3RlOg0KPiANCj4gT24gMDIvMjIvMjAx OSAxMjozNiBQTSwgQWxhbiBIYXl3YXJkIHdyb3RlOg0KPj4gKyMgU2FmZSB2 ZXJzaW9uIG9mIGNkIHRoYXQgZW5zdXJlcyB0aGUgbG9nIGZpbGUgaXMgbm90 IHN0b3BwZWQuDQo+IA0KPiBUaGlzIGNvbW1lbnQgc2VlbXMgdW5jbGVhciB0 byBtZSwgaWYgeW91IGRvbid0IGNvbnNpZGVyIHRoZSBlbWFpbCBjb250ZXh0 Lg0KPiANCj4gV2hhdCBkb2VzIGl0IG1lYW4gdG8gInN0b3AgYSBmaWxlIiwg Zm9yIGluc3RhbmNlPw0KPiANCj4gSG93IGFib3V0Og0KPiANCj4gICAjIE92 ZXJyaWRlIHRoZSAnY2QnIGJ1aWx0aW4gd2l0aCBhIHZlcnNpb24gdGhhdCBl bnN1cmVzIHRoYXQgdGhlDQo+ICAgIyBsb2cgZmlsZSBrZWVwcyBwb2ludGlu ZyBhdCB0aGUgc2FtZSBmaWxlLiAgV2UgbmVlZCB0aGlzIGJlY2F1c2UNCj4g ICAjIHVuZm9ydHVuYXRlbHkgdGhlIHBhdGggdG8gdGhlIGxvZyBmaWxlIGlz IHJlY29yZGVkIHVzaW5nIGFuDQo+ICAgIyByZWxhdGl2ZSBwYXRoIG5hbWUs IGFuZCwgd2Ugc29tZXRpbWVzIG5lZWQgdG8gY2xvc2UvcmVvcGVuIHRoZSBs b2cNCj4gICAjIGFmdGVyIGNoYW5naW5nIHRoZSBjdXJyZW50IGRpcmVjdG9y eS4gIFNlZSBnZXRfY29tcGlsZXJfaW5mby4NCj4gDQoNCk9rLCBJ4oCZbSBo YXBweSB3aXRoIHN3aXRjaGluZyB0byB0aGF0LiAgSSB3YW50ZWQgdG8ga2Vl cCB0aGUgY29tbWVudCBhDQpsaXR0bGUgbW9yZSBnZW5lcmljLCBidXQgYWdy ZWVkIGl0IG1ha2VzIG1vcmUgc2Vuc2UgdGhpcyB3YXkuDQoNCg0KQWxhbi4N Cg0KDQo= >From gdb-patches-return-154096-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Feb 22 17:14:29 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 90248 invoked by alias); 22 Feb 2019 17:14:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 90229 invoked by uid 89); 22 Feb 2019 17:14:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=evidence X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr130053.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (40.107.13.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Feb 2019 17:14:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pguryXlahKo5s2bF7TreZkoO1w9FfE2KMN9gCw3n6RY=; b=CHvbHe5PPFYEavZya9KJCVwMUEXtjqcY726Asq05fRjt0UMbaHefJqO7/IO9fLB9iIphoFKyoYmAmUE71d2SCSZcfq/iI0zY3g/h2IYNrPrXarVktYFTV0a3R0sLPcZdOQoTKMxdjLVxScpN4+KFf5/aWidxZ20fMZ9pqEp57Ec= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2549.eurprd08.prod.outlook.com (10.172.251.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.18; Fri, 22 Feb 2019 17:14:23 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::e974:35a7:c83c:e5b7]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::e974:35a7:c83c:e5b7%3]) with mapi id 15.20.1622.020; Fri, 22 Feb 2019 17:14:23 +0000 From: Alan Hayward To: Tom Tromey CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH/RFC] gdbserver: Add command line option to not use SO_REUSEADDR Date: Fri, 22 Feb 2019 17:14:00 -0000 Message-ID: References: <20190212184827.91720-1-alan.hayward@arm.com> <87d0nv5rgu.fsf@tromey.com> In-Reply-To: <87d0nv5rgu.fsf@tromey.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="utf-8" Content-ID: <1567E79DCF7C6E43A43DFA07E9035918@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00363.txt.bz2 Content-length: 2595 DQoNCj4gT24gMTMgRmViIDIwMTksIGF0IDIxOjA1LCBUb20gVHJvbWV5IDx0 b21AdHJvbWV5LmNvbT4gd3JvdGU6DQo+IA0KPj4+Pj4+ICJBbGFuIiA9PSBB bGFuIEhheXdhcmQgPEFsYW4uSGF5d2FyZEBhcm0uY29tPiB3cml0ZXM6DQo+ IA0KPiBBbGFuPiAoTm90IHN1cmUgaWYgdGhlcmUgaXMgYW55IGFkZGl0aW9u YWwgZG9jdW1lbnRhdGlvbiB0aGF0IHdpbGwgbmVlZA0KPiBBbGFuPiAgdXBk YXRpbmcgYWxvbmdzaWRlIHRoaXMgcGF0Y2gsIG9yIGFueSBvdGhlciBhZGRp dGlvbnMgdGhhdCBuZWVkDQo+IEFsYW4+ICB0byBnbyBhbG9uZ3NpZGUgbmV3 IGNvbW1hbmQgbGluZSBmbGFncykuDQo+IA0KPiBUaGVyZSBpcyBzb21lIGRv Y3VtZW50YXRpb24gb24gaW52b2tpbmcgZ2Ric2VydmVyIGluIHRoZSBtYW51 YWwsIHNvIHRoYXQNCj4gc2hvdWxkIGJlIHVwZGF0ZWQuDQoNCk5vdGVkLiBJ 4oCZbGwgcHV0IHRoYXQgaW50byB0aGUgbmV4dCB2ZXJzaW9uLCBvciByYWlz ZSBhbiBhZGRpdGlvbmFsIHBhdGNoLg0KDQo+IA0KPiBBbGFuPiBGb3JjaW5n IG9uIGdkYiBhbmQgZ2Ric2VydmVyIGRlYnVnIHNob3dzIHRoYXQgZm9yIHRo ZSBmYWlsdXJlIGNhc2VzDQo+IEFsYW4+IGdkYnNlcnZlciBpcyBsYXVuY2hl ZCwgY29ubmVjdHMgdG8gZ2RiIGFuZCBzdWNlc3NmdWxseSBzZW5kcyBhbmQN Cj4gQWxhbj4gcmVjZWl2ZXMgcGFja2V0cy4gIE1lYW53aGlsZSBvbiB0aGUg Z2RiIHNpZGUsIG5vIHBhY2tldHMgYXJlIHNlbnQgb3INCj4gQWxhbj4gcmVj ZWl2ZWQgYW5kIHRoZSBjb25uZWN0aW9uIHNpbXBseSB0aW1lcyBvdXQuICBU aGlzIGluZGljYXRlcyB0aGF0DQo+IEFsYW4+IHRoZSBnZGIgZnJvbSBhbm90 aGVyIHJ1bm5pbmcgdGVzdCBoYXMgY29ubmVjdGVkIHRvIHRoaXMgZ2Ric2Vy dmVyLg0KPiANCj4gQ291bGQgeW91IHdhbGsgbWUgdGhyb3VnaCBob3cgdGhp cyBoYXBwZW5zPyAgSXQgc2VlbXMgc3RyYW5nZSB0byBtZSB0aGF0DQo+IHRo ZXJlIGNvdWxkIGJlIGFueSBraW5kIG9mIHJhY2UuICBXaGF0IEkgZG9uJ3Qg dW5kZXJzdGFuZCBpcyB0aGF0IGlmIHR3bw0KPiB0ZXN0cyBjYW4gcnVuIGlu IHBhcmFsbGVsLCBib3RoIHN0YXJ0IGdkYnNlcnZlciwgYW5kIHRoZW4gb25l IGdkYiBjYW4NCj4gY29ubmVjdCB0byB0aGUgd3Jvbmcgc2VydmVyIC0tIHRo ZW4gaXQgc2VlbXMgdG8gbWUgdGhhdCB0aGUgYnVnIG11c3QgYmUNCj4gaW4g dGhlIHRlc3Qgc3VpdGUgaXRzZWxmPw0KPiANCg0KU29ycnksIHRvdGFsbHkg bWlzc2VkIHJlcGx5aW5nIHRvIHRoaXMgcGFydC4gIEnigJlsbCBnYXRoZXIg c29tZSBtb3JlIGV2aWRlbmNlDQphbmQgZ2V0IGJhY2sgdG8geW91IG5leHQg d2Vlay4NCg0KDQoNCj4gQWxhbj4gV2hlbiBydW5uaW5nIHdpdGggLWo1NSBv biBIRUFEDQo+IA0KPiBKZWFsb3VzLg0KPiANCj4gQWxhbj4gMjAxOS0wMi0x MiAgQWxhbiBIYXl3YXJkICA8YWxhbi5oYXl3YXJkQGFybS5jb20+DQo+IEFs YW4+IAkqIHJlbW90ZS11dGlscy5jIChyZW1vdGVfcHJlcGFyZSk6IENoZWNr IHJldXNlIGZsYWcuDQo+IEFsYW4+IAkqIHNlcnZlci5jIChnZGJzZXJ2ZXJf dXNhZ2UpOiBBZGQgcmV1c2UgaGVscCBtZXNzYWdlcy4NCj4gQWxhbj4gCShj YXB0dXJlZF9tYWluKTogQ2hlY2sgZm9yIHJldXNlIGZsYWdzDQo+IEFsYW4+ IAkqIHNlcnZlci5oIChzdHJ1Y3QgY2xpZW50X3N0YXRlKTogQWRkIHJldXNl IGZsYWcuDQo+IA0KPiBGV0lXIHRoZSBjb250ZW50cyBvZiB0aGUgcGF0Y2gg YWxsIHNlZW0gZmluZSB0byBtZS4gIEJ1dCwgSSdkIGxpa2UgdG8NCj4gdW5k ZXJzdGFuZCB0aGUgcHJvYmxlbSBiZXR0ZXIgYmVmb3JlIGFwcHJvdmluZyBp dCAoYW5kIGFsc28gdGhlcmUncyB0aGUNCj4gZG9jdW1lbnRhdGlvbikuDQo+ IA0KPiB0aGFua3MsDQo+IFRvbQ0KDQo= >From gdb-patches-return-154097-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Feb 22 17:16:59 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 102880 invoked by alias); 22 Feb 2019 17:16:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 102819 invoked by uid 89); 22 Feb 2019 17:16:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=sweep X-HELO: mx2.freebsd.org Received: from mx2.freebsd.org (HELO mx2.freebsd.org) (8.8.178.116) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Feb 2019 17:16:57 +0000 Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 9D5B572994; Fri, 22 Feb 2019 17:16:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9B78B76645; Fri, 22 Feb 2019 17:16:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-3.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4F9B416100; Fri, 22 Feb 2019 17:16:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: [RFC] Fix BFD leak in solib-darwin.c To: Tom Tromey , gdb-patches@sourceware.org References: <20190222163645.9349-1-tromey@adacore.com> From: John Baldwin Openpgp: preference=signencrypt Message-ID: <184aefb1-38fc-cc39-0f3a-4bd350c47e11@FreeBSD.org> Date: Fri, 22 Feb 2019 17:16:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190222163645.9349-1-tromey@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 9B78B76645 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.94 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.94)[-0.944,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_LONG(-1.00)[-0.999,0] X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00364.txt.bz2 Content-length: 1567 On 2/22/19 8:36 AM, Tom Tromey wrote: > commit 192b62ce0b4bb5c61188f570e127a26d2c32f716 ("Use class to manage > BFD reference counts") changed darwin_get_dyld_bfd to use: > > + dyld_bfd.release (); > > rather than > > - do_cleanups (cleanup); > > However, using release here leaks the BFD. Instead I believe reset > should be used instead. > > I can't readily test this, so please take a look and let me know what > you think. > > gdb/ChangeLog > 2019-02-22 Tom Tromey > > * solib-darwin.c (darwin_get_dyld_bfd): Use reset, not release. > --- > gdb/ChangeLog | 4 ++++ > gdb/solib-darwin.c | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gdb/solib-darwin.c b/gdb/solib-darwin.c > index d3060604bad..da410ad4660 100644 > --- a/gdb/solib-darwin.c > +++ b/gdb/solib-darwin.c > @@ -455,7 +455,7 @@ darwin_get_dyld_bfd () > if (sub != NULL) > dyld_bfd = sub; > else > - dyld_bfd.release (); > + dyld_bfd.reset (nullptr); > } > return dyld_bfd; > } I haven't tested, but this LGTM. Simon has noticed several instances of this bug where release() was used instead of reset(). (The most recent one was in the build-id separate debug file code that I think hasn't been committed yet.) It might be worth doing a quick sweep of current 'release' calls (if there aren't too many) to check for other leaks. -- John Baldwin                                                                            Â