From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25816 invoked by alias); 2 Dec 2009 11:37:05 -0000 Received: (qmail 25808 invoked by uid 22791); 2 Dec 2009 11:37:04 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Dec 2009 11:36:53 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 3BE85290011; Wed, 2 Dec 2009 12:36:51 +0100 (CET) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XZsPHWz81Qrf; Wed, 2 Dec 2009 12:36:50 +0100 (CET) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id A662A290001; Wed, 2 Dec 2009 12:36:50 +0100 (CET) Subject: Re: [RFA] clean-up of sym_read mainline flag (1/2) Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: text/plain; charset=us-ascii From: Tristan Gingold In-Reply-To: Date: Wed, 02 Dec 2009 11:37:00 -0000 Cc: gdb-patches ml Content-Transfer-Encoding: 7bit Message-Id: References: <41F206A6-E60C-4A55-B4F1-CC1C00626188@adacore.com> To: tromey@redhat.com X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00013.txt.bz2 On Nov 30, 2009, at 9:19 PM, Tom Tromey wrote: >>>>>> "Tristan" == Tristan Gingold writes: > > Tristan> The mainline flag from sym_read routines was passed as argument > Tristan> to functions that doesn't use it. To clean-up a little bit and > Tristan> to make the code more readable, this patch removes this unused > Tristan> parameter. > > This is almost ok. > > Tristan> void > Tristan> -coffstab_build_psymtabs (struct objfile *objfile, int mainline, > Tristan> +coffstab_build_psymtabs (struct objfile *objfile, > Tristan> CORE_ADDR textaddr, unsigned int textsize, > > I spot-checked and noticed that this function (and some others in this > file) documents the 'mainline' parameter in its header comment. These > comments must also be updated. > > This is ok with that change. Please be sure to check all the functions, I have updated the comments too, and I hope I checked all the functions. Thanks, Tristan.