From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8694 invoked by alias); 24 Sep 2012 19:19:43 -0000 Received: (qmail 8683 invoked by uid 22791); 24 Sep 2012 19:19:42 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MIME_QP_LONG_LINE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from server-nat-6.cs.umd.edu (HELO bacon.cs.umd.edu) (128.8.127.149) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Sep 2012 19:19:29 +0000 Received: from [10.109.170.227] (129-2-129-154.wireless.umd.edu [129.2.129.154]) (Authenticated sender: khooyp) by bacon.cs.umd.edu (Postfix) with ESMTPSA id 62966B407AC; Mon, 24 Sep 2012 15:19:27 -0400 (EDT) Subject: [PATCH] Also install data-directory into the build directory as computed by relocate_gdb_directory Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: multipart/mixed; boundary=Apple-Mail-44-839975562 From: Khoo Yit Phang In-Reply-To: <20120924170348.GI4146@adacore.com> Date: Mon, 24 Sep 2012 19:19:00 -0000 Cc: Khoo Yit Phang , Jan Kratochvil , GDB Patches Message-Id: References: <20120922110822.GA28159@host2.jankratochvil.net> <78B3333C-92F9-474D-8352-087C5A0F575B@cs.umd.edu> <20120924072945.GA4146@adacore.com> <20120924145910.GE4146@adacore.com> <2878953E-B698-43F3-989A-A551D96BAB62@cs.umd.edu> <20120924152641.GF4146@adacore.com> <9F52A338-A158-44DC-90C1-F46503859613@cs.umd.edu> <285502C6-1395-4049-9D55-031EDA3AD06D@cs.umd.edu> <20120924170348.GI4146@adacore.com> To: Joel Brobecker X-CSD-MailScanner-ID: 62966B407AC.AF046 X-CSD-MailScanner: Found to be clean X-CSD-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-49.999, required 5, autolearn=not spam, ALL_TRUSTED -50.00, MIME_QP_LONG_LINE 0.00) X-CSD-MailScanner-From: khooyp@cs.umd.edu X-CSD-MailScanner-Watermark: 1349119167.57316@RYv1n3VhqnvojHvF8coyTQ Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00525.txt.bz2 --Apple-Mail-44-839975562 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Content-length: 828 Hi, On Sep 24, 2012, at 1:03 PM, Joel Brobecker wrote: >> Here's yet another alternative: gdb already tries to locate >> data-directory in $BUILDDIR/share/gdb as part of the relocation logic; >> we can install a symlink there that points to >> $BUILDDIR/gdb/data-directory, or make a copy for platforms that don't >> support symlinks. >=20 > Sounds like an interesting idea. We could even do a local install > of the share directory with $BUILDDIR as the prefix, to avoid > duplicating the code, if that helps. But people might complain that > this steps is unnecessary for those who always do an install after > build. I think it's sufficiently negligible to be OK, personally. Here's a first attempt at this. It's quite simple, but it assumes that $GDB= _DATADIR and/or $bindir aren't too unusual. Yit September 24, 2012 --Apple-Mail-44-839975562 Content-Disposition: attachment; filename=builddir-data-directory.txt Content-Type: text/plain; name="builddir-data-directory.txt" Content-Transfer-Encoding: quoted-printable Content-length: 1006 gdb/ChangeLog 2012-09-24 Khoo Yit Phang * data-directory/Makefile.in (all): Also install data-directory into the build directory at the location computed by relocate_gdb_directory when gdb is run from the build directory. diff --git a/gdb/data-directory/Makefile.in b/gdb/data-directory/Makefile.in --- a/gdb/data-directory/Makefile.in +++ b/gdb/data-directory/Makefile.in @@ -95,8 +95,14 @@ "RUNTEST=3D$(RUNTEST)" \ "RUNTESTFLAGS=3D$(RUNTESTFLAGS)" =20 +# Also install data-directory into the build directory at the location +# computed by relocate_gdb_directory when gdb is run from the build direct= ory. .PHONY: all all: stamp-syscalls stamp-python + @$(MAKE) $(FLAGS_TO_PASS) \ + "SYSCALLS_INSTALL_DIR=3D$(top_builddir)/../$(SYSCALLS_INSTALL_DIR:$(pre= fix)/%=3D%)" \ + "PYTHON_INSTALL_DIR=3D$(top_builddir)/../$(PYTHON_INSTALL_DIR:$(prefix)= /%=3D%)" \ + install-only =20 # For portability's sake, we need to handle systems that don't have # symbolic links. --Apple-Mail-44-839975562--