From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33875 invoked by alias); 12 Jun 2018 14:37:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33370 invoked by uid 89); 12 Jun 2018 14:37:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=lawyer, anytime, opinion, staff X-HELO: EUR04-DB3-obe.outbound.protection.outlook.com Received: from mail-eopbgr60065.outbound.protection.outlook.com (HELO EUR04-DB3-obe.outbound.protection.outlook.com) (40.107.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Jun 2018 14:37:42 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) by DB6PR0802MB2310.eurprd08.prod.outlook.com (10.172.228.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.15; Tue, 12 Jun 2018 14:37:39 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::d984:bdee:1856:c64]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::d984:bdee:1856:c64%7]) with mapi id 15.20.0841.019; Tue, 12 Jun 2018 14:37:39 +0000 From: Alan Hayward To: Simon Marchi CC: GDB Patches , Simon Marchi , nd Subject: Re: [PATCH v2 02/10] Add Aarch64 SVE Linux headers Date: Tue, 12 Jun 2018 14:37:00 -0000 Message-ID: References: <20180606151629.36602-1-alan.hayward@arm.com> <20180606151629.36602-3-alan.hayward@arm.com> <9FBBFBF2-9363-49AA-8BC3-20E4E0AFBFED@arm.com> <5862fa9c22cc48d86256686e74d60f20@polymtl.ca> <82743c0795488492486076685b9f8828@polymtl.ca> In-Reply-To: <82743c0795488492486076685b9f8828@polymtl.ca> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: DB6PR0802MB2310: nodisclaimer: True x-exchange-antispam-report-test: UriScan:(244540007438412); x-ms-exchange-senderadcheck: 1 x-forefront-prvs: 07013D7479 received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 313e0bcd-104a-4669-6ebf-08d5d0720c4d X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 313e0bcd-104a-4669-6ebf-08d5d0720c4d X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2018 14:37:39.2442 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2310 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00307.txt.bz2 DQoNCj4gT24gOCBKdW4gMjAxOCwgYXQgMTY6MjMsIFNpbW9uIE1hcmNoaSA8 c2ltb24ubWFyY2hpQHBvbHltdGwuY2E+IHdyb3RlOg0KPiANCj4gT24gMjAx OC0wNi0wOCAxMDozNywgU2ltb24gTWFyY2hpIHdyb3RlOg0KPj4gVGhlIGNv ZGUgbG9va3MgZ29vZCB0byBtZSwgdGhhbmtzLiAgSSBhbSBzdGlsbCB1bnN1 cmUgYWJvdXQgdGhlDQo+PiBsaWNlbnNpbmcgc2lkZSBvZiBpdCwgbGV0IG1l IGFzayB0aGUgRlNGIHBlb3BsZSBhYm91dCBpdCwgSSdsbCBjb21lDQo+PiBi YWNrIHRvIHlvdSB3aGVuIGl0J3MgZG9uZS4gIEkgaG9wZSBpdCB3b24ndCB0 YWtlIHRvbyBsb25nIQ0KPiANCj4gSGkgQWxhbiwNCj4gDQo+IEFmdGVyIGRp c2N1c3Npb24gd2l0aCBvdGhlciBtYWludGFpbmVycywgaXQgd2FzIHN1Z2dl c3RlZCB0byBhdm9pZCBpbnZvbHZpbmcgdGhlIGxlZ2FsIHN0YWZmIGlmIHdl IHdhbnQgdG8gcmVzb2x2ZSB0aGlzIGFueXRpbWUgc29vbi4NCj4gDQo+IFNp bmNlIEFSTSBhbHJlYWR5IGhvbGRzIHRoZSBjb3B5cmlnaHQgdG8gdGhlc2Ug aGVhZGVyIGZpbGVzIGFueXdheSAodGhleSB3ZXJlIGFsbCB3cml0dGVuIGJ5 IEFSTSBwZW9wbGUpLCB5b3UgbWF5IGJlIGFibGUgdG8gc3VibWl0IHRoYXQg Y29kZSBhcyByZWd1bGFyIEZTRi1hc3NpZ25lZCBjb2RlLCB3aXRob3V0IGNo YW5naW5nIHRoZSBzdGF0dXMgb2YgdGhlIGtlcm5lbCBjb3B5LiAgQnV0IG5v Ym9keSBoZXJlIGlzIGEgbGF3eWVyLCBzbyBub2JvZHkgd2FudHMgdG8gc2F5 IGZvciBzdXJlIDopLg0KPiANCj4gTWF5YmUgaXQncyBvayBhZnRlciBhbGwg aWYgd2UgZG9uJ3QgaW5jbHVkZSB0aGVzZSBoZWFkZXJzIChhdCBsZWFzdCBm b3Igbm93KSwgYW5kIHJlcXVpcmUgdGhhdCBHREIgZm9yIG5hdGl2ZSBBQXJj aDY0IGlzIGJ1aWx0IGFnYWluc3QgdGhlIGhlYWRlcnMgb2YgYSA+PSA0LjE1 IGtlcm5lbD8gIFRoZXkgY2FuIGFsd2F5cyBiZSBpbmNsdWRlZCBsYXRlciwg YnV0IGl0IHdvdWxkIGF2b2lkIGRlbGF5aW5nIHRoZSBpbmNsdXNpb24gb2Yg dGhlIGZlYXR1cmUsIHNpbmNlIHlvdSB3YW50IHRvIGhhdmUgaXQgYmVmb3Jl IHdlIGJyYW5jaCA4LjIuDQo+IA0KDQpTb3JyeSwgSSBkaWQgbWlzcyB0aGlz IG9uZSAoSSB0aGluayBJIHNlbnQgbXkgcmVwbHkgdG8gdGhlIHByZXZpb3Vz DQpvbmUgbW9yZSBvciBsZXNzIHRoZSBzYW1lIHRpbWUgeW91IHNlbnQgdGhp cykuDQoNCklmIEkgY29tbWl0IHRoaXMsIChJIHRoaW5rKSB0aGlzIGlzIGdv aW5nIHRvIGNhdXNlIGJ1aWxkYm90IHRvIGJyZWFrDQpmb3IgdGhlIGFhcmNo NjQgYnVpbGRzLg0KKE91dCBvZiBpbnRlcmVzdCAtIEnigJl2ZSBoZWFyZCBw ZW9wbGUgc2F5IHRoZXkgdGVzdGVkIG9uIGJ1aWxkYm90LiBBcmUNCnRoZXJl IHNvbWUgaW5zdHJ1Y3Rpb25zIGZvciBkb2luZyB0aGF0PyBJIGNhbiB0cnkg aXQgb3V0LikNCg0KSSBzdXNwZWN0IHVwZGF0aW5nIGJ1aWxkYm90IGlzIGFs c28gbm90IGEgcXVpY2sgZml4Lg0KDQpJZiBhbGwgdGhhdOKAmXMgbm90IG9r IChJIHN1c3BlY3Qgbm90KSwgSeKAmWxsIGhhdmUgYSBxdWljayB3b3JkIHdp dGggdGhlDQptb3JlIGxlZ2FsIGF3YXJlIHBlb3BsZSBvbiBteSBzaWRlLCBz ZWUgaWYgdGhlcmUgaXMgYW55IG9waW5pb24uDQoNCg0KQWxhbi4NCg0K >From gdb-patches-return-148165-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Jun 12 14:43:23 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 72841 invoked by alias); 12 Jun 2018 14:43:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 72826 invoked by uid 89); 12 Jun 2018 14:43:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=staff X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Jun 2018 14:43:21 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 54648401EF23; Tue, 12 Jun 2018 14:43:20 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 44DE016875; Tue, 12 Jun 2018 14:43:18 +0000 (UTC) Subject: Re: [PATCH v2 02/10] Add Aarch64 SVE Linux headers To: Alan Hayward , Simon Marchi References: <20180606151629.36602-1-alan.hayward@arm.com> <20180606151629.36602-3-alan.hayward@arm.com> <9FBBFBF2-9363-49AA-8BC3-20E4E0AFBFED@arm.com> <5862fa9c22cc48d86256686e74d60f20@polymtl.ca> <82743c0795488492486076685b9f8828@polymtl.ca> Cc: GDB Patches , Simon Marchi , nd From: Pedro Alves Message-ID: <8f6d2b87-707a-3e34-325c-ed9338e9c1f6@redhat.com> Date: Tue, 12 Jun 2018 14:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00308.txt.bz2 Content-length: 1582 On 06/12/2018 03:37 PM, Alan Hayward wrote: > > >> On 8 Jun 2018, at 16:23, Simon Marchi wrote: >> >> On 2018-06-08 10:37, Simon Marchi wrote: >>> The code looks good to me, thanks. I am still unsure about the >>> licensing side of it, let me ask the FSF people about it, I'll come >>> back to you when it's done. I hope it won't take too long! >> >> Hi Alan, >> >> After discussion with other maintainers, it was suggested to avoid involving the legal staff if we want to resolve this anytime soon. >> >> Since ARM already holds the copyright to these header files anyway (they were all written by ARM people), you may be able to submit that code as regular FSF-assigned code, without changing the status of the kernel copy. But nobody here is a lawyer, so nobody wants to say for sure :). >> >> Maybe it's ok after all if we don't include these headers (at least for now), and require that GDB for native AArch64 is built against the headers of a >= 4.15 kernel? They can always be included later, but it would avoid delaying the inclusion of the feature, since you want to have it before we branch 8.2. >> > > Sorry, I did miss this one (I think I sent my reply to the previous > one more or less the same time you sent this). > > If I commit this, What's "this" ? How about we add a configure check to check if the system headers support the needed SVE bits, and guard the native gdb SVE bits with HAVE_AARCH64_SVE or something like that? (I think) this is going to cause buildbot to break > for the aarch64 builds. Thanks, Pedro Alves