From: 傅继晗 <fjhhz1997@gmail.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] Modify python-config.py or replace it with official one to support python3
Date: Mon, 20 Jan 2020 15:05:00 -0000 [thread overview]
Message-ID: <CAPwS6qMKW+PzjHQiLM19aDy-8=rFO8aF9WMiRS=nOjK=iJaSzQ@mail.gmail.com> (raw)
In-Reply-To: <CAPwS6qN9iHy=4XrXCf8AhEw=NY3G9T2=9-3iHn0iaotXQ4TVQg@mail.gmail.com>
The formal patch only works on OSX.And here is the patch to make the
crossbuild available.
diff --git a/gdb/configure-origin b/gdb/configure
--- a/gdb/configure-origin
+++ b/gdb/configure
@@ -9858,21 +9858,21 @@ fi
# We have a python program to use, but it may be too old.
# Don't flag an error for --with-python=auto (the default).
have_python_config=yes
- python_includes=`${python_prog} ${srcdir}/python/python-config.py --includes`
+ python_includes=`${python_prog}-config --includes`
if test $? != 0; then
have_python_config=failed
if test "${with_python}" != auto; then
as_fn_error "failure running python-config --includes" "$LINENO" 5
fi
fi
- python_libs=`${python_prog} ${srcdir}/python/python-config.py --ldflags`
+ python_libs=`${python_prog}-config --ldflags`
if test $? != 0; then
have_python_config=failed
if test "${with_python}" != auto; then
as_fn_error "failure running python-config --ldflags" "$LINENO" 5
fi
fi
- python_prefix=`${python_prog} ${srcdir}/python/python-config.py --exec-prefix`
+ python_prefix=`${python_prog}-config --exec-prefix`
if test $? != 0; then
have_python_config=failed
if test "${with_python}" != auto; then
傅继晗 <fjhhz1997@gmail.com> 于2020年1月20日周一 下午8:02写道：
>
> By default,gdb is compiled with python2 script support on OSX. However,when compiled with arg "--with-python=/path/to/python3 " to support python3 ,some error occurred that seems python3 is not recognized.
> The reason is that the python-config.py is not the same as the official one.BTW,this issue was once referred at 20 Dec 2012 mail :https://sourceware.org/ml/gdb-patches/2012-12/msg00751.html.
> Somehow,It is not committed(maybe the maintainer forgot it due to the happy chrismas holiday).
> And here is my patch:
>
> index: b/gdb/python/python-config.py
> ===============================
> --- a/gdb/python/python-config.py
> +++ b/gdb/python/python-config.py
> @@ -72,7 +72,7 @@ for opt in opt_flags:
> libs.insert(0, '-L' + getvar('LIBPL'))
> elif os.name == 'nt':
> libs.insert(0, '-L' + sysconfig.PREFIX + '/libs')
> - if getvar('LINKFORSHARED') is not None:
> + if not getvar('PYTHONFRAMEWORK'):
> libs.extend(getvar('LINKFORSHARED').split())
> print (to_unix_path(' '.join(libs)))
next prev parent reply other threads:[~2020-01-20 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 14:05 傅继晗
2020-01-20 15:05 ` 傅继晗 [this message]
2020-01-21 1:31 ` Christian Biesinger via gdb-patches
[not found] ` <CAPwS6qOtjH-g88iy7DmUoMyUO1F7O+vZQWoWNZfzZoVkSJ=qtQ@mail.gmail.com>
2020-01-22 2:04 ` 傅继晗
2020-01-22 2:16 ` 傅继晗
2020-01-22 6:12 ` 傅继晗
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPwS6qMKW+PzjHQiLM19aDy-8=rFO8aF9WMiRS=nOjK=iJaSzQ@mail.gmail.com' \
--to=fjhhz1997@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox