From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17555 invoked by alias); 4 Aug 2012 05:55:29 -0000 Received: (qmail 17547 invoked by uid 22791); 4 Aug 2012 05:55:27 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-we0-f169.google.com (HELO mail-we0-f169.google.com) (74.125.82.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 04 Aug 2012 05:55:11 +0000 Received: by weys10 with SMTP id s10so1000314wey.0 for ; Fri, 03 Aug 2012 22:55:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.217.2.133 with SMTP id p5mr2149252wes.143.1344059710261; Fri, 03 Aug 2012 22:55:10 -0700 (PDT) Received: by 10.217.1.148 with HTTP; Fri, 3 Aug 2012 22:55:10 -0700 (PDT) In-Reply-To: <87sjcisgyj.fsf@fleche.redhat.com> References: <20120705140038.GB27886@host2.jankratochvil.net> <87d34arsf3.fsf@fleche.redhat.com> <20120707061655.GA28438@host2.jankratochvil.net> <20120722163408.GA20790@host2.jankratochvil.net> <20120722164948.GA20982@host2.jankratochvil.net> <87sjcisgyj.fsf@fleche.redhat.com> Date: Sat, 04 Aug 2012 05:55:00 -0000 Message-ID: Subject: Re: [PATCH] cd command defaults to ~ From: Nathaniel Flath To: Tom Tromey Cc: Jan Kratochvil , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00132.txt.bz2 Sorry for the late reply again. In any case, I've done FSF assignment for Emacs. Patch w/ recommended updates follows: ChangeLog gdb/ 2012-07-21 Nathaniel Flath * NEWS: New entry for 'cd' default parameters. * cli/cli-cmds.c (cd_command): Replace error_no_arg by DIR assignment. doc/ 2012-07-21 Nathaniel Flath * gdb.texinfo (Working Directory): Added information about new default argument for 'cd' command. index: NEWS =================================================================== RCS file: /cvs/src/src/gdb/NEWS,v retrieving revision 1.533 diff -u -r1.533 NEWS --- NEWS 4 Jul 2012 20:49:56 -0000 1.533 +++ NEWS 7 Jul 2012 04:28:05 -0000 @@ -3,6 +3,8 @@ *** Changes since GDB 7.4 +* The 'cd' command now defaults to using '~'(the home directory) if not given an argument. + * GDB now supports x32 ABI. Visit for more x32 ABI info. Index: cli/cli-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v retrieving revision 1.131 diff -u -r1.131 cli-cmds.c --- cli/cli-cmds.c 13 Jun 2012 15:47:15 -0000 1.131 +++ cli/cli-cmds.c 7 Jul 2012 04:28:05 -0000 @@ -367,7 +367,7 @@ dont_repeat (); if (dir == 0) - error_no_arg (_("new working directory")); + dir = "~"; dir = tilde_expand (dir); make_cleanup (xfree, dir); Index: doc/gdb.texinfo =================================================================== RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v retrieving revision 1.990 diff -u -r1.990 gdb.texinfo --- doc/gdb.texinfo 5 Jul 2012 01:08:24 -0000 1.990 +++ doc/gdb.texinfo 7 Jul 2012 04:28:06 -0000 @@ -2275,7 +2275,8 @@ @kindex cd @cindex change working directory -@item cd @var{directory} -Set the @value{GDBN} working directory to @var{directory}. +@item cd @r{[}@var{directory}@r{]} +Set the @value{GDBN} working directory to @var{directory}. If not +given, +@var{directory} uses @file'~'. @kindex pwd @item pwd On Mon, Jul 23, 2012 at 7:13 AM, Tom Tromey wrote: >>>>>> "Jan" == Jan Kratochvil writes: > > Jan> I guess Tom assumes no FSF copyright assignment is needed for this > Jan> patch, Tom? > > I think it is small enough. > > Tom