From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CtOfLasxf2exywcAWB0awg (envelope-from ) for ; Wed, 08 Jan 2025 21:17:15 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=lfMjpAV0; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A15F21E0C0; Wed, 8 Jan 2025 21:17:15 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 44C2A1E091 for ; Wed, 8 Jan 2025 21:17:14 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 97F5D3858C60 for ; Thu, 9 Jan 2025 02:17:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 97F5D3858C60 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=lfMjpAV0 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 5E35B3858D39 for ; Thu, 9 Jan 2025 02:14:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E35B3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5E35B3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::629 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736388865; cv=none; b=k0Jz3H4BL+UFmnHJ0oXH2w7djvSy4pvXXbyJH/gR4+AVIJs3W6SKeLhDaMEsKooaVOTGKFBck1yyj2YN6CML6PVSsu15zYAVaSI0SfN2v/5z+FKRW4fHpLGZc5xONFzS+L1mwrGCH1LHHS/ze7/Pu6RWEHS80s9QQO9bZ8onW3s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736388865; c=relaxed/simple; bh=vskDTrkPLF/LO+XodnPmnR2kUqU4sSffN2ZGTu2x5Z4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=LwI1gc6mDrD0yeCerqxYJJ9Lt0ZhnpS0G3dEKshPPx/Kh88FMvHKOoRUDtmaA3EOwTSDT3yXMw491gPpxXYeg2KHvkQNW/NRhR3BUE/pMd98mp9yABKXmWFIPTtcXsfEYwcWwkyTgy65luOMo71vcA42AeU3rDGpmWmsVyPptrI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E35B3858D39 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-2166360285dso6055255ad.1 for ; Wed, 08 Jan 2025 18:14:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1736388859; x=1736993659; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BPdwuaMhCzqtQ5SNVi6ThBSNhHvWY+MQx/WcSUhyk4E=; b=lfMjpAV0Uv8FLFHdJkoQ5ZFgwL8rht9ksXhSxTK2dLppSEyQx74sO3hmAx6H6haEM1 mZHQsWQN229uRGUOMkhPQbkLpNlN2wUTh/3aAeTrygESEkRMZxKPXkx7krvg2CxfGLdh uzTunXmtyYO7lqNNuy/AhoCeGPzLU8iG/dtoGwKIlr2qEwzrPvLgv4nrhi/h1xIr7dX2 D23c9HmsBVXTOM/oAKKCXHhJgQNf44eggba8JvM0UtNuu8gA7xeTxZpql+CAs5aI/XzR is/YnxyNzT7qAAar5rxeWiUrod1I7IUeX1xNgecqC7BeZxw0T/D3evZsn0v0adqg1Mvy TPCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736388859; x=1736993659; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BPdwuaMhCzqtQ5SNVi6ThBSNhHvWY+MQx/WcSUhyk4E=; b=IZAtqfoqs6EGadJkBDEeEDRFyEs8ebY49+cZXwn+gihRmgw25uCS4IE1MWal/Fr3vB k3To6aZdXGg3HU5B0UlmrMSdE2k2kQXKAxfk8VoWHbqvaCcxyB3CgC9GXGW7x4uAJrch Q5yONtS8JOJYYl995620Qs+w2YgLFLdXc7iYseA6R/Pf28AcdZedxvo9J43qbSCHpBfn NlVvvtipXhUs9WgZf3LaVYo8KE+FAkGihLykXqN/Wdwa/zAUR2ChvtbNyw15KWArwiYE a5GARwQ96UvOC2P3S02G7+MwiqUBsjwnsD6K30n6ttwZ8fOeDnFKFermZART1AUG1qdD Jlcg== X-Forwarded-Encrypted: i=1; AJvYcCVRoXHDqJZBirDcJOKotNNwrTmZSX+G8i2C5Xdwmb6CTyh+oWrQX+Na8sflLHaaDh4N+wgODRMpcbeCGg==@sourceware.org X-Gm-Message-State: AOJu0YzSyf0lvAZWUFEJrwOb7xVRzH3kqgdJ7eHLkNJl6z4gGy8CtAFe qIs1ZNJiLtUpZfj3w/8V3ioPnOS0VI1WR7Wkw4gHBe32NhpNixtP2AsgVFnbP+p8qL8IvTYEzDb PteWeRkZQgGr63qgkkgg3RXUcD/97TlL484Oq3Q== X-Gm-Gg: ASbGnctoH9OYPNEbRqGW9Qc9VjopP3CiwU6wp+ou3NB29yjVzvqEH7MpcYJUPw0CVoU qGDQqOVfcRBIDlyfLvHcqXUqgu2YWq3QLFYTS X-Google-Smtp-Source: AGHT+IF7mp9OgpOo3nyhKoFKX6luI0u2hj1GTcK2wyZvNFYtqC3skHPbkbq54/JhSJ7NRSTzEF9Ue3tjwSP83HBnCYA= X-Received: by 2002:a05:6a21:2d09:b0:1e0:d1db:4d8a with SMTP id adf61e73a8af0-1e88d0edac9mr7755479637.10.1736388859395; Wed, 08 Jan 2025 18:14:19 -0800 (PST) MIME-Version: 1.0 References: <20241216-fix_objdump_partial_insn-v2-1-8de88a115dbc@rivosinc.com> <87h66c2pzz.fsf@redhat.com> In-Reply-To: <87h66c2pzz.fsf@redhat.com> From: Nelson Chu Date: Thu, 9 Jan 2025 10:14:08 +0800 X-Gm-Features: AbW1kvaWTxaDeNSYkjo15l1UaXph7P_t7KB7xHBS2dZ8a-uE-ky2rTBs4VA5ZA8 Message-ID: Subject: Re: [PATCH v2] RISC-V: Fix disassembly of partial instructions To: Andrew Burgess Cc: Charlie Jenkins , jiawei , gdb-patches , Binutils , Jan Beulich Content-Type: multipart/alternative; boundary="00000000000028173c062b3c8990" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --00000000000028173c062b3c8990 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks Andrew, Jan, and Maciej. I see the newest v4 patches, including test cases, so I committed them after passed the regressions. Thanks Nelson On Mon, Jan 6, 2025 at 6:31=E2=80=AFPM Andrew Burgess = wrote: > Nelson Chu writes: > > > Some minor GNU coding styles as follows. Also cc Jan and Andrew, hope > they > > still have time in their busy schedules can help to see if there are so= me > > side effects. > > I caught up on this thread today. All the suggestions seem like good > advice to me. But I have no issues with the underlying fix, it seems > like a good improvement to me. > > Acked-By: Andrew Burgess > > Thanks, > Andrew > > --00000000000028173c062b3c8990 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks Andrew, Jan, and Maciej.

I see the newest v4 patches, including test cases, so = I committed them after passed the regressions.

Tha= nks
Nelson

On Mon, Jan 6, 2025 at 6:31=E2=80=AFPM Andrew Burgess &= lt;aburgess@redhat= .com> wrote:
Nelson Chu <nelson@rivosinc.com> writes:

> Some minor GNU coding styles as follows.=C2=A0 Also cc Jan and Andrew,= hope they
> still have time in their busy schedules can help to see if there are s= ome
> side effects.

I caught up on this thread today.=C2=A0 All the suggestions seem like good<= br> advice to me.=C2=A0 But I have no issues with the underlying fix, it seems<= br> like a good improvement to me.

Acked-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew

--00000000000028173c062b3c8990--