From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32925 invoked by alias); 14 Jul 2017 15:19:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32915 invoked by uid 89); 14 Jul 2017 15:19:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.2 spammy=UD:pobox.com, H*RU:sk:mail-io, H*r:sk:mail-io, convey X-HELO: sasl.smtp.pobox.com Received: from pb-smtp2.pobox.com (HELO sasl.smtp.pobox.com) (64.147.108.71) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Jul 2017 15:19:41 +0000 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 0E97B8A089 for ; Fri, 14 Jul 2017 11:19:39 -0400 (EDT) Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 07A8F8A088 for ; Fri, 14 Jul 2017 11:19:39 -0400 (EDT) Received: from mail-io0-f178.google.com (unknown [209.85.223.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 84A2C8A085 for ; Fri, 14 Jul 2017 11:19:38 -0400 (EDT) Received: by mail-io0-f178.google.com with SMTP id h64so16031239iod.0 for ; Fri, 14 Jul 2017 08:19:38 -0700 (PDT) X-Gm-Message-State: AIVw111TuPKsnBzXQHa8H1h7aeWaEDzKeMUhDn48VJ3/B4FSxuctavJI CoYtpZWG9kdHJ3uT3golD+y40/v8uQ== X-Received: by 10.107.141.74 with SMTP id p71mr8896924iod.175.1500045578009; Fri, 14 Jul 2017 08:19:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.154.85 with HTTP; Fri, 14 Jul 2017 08:18:57 -0700 (PDT) In-Reply-To: <20170713123400.28917-2-tom@tromey.com> References: <20170713123400.28917-1-tom@tromey.com> <20170713123400.28917-2-tom@tromey.com> From: Jonah Graham Date: Fri, 14 Jul 2017 15:19:00 -0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFA 1/2] Fix two regressions in scalar printing To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Pobox-Relay-ID: DA1289F4-68A7-11E7-A234-61520C78B957-18936988!pb-smtp2.pobox.com X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00187.txt.bz2 On 13 July 2017 at 13:33, Tom Tromey wrote: > > PR gdb/21675 points out a few regressions in scalar printing. > > One type of regression is due to not carrying over the old handling of > floating point printing -- where a format like "/x" causes a floating > point number to first be cast to integer. While this behavior does not > seem very useful to me, apparently at least one person is testing for > it, and we did agree in the earlier thread to preserve this. So, this > patch extends this behavior to the 'd' and 'u' formats. While Eclipse CDT is testing for this format, speaking as an Eclipse CDT committer, the Eclipse CDT community should be happy to change the behaviour if the GDB community is. The tests purpose in Eclipse CDT is to ensure that there is proper communication between CDT and GDB over MI. Personally I would prefer changes like this to be on major version number changes, but I am not intimately familiar with what GDB version numbers are intending to convey to users. > The other regression is a longstanding bug in print_octal_chars: one of > the constants was wrong. This patch fixes the constant and adds static > asserts to help catch this sort of error. In filing gdb/21675 I seem to have combined two issues that I thought were the same cause (due to having both been triggered by the same GDB change). This part of the bug is the problematic one.