From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Vev4INRLcmDAWwAAWB0awg (envelope-from ) for ; Sat, 10 Apr 2021 21:07:32 -0400 Received: by simark.ca (Postfix, from userid 112) id 7D4061EE1B; Sat, 10 Apr 2021 21:07:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 779F21E01F for ; Sat, 10 Apr 2021 21:07:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B45D1388F015; Sun, 11 Apr 2021 01:07:30 +0000 (GMT) Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by sourceware.org (Postfix) with ESMTPS id 23843386100F for ; Sun, 11 Apr 2021 01:07:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 23843386100F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kichwacoders.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=jonah@kichwacoders.com Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 1854BB8409 for ; Sat, 10 Apr 2021 21:07:25 -0400 (EDT) (envelope-from jonah@kichwacoders.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=mime-version :references:in-reply-to:from:date:message-id:subject:to:cc :content-type; s=sasl; bh=YsWm2R0+vSC08mnVtboT5NACn4k=; b=W8ql1M QtMfg9HR8LNLjHU7jyFNcy14HJKBy34wHE98m17+pF6k4enve2qMIWANEJGeJYyu jPzdSSFwy8nROh1bK97YasKLAWYsBvggQ5ArDRLRlXHkRD0z3OB8NMoh5KeRzfEr yznxFw7C3WGgp0no0jjB5NxZJ1APQ1KFke9W0= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 0EBF3B8408 for ; Sat, 10 Apr 2021 21:07:25 -0400 (EDT) (envelope-from jonah@kichwacoders.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kichwacoders.com; h=mime-version:references:in-reply-to:from:date:message-id:subject:to:cc:content-type; s=mesmtp; bh=HahdId1+Eds2TLP+Q4lTa6mrS45e2ewdSDt+FUfKpNk=; b=LkDQKt2ZGVtzljlQptWzDak5HNy7+RgYpk/SAEBbkMSglIfxz7JAAOgyEEaDZaMLGYmqLwWPDESQVrKVtaltg2RtCdg674CHByPykXmPdmmMp1Y6I3dgOOxo5k6ALoolGBjNaPYakanD7csbTPwjjcqAdzLUg2lhkVqDBc13QJk= Received: from mail-wm1-f49.google.com (unknown [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 459EAB8403 for ; Sat, 10 Apr 2021 21:07:24 -0400 (EDT) (envelope-from jonah@kichwacoders.com) Received: by mail-wm1-f49.google.com with SMTP id y124-20020a1c32820000b029010c93864955so6657422wmy.5 for ; Sat, 10 Apr 2021 18:07:24 -0700 (PDT) X-Gm-Message-State: AOAM533xYyKRR9LjYKdpBENKFfLVNDWNOTQ7LjK8UpS/yUGfscGbg6rw tSmDVSsO6R1IsM35AzJdgrDQwsd5HmrB8CuwyYg= X-Google-Smtp-Source: ABdhPJxYO37sdn93lCX9/sxnEPXEUMbP4ZNNd7Dpy+DzJvrmBgeEDuCLGefnCyRHd6DgL10N8oARIN6omnjp5tbgjm8= X-Received: by 2002:a7b:c047:: with SMTP id u7mr20263709wmc.98.1618103243265; Sat, 10 Apr 2021 18:07:23 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonah Graham Date: Sat, 10 Apr 2021 21:06:47 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 4/4] gdb/mi: add a '--force-condition' flag to the '-break-insert' cmd To: Tankut Baris Aktemur X-Pobox-Relay-ID: 465ED14A-9A62-11EB-8BDD-74DE23BA3BAF-18936988!pb-smtp2.pobox.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Thu, 8 Apr 2021 at 10:23, Tankut Baris Aktemur < tankut.baris.aktemur@intel.com> wrote: > Add a '--force-condition' flag to the '-break-insert' command to be > able to force conditions. The '-break-condition' command directly > uses the CLI's 'cond' command; hence, it already recognizes the > '-force' flag. > > Because the '-dprintf-insert' command uses the same mechanism as the > '-break-insert' command, it obtains the '--force-condition' flag, too. > I don't know whether it matters, but in (MI) -break-condition, (CLI) break, and (CLI) condition the force flag starts with one dash, but in (MI) -break-insert/-dprintf-insert it starts with two dashes. I think there is a convention that the MI long option names start with two dashes, so -break-condition should probably accept --force for consistency. The CLI certainly doesn't seem to have such a consistency AFAIU. Thanks Jonah >