From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sMg0FhmM62BbXQAAWB0awg (envelope-from ) for ; Sun, 11 Jul 2021 20:26:01 -0400 Received: by simark.ca (Postfix, from userid 112) id 584281EDEE; Sun, 11 Jul 2021 20:26:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 860351E01B for ; Sun, 11 Jul 2021 20:26:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1E6F0384C001 for ; Mon, 12 Jul 2021 00:26:00 +0000 (GMT) Received: from pb-smtp20.pobox.com (pb-smtp20.pobox.com [173.228.157.52]) by sourceware.org (Postfix) with ESMTPS id 0496F3854834 for ; Mon, 12 Jul 2021 00:25:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0496F3854834 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kichwacoders.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=kichwacoders.com Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 34865146BFE for ; Sun, 11 Jul 2021 20:25:48 -0400 (EDT) (envelope-from jonah@kichwacoders.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h= mime-version:references:in-reply-to:from:date:message-id:subject :to:cc:content-type; s=sasl; bh=bROXLHRPrkRk3Dl6CvHiMhKQ0A++UUKM BFI6HLD0bFg=; b=OPLMuWBOV8wYyvYlr5XUjq15ofnBCxJTmZTIp5EOp64n+CRD nulnAF97hnvBTD7mJ7qiUFF9hzLsWwjUwR9pXUfwVyWu15jzWtGJfU6xhBu3UU9u 22+rkwP1wNLk4p7cMqEf9LQg9uL2WoBJeUutXjJFQ0ZiQQ6bGceXCfxe93c= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 2D859146BFD for ; Sun, 11 Jul 2021 20:25:48 -0400 (EDT) (envelope-from jonah@kichwacoders.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kichwacoders.com; h=mime-version:references:in-reply-to:from:date:message-id:subject:to:cc:content-type; s=mesmtp; bh=bROXLHRPrkRk3Dl6CvHiMhKQ0A++UUKMBFI6HLD0bFg=; b=HdnzFPmRR9nlH0GoMUbG8hm8JeArtE9YwM1087anED52skeFtI9dwOLWVfexwNxCJzFFUv00u/6vMRok4zOPXBcgbswLOSYrClvjpsPHknoTQ+OLouxAE8ebxOz036IsEzDhR+npoZRd+Amg48XcfcuhwYyzW+nJBvU8JxT6T1k= Received: from mail-wr1-f42.google.com (unknown [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id CDAA4146BFB for ; Sun, 11 Jul 2021 20:25:44 -0400 (EDT) (envelope-from jonah@kichwacoders.com) Received: by mail-wr1-f42.google.com with SMTP id p8so22761729wrr.1 for ; Sun, 11 Jul 2021 17:25:44 -0700 (PDT) X-Gm-Message-State: AOAM533HQL+CgfW1BQOwUN82yfojWjxjZPnJweeaq6vKZA7aKnB8QYep XShX+oz5fUflcL48/TK/0oD+Tpl2k8Uvt71lRqM= X-Google-Smtp-Source: ABdhPJzhTP/7tRlLipFHfsuApVAdwRrrRlAH3GiIp7lWfA9ltcjWr2X2jauTB1MhmGv+uAk+OG2yqN4/TLg0/aW5XAw= X-Received: by 2002:adf:b605:: with SMTP id f5mr55659371wre.419.1626049543087; Sun, 11 Jul 2021 17:25:43 -0700 (PDT) MIME-Version: 1.0 References: <0da0d85b-e5c8-7c4a-b428-0f6f7ff6e404@polymtl.ca> In-Reply-To: From: Jonah Graham Date: Sun, 11 Jul 2021 20:25:07 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/2] gdb/mi: add a '--force' flag to the '-break-condition' command To: Simon Marchi X-Pobox-Relay-ID: B296A148-E2A7-11EB-8DC5-D5C30F5B5667-18936988!pb-smtp20.pobox.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" ~~~ Jonah Graham Kichwa Coders www.kichwacoders.com On Sun, 11 Jul 2021 at 14:51, Jonah Graham wrote: > On Wed, 5 May 2021 at 22:46, Simon Marchi wrote: > >> > + /* There must be at least two more args: a bpnum and a condition >> > + expression. */ >> > + if (oind + 1 >= argc) >> > + error (_("-break-condition: Missing arguments")); >> >> I don't know what the standard is for MI commands, but it would be handy >> for somebody trying this by hand to say what are the expected arguments >> in the error message. >> > > Hi Baris and Simon, > > Sorry I didn't catch this earlier, but this change breaks removing > conditions from MI. "-break-condition 2" should remove the condition for > breakpoint 2, same as "condition 2" at CLI does. Instead an error message > is returned: > > ^error,msg="-break-condition: Missing the and/or argument" > > which corresponds to the updated error message that was actually committed. > > I raised https://sourceware.org/bugzilla/show_bug.cgi?id=28076 to track > this. > > Jonah > PS. If you have a patch that you want me to run the Eclipse CDT testsuite on, please cc me on the patch. Jonah > > > > > >> >> Otherwise, LGTM, thanks! >> >> Simon >> >