Re: [PATCH v2 4/4] gdb/mi: add a '--force-condition' flag to the '-break-insert' cmd

Simon Marchi via Gdb-patches
2021-04-11T01:13:07Z

On 2021-04-10 9:06 p.m., Jonah Graham wrote:> On Thu, 8 Apr 2021 at 10:23, Tankut Baris Aktemur <
> tankut.baris.aktemur@intel.com> wrote:
>
>> Add a '--force-condition' flag to the '-break-insert' command to be
>> able to force conditions. The '-break-condition' command directly
>> uses the CLI's 'cond' command; hence, it already recognizes the
>> '-force' flag.
>>
>> Because the '-dprintf-insert' command uses the same mechanism as the
>> '-break-insert' command, it obtains the '--force-condition' flag, too.
>>
>
> I don't know whether it matters, but in (MI) -break-condition, (CLI) break,
> and (CLI) condition the force flag starts with one dash, but in (MI)
> -break-insert/-dprintf-insert it starts with two dashes.
>
> I think there is a convention that the MI long option names start with two
> dashes, so -break-condition should probably accept --force for consistency.
> The CLI certainly doesn't seem to have such a consistency AFAIU.

Good point, I think we should make -break-condition use --force. Since
it wasn't released yet, we can still change it.

Simon