Re: [PATCH v4 2/2] gdb/mi: add a '--force' flag to the '-break-condition' command

Jonah Graham
2021-07-11T18:52:57Z

On Wed, 5 May 2021 at 22:46, Simon Marchi <simon.marchi@polymtl.ca> wrote:

> > + /* There must be at least two more args: a bpnum and a condition
> > + expression. */
> > + if (oind + 1 >= argc)
> > + error (_("-break-condition: Missing arguments"));
>
> I don't know what the standard is for MI commands, but it would be handy
> for somebody trying this by hand to say what are the expected arguments
> in the error message.
>

Hi Baris and Simon,

Sorry I didn't catch this earlier, but this change breaks removing
conditions from MI. "-break-condition 2" should remove the condition for
breakpoint 2, same as "condition 2" at CLI does. Instead an error message
is returned:

^error,msg="-break-condition: Missing the <number> and/or <expr> argument"

which corresponds to the updated error message that was actually committed.

I raised https://sourceware.org/bugzilla/show_bug.cgi?id=28076 to track
this.

Jonah

>
> Otherwise, LGTM, thanks!
>
> Simon
>