Re: [PATCH v4 2/2] gdb/breakpoint: add flags to 'condition' and 'break' commands to force condition

Eli Zaretskii via Gdb-patches
2020-10-13T15:08:49Z

> Date: Tue, 13 Oct 2020 14:25:03 +0200
> From: Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org>
> Cc: simark@simark.ca
>
> gdb/ChangeLog:
> 2020-07-31 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
>
> * breakpoint.h (set_breakpoint_condition): Add a new bool parameter.
> * breakpoint.c: Update the help text of the 'condition' and 'break'
> commands.
> (set_breakpoint_condition): Take a new bool parameter
> to control whether condition definition should be forced even when
> the condition expression is invalid in all of the current locations.
> (condition_command): Update the call to 'set_breakpoint_condition'.
> (find_condition_and_thread): Take the "-force-condition" flag into
> account.
> * linespec.c (linespec_keywords): Add "-force-condition" as an
> element.
> (FORCE_KEYWORD_INDEX): New #define.
> (linespec_lexer_lex_keyword): Update to consider "-force-condition"
> as a keyword.
> * ada-lang.c (create_ada_exception_catchpoint): Ditto.
> * guile/scm-breakpoint.c (gdbscm_set_breakpoint_condition_x): Ditto.
> * python/py-breakpoint.c (bppy_set_condition): Ditto.
>
> gdb/testsuite/ChangeLog:
> 2020-08-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
>
> * gdb.base/condbreak-multi-context.exp: Expand to test forcing
> the condition.
> * gdb.linespec/cpcompletion.exp: Update to consider the
> '-force-condition' keyword.
> * gdb.linespec/explicit.exp: Ditto.
> * lib/completion-support.exp: Ditto.
>
> gdb/doc/ChangeLog:
> 2020-07-31 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
>
> * gdb.texinfo (Set Breaks): Document the '-force-condition' flag
> of the 'break'command.
> * gdb.texinfo (Conditions): Document the '-force' flag of the
> 'condition' command.

OK for the documentation part.

What about the NEWS?

Thanks.